Bring method back that was mistakenly removed

- We're also improving specs to avoid this could happen again

2 files changed, 11 insertions, 3 deletions

diff --git a/spec/services/clusters/applications/check_installation_progress_service_spec.rb b/spec/services/clusters/applications/check_installation_progress_service_spec.rb
index 464a67649ff..02fd4b63c89 100644
--- a/spec/services/clusters/applications/check_installation_progress_service_spec.rb
+++ b/spec/services/clusters/applications/check_installation_progress_service_spec.rb
@@ -142,7 +142,11 @@ describe Clusters::Applications::CheckInstallationProgressService, '#execute' do
       end
 
       it 'removes the installation POD' do
-        expect(service).to receive(:remove_installation_pod).once
+        expect_any_instance_of(Gitlab::Kubernetes::Helm::Api)
+          .to receive(:delete_pod!)
+          .with(kind_of(String))
+          .once
+        expect(service).to receive(:remove_installation_pod).and_call_original
 
         service.execute
       end
diff --git a/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb b/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb
index 1a9f7089c3d..68ad0208226 100644
--- a/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb
+++ b/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb
@@ -47,11 +47,15 @@ describe Clusters::Applications::CheckUninstallProgressService do
     context 'when installation POD succeeded' do
       let(:phase) { Gitlab::Kubernetes::Pod::SUCCEEDED }
       before do
+        expect_any_instance_of(Gitlab::Kubernetes::Helm::Api)
+            .to receive(:delete_pod!)
+            .with(kind_of(String))
+            .once
         expect(service).to receive(:pod_phase).once.and_return(phase)
       end
 
       it 'removes the installation POD' do
-        expect(service).to receive(:remove_installation_pod).once
+        expect(service).to receive(:remove_uninstallation_pod).and_call_original
 
         service.execute
       end
@@ -76,7 +80,7 @@ describe Clusters::Applications::CheckUninstallProgressService do
         end
 
         it 'still removes the installation POD' do
-          expect(service).to receive(:remove_installation_pod).once
+          expect(service).to receive(:remove_uninstallation_pod).and_call_original
 
           service.execute
         end