Fix more specs

1 files changed, 14 insertions, 16 deletions

diff --git a/spec/services/groups/update_service_spec.rb b/spec/services/groups/update_service_spec.rb
index 9d427ff2d90..7732482cdaa 100644
--- a/spec/services/groups/update_service_spec.rb
+++ b/spec/services/groups/update_service_spec.rb
@@ -6,9 +6,8 @@ describe Groups::UpdateService, services: true do
   let!(:internal_group)   { create(:group, :internal) }
   let!(:public_group)     { create(:group, :public) }
 
-  describe "execute" do
+  describe "#execute" do
     context "project visibility_level validation" do
-
       context "public group with public projects" do
         let!(:service) { described_class.new(public_group, user, visibility_level: Gitlab::VisibilityLevel::INTERNAL ) }
 
@@ -18,33 +17,32 @@ describe Groups::UpdateService, services: true do
         end
 
         it "cant downgrade permission level" do
-          expect(service.execute).to be_falsy
           expect(public_group.errors.count).to eq(2)
         end
       end
 
       context "internal group with internal project" do
-          let!(:service) { described_class.new(internal_group, user, visibility_level: Gitlab::VisibilityLevel::PRIVATE ) }
-  
-          before do
-            internal_group.add_user(user, Gitlab::Access::MASTER)
-            create(:project, :internal, group: internal_group)
-          end
-  
-          it "cant downgrade permission level" do
-            expect(service.execute).to be_falsy
-            expect(internal_group.errors.count).to eq(2)
-          end
+        let!(:service) { described_class.new(internal_group, user, visibility_level: Gitlab::VisibilityLevel::PRIVATE ) }
+
+        before do
+          internal_group.add_user(user, Gitlab::Access::MASTER)
+          create(:project, :internal, group: internal_group)
+        end
+
+        it "cant downgrade permission level" do
+          expect(internal_group.errors.count).to eq(2)
         end
+      end
     end
   end
 
   context "unauthorized visibility_level validation" do
     let!(:service) { described_class.new(internal_group, user, visibility_level: 99 ) }
-    before { internal_group.add_user(user, Gitlab::Access::MASTER) }
+    before do
+      internal_group.add_user(user, Gitlab::Access::MASTER)
+    end
 
     it "does not change permission level" do
-      expect(service.execute).to be_falsy
       expect(internal_group.errors.count).to eq(1)
     end
   end