diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-05-19 10:33:21 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-05-19 10:33:21 +0300 |
commit | 36a59d088eca61b834191dacea009677a96c052f (patch) | |
tree | e4f33972dab5d8ef79e3944a9f403035fceea43f /spec/services/incident_management/timeline_events/create_service_spec.rb | |
parent | a1761f15ec2cae7c7f7bbda39a75494add0dfd6f (diff) |
Add latest changes from gitlab-org/gitlab@15-0-stable-eev15.0.0-rc42
Diffstat (limited to 'spec/services/incident_management/timeline_events/create_service_spec.rb')
-rw-r--r-- | spec/services/incident_management/timeline_events/create_service_spec.rb | 117 |
1 files changed, 117 insertions, 0 deletions
diff --git a/spec/services/incident_management/timeline_events/create_service_spec.rb b/spec/services/incident_management/timeline_events/create_service_spec.rb new file mode 100644 index 00000000000..38ce15e74f1 --- /dev/null +++ b/spec/services/incident_management/timeline_events/create_service_spec.rb @@ -0,0 +1,117 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe IncidentManagement::TimelineEvents::CreateService do + let_it_be(:user_with_permissions) { create(:user) } + let_it_be(:user_without_permissions) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be_with_refind(:incident) { create(:incident, project: project) } + let_it_be(:comment) { create(:note, project: project, noteable: incident) } + + let(:args) do + { + note: 'note', + occurred_at: Time.current, + action: 'new comment', + promoted_from_note: comment + } + end + + let(:current_user) { user_with_permissions } + let(:service) { described_class.new(incident, current_user, args) } + + before_all do + project.add_developer(user_with_permissions) + project.add_reporter(user_without_permissions) + end + + describe '#execute' do + shared_examples 'error response' do |message| + it 'has an informative message' do + expect(execute).to be_error + expect(execute.message).to eq(message) + end + end + + shared_examples 'success response' do + it 'has timeline event', :aggregate_failures do + expect(execute).to be_success + + result = execute.payload[:timeline_event] + expect(result).to be_a(::IncidentManagement::TimelineEvent) + expect(result.author).to eq(current_user) + expect(result.incident).to eq(incident) + expect(result.project).to eq(project) + expect(result.note).to eq(args[:note]) + expect(result.promoted_from_note).to eq(comment) + end + end + + subject(:execute) { service.execute } + + context 'when current user is blank' do + let(:current_user) { nil } + + it_behaves_like 'error response', 'You have insufficient permissions to manage timeline events for this incident' + end + + context 'when user does not have permissions to create timeline events' do + let(:current_user) { user_without_permissions } + + it_behaves_like 'error response', 'You have insufficient permissions to manage timeline events for this incident' + end + + context 'when error occurs during creation' do + let(:args) { {} } + + it_behaves_like 'error response', "Occurred at can't be blank, Note can't be blank, and Note html can't be blank" + end + + context 'with default action' do + let(:args) { { note: 'note', occurred_at: Time.current, promoted_from_note: comment } } + + it_behaves_like 'success response' + + it 'matches the default action', :aggregate_failures do + result = execute.payload[:timeline_event] + + expect(result.action).to eq(IncidentManagement::TimelineEvents::DEFAULT_ACTION) + end + end + + context 'with non_default action' do + it_behaves_like 'success response' + + it 'matches the action from arguments', :aggregate_failures do + result = execute.payload[:timeline_event] + + expect(result.action).to eq(args[:action]) + end + end + + it 'successfully creates a database record', :aggregate_failures do + expect { execute }.to change { ::IncidentManagement::TimelineEvent.count }.by(1) + end + + context 'when incident_timeline feature flag is enabled' do + before do + stub_feature_flags(incident_timeline: project) + end + + it 'creates a system note' do + expect { execute }.to change { incident.notes.reload.count }.by(1) + end + end + + context 'when incident_timeline feature flag is disabled' do + before do + stub_feature_flags(incident_timeline: false) + end + + it 'does not create a system note' do + expect { execute }.not_to change { incident.notes.reload.count } + end + end + end +end |