Avoid touch label links that does not belongs to project when moving it

1 files changed, 17 insertions, 12 deletions

diff --git a/spec/services/labels/transfer_service_spec.rb b/spec/services/labels/transfer_service_spec.rb
index cb09c16698a..ddf3527dc0f 100644
--- a/spec/services/labels/transfer_service_spec.rb
+++ b/spec/services/labels/transfer_service_spec.rb
@@ -5,33 +5,38 @@ describe Labels::TransferService, services: true do
     let(:user)    { create(:user) }
     let(:group_1) { create(:group) }
     let(:group_2) { create(:group) }
-    let(:project) { create(:project, namespace: group_2) }
+    let(:group_3) { create(:group) }
+    let(:project_1) { create(:project, namespace: group_2) }
+    let(:project_2) { create(:project, namespace: group_3) }
 
     let(:group_label_1) { create(:group_label, group: group_1, name: 'Group Label 1') }
     let(:group_label_2) { create(:group_label, group: group_1, name: 'Group Label 2') }
     let(:group_label_3) { create(:group_label, group: group_1, name: 'Group Label 3') }
     let(:group_label_4) { create(:group_label, group: group_2, name: 'Group Label 4') }
-    let(:project_label_1) { create(:label, project: project, name: 'Project Label 1') }
+    let(:group_label_5) { create(:group_label, group: group_3, name: 'Group Label 5') }
+    let(:project_label_1) { create(:label, project: project_1, name: 'Project Label 1') }
 
-    subject(:service) { described_class.new(user, group_1, project) }
+    subject(:service) { described_class.new(user, group_1, project_1) }
 
     before do
-      create(:labeled_issue, project: project, labels: [group_label_1])
-      create(:labeled_issue, project: project, labels: [group_label_4])
-      create(:labeled_issue, project: project, labels: [project_label_1])
-      create(:labeled_merge_request, source_project: project, labels: [group_label_1, group_label_2])
+      create(:labeled_issue, project: project_1, labels: [group_label_1])
+      create(:labeled_issue, project: project_1, labels: [group_label_4])
+      create(:labeled_issue, project: project_1, labels: [project_label_1])
+      create(:labeled_issue, project: project_2, labels: [group_label_5])
+      create(:labeled_merge_request, source_project: project_1, labels: [group_label_1, group_label_2])
+      create(:labeled_merge_request, source_project: project_2, labels: [group_label_5])
     end
 
     it 'recreates the missing group labels at project level' do
-      expect { service.execute }.to change(project.labels, :count).by(2)
+      expect { service.execute }.to change(project_1.labels, :count).by(2)
     end
 
     it 'recreates label priorities related to the missing group labels' do
-      create(:label_priority, project: project, label: group_label_1, priority: 1)
+      create(:label_priority, project: project_1, label: group_label_1, priority: 1)
 
       service.execute
 
-      new_project_label = project.labels.find_by(title: group_label_1.title)
+      new_project_label = project_1.labels.find_by(title: group_label_1.title)
       expect(new_project_label.id).not_to eq group_label_1.id
       expect(new_project_label.priorities).not_to be_empty
     end
@@ -39,13 +44,13 @@ describe Labels::TransferService, services: true do
     it 'does not recreate missing group labels that are not applied to issues or merge requests' do
       service.execute
 
-      expect(project.labels.where(title: group_label_3.title)).to be_empty
+      expect(project_1.labels.where(title: group_label_3.title)).to be_empty
     end
 
     it 'does not recreate missing group labels that already exist in the project group' do
       service.execute
 
-      expect(project.labels.where(title: group_label_4.title)).to be_empty
+      expect(project_1.labels.where(title: group_label_4.title)).to be_empty
     end
   end
 end