diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-02-18 13:34:06 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-02-18 13:34:06 +0300 |
commit | 859a6fb938bb9ee2a317c46dfa4fcc1af49608f0 (patch) | |
tree | d7f2700abe6b4ffcb2dcfc80631b2d87d0609239 /spec/services/members/update_service_spec.rb | |
parent | 446d496a6d000c73a304be52587cd9bbc7493136 (diff) |
Add latest changes from gitlab-org/gitlab@13-9-stable-eev13.9.0-rc42
Diffstat (limited to 'spec/services/members/update_service_spec.rb')
-rw-r--r-- | spec/services/members/update_service_spec.rb | 24 |
1 files changed, 21 insertions, 3 deletions
diff --git a/spec/services/members/update_service_spec.rb b/spec/services/members/update_service_spec.rb index 2d4457f3f62..a1b1397d444 100644 --- a/spec/services/members/update_service_spec.rb +++ b/spec/services/members/update_service_spec.rb @@ -13,9 +13,11 @@ RSpec.describe Members::UpdateService do { access_level: Gitlab::Access::MAINTAINER } end + subject { described_class.new(current_user, params).execute(member, permission: permission) } + shared_examples 'a service raising Gitlab::Access::AccessDeniedError' do it 'raises Gitlab::Access::AccessDeniedError' do - expect { described_class.new(current_user, params).execute(member, permission: permission) } + expect { subject } .to raise_error(Gitlab::Access::AccessDeniedError) end end @@ -24,18 +26,24 @@ RSpec.describe Members::UpdateService do it 'updates the member' do expect(TodosDestroyer::EntityLeaveWorker).not_to receive(:perform_in).with(Todo::WAIT_FOR_DELETE, member.user_id, member.source_id, source.class.name) - updated_member = described_class.new(current_user, params).execute(member, permission: permission) + updated_member = subject.fetch(:member) expect(updated_member).to be_valid expect(updated_member.access_level).to eq(Gitlab::Access::MAINTAINER) end + it 'returns success status' do + result = subject.fetch(:status) + + expect(result).to eq(:success) + end + context 'when member is downgraded to guest' do shared_examples 'schedules to delete confidential todos' do it do expect(TodosDestroyer::EntityLeaveWorker).to receive(:perform_in).with(Todo::WAIT_FOR_DELETE, member.user_id, member.source_id, source.class.name).once - updated_member = described_class.new(current_user, params).execute(member, permission: permission) + updated_member = subject.fetch(:member) expect(updated_member).to be_valid expect(updated_member.access_level).to eq(Gitlab::Access::GUEST) @@ -62,6 +70,16 @@ RSpec.describe Members::UpdateService do expect { described_class.new(current_user, params) }.to raise_error(ArgumentError, 'invalid value for Integer(): "invalid"') end end + + context 'when member is not valid' do + let(:params) { { expires_at: 2.days.ago } } + + it 'returns error status' do + result = subject + + expect(result[:status]).to eq(:error) + end + end end before do |