diff options
author | Gabriel Mazetto <brodock@gmail.com> | 2017-11-15 16:42:38 +0300 |
---|---|---|
committer | Gabriel Mazetto <brodock@gmail.com> | 2017-11-23 16:19:36 +0300 |
commit | 4af26c1c65e4cc1d18a37acbc2af6ae29e91b336 (patch) | |
tree | 28b8b35469e6fb41c3c914e051e433b51d26005c /spec/services | |
parent | 0a4d55a1c9f58f383f23b8f60bbe1acba1b8511c (diff) |
WIP Attachments migration
Diffstat (limited to 'spec/services')
-rw-r--r-- | spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb | 72 | ||||
-rw-r--r-- | spec/services/projects/hashed_storage_migration_service_spec.rb | 40 |
2 files changed, 112 insertions, 0 deletions
diff --git a/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb b/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb new file mode 100644 index 00000000000..81f05074261 --- /dev/null +++ b/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb @@ -0,0 +1,72 @@ +require 'spec_helper' + +describe Projects::HashedStorage::MigrateAttachmentsService do + subject(:service) { described_class.new(project) } + let(:project) { create(:project) } + let(:legacy_storage) { Storage::LegacyProject.new(project) } + let(:hashed_storage) { Storage::HashedProject.new(project) } + + let!(:upload) { Upload.find_by(path: file_uploader.relative_path) } + let(:file_uploader) { build(:file_uploader, project: project) } + let(:old_path) { attachments_path(legacy_storage, upload) } + let(:new_path) { attachments_path(hashed_storage, upload) } + + let(:other_file_uploader) { build(:file_uploader, project: project) } + let(:other_old_path) { attachments_path(legacy_storage, other_upload) } + let(:other_new_path) { attachments_path(hashed_storage, other_upload) } + + context '#execute' do + context 'when succeeds' do + it 'moves attachments to hashed storage layout' do + expect(File.file?(old_path)).to be_truthy + expect(File.file?(new_path)).to be_falsey + + service.execute + + expect(File.file?(old_path)).to be_falsey + expect(File.file?(new_path)).to be_truthy + end + end + + context 'when original file does not exist anymore' do + let!(:other_upload) { Upload.find_by(path: other_file_uploader.relative_path) } + + before do + File.unlink(old_path) + end + + it 'skips moving the file and goes to next' do + expect(FileUtils).not_to receive(:mv).with(old_path, new_path) + expect(FileUtils).to receive(:mv).with(other_old_path, other_new_path).and_call_original + + service.execute + + expect(File.file?(new_path)).to be_falsey + expect(File.file?(other_new_path)).to be_truthy + end + end + + context 'when target file already exists' do + let!(:other_upload) { Upload.find_by(path: other_file_uploader.relative_path) } + + before do + FileUtils.mkdir_p(File.dirname(new_path)) + FileUtils.touch(new_path) + end + + it 'skips moving the file and goes to next' do + expect(FileUtils).not_to receive(:mv).with(old_path, new_path) + expect(FileUtils).to receive(:mv).with(other_old_path, other_new_path).and_call_original + expect(File.file?(new_path)).to be_truthy + + service.execute + + expect(File.file?(old_path)).to be_truthy + end + end + end + + def attachments_path(storage, upload) + File.join(CarrierWave.root, FileUploader.base_dir, storage.disk_path, upload.path) + end +end diff --git a/spec/services/projects/hashed_storage_migration_service_spec.rb b/spec/services/projects/hashed_storage_migration_service_spec.rb new file mode 100644 index 00000000000..28b6daf217e --- /dev/null +++ b/spec/services/projects/hashed_storage_migration_service_spec.rb @@ -0,0 +1,40 @@ +require 'spec_helper' + +describe Projects::HashedStorageMigrationService do + let(:project) { create(:project, :empty_repo, :wiki_repo) } + subject(:service) { described_class.new(project) } + + describe '#execute' do + context 'repository migration' do + it 'delegates migration to Projects::HashedStorage::MigrateRepositoryService' do + expect(Projects::HashedStorage::MigrateRepositoryService).to receive(:new).with(project, subject.logger).and_call_original + expect_any_instance_of(Projects::HashedStorage::MigrateRepositoryService).to receive(:execute) + + service.execute + end + + it 'does not delegate migration if repository is already migrated' do + project.storage_version = ::Project::LATEST_STORAGE_VERSION + expect_any_instance_of(Projects::HashedStorage::MigrateRepositoryService).not_to receive(:execute) + + service.execute + end + end + + context 'attachments migration' do + it 'delegates migration to Projects::HashedStorage::MigrateRepositoryService' do + expect(Projects::HashedStorage::MigrateAttachmentsService).to receive(:new).with(project, subject.logger).and_call_original + expect_any_instance_of(Projects::HashedStorage::MigrateAttachmentsService).to receive(:execute) + + service.execute + end + + it 'does not delegate migration if attachments are already migrated' do + project.storage_version = ::Project::LATEST_STORAGE_VERSION + expect_any_instance_of(Projects::HashedStorage::MigrateAttachmentsService).not_to receive(:execute) + + service.execute + end + end + end +end |