Check container repository exists for a given path

1 files changed, 16 insertions, 15 deletions

diff --git a/spec/services/container_registry/create_repository_service_spec.rb b/spec/services/container_registry/create_repository_service_spec.rb
index dfd07c8cc02..ac7b147f92e 100644
--- a/spec/services/container_registry/create_repository_service_spec.rb
+++ b/spec/services/container_registry/create_repository_service_spec.rb
@@ -14,18 +14,6 @@ describe ContainerRegistry::CreateRepositoryService, '#execute' do
     stub_container_registry_config(enabled: true)
   end
 
-  context 'when container repository already exists' do
-    before do
-      create(:container_repository, project: project, name: 'my/image')
-    end
-
-    it 'does not create container repository again' do
-      expect { service.execute(path) }
-        .to raise_error(Gitlab::Access::AccessDeniedError)
-        .and change { ContainerRepository.count }.by(0)
-    end
-  end
-
   context 'when repository is created by an user' do
     context 'when user has no ability to create a repository' do
       it 'does not create a new container repository' do
@@ -40,9 +28,22 @@ describe ContainerRegistry::CreateRepositoryService, '#execute' do
         project.add_developer(user)
       end
 
-      it 'creates a new container repository' do
-        expect { service.execute(path) }
-          .to change { project.container_repositories.count }.by(1)
+      context 'when repository already exists' do
+        before do
+          create(:container_repository, project: project, name: 'my/image')
+        end
+
+        it 'does not create container repository again' do
+          expect { service.execute(path) }
+            .to_not change { ContainerRepository.count }
+        end
+      end
+
+      context 'when repository does not exist yet' do
+        it 'creates a new container repository' do
+          expect { service.execute(path) }
+            .to change { project.container_repositories.count }.by(1)
+        end
       end
     end
   end