diff options
author | Heinrich Lee Yu <hleeyu@gmail.com> | 2018-12-31 11:39:43 +0300 |
---|---|---|
committer | Heinrich Lee Yu <hleeyu@gmail.com> | 2019-01-07 06:16:58 +0300 |
commit | e2698d5d7455d91fa94f9bbf1fc838f8cb142700 (patch) | |
tree | 900a7abd2983a5a31843c25a13ce06898c1e02d6 /spec/services | |
parent | 63e9969ca3ac57839b78d9cc44bcf32bc9a45248 (diff) |
Improve email messages
Also refactored cleanup view to use the same localized string
Diffstat (limited to 'spec/services')
-rw-r--r-- | spec/services/issues/import_csv_service_spec.rb | 14 | ||||
-rw-r--r-- | spec/services/upload_service_spec.rb | 2 |
2 files changed, 8 insertions, 8 deletions
diff --git a/spec/services/issues/import_csv_service_spec.rb b/spec/services/issues/import_csv_service_spec.rb index f5e58bc9a9e..848dc2c2cd2 100644 --- a/spec/services/issues/import_csv_service_spec.rb +++ b/spec/services/issues/import_csv_service_spec.rb @@ -21,7 +21,7 @@ describe Issues::ImportCsvService do expect_any_instance_of(Notify).to receive(:import_issues_csv_email) expect(subject[:success]).to eq(0) - expect(subject[:valid_file]).to eq(false) + expect(subject[:parse_error]).to eq(true) end end @@ -32,8 +32,8 @@ describe Issues::ImportCsvService do expect_any_instance_of(Notify).to receive(:import_issues_csv_email) expect(subject[:success]).to eq(3) - expect(subject[:errors]).to eq([]) - expect(subject[:valid_file]).to eq(true) + expect(subject[:error_lines]).to eq([]) + expect(subject[:parse_error]).to eq(false) end end @@ -44,8 +44,8 @@ describe Issues::ImportCsvService do expect_any_instance_of(Notify).to receive(:import_issues_csv_email) expect(subject[:success]).to eq(2) - expect(subject[:errors]).to eq([3]) - expect(subject[:valid_file]).to eq(true) + expect(subject[:error_lines]).to eq([3]) + expect(subject[:parse_error]).to eq(false) end end @@ -56,8 +56,8 @@ describe Issues::ImportCsvService do expect_any_instance_of(Notify).to receive(:import_issues_csv_email) expect(subject[:success]).to eq(3) - expect(subject[:errors]).to eq([4]) - expect(subject[:valid_file]).to eq(true) + expect(subject[:error_lines]).to eq([4]) + expect(subject[:parse_error]).to eq(false) end end end diff --git a/spec/services/upload_service_spec.rb b/spec/services/upload_service_spec.rb index 57382c4bc8d..4a809d5bf18 100644 --- a/spec/services/upload_service_spec.rb +++ b/spec/services/upload_service_spec.rb @@ -63,7 +63,7 @@ describe UploadService do @link_to_file = upload_file(@project, txt) end - it { expect(@link_to_file).to eq(nil) } + it { expect(@link_to_file).to eq({}) } end end |