Commits without .gitlab-ci.yml are marked as skipped

- Save detailed error when YAML syntax

1 files changed, 19 insertions, 1 deletions

diff --git a/spec/services/ci/create_commit_service_spec.rb b/spec/services/ci/create_commit_service_spec.rb
index e3a8fe9681b..392f5fce35f 100644
--- a/spec/services/ci/create_commit_service_spec.rb
+++ b/spec/services/ci/create_commit_service_spec.rb
@@ -100,7 +100,7 @@ module Ci
         end
 
         it "skips builds creation if there is [ci skip] tag in commit message and yaml is invalid" do
-          stub_ci_commit_yaml_file('invalid: file')
+          stub_ci_commit_yaml_file('invalid: file: fiile')
           commits = [{ message: message }]
           commit = service.execute(project, user,
                                    ref: 'refs/tags/0_1',
@@ -110,6 +110,24 @@ module Ci
           )
           expect(commit.builds.any?).to be false
           expect(commit.status).to eq("skipped")
+          expect(commit.yaml_errors).to be_nil
+        end
+      end
+
+      describe :config_processor do
+        it "skips builds creation if yaml is invalid" do
+          allow_any_instance_of(Ci::Commit).to receive(:git_commit_message) { "message" }
+          stub_ci_commit_yaml_file('invalid: file: file')
+          commits = [{ message: message }]
+          commit = service.execute(project, user,
+                                   ref: 'refs/tags/0_1',
+                                   before: '00000000',
+                                   after: '31das312',
+                                   commits: commits
+          )
+          expect(commit.builds.any?).to be false
+          expect(commit.status).to eq("skipped")
+          expect(commit.yaml_errors).to_not be_nil
         end
       end