diff options
| author | Sean McGivern <sean@mcgivern.me.uk> | 2017-04-04 16:33:42 +0300 |
|---|---|---|
| committer | Sean McGivern <sean@mcgivern.me.uk> | 2017-04-04 16:33:42 +0300 |
| commit | 796d65f1feeb13c5bbdedee3f7290bd962c4c421 (patch) | |
| tree | fee4fcfd24818c3bef0bde6faf1b6c1b51aeb887 /spec/support/issuables_list_metadata_shared_examples.rb | |
| parent | 7f8f927aafb0f3a618ccce76e802e30a16b04b42 (diff) | |
| parent | e52b1df1d5391f0fa0b9ec7eb2d3492b05f64ba4 (diff) | |
Merge branch '29492-useless-queries' into 'master'
remove useless queries with false conditions (e.g 1=0)
Closes #29492
See merge request !10141
Diffstat (limited to 'spec/support/issuables_list_metadata_shared_examples.rb')
| -rw-r--r-- | spec/support/issuables_list_metadata_shared_examples.rb | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/spec/support/issuables_list_metadata_shared_examples.rb b/spec/support/issuables_list_metadata_shared_examples.rb index 7ea4073ef2b..3406e4c3161 100644 --- a/spec/support/issuables_list_metadata_shared_examples.rb +++ b/spec/support/issuables_list_metadata_shared_examples.rb @@ -33,4 +33,19 @@ shared_examples 'issuables list meta-data' do |issuable_type, action = nil| expect(meta_data[id].upvotes).to eq(id + 2) end end + + describe "when given empty collection" do + let(:project2) { create(:empty_project, :public) } + + it "doesn't execute any queries with false conditions" do + get_action = + if action + proc { get action } + else + proc { get :index, namespace_id: project2.namespace, project_id: project2 } + end + + expect(&get_action).not_to make_queries_matching(/WHERE (?:1=0|0=1)/) + end + end end |