Add latest changes from gitlab-org/gitlab@13-8-stable-eev13.8.0-rc42

7 files changed, 324 insertions, 14 deletions

diff --git a/spec/support/shared_contexts/email_shared_context.rb b/spec/support/shared_contexts/email_shared_context.rb
index 298e03162c4..9dffea7c94e 100644
--- a/spec/support/shared_contexts/email_shared_context.rb
+++ b/spec/support/shared_contexts/email_shared_context.rb
@@ -1,16 +1,16 @@
 # frozen_string_literal: true
 
 RSpec.shared_context :email_shared_context do
-  let(:mail_key) { "59d8df8370b7e95c5a49fbf86aeb2c93" }
+  let(:mail_key) { '59d8df8370b7e95c5a49fbf86aeb2c93' }
   let(:receiver) { Gitlab::Email::Receiver.new(email_raw) }
-  let(:markdown) { "![image](uploads/image.png)" }
+  let(:markdown) { '![image](uploads/image.png)' }
 
   def setup_attachment
     allow_any_instance_of(Gitlab::Email::AttachmentUploader).to receive(:execute).and_return(
       [
         {
-          url: "uploads/image.png",
-          alt: "image",
+          url: 'uploads/image.png',
+          alt: 'image',
           markdown: markdown
         }
       ]
@@ -19,23 +19,252 @@ RSpec.shared_context :email_shared_context do
 end
 
 RSpec.shared_examples :reply_processing_shared_examples do
-  context "when the user could not be found" do
+  context 'when the user could not be found' do
     before do
       user.destroy!
     end
 
-    it "raises a UserNotFoundError" do
+    it 'raises a UserNotFoundError' do
       expect { receiver.execute }.to raise_error(Gitlab::Email::UserNotFoundError)
     end
   end
 
-  context "when the user is not authorized to the project" do
+  context 'when the user is not authorized to the project' do
     before do
       project.update_attribute(:visibility_level, Project::PRIVATE)
     end
 
-    it "raises a ProjectNotFound" do
+    it 'raises a ProjectNotFound' do
       expect { receiver.execute }.to raise_error(Gitlab::Email::ProjectNotFound)
     end
   end
 end
+
+RSpec.shared_examples :checks_permissions_on_noteable_examples do
+  context 'when user has access' do
+    before do
+      project.add_reporter(user)
+    end
+
+    it 'creates a comment' do
+      expect { receiver.execute }.to change { noteable.notes.count }.by(1)
+    end
+  end
+
+  context 'when user does not have access' do
+    it 'raises UserNotAuthorizedError' do
+      expect { receiver.execute }.to raise_error(Gitlab::Email::UserNotAuthorizedError)
+    end
+  end
+end
+
+RSpec.shared_examples :note_handler_shared_examples do |forwardable|
+  context 'when the noteable could not be found' do
+    before do
+      noteable.destroy!
+    end
+
+    it 'raises a NoteableNotFoundError' do
+      expect { receiver.execute }.to raise_error(Gitlab::Email::NoteableNotFoundError)
+    end
+  end
+
+  context 'when the note could not be saved' do
+    before do
+      allow_any_instance_of(Note).to receive(:persisted?).and_return(false)
+    end
+
+    it 'raises an InvalidNoteError' do
+      expect { receiver.execute }.to raise_error(Gitlab::Email::InvalidNoteError)
+    end
+
+    context 'because the note was update commands only' do
+      let!(:email_raw) { update_commands_only }
+
+      context 'and current user cannot update noteable' do
+        it 'raises a CommandsOnlyNoteError' do
+          expect { receiver.execute }.to raise_error(Gitlab::Email::InvalidNoteError)
+        end
+      end
+
+      context 'and current user can update noteable' do
+        before do
+          project.add_developer(user)
+        end
+
+        it 'does not raise an error', unless: forwardable do
+          expect { receiver.execute }.to change { noteable.resource_state_events.count }.by(1)
+
+          expect(noteable.reload).to be_closed
+        end
+
+        it 'raises an InvalidNoteError', if: forwardable do
+          expect { receiver.execute }.to raise_error(Gitlab::Email::InvalidNoteError)
+        end
+      end
+    end
+  end
+
+  context 'when the note contains quick actions' do
+    let!(:email_raw) { commands_in_reply }
+
+    context 'and current user cannot update the noteable' do
+      it 'only executes the commands that the user can perform' do
+        expect { receiver.execute }
+          .to change { noteable.notes.user.count }.by(1)
+                .and change { user.todos_pending_count }.from(0).to(1)
+
+        expect(noteable.reload).to be_open
+      end
+    end
+
+    context 'and current user can update noteable' do
+      before do
+        project.add_developer(user)
+      end
+
+      it 'posts a note and updates the noteable' do
+        expect(TodoService.new.todo_exist?(noteable, user)).to be_falsy
+
+        expect { receiver.execute }
+          .to change { noteable.notes.user.count }.by(1)
+                .and change { user.todos_pending_count }.from(0).to(1)
+
+        expect(noteable.reload).to be_closed
+      end
+    end
+  end
+
+  context 'when the reply is blank' do
+    let!(:email_raw) { no_content }
+
+    it 'raises an EmptyEmailError', unless: forwardable do
+      expect { receiver.execute }.to raise_error(Gitlab::Email::EmptyEmailError)
+    end
+
+    it 'allows email to only have quoted text', if: forwardable do
+      expect { receiver.execute }.not_to raise_error(Gitlab::Email::EmptyEmailError)
+    end
+  end
+
+  context 'when discussion is locked' do
+    before do
+      noteable.update_attribute(:discussion_locked, true)
+    end
+
+    it_behaves_like :checks_permissions_on_noteable_examples
+  end
+
+  context 'when everything is fine' do
+    before do
+      setup_attachment
+    end
+
+    it 'adds all attachments' do
+      expect_next_instance_of(Gitlab::Email::AttachmentUploader) do |uploader|
+        expect(uploader).to receive(:execute).with(upload_parent: project, uploader_class: FileUploader).and_return(
+          [
+            {
+              url: 'uploads/image.png',
+              alt: 'image',
+              markdown: markdown
+            }
+          ]
+        )
+      end
+
+      receiver.execute
+
+      note = noteable.notes.last
+      expect(note.note).to include(markdown)
+      expect(note.note).to include('Jake out')
+    end
+  end
+
+  context 'when the service desk' do
+    let(:project) { create(:project, :public, service_desk_enabled: true) }
+    let(:support_bot) { User.support_bot }
+    let(:noteable) { create(:issue, project: project, author: support_bot, title: 'service desk issue') }
+    let!(:note) { create(:note, project: project, noteable: noteable) }
+    let(:email_raw) { with_quick_actions }
+
+    let!(:sent_notification) do
+      SentNotification.record_note(note, support_bot.id, mail_key)
+    end
+
+    context 'is enabled' do
+      before do
+        allow(Gitlab::ServiceDesk).to receive(:enabled?).with(project: project).and_return(true)
+        project.project_feature.update!(issues_access_level: issues_access_level)
+      end
+
+      context 'when issues are enabled for everyone' do
+        let(:issues_access_level) { ProjectFeature::ENABLED }
+
+        it 'creates a comment' do
+          expect { receiver.execute }.to change { noteable.notes.count }.by(1)
+        end
+
+        context 'when quick actions are present' do
+          before do
+            receiver.execute
+            noteable.reload
+          end
+
+          context 'when author is a support_bot', unless: forwardable do
+            it 'encloses quick actions with code span markdown' do
+              note = Note.last
+              expect(note.note).to include("Jake out\n\n`/close`\n`/title test`")
+              expect(noteable.title).to eq('service desk issue')
+              expect(noteable).to be_opened
+            end
+          end
+
+          context 'when author is a normal user', if: forwardable do
+            it 'extracted the quick actions' do
+              note = Note.last
+              expect(note.note).to include('Jake out')
+              expect(note.note).not_to include("`/close`\n`/title test`")
+            end
+          end
+        end
+      end
+
+      context 'when issues are protected members only' do
+        let(:issues_access_level) { ProjectFeature::PRIVATE }
+
+        before do
+          if recipient.support_bot?
+            @changed_by = 1
+          else
+            @changed_by = 2
+            project.add_developer(recipient)
+          end
+        end
+
+        it 'creates a comment' do
+          expect { receiver.execute }.to change { noteable.notes.count }.by(@changed_by)
+        end
+      end
+
+      context 'when issues are disabled' do
+        let(:issues_access_level) { ProjectFeature::DISABLED }
+
+        it 'does not create a comment' do
+          expect { receiver.execute }.to raise_error(Gitlab::Email::UserNotAuthorizedError)
+        end
+      end
+    end
+
+    context 'is disabled', unless: forwardable do
+      before do
+        allow(Gitlab::ServiceDesk).to receive(:enabled?).and_return(false)
+        allow(Gitlab::ServiceDesk).to receive(:enabled?).with(project: project).and_return(false)
+      end
+
+      it 'does not create a comment' do
+        expect { receiver.execute }.to raise_error(Gitlab::Email::ProjectNotFound)
+      end
+    end
+  end
+end
diff --git a/spec/support/shared_contexts/finders/issues_finder_shared_contexts.rb b/spec/support/shared_contexts/finders/issues_finder_shared_contexts.rb
index 9ffde54c84a..d9cbea58406 100644
--- a/spec/support/shared_contexts/finders/issues_finder_shared_contexts.rb
+++ b/spec/support/shared_contexts/finders/issues_finder_shared_contexts.rb
@@ -8,13 +8,53 @@ RSpec.shared_context 'IssuesFinder context' do
   let_it_be(:project1, reload: true) { create(:project, group: group) }
   let_it_be(:project2, reload: true) { create(:project) }
   let_it_be(:project3, reload: true) { create(:project, group: subgroup) }
-  let_it_be(:milestone) { create(:milestone, project: project1) }
+  let_it_be(:release) { create(:release, project: project1, tag: 'v1.0.0') }
+  let_it_be(:milestone) { create(:milestone, project: project1, releases: [release]) }
   let_it_be(:label) { create(:label, project: project2) }
   let_it_be(:label2) { create(:label, project: project2) }
-  let_it_be(:issue1, reload: true) { create(:issue, author: user, assignees: [user], project: project1, milestone: milestone, title: 'gitlab', created_at: 1.week.ago, updated_at: 1.week.ago) }
-  let_it_be(:issue2, reload: true) { create(:issue, author: user, assignees: [user], project: project2, description: 'gitlab', created_at: 1.week.from_now, updated_at: 1.week.from_now) }
-  let_it_be(:issue3, reload: true) { create(:issue, author: user2, assignees: [user2], project: project2, title: 'tanuki', description: 'tanuki', created_at: 2.weeks.from_now, updated_at: 2.weeks.from_now) }
+  let_it_be(:issue1, reload: true) do
+    create(:issue,
+           author: user,
+           assignees: [user],
+           project: project1,
+           milestone: milestone,
+           title: 'gitlab',
+           created_at: 1.week.ago,
+           updated_at: 1.week.ago)
+  end
+
+  let_it_be(:issue2, reload: true) do
+    create(:issue,
+           author: user,
+           assignees: [user],
+           project: project2,
+           description: 'gitlab',
+           created_at: 1.week.from_now,
+           updated_at: 1.week.from_now)
+  end
+
+  let_it_be(:issue3, reload: true) do
+    create(:issue,
+           author: user2,
+           assignees: [user2],
+           project: project2,
+           title: 'tanuki',
+           description: 'tanuki',
+           created_at: 2.weeks.from_now,
+           updated_at: 2.weeks.from_now)
+  end
+
   let_it_be(:issue4, reload: true) { create(:issue, project: project3) }
+  let_it_be(:issue5, reload: true) do
+    create(:issue,
+           author: user,
+           assignees: [user],
+           project: project1,
+           title: 'wotnot',
+           created_at: 3.days.ago,
+           updated_at: 3.days.ago)
+  end
+
   let_it_be(:award_emoji1) { create(:award_emoji, name: 'thumbsup', user: user, awardable: issue1) }
   let_it_be(:award_emoji2) { create(:award_emoji, name: 'thumbsup', user: user2, awardable: issue2) }
   let_it_be(:award_emoji3) { create(:award_emoji, name: 'thumbsdown', user: user, awardable: issue3) }
diff --git a/spec/support/shared_contexts/finders/users_finder_shared_contexts.rb b/spec/support/shared_contexts/finders/users_finder_shared_contexts.rb
index 54022aeb494..6a09497a497 100644
--- a/spec/support/shared_contexts/finders/users_finder_shared_contexts.rb
+++ b/spec/support/shared_contexts/finders/users_finder_shared_contexts.rb
@@ -2,6 +2,7 @@
 
 RSpec.shared_context 'UsersFinder#execute filter by project context' do
   let_it_be(:normal_user) { create(:user, username: 'johndoe') }
+  let_it_be(:admin_user) { create(:user, :admin, username: 'iamadmin') }
   let_it_be(:blocked_user) { create(:user, :blocked, username: 'notsorandom') }
   let_it_be(:external_user) { create(:user, :external) }
   let_it_be(:omniauth_user) { create(:omniauth_user, provider: 'twitter', extern_uid: '123456') }
diff --git a/spec/support/shared_contexts/navbar_structure_context.rb b/spec/support/shared_contexts/navbar_structure_context.rb
index 549dc1cff1d..57d8320b76a 100644
--- a/spec/support/shared_contexts/navbar_structure_context.rb
+++ b/spec/support/shared_contexts/navbar_structure_context.rb
@@ -137,6 +137,7 @@ RSpec.shared_context 'group navbar structure' do
         _('Projects'),
         _('Repository'),
         _('CI / CD'),
+        _('Packages & Registries'),
         _('Webhooks')
       ]
     }
diff --git a/spec/support/shared_contexts/policies/group_policy_shared_context.rb b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
index e0e2a18cdd2..e7bc1450601 100644
--- a/spec/support/shared_contexts/policies/group_policy_shared_context.rb
+++ b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
@@ -19,8 +19,29 @@ RSpec.shared_context 'GroupPolicy context' do
   end
 
   let(:read_group_permissions) { %i[read_label read_list read_milestone read_board] }
-  let(:reporter_permissions) { %i[admin_label read_container_image read_metrics_dashboard_annotation read_prometheus] }
-  let(:developer_permissions) { %i[admin_milestone create_metrics_dashboard_annotation delete_metrics_dashboard_annotation update_metrics_dashboard_annotation] }
+
+  let(:reporter_permissions) do
+    %i[
+        admin_label
+        admin_board
+        read_container_image
+        read_metrics_dashboard_annotation
+        read_prometheus
+        read_package_settings
+      ]
+  end
+
+  let(:developer_permissions) do
+    %i[
+        admin_milestone
+        create_metrics_dashboard_annotation
+        delete_metrics_dashboard_annotation
+        update_metrics_dashboard_annotation
+        create_custom_emoji
+        create_package_settings
+      ]
+  end
+
   let(:maintainer_permissions) do
     %i[
       create_projects
diff --git a/spec/support/shared_contexts/read_ci_configuration_shared_context.rb b/spec/support/shared_contexts/read_ci_configuration_shared_context.rb
index f8f33e2a745..04c50171766 100644
--- a/spec/support/shared_contexts/read_ci_configuration_shared_context.rb
+++ b/spec/support/shared_contexts/read_ci_configuration_shared_context.rb
@@ -5,5 +5,13 @@ RSpec.shared_context 'read ci configuration for sast enabled project' do
     File.read(Rails.root.join('spec/support/gitlab_stubs/gitlab_ci_for_sast.yml'))
   end
 
+  let_it_be(:gitlab_ci_yml_default_analyzers_content) do
+    File.read(Rails.root.join('spec/support/gitlab_stubs/gitlab_ci_for_sast_default_analyzers.yml'))
+  end
+
+  let_it_be(:gitlab_ci_yml_excluded_analyzers_content) do
+    File.read(Rails.root.join('spec/support/gitlab_stubs/gitlab_ci_for_sast_excluded_analyzers.yml'))
+  end
+
   let_it_be(:project) { create(:project, :repository) }
 end
diff --git a/spec/support/shared_contexts/requests/api/nuget_packages_shared_context.rb b/spec/support/shared_contexts/requests/api/nuget_packages_shared_context.rb
new file mode 100644
index 00000000000..f877d6299bd
--- /dev/null
+++ b/spec/support/shared_contexts/requests/api/nuget_packages_shared_context.rb
@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+RSpec.shared_context 'nuget api setup' do
+  include WorkhorseHelpers
+  include PackagesManagerApiSpecHelpers
+  include HttpBasicAuthHelpers
+
+  let_it_be(:user) { create(:user) }
+  let_it_be(:personal_access_token) { create(:personal_access_token, user: user) }
+end