diff options
author | Robert Speicher <robert@gitlab.com> | 2016-07-15 23:07:51 +0300 |
---|---|---|
committer | Robert Speicher <robert@gitlab.com> | 2016-07-15 23:07:51 +0300 |
commit | 27e4a95221539ccb6749b2de8a75a8c17427115f (patch) | |
tree | 23f12cec60e1b8b724f6084949496f932da71735 /spec/support | |
parent | 89665649b01c8adef03e30d7f8e1ee633aa22e45 (diff) | |
parent | 341d8bc3f7fbe3763250af1e89020b81dad34bb8 (diff) |
Merge branch '17341-firefox-u2f' into 'master'
Allow U2F devices to be used in Firefox
- Adds U2F support for Firefox
- Improve U2F feature detection logic
- Have authentication flow be closer to the spec (single challenge instead of a challenge for each `signRequest`)
- Closes #17341
- Related to #15337
See merge request !5177
Diffstat (limited to 'spec/support')
-rw-r--r-- | spec/support/fake_u2f_device.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/support/fake_u2f_device.rb b/spec/support/fake_u2f_device.rb index 553fe9f1fbc..f550e9a0160 100644 --- a/spec/support/fake_u2f_device.rb +++ b/spec/support/fake_u2f_device.rb @@ -18,8 +18,8 @@ class FakeU2fDevice def respond_to_u2f_authentication app_id = @page.evaluate_script('gon.u2f.app_id') - challenges = @page.evaluate_script('gon.u2f.challenges') - json_response = u2f_device(app_id).sign_response(challenges[0]) + challenge = @page.evaluate_script('gon.u2f.challenge') + json_response = u2f_device(app_id).sign_response(challenge) @page.execute_script(" u2f.sign = function(appId, challenges, signRequests, callback) { |