Allow MR diffs to be placed into an object store

1 files changed, 67 insertions, 0 deletions

diff --git a/spec/uploaders/external_diff_uploader_spec.rb b/spec/uploaders/external_diff_uploader_spec.rb
new file mode 100644
index 00000000000..1c959770dc4
--- /dev/null
+++ b/spec/uploaders/external_diff_uploader_spec.rb
@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+describe ExternalDiffUploader do
+  let(:diff) { create(:merge_request).merge_request_diff }
+  let(:path) { Gitlab.config.external_diffs.storage_path }
+
+  subject(:uploader) { described_class.new(diff, :external_diff) }
+
+  it_behaves_like "builds correct paths",
+                  store_dir: %r[merge_request_diffs/mr-\d+],
+                  cache_dir: %r[/external-diffs/tmp/cache],
+                  work_dir: %r[/external-diffs/tmp/work]
+
+  context "object store is REMOTE" do
+    before do
+      stub_external_diffs_object_storage
+    end
+
+    include_context 'with storage', described_class::Store::REMOTE
+
+    it_behaves_like "builds correct paths",
+                    store_dir: %r[merge_request_diffs/mr-\d+]
+  end
+
+  describe 'migration to object storage' do
+    context 'with object storage disabled' do
+      it "is skipped" do
+        expect(ObjectStorage::BackgroundMoveWorker).not_to receive(:perform_async)
+
+        diff
+      end
+    end
+
+    context 'with object storage enabled' do
+      before do
+        stub_external_diffs_setting(enabled: true)
+        stub_external_diffs_object_storage(background_upload: true)
+      end
+
+      it 'is scheduled to run after creation' do
+        expect(ObjectStorage::BackgroundMoveWorker).to receive(:perform_async).with(described_class.name, 'MergeRequestDiff', :external_diff, kind_of(Numeric))
+
+        diff
+      end
+    end
+  end
+
+  describe 'remote file' do
+    context 'with object storage enabled' do
+      before do
+        stub_external_diffs_setting(enabled: true)
+        stub_external_diffs_object_storage
+
+        diff.update!(external_diff_store: described_class::Store::REMOTE)
+      end
+
+      it 'can store file remotely' do
+        allow(ObjectStorage::BackgroundMoveWorker).to receive(:perform_async)
+
+        diff
+
+        expect(diff.external_diff_store).to eq(described_class::Store::REMOTE)
+        expect(diff.external_diff.path).not_to be_blank
+      end
+    end
+  end
+end