call Gitlab::Favicon.status in serializer

this ways we can keep the `lib/gitlab/ci/status/*` classes to return the
bare favicon name as it was before.

also the favicon uploader versions are now have the same names as the
stock favicons (+ `favicon_` prefix), which makes working with the
status names easier.

1 files changed, 3 insertions, 3 deletions

diff --git a/spec/uploaders/favicon_uploader_spec.rb b/spec/uploaders/favicon_uploader_spec.rb
index 5989d294112..b521670addb 100644
--- a/spec/uploaders/favicon_uploader_spec.rb
+++ b/spec/uploaders/favicon_uploader_spec.rb
@@ -19,11 +19,11 @@ RSpec.describe FaviconUploader do
     end
 
     it 'has the correct format' do
-      expect(uploader.default).to be_format('ico')
+      expect(uploader.favicon_main).to be_format('ico')
     end
 
     it 'has the correct dimensions' do
-      expect(uploader.default).to have_dimensions(32, 32)
+      expect(uploader.favicon_main).to have_dimensions(32, 32)
     end
 
     it 'generates all the status icons' do
@@ -31,7 +31,7 @@ RSpec.describe FaviconUploader do
       expect(FaviconUploader::STATUS_ICON_NAMES.count).to eq 10
 
       FaviconUploader::STATUS_ICON_NAMES.each do |status_name|
-        expect(File.exist?(uploader.status_not_found.file.file)).to be true
+        expect(File.exist?(uploader.favicon_status_not_found.file.file)).to be true
       end
     end
   end