diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-10-21 10:08:36 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-10-21 10:08:36 +0300 |
commit | 48aff82709769b098321c738f3444b9bdaa694c6 (patch) | |
tree | e00c7c43e2d9b603a5a6af576b1685e400410dee /spec/views/projects/tracing/show.html.haml_spec.rb | |
parent | 879f5329ee916a948223f8f43d77fba4da6cd028 (diff) |
Add latest changes from gitlab-org/gitlab@13-5-stable-eev13.5.0-rc42
Diffstat (limited to 'spec/views/projects/tracing/show.html.haml_spec.rb')
-rw-r--r-- | spec/views/projects/tracing/show.html.haml_spec.rb | 59 |
1 files changed, 59 insertions, 0 deletions
diff --git a/spec/views/projects/tracing/show.html.haml_spec.rb b/spec/views/projects/tracing/show.html.haml_spec.rb new file mode 100644 index 00000000000..96dc6a18fc7 --- /dev/null +++ b/spec/views/projects/tracing/show.html.haml_spec.rb @@ -0,0 +1,59 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe 'projects/tracings/show' do + let_it_be_with_reload(:project) { create(:project) } + let_it_be(:error_tracking_setting) { create(:project_error_tracking_setting, project: project) } + + before do + assign(:project, project) + allow(view).to receive(:error_tracking_setting) + .and_return(error_tracking_setting) + end + + context 'with project.tracing_external_url' do + let_it_be(:tracing_url) { 'https://tracing.url' } + let_it_be(:tracing_setting) { create(:project_tracing_setting, project: project, external_url: tracing_url) } + + before do + allow(view).to receive(:can?).and_return(true) + allow(view).to receive(:tracing_setting).and_return(tracing_setting) + end + + it 'renders iframe' do + render + + expect(rendered).to match(/iframe/) + end + + context 'with malicious external_url' do + let(:malicious_tracing_url) { "https://replaceme.com/'><script>alert(document.cookie)</script>" } + let(:cleaned_url) { "https://replaceme.com/'>" } + + before do + tracing_setting.update_column(:external_url, malicious_tracing_url) + end + + it 'sanitizes external_url' do + render + + expect(tracing_setting.external_url).to eq(malicious_tracing_url) + expect(rendered).to have_xpath("//iframe[@src=\"#{cleaned_url}\"]") + end + end + end + + context 'without project.tracing_external_url' do + before do + allow(view).to receive(:can?).and_return(true) + end + + it 'renders empty state' do + render + + expect(rendered).to have_link('Add Jaeger URL') + expect(rendered).not_to match(/iframe/) + end + end +end |