diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-05-19 10:33:21 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-05-19 10:33:21 +0300 |
commit | 36a59d088eca61b834191dacea009677a96c052f (patch) | |
tree | e4f33972dab5d8ef79e3944a9f403035fceea43f /spec/workers/container_expiration_policy_worker_spec.rb | |
parent | a1761f15ec2cae7c7f7bbda39a75494add0dfd6f (diff) |
Add latest changes from gitlab-org/gitlab@15-0-stable-eev15.0.0-rc42
Diffstat (limited to 'spec/workers/container_expiration_policy_worker_spec.rb')
-rw-r--r-- | spec/workers/container_expiration_policy_worker_spec.rb | 84 |
1 files changed, 3 insertions, 81 deletions
diff --git a/spec/workers/container_expiration_policy_worker_spec.rb b/spec/workers/container_expiration_policy_worker_spec.rb index 2cfb613865d..ef6266aeba3 100644 --- a/spec/workers/container_expiration_policy_worker_spec.rb +++ b/spec/workers/container_expiration_policy_worker_spec.rb @@ -11,15 +11,13 @@ RSpec.describe ContainerExpirationPolicyWorker do describe '#perform' do subject { worker.perform } - shared_examples 'not executing any policy' do - it 'does not run any policy' do - expect(ContainerExpirationPolicyService).not_to receive(:new) + context 'process cleanups' do + it 'calls the limited capacity worker' do + expect(ContainerExpirationPolicies::CleanupContainerRepositoryWorker).to receive(:perform_with_capacity) subject end - end - shared_examples 'handling a taken exclusive lease' do context 'with exclusive lease taken' do before do stub_exclusive_lease_taken(worker.lease_key, timeout: 5.hours) @@ -34,82 +32,6 @@ RSpec.describe ContainerExpirationPolicyWorker do end end - context 'with throttling enabled' do - before do - stub_feature_flags(container_registry_expiration_policies_throttling: true) - end - - it 'calls the limited capacity worker' do - expect(ContainerExpirationPolicies::CleanupContainerRepositoryWorker).to receive(:perform_with_capacity) - - subject - end - - it_behaves_like 'handling a taken exclusive lease' - end - - context 'with throttling disabled' do - before do - stub_feature_flags(container_registry_expiration_policies_throttling: false) - end - - context 'with no container expiration policies' do - it_behaves_like 'not executing any policy' - end - - context 'with container expiration policies' do - let_it_be(:container_expiration_policy, reload: true) { create(:container_expiration_policy, :runnable) } - let_it_be(:container_repository) { create(:container_repository, project: container_expiration_policy.project) } - - context 'a valid policy' do - it 'runs the policy' do - expect(ContainerExpirationPolicyService) - .to receive(:new).with(container_expiration_policy.project, nil).and_call_original - expect(CleanupContainerRepositoryWorker).to receive(:perform_async).once.and_call_original - - expect { subject }.not_to raise_error - end - end - - context 'a disabled policy' do - before do - container_expiration_policy.disable! - end - - it_behaves_like 'not executing any policy' - end - - context 'a policy that is not due for a run' do - before do - container_expiration_policy.update_column(:next_run_at, 2.minutes.from_now) - end - - it_behaves_like 'not executing any policy' - end - - context 'a policy linked to no container repository' do - before do - container_expiration_policy.container_repositories.delete_all - end - - it_behaves_like 'not executing any policy' - end - - context 'an invalid policy' do - before do - container_expiration_policy.update_column(:name_regex, '*production') - end - - it 'disables the policy and tracks an error' do - expect(ContainerExpirationPolicyService).not_to receive(:new).with(container_expiration_policy, nil) - expect(Gitlab::ErrorTracking).to receive(:log_exception).with(instance_of(described_class::InvalidPolicyError), container_expiration_policy_id: container_expiration_policy.id) - - expect { subject }.to change { container_expiration_policy.reload.enabled }.from(true).to(false) - end - end - end - end - context 'process stale ongoing cleanups' do let_it_be(:stuck_cleanup) { create(:container_repository, :cleanup_ongoing, expiration_policy_started_at: 1.day.ago) } let_it_be(:container_repository1) { create(:container_repository, :cleanup_scheduled) } |