diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2016-10-04 19:03:10 +0300 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2016-10-05 13:40:17 +0300 |
| commit | 16ed9b6129daf51a296d4576580c5f232d043db6 (patch) | |
| tree | 107b5b70f5f4b43ad5ddbda7b2d31fc5627150e6 /spec/workers/post_receive_spec.rb | |
| parent | 7887a3dafb6902cc39c831e307c48faf49f80b51 (diff) | |
Refactor Gitlab::Identifier
This refactors Gitlab::Identifier so it uses fewer queries and is
actually tested. Queries are reduced by caching the output as well as
using 1 query (instead of 2) to find a user using an SSH key.
Diffstat (limited to 'spec/workers/post_receive_spec.rb')
| -rw-r--r-- | spec/workers/post_receive_spec.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/spec/workers/post_receive_spec.rb b/spec/workers/post_receive_spec.rb index 1d2cf7acddd..ffeaafe654a 100644 --- a/spec/workers/post_receive_spec.rb +++ b/spec/workers/post_receive_spec.rb @@ -79,7 +79,9 @@ describe PostReceive do end it "does not run if the author is not in the project" do - allow(Key).to receive(:find_by).with(hash_including(id: anything())) { nil } + allow_any_instance_of(Gitlab::GitPostReceive). + to receive(:identify_using_ssh_key). + and_return(nil) expect(project).not_to receive(:execute_hooks) |