diff options
author | Douwe Maan <douwe@gitlab.com> | 2018-11-28 15:36:26 +0300 |
---|---|---|
committer | Douwe Maan <douwe@gitlab.com> | 2018-11-28 15:36:26 +0300 |
commit | ae563565387177e8d15b2402246cab6315e9a04b (patch) | |
tree | d63722883c38ee62f8643d461ec32e72f0c9044c /spec | |
parent | 06d1db85b807c9d390bdab624ca095138bc86863 (diff) | |
parent | 329a890f8baebb2da3b30d4b2fdfc0cc1f96b5e6 (diff) |
Merge branch '51061-readme-url-n-1-rpc-call-resolved' into 'master'
Resolves N+1 RPC call for Project#readme_url
Closes #51061
See merge request gitlab-org/gitlab-ce!23357
Diffstat (limited to 'spec')
-rw-r--r-- | spec/models/repository_spec.rb | 40 |
1 files changed, 39 insertions, 1 deletions
diff --git a/spec/models/repository_spec.rb b/spec/models/repository_spec.rb index 187283b284b..f09b4b67061 100644 --- a/spec/models/repository_spec.rb +++ b/spec/models/repository_spec.rb @@ -1488,6 +1488,7 @@ describe Repository do :size, :commit_count, :rendered_readme, + :readme_path, :contribution_guide, :changelog, :license_blob, @@ -1874,6 +1875,42 @@ describe Repository do end end + describe '#readme_path', :use_clean_rails_memory_store_caching do + context 'with a non-existing repository' do + let(:project) { create(:project) } + + it 'returns nil' do + expect(repository.readme_path).to be_nil + end + end + + context 'with an existing repository' do + context 'when no README exists' do + let(:project) { create(:project, :empty_repo) } + + it 'returns nil' do + expect(repository.readme_path).to be_nil + end + end + + context 'when a README exists' do + let(:project) { create(:project, :repository) } + + it 'returns the README' do + expect(repository.readme_path).to eq("README.md") + end + + it 'caches the response' do + expect(repository).to receive(:readme).and_call_original.once + + 2.times do + expect(repository.readme_path).to eq("README.md") + end + end + end + end + end + describe '#expire_statistics_caches' do it 'expires the caches' do expect(repository).to receive(:expire_method_caches) @@ -2042,9 +2079,10 @@ describe Repository do describe '#refresh_method_caches' do it 'refreshes the caches of the given types' do expect(repository).to receive(:expire_method_caches) - .with(%i(rendered_readme license_blob license_key license)) + .with(%i(rendered_readme readme_path license_blob license_key license)) expect(repository).to receive(:rendered_readme) + expect(repository).to receive(:readme_path) expect(repository).to receive(:license_blob) expect(repository).to receive(:license_key) expect(repository).to receive(:license) |