diff options
author | Robert Speicher <rspeicher@gmail.com> | 2017-06-10 01:12:00 +0300 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2017-06-10 01:23:19 +0300 |
commit | f2dee8e8555409d3b1d333703581c6d62166cf83 (patch) | |
tree | 6096261b6d7aa2d15f1c51f8c3e671f19ff40782 /spec | |
parent | b16730fc8317b282d5dc86dbc8936c74303f5a36 (diff) |
Test todos_count_format helper at the correct level to improve speed
Instead of an integration test that creates 101 Todo records to test a
simple view helper, just unit test the helper.
Diffstat (limited to 'spec')
-rw-r--r-- | spec/features/todos/todos_spec.rb | 23 | ||||
-rw-r--r-- | spec/helpers/todos_helper_spec.rb | 13 |
2 files changed, 13 insertions, 23 deletions
diff --git a/spec/features/todos/todos_spec.rb b/spec/features/todos/todos_spec.rb index bb4b2aed0e3..feb2fe8a7d1 100644 --- a/spec/features/todos/todos_spec.rb +++ b/spec/features/todos/todos_spec.rb @@ -333,29 +333,6 @@ describe 'Dashboard Todos', feature: true do end end - context 'User have large number of todos' do - before do - create_list(:todo, 101, :mentioned, user: user, project: project, target: issue, author: author) - - login_as(user) - visit dashboard_todos_path - end - - it 'shows 99+ for count >= 100 in notification' do - expect(page).to have_selector('.todos-count', text: '99+') - end - - it 'shows exact number in To do tab' do - expect(page).to have_selector('.todos-pending .badge', text: '101') - end - - it 'shows exact number for count < 100' do - 3.times { first('.js-done-todo').click } - - expect(page).to have_selector('.todos-count', text: '98') - end - end - context 'User has a Build Failed todo' do let!(:todo) { create(:todo, :build_failed, user: user, project: project, author: author) } diff --git a/spec/helpers/todos_helper_spec.rb b/spec/helpers/todos_helper_spec.rb index 50060a0925d..18a41ca24e3 100644 --- a/spec/helpers/todos_helper_spec.rb +++ b/spec/helpers/todos_helper_spec.rb @@ -1,6 +1,19 @@ require "spec_helper" describe TodosHelper do + describe '#todos_count_format' do + it 'shows fuzzy count for 100 or more items' do + expect(helper.todos_count_format(100)).to eq '99+' + expect(helper.todos_count_format(1000)).to eq '99+' + end + + it 'shows exact count for 99 or fewer items' do + expect(helper.todos_count_format(99)).to eq '99' + expect(helper.todos_count_format(50)).to eq '50' + expect(helper.todos_count_format(1)).to eq '1' + end + end + describe '#todo_projects_options' do let(:projects) { create_list(:empty_project, 3) } let(:user) { create(:user) } |