diff options
| author | Paul Slaughter <pslaughter@gitlab.com> | 2019-09-01 05:58:31 +0300 |
|---|---|---|
| committer | Paul Slaughter <pslaughter@gitlab.com> | 2019-09-01 05:58:31 +0300 |
| commit | bfed409d373b7f373c8dd5f33aade3c620690fec (patch) | |
| tree | 9b4c5d185b5993f59c8c655aa323bb261b21630c /spec | |
| parent | dc864927246746a34b675c7ee8ffbd1b533841e0 (diff) | |
| parent | 9575288f6259e37726c61451478b9c7d5a73b843 (diff) | |
Merge branch 'refactor/showStagedIcon' into 'master'
Refactor showStagedIcon property's behavior to match its name
Closes #66071
See merge request gitlab-org/gitlab-ce!32333
Diffstat (limited to 'spec')
| -rw-r--r-- | spec/frontend/vue_shared/components/changed_file_icon_spec.js | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/spec/frontend/vue_shared/components/changed_file_icon_spec.js b/spec/frontend/vue_shared/components/changed_file_icon_spec.js index 806602877ef..d0586f9e63f 100644 --- a/spec/frontend/vue_shared/components/changed_file_icon_spec.js +++ b/spec/frontend/vue_shared/components/changed_file_icon_spec.js @@ -106,12 +106,10 @@ describe('Changed file icon', () => { expect(findIcon().props('size')).toBe(size); }); - // NOTE: It looks like 'showStagedIcon' behavior is backwards to what the name suggests - // https://gitlab.com/gitlab-org/gitlab-ce/issues/66071 it.each` showStagedIcon | iconName | desc - ${false} | ${'file-modified-solid'} | ${'with showStagedIcon false, renders staged icon'} - ${true} | ${'file-modified'} | ${'with showStagedIcon true, renders regular icon'} + ${true} | ${'file-modified-solid'} | ${'with showStagedIcon true, renders staged icon'} + ${false} | ${'file-modified'} | ${'with showStagedIcon false, renders regular icon'} `('$desc', ({ showStagedIcon, iconName }) => { factory({ file: stagedFile(), |