Move #create_confidentiality_note to Issues::UpdateService

Signed-off-by: Rémy Coutable <remy@rymai.me>

2 files changed, 5 insertions, 13 deletions

diff --git a/spec/services/issues/update_service_spec.rb b/spec/services/issues/update_service_spec.rb
index c9d8f1b382c..810a1f2d666 100644
--- a/spec/services/issues/update_service_spec.rb
+++ b/spec/services/issues/update_service_spec.rb
@@ -82,10 +82,10 @@ describe Issues::UpdateService, services: true do
       end
 
       it 'creates system note about confidentiality change' do
-        note = find_note('Marked as confidential')
+        note = find_note('Made the issue confidential')
 
         expect(note).not_to be_nil
-        expect(note.note).to eq 'Marked as confidential'
+        expect(note.note).to eq 'Made the issue confidential'
       end
     end
 
diff --git a/spec/services/system_note_service_spec.rb b/spec/services/system_note_service_spec.rb
index 4fa60436155..bffad59b8b6 100644
--- a/spec/services/system_note_service_spec.rb
+++ b/spec/services/system_note_service_spec.rb
@@ -244,24 +244,16 @@ describe SystemNoteService, services: true do
           to eq "Title changed from **Old title** to **#{noteable.title}**"
       end
     end
-
-    context 'when noteable does not respond to `title' do
-      let(:noteable) { double('noteable') }
-
-      it 'returns nil' do
-        expect(subject).to be_nil
-      end
-    end
   end
 
-  describe '.change_confidentiality' do
-    subject { described_class.change_confidentiality(noteable, project, author) }
+  describe '.change_issue_confidentiality' do
+    subject { described_class.change_issue_confidentiality(noteable, project, author) }
 
     context 'when noteable responds to `confidential`' do
       it_behaves_like 'a system note'
 
       it 'sets the note text' do
-        expect(subject.note).to eq "Marked as not confidential"
+        expect(subject.note).to eq 'Made the issue visible'
       end
     end
   end