diff options
author | Douwe Maan <douwe@gitlab.com> | 2017-08-15 18:05:28 +0300 |
---|---|---|
committer | Jarka Kadlecova <jarka@gitlab.com> | 2017-08-16 18:24:00 +0300 |
commit | ed1ff6baa7898eda26f495198be25cd6f5d67cb4 (patch) | |
tree | 88fc5cc64b5cbe65f090ebcec0bdea65b7867ce9 /spec | |
parent | 421dbfade101e3058b13979eeb3cf1a66b7c18e7 (diff) |
Merge branch 'fix-any-projects-array' into 'master'
Allow usage of any_projects? with an Array
Closes #3646
See merge request !13559
Diffstat (limited to 'spec')
-rw-r--r-- | spec/helpers/projects_helper_spec.rb | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/spec/helpers/projects_helper_spec.rb b/spec/helpers/projects_helper_spec.rb index 37a5e6b474e..d1efa318d14 100644 --- a/spec/helpers/projects_helper_spec.rb +++ b/spec/helpers/projects_helper_spec.rb @@ -432,9 +432,7 @@ describe ProjectsHelper do end describe '#any_projects?' do - before do - create(:project) - end + let!(:project) { create(:project) } it 'returns true when projects will be returned' do expect(helper.any_projects?(Project.all)).to eq(true) @@ -444,6 +442,14 @@ describe ProjectsHelper do expect(helper.any_projects?(Project.none)).to eq(false) end + it 'returns true when using a non-empty Array' do + expect(helper.any_projects?([project])).to eq(true) + end + + it 'returns false when using an empty Array' do + expect(helper.any_projects?([])).to eq(false) + end + it 'only executes a single query when a LIMIT is applied' do relation = Project.limit(1) recorder = ActiveRecord::QueryRecorder.new do |