Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorDhiraj Bodicherla <dhiraj@gitlab.com>2019-06-20 23:27:57 +0300
committerDhiraj Bodicherla <dhiraj@gitlab.com>2019-06-27 02:09:11 +0300
commit862e3ebad7d9589f677e06c35ed53c1e41855fd3 (patch)
tree53663d6ecbeafdde1ef1f3c944392829541c608b /spec
parent13d8992006c5212726b843c4dd06d43caab2f7f9 (diff)
Turn commit sha in monitor charts popover to link
Commit sha in deployment popovers within monitoring dashboard are not clickable or selectable. This commit makes those commit sha links selectable and point to projects commit page
Diffstat (limited to 'spec')
-rw-r--r--spec/javascripts/monitoring/charts/area_spec.js15
1 files changed, 12 insertions, 3 deletions
diff --git a/spec/javascripts/monitoring/charts/area_spec.js b/spec/javascripts/monitoring/charts/area_spec.js
index ac7e0bb12a1..d3a76f33679 100644
--- a/spec/javascripts/monitoring/charts/area_spec.js
+++ b/spec/javascripts/monitoring/charts/area_spec.js
@@ -1,14 +1,19 @@
import { shallowMount } from '@vue/test-utils';
+import { GlLink } from '@gitlab/ui';
import { GlAreaChart, GlChartSeriesLabel } from '@gitlab/ui/dist/charts';
import { shallowWrapperContainsSlotText } from 'spec/helpers/vue_test_utils_helper';
import Area from '~/monitoring/components/charts/area.vue';
import { createStore } from '~/monitoring/stores';
import * as types from '~/monitoring/stores/mutation_types';
+import { TEST_HOST } from 'spec/test_constants';
import MonitoringMock, { deploymentData } from '../mock_data';
describe('Area component', () => {
+ const mockSha = 'mockSha';
const mockWidgets = 'mockWidgets';
const mockSvgPathContent = 'mockSvgPathContent';
+ const projectPath = `${TEST_HOST}/path/to/project`;
+ const commitUrl = `${projectPath}/commit/${mockSha}`;
let mockGraphData;
let areaChart;
let spriteSpy;
@@ -26,6 +31,7 @@ describe('Area component', () => {
graphData: mockGraphData,
containerWidth: 0,
deploymentData: store.state.monitoringDashboard.deploymentData,
+ projectPath,
},
slots: {
default: mockWidgets,
@@ -88,11 +94,14 @@ describe('Area component', () => {
);
});
- it('renders commit sha in tooltip content', () => {
- const mockSha = 'mockSha';
+ it('renders clickable commit sha in tooltip content', () => {
areaChart.vm.tooltip.sha = mockSha;
+ areaChart.vm.tooltip.commitUrl = commitUrl;
- expect(shallowWrapperContainsSlotText(glAreaChart, 'tooltipContent', mockSha)).toBe(true);
+ const commitLink = areaChart.find(GlLink);
+
+ expect(shallowWrapperContainsSlotText(commitLink, 'default', mockSha)).toBe(true);
+ expect(commitLink.attributes('href')).toEqual(commitUrl);
});
});
});