diff options
| author | Sean McGivern <sean@mcgivern.me.uk> | 2017-03-21 14:57:38 +0300 |
|---|---|---|
| committer | Lin Jen-Shin <godfat@godfat.org> | 2017-03-21 17:38:42 +0300 |
| commit | 9e53fb5e55a36585671c2724d670f07f812d2f12 (patch) | |
| tree | b79c3c8e909b9347a09a0e9137843398e3b5020d /spec | |
| parent | 169c70fda4635d13fc69f86a6f20d07f755651e8 (diff) | |
Merge branch 'api-project-issues-404' into 'master'
Return 404 in project issues API endpoint when project cannot be found
Closes #29631
See merge request !10093
Diffstat (limited to 'spec')
| -rw-r--r-- | spec/requests/api/issues_spec.rb | 6 | ||||
| -rw-r--r-- | spec/requests/api/v3/issues_spec.rb | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/spec/requests/api/issues_spec.rb b/spec/requests/api/issues_spec.rb index ea62186434d..dd17ab58928 100644 --- a/spec/requests/api/issues_spec.rb +++ b/spec/requests/api/issues_spec.rb @@ -534,6 +534,12 @@ describe API::Issues, api: true do describe "GET /projects/:id/issues" do let(:base_url) { "/projects/#{project.id}" } + it 'returns 404 when project does not exist' do + get api('/projects/1000/issues', non_member) + + expect(response).to have_http_status(404) + end + it "returns 404 on private projects for other users" do private_project = create(:empty_project, :private) create(:issue, project: private_project) diff --git a/spec/requests/api/v3/issues_spec.rb b/spec/requests/api/v3/issues_spec.rb index 1941ca0d7d8..51021eec63c 100644 --- a/spec/requests/api/v3/issues_spec.rb +++ b/spec/requests/api/v3/issues_spec.rb @@ -439,6 +439,12 @@ describe API::V3::Issues, api: true do describe "GET /projects/:id/issues" do let(:base_url) { "/projects/#{project.id}" } + it 'returns 404 when project does not exist' do + get v3_api('/projects/1000/issues', non_member) + + expect(response).to have_http_status(404) + end + it "returns 404 on private projects for other users" do private_project = create(:empty_project, :private) create(:issue, project: private_project) |