diff options
author | Stan Hu <stanhu@gmail.com> | 2019-02-26 21:45:47 +0300 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2019-02-26 21:45:47 +0300 |
commit | 9812006568061f0afd8dfb146920e526877d4d9b (patch) | |
tree | e9537264f5b8c031b9c922d16c50e44a3e3f8fd1 /spec | |
parent | 9b3a0de5ed44fdcdb01bd520ad8e0ec8e3ab7ea6 (diff) | |
parent | f4be2d4e1bd4ac456610c72862f20ff29b3820a8 (diff) |
Merge branch 'revert-48e6db0d' into 'master'
Revert "Merge branch '56726-fix-n+1-in-issues-and-merge-requests-api' into 'master'"
See merge request gitlab-org/gitlab-ce!25570
Diffstat (limited to 'spec')
-rw-r--r-- | spec/lib/gitlab/issuable_metadata_spec.rb | 8 | ||||
-rw-r--r-- | spec/requests/api/merge_requests_spec.rb | 12 |
2 files changed, 4 insertions, 16 deletions
diff --git a/spec/lib/gitlab/issuable_metadata_spec.rb b/spec/lib/gitlab/issuable_metadata_spec.rb index 6ec86163233..42635a68ee1 100644 --- a/spec/lib/gitlab/issuable_metadata_spec.rb +++ b/spec/lib/gitlab/issuable_metadata_spec.rb @@ -28,12 +28,12 @@ describe Gitlab::IssuableMetadata do expect(data.count).to eq(2) expect(data[issue.id].upvotes).to eq(1) expect(data[issue.id].downvotes).to eq(0) - expect(data[issue.id].user_notes_count).to eq(0) + expect(data[issue.id].notes_count).to eq(0) expect(data[issue.id].merge_requests_count).to eq(1) expect(data[closed_issue.id].upvotes).to eq(0) expect(data[closed_issue.id].downvotes).to eq(1) - expect(data[closed_issue.id].user_notes_count).to eq(0) + expect(data[closed_issue.id].notes_count).to eq(0) expect(data[closed_issue.id].merge_requests_count).to eq(0) end end @@ -51,12 +51,12 @@ describe Gitlab::IssuableMetadata do expect(data.count).to eq(2) expect(data[merge_request.id].upvotes).to eq(1) expect(data[merge_request.id].downvotes).to eq(1) - expect(data[merge_request.id].user_notes_count).to eq(1) + expect(data[merge_request.id].notes_count).to eq(1) expect(data[merge_request.id].merge_requests_count).to eq(0) expect(data[merge_request_closed.id].upvotes).to eq(0) expect(data[merge_request_closed.id].downvotes).to eq(0) - expect(data[merge_request_closed.id].user_notes_count).to eq(0) + expect(data[merge_request_closed.id].notes_count).to eq(0) expect(data[merge_request_closed.id].merge_requests_count).to eq(0) end end diff --git a/spec/requests/api/merge_requests_spec.rb b/spec/requests/api/merge_requests_spec.rb index edeb52adbb2..b4cd3130dc5 100644 --- a/spec/requests/api/merge_requests_spec.rb +++ b/spec/requests/api/merge_requests_spec.rb @@ -320,18 +320,6 @@ describe API::MergeRequests do expect(json_response.first['title']).to eq merge_request_closed.title expect(json_response.first['id']).to eq merge_request_closed.id end - - it 'avoids N+1 queries' do - control = ActiveRecord::QueryRecorder.new do - get api("/projects/#{project.id}/merge_requests", user) - end.count - - create(:merge_request, author: user, assignee: user, source_project: project, target_project: project, created_at: base_time) - - expect do - get api("/projects/#{project.id}/merge_requests", user) - end.not_to exceed_query_limit(control) - end end describe "GET /groups/:id/merge_requests" do |