diff options
author | Sean McGivern <sean@mcgivern.me.uk> | 2018-01-18 14:18:44 +0300 |
---|---|---|
committer | Sean McGivern <sean@mcgivern.me.uk> | 2018-01-18 14:18:44 +0300 |
commit | d617c24f59f9cc1c068301ec755caa2de6cd6b73 (patch) | |
tree | 485ab910acbd4045a72172ce005aaac9b8a3eaf9 /spec | |
parent | 2af0b083c6791f50681a1afdae3d59e703c693b5 (diff) | |
parent | 1a3bcc76ea14dda52447a517122117942914ecac (diff) |
Merge branch '42129-fix-project-snippet-user-agent-detail' into 'master'
Fix the user-agent detail API endpoint for project snippets
Closes #42129
See merge request gitlab-org/gitlab-ce!16521
Diffstat (limited to 'spec')
-rw-r--r-- | spec/requests/api/project_snippets_spec.rb | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/spec/requests/api/project_snippets_spec.rb b/spec/requests/api/project_snippets_spec.rb index e741ac4b7bd..4a2289ca137 100644 --- a/spec/requests/api/project_snippets_spec.rb +++ b/spec/requests/api/project_snippets_spec.rb @@ -1,9 +1,9 @@ require 'rails_helper' describe API::ProjectSnippets do - let(:project) { create(:project, :public) } - let(:user) { create(:user) } - let(:admin) { create(:admin) } + set(:project) { create(:project, :public) } + set(:user) { create(:user) } + set(:admin) { create(:admin) } describe "GET /projects/:project_id/snippets/:id/user_agent_detail" do let(:snippet) { create(:project_snippet, :public, project: project) } @@ -18,6 +18,13 @@ describe API::ProjectSnippets do expect(json_response['akismet_submitted']).to eq(user_agent_detail.submitted) end + it 'respects project scoping' do + other_project = create(:project) + + get api("/projects/#{other_project.id}/snippets/#{snippet.id}/user_agent_detail", admin) + expect(response).to have_gitlab_http_status(404) + end + it "returns unautorized for non-admin users" do get api("/projects/#{snippet.project.id}/snippets/#{snippet.id}/user_agent_detail", user) |