diff options
author | Douwe Maan <douwe@gitlab.com> | 2019-03-07 14:24:23 +0300 |
---|---|---|
committer | Douwe Maan <douwe@gitlab.com> | 2019-03-07 14:24:23 +0300 |
commit | e571cbaa2f0b5096e514bc96fbc8f26909d8e52b (patch) | |
tree | ae7102a87c932b8843c5644395d2a95c57a5ee5a /spec | |
parent | 45b3c5420c1a45595211f941bac23ad9f2188af7 (diff) | |
parent | f40aecddb763cf0b9a37a8e9aa00229e60bd5e2b (diff) |
Merge branch 'gt-update-activity-filter-for-issues' into 'master'
Update activity filter for issues
Closes #53334
See merge request gitlab-org/gitlab-ce!23423
Diffstat (limited to 'spec')
-rw-r--r-- | spec/features/dashboard/activity_spec.rb | 17 | ||||
-rw-r--r-- | spec/lib/event_filter_spec.rb | 8 |
2 files changed, 19 insertions, 6 deletions
diff --git a/spec/features/dashboard/activity_spec.rb b/spec/features/dashboard/activity_spec.rb index bf91dc121d8..c55dc4523f7 100644 --- a/spec/features/dashboard/activity_spec.rb +++ b/spec/features/dashboard/activity_spec.rb @@ -39,6 +39,8 @@ describe 'Dashboard > Activity' do event end + let(:issue) { create(:issue, project: project) } + let!(:merged_event) do create(:event, :merged, project: project, target: merge_request, author: user) end @@ -59,6 +61,10 @@ describe 'Dashboard > Activity' do create(:event, :closed, project: project, target: milestone, author: user) end + let!(:issue_event) do + create(:event, :created, project: project, target: issue, author: user) + end + before do project.add_maintainer(user) @@ -74,6 +80,7 @@ describe 'Dashboard > Activity' do expect(page).to have_content('closed') expect(page).to have_content('commented on') expect(page).to have_content('closed milestone') + expect(page).to have_content('opened issue') end end @@ -87,6 +94,7 @@ describe 'Dashboard > Activity' do expect(page).not_to have_content('accepted') expect(page).not_to have_content('closed') expect(page).not_to have_content('commented on') + expect(page).not_to have_content('opened issue') end end @@ -100,6 +108,7 @@ describe 'Dashboard > Activity' do expect(page).to have_content('accepted') expect(page).not_to have_content('closed') expect(page).not_to have_content('commented on') + expect(page).not_to have_content('opened issue') end end @@ -111,9 +120,10 @@ describe 'Dashboard > Activity' do expect(page).not_to have_content('pushed new branch') expect(page).not_to have_content('joined') expect(page).not_to have_content('accepted') - expect(page).to have_content('closed') + expect(page).not_to have_content('closed') expect(page).not_to have_content('commented on') - expect(page).to have_content('closed milestone') + expect(page).not_to have_content('closed milestone') + expect(page).to have_content('opened issue') end end @@ -127,6 +137,7 @@ describe 'Dashboard > Activity' do expect(page).not_to have_content('accepted') expect(page).not_to have_content('closed') expect(page).to have_content('commented on') + expect(page).not_to have_content('opened issue') end end @@ -140,6 +151,7 @@ describe 'Dashboard > Activity' do expect(page).not_to have_content('accepted') expect(page).not_to have_content('closed') expect(page).not_to have_content('commented on') + expect(page).not_to have_content('opened issue') end end @@ -155,6 +167,7 @@ describe 'Dashboard > Activity' do expect(page).not_to have_content('accepted') expect(page).not_to have_content('closed') expect(page).not_to have_content('commented on') + expect(page).not_to have_content('opened issue') end end end diff --git a/spec/lib/event_filter_spec.rb b/spec/lib/event_filter_spec.rb index 30016da6828..6648e141b7a 100644 --- a/spec/lib/event_filter_spec.rb +++ b/spec/lib/event_filter_spec.rb @@ -26,10 +26,10 @@ describe EventFilter do set(:push_event) { create(:push_event, project: public_project) } set(:merged_event) { create(:event, :merged, project: public_project, target: public_project) } - set(:created_event) { create(:event, :created, project: public_project, target: public_project) } - set(:updated_event) { create(:event, :updated, project: public_project, target: public_project) } - set(:closed_event) { create(:event, :closed, project: public_project, target: public_project) } - set(:reopened_event) { create(:event, :reopened, project: public_project, target: public_project) } + set(:created_event) { create(:event, :created, project: public_project, target: create(:issue, project: public_project)) } + set(:updated_event) { create(:event, :updated, project: public_project, target: create(:issue, project: public_project)) } + set(:closed_event) { create(:event, :closed, project: public_project, target: create(:issue, project: public_project)) } + set(:reopened_event) { create(:event, :reopened, project: public_project, target: create(:issue, project: public_project)) } set(:comments_event) { create(:event, :commented, project: public_project, target: public_project) } set(:joined_event) { create(:event, :joined, project: public_project, target: public_project) } set(:left_event) { create(:event, :left, project: public_project, target: public_project) } |