diff options
author | Rémy Coutable <remy@rymai.me> | 2016-10-13 19:33:19 +0300 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2016-10-17 15:13:42 +0300 |
commit | b777bd73f30bc5a2cf03e73512ec31bbe747b320 (patch) | |
tree | df3f5600f9c3bca5c18ac8aa1a943ed92a7bacf0 /spec | |
parent | 42195ff6598349d2d45813eedd2184ec3f9b5175 (diff) |
Merge branch '22655-deployments-don-t-always-have-keep-around-refs' into 'master'
Handle case where deployment ref no longer exists
## What does this MR do?
In 8.9, we didn't create keep-around refs for deployments. So it's possible that someone created a deployment (say, for testing), and then deleted the branch and all other references to that commit. That commit could then get GCed, and trying to view MRs on 8.11+ will show a 500. See https://gitlab.com/gitlab-org/gitlab-ce/issues/22655#note_16575020 for more details.
## Why was this MR needed?
If someone created a deployment on 8.9, then deleted all references to the commit for that deployment, we will throw an exception when checking if the deployment includes a commit.
Closes #22655.
See merge request !6855
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'spec')
-rw-r--r-- | spec/models/deployment_spec.rb | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/spec/models/deployment_spec.rb b/spec/models/deployment_spec.rb index bfff639ad78..01a4a53a264 100644 --- a/spec/models/deployment_spec.rb +++ b/spec/models/deployment_spec.rb @@ -38,5 +38,14 @@ describe Deployment, models: true do expect(deployment.includes_commit?(commit)).to be true end end + + context 'when the SHA for the deployment does not exist in the repo' do + it 'returns false' do + deployment.update(sha: Gitlab::Git::BLANK_SHA) + commit = project.commit + + expect(deployment.includes_commit?(commit)).to be false + end + end end end |