diff options
author | John Jarvis <jarv@gitlab.com> | 2019-01-02 12:32:48 +0300 |
---|---|---|
committer | John Jarvis <jarv@gitlab.com> | 2019-01-02 12:32:48 +0300 |
commit | e035e469e4b9f4bb716080be13c56d2ef17779ff (patch) | |
tree | 6d240efda1c85b095b70539ab13bef29a054dda8 /spec | |
parent | 1bc6dc28b36ccf031ac24a893263eae578e1a2b0 (diff) | |
parent | 08bfec57c3e17225a93a33e464a898a14741d5c4 (diff) |
Merge branch 'security-master-url-rel' into 'master'
[master] Set URL rel attribute for broken URLs
See merge request gitlab/gitlabhq!2695
Diffstat (limited to 'spec')
-rw-r--r-- | spec/lib/banzai/filter/external_link_filter_spec.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/spec/lib/banzai/filter/external_link_filter_spec.rb b/spec/lib/banzai/filter/external_link_filter_spec.rb index 2a3c0cd78b8..e6dae8d5382 100644 --- a/spec/lib/banzai/filter/external_link_filter_spec.rb +++ b/spec/lib/banzai/filter/external_link_filter_spec.rb @@ -49,16 +49,16 @@ describe Banzai::Filter::ExternalLinkFilter do end context 'for invalid urls' do - it 'skips broken hrefs' do + it 'adds rel and target attributes to broken hrefs' do doc = filter %q(<p><a href="don't crash on broken urls">Google</a></p>) - expected = %q(<p><a href="don't%20crash%20on%20broken%20urls">Google</a></p>) + expected = %q(<p><a href="don't%20crash%20on%20broken%20urls" rel="nofollow noreferrer noopener" target="_blank">Google</a></p>) expect(doc.to_html).to eq(expected) end - it 'skips improperly formatted mailtos' do + it 'adds rel and target to improperly formatted mailtos' do doc = filter %q(<p><a href="mailto://jblogs@example.com">Email</a></p>) - expected = %q(<p><a href="mailto://jblogs@example.com">Email</a></p>) + expected = %q(<p><a href="mailto://jblogs@example.com" rel="nofollow noreferrer noopener" target="_blank">Email</a></p>) expect(doc.to_html).to eq(expected) end |