Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorKamil Trzcinski <ayufan@ayufan.eu>2016-12-07 21:30:14 +0300
committerKamil Trzcinski <ayufan@ayufan.eu>2016-12-07 21:30:14 +0300
commit8842f55201ae4725b307336686f8ab168fa0effb (patch)
tree9fd3079231ad2258374e54e6ff26168e5809be43 /spec
parent93c72e0f71919968972e874519e01370edcce022 (diff)
Code review
Diffstat (limited to 'spec')
-rw-r--r--spec/lib/gitlab/ci/status/factory_spec.rb6
-rw-r--r--spec/lib/gitlab/ci/status/pipeline/factory_spec.rb4
2 files changed, 3 insertions, 7 deletions
diff --git a/spec/lib/gitlab/ci/status/factory_spec.rb b/spec/lib/gitlab/ci/status/factory_spec.rb
index 8ebdbddb001..d5bd7f7102b 100644
--- a/spec/lib/gitlab/ci/status/factory_spec.rb
+++ b/spec/lib/gitlab/ci/status/factory_spec.rb
@@ -1,15 +1,11 @@
require 'spec_helper'
describe Gitlab::Ci::Status::Factory do
- let(:object) { double(status: :created) }
-
subject do
described_class.new(object)
end
- let(:status) do
- subject.fabricate!
- end
+ let(:status) { subject.fabricate! }
context 'when object has a core status' do
HasStatus::AVAILABLE_STATUSES.each do |core_status|
diff --git a/spec/lib/gitlab/ci/status/pipeline/factory_spec.rb b/spec/lib/gitlab/ci/status/pipeline/factory_spec.rb
index 939ad2edf04..d6243940f2e 100644
--- a/spec/lib/gitlab/ci/status/pipeline/factory_spec.rb
+++ b/spec/lib/gitlab/ci/status/pipeline/factory_spec.rb
@@ -21,7 +21,7 @@ describe Gitlab::Ci::Status::Pipeline::Factory do
Gitlab::Ci::Status.const_get(core_status.capitalize))
end
- it 'extends core status with common stage methods' do
+ it 'extends core status with common pipeline methods' do
expect(status).to have_details
expect(status).not_to have_action
expect(status.details_path)
@@ -45,7 +45,7 @@ describe Gitlab::Ci::Status::Pipeline::Factory do
.to be_a Gitlab::Ci::Status::Pipeline::SuccessWithWarnings
end
- it 'extends core status with common stage methods' do
+ it 'extends core status with common pipeline methods' do
expect(status).to have_details
end
end