Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-07-04 12:37:28 +0300
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-07-04 19:36:06 +0300
commitbfad4c61f10f689868817cf0b94cddaa1de22240 (patch)
treed4915bee125f243c7a50f01718f2e556771c27b1 /spec
parenteb151e77ff389c3e22454145cfd55cfaa4be7948 (diff)
Add minor improvements in readability in CI config
Diffstat (limited to 'spec')
-rw-r--r--spec/lib/ci/gitlab_ci_yaml_processor_spec.rb4
-rw-r--r--spec/lib/gitlab/ci/config/node/boolean_spec.rb2
-rw-r--r--spec/lib/gitlab/ci/config/node/configurable_spec.rb1
3 files changed, 3 insertions, 4 deletions
diff --git a/spec/lib/ci/gitlab_ci_yaml_processor_spec.rb b/spec/lib/ci/gitlab_ci_yaml_processor_spec.rb
index 262a91fedff..33b9d5f8f22 100644
--- a/spec/lib/ci/gitlab_ci_yaml_processor_spec.rb
+++ b/spec/lib/ci/gitlab_ci_yaml_processor_spec.rb
@@ -551,8 +551,8 @@ module Ci
config_processor = GitlabCiYamlProcessor.new(config, path)
##
- # When variables config is empty, we asumme this is a correct,
- # see issue #18775
+ # When variables config is empty, we assume this is a valid
+ # configuration, see issue #18775
#
expect(config_processor.job_variables(:rspec))
.to be_an_instance_of(Array).and be_empty
diff --git a/spec/lib/gitlab/ci/config/node/boolean_spec.rb b/spec/lib/gitlab/ci/config/node/boolean_spec.rb
index 32639296e6d..deafa8bf8a7 100644
--- a/spec/lib/gitlab/ci/config/node/boolean_spec.rb
+++ b/spec/lib/gitlab/ci/config/node/boolean_spec.rb
@@ -21,7 +21,7 @@ describe Gitlab::Ci::Config::Node::Boolean do
end
context 'when entry value is not valid' do
- let(:config) { [ 'incorrect' ] }
+ let(:config) { ['incorrect'] }
describe '#errors' do
it 'saves errors' do
diff --git a/spec/lib/gitlab/ci/config/node/configurable_spec.rb b/spec/lib/gitlab/ci/config/node/configurable_spec.rb
index 4a1550517fb..c468ecf957b 100644
--- a/spec/lib/gitlab/ci/config/node/configurable_spec.rb
+++ b/spec/lib/gitlab/ci/config/node/configurable_spec.rb
@@ -22,7 +22,6 @@ describe Gitlab::Ci::Config::Node::Configurable do
validator.validate
end
-
context 'when node validator is invalid' do
let(:instance) { node.new('ls') }