diff options
Diffstat (limited to '.gitlab/merge_request_templates/Removals.md')
| -rw-r--r-- | .gitlab/merge_request_templates/Removals.md | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/.gitlab/merge_request_templates/Removals.md b/.gitlab/merge_request_templates/Removals.md index 9d3738f63b5..0b7f1efe006 100644 --- a/.gitlab/merge_request_templates/Removals.md +++ b/.gitlab/merge_request_templates/Removals.md @@ -5,11 +5,11 @@ /milestone % /assign `@EM/PM` (choose the DRI; remove backticks here, and below) -**Be sure to link this MR to the relevant issue(s).** +**Be sure to link this MR to the relevant issues.** - Deprecation issue: - Removal issue: -- MR that removes the feature (optional): +- MR that removed (or _will_ remove) the feature: If there is no relevant deprecation issue, hit pause and: @@ -45,6 +45,7 @@ Please review the [guidelines for removals](https://about.gitlab.com/handbook/ma - [ ] Follow the process to [create a removal YAML file](https://about.gitlab.com/handbook/marketing/blog/release-posts/#creating-a-removal-entry). - [ ] Add reviewers by the 10th. - [ ] When ready to be merged and not later than the 15th, add the ~ready label and @ message the TW for final review and merge. + - Removal notices should not be merged before the code is removed from the product. Do not mark ~ready until the removal is complete, or you are certain it will be completed within the current milestone and released. If PMs are not sure, they should confirm with their Engineering Manager. ## Reviewers @@ -66,13 +67,15 @@ with the same process as regular docs MRs. Add suggestions as needed, @ message the PM to inform them the first review is complete, and remove yourself as a reviewer if it's not yet ready for merge. +**Removal notices should not be merged before the code is removed from the product.** + <details> <summary>Expand for Details</summary> - [ ] Title: - Length limit: 7 words (not including articles or prepositions). - Capitalization: ensure the title is [sentence cased](https://design.gitlab.com/content/punctuation#case). - - No Markdown `` `code` `` formatting in the title, as it doesn't render correctly in the release post. + - Rewrite to exclude the words `removal` and `remove` if necessary. - [ ] Consistency: - Ensure that all resources (docs, removal, etc.) refer to the feature with the same term / feature name. - [ ] Content: |