diff options
Diffstat (limited to '.rubocop_manual_todo.yml')
| -rw-r--r-- | .rubocop_manual_todo.yml | 302 |
1 files changed, 114 insertions, 188 deletions
diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 647d5e4c5ac..2cbfeec1048 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -10,191 +10,6 @@ # - guidelines for use found in # https://docs.gitlab.com/ee/development/contributing/style_guides.html#resolving-rubocop-exceptions. -# WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/337596 -Graphql/Descriptions: - Exclude: - - 'ee/app/graphql/types/iteration_state_enum.rb' - - 'ee/app/graphql/types/requirements_management/requirement_state_enum.rb' - - 'ee/app/graphql/types/requirements_management/test_report_state_enum.rb' - - 'ee/app/graphql/types/security_scanner_type_enum.rb' - - 'ee/app/graphql/types/vulnerability/issue_link_type_enum.rb' - - 'ee/app/graphql/types/vulnerability_grade_enum.rb' - - 'ee/app/graphql/types/vulnerability_report_type_enum.rb' - - 'ee/app/graphql/types/vulnerability_severity_enum.rb' - - 'ee/app/graphql/types/vulnerability_state_enum.rb' - - 'ee/app/graphql/types/vulnerability_confidence_enum.rb' - - 'app/graphql/resolvers/labels_resolver.rb' - - 'app/graphql/resolvers/merge_requests_resolver.rb' - - 'app/graphql/resolvers/milestones_resolver.rb' - - 'app/graphql/resolvers/package_details_resolver.rb' - - 'app/graphql/resolvers/paginated_tree_resolver.rb' - - 'app/graphql/resolvers/release_resolver.rb' - - 'app/graphql/resolvers/repository_branch_names_resolver.rb' - - 'app/graphql/resolvers/snippets_resolver.rb' - - 'app/graphql/resolvers/todo_resolver.rb' - - 'app/graphql/resolvers/tree_resolver.rb' - - 'app/graphql/resolvers/users/snippets_resolver.rb' - - 'app/graphql/types/admin/analytics/usage_trends/measurement_type.rb' - - 'app/graphql/types/admin/sidekiq_queues/delete_jobs_response_type.rb' - - 'app/graphql/types/alert_management/alert_type.rb' - - 'app/graphql/types/award_emojis/award_emoji_type.rb' - - 'app/graphql/types/ci/config/job_restriction_type.rb' - - 'app/graphql/types/ci/config/status_enum.rb' - - 'app/graphql/types/ci/pipeline_type.rb' - - 'app/graphql/types/ci_configuration/sast/ui_component_size_enum.rb' - - 'app/graphql/types/commit_action_type.rb' - - 'app/graphql/types/container_repository_cleanup_status_enum.rb' - - 'app/graphql/types/container_repository_tag_type.rb' - - 'app/graphql/types/container_repository_type.rb' - - 'app/graphql/types/custom_emoji_type.rb' - - 'app/graphql/types/design_management/design_at_version_type.rb' - - 'app/graphql/types/design_management/design_fields.rb' - - 'app/graphql/types/diff_paths_input_type.rb' - - 'app/graphql/types/environment_type.rb' - - 'app/graphql/types/eventable_type.rb' - - 'app/graphql/types/group_type.rb' - - 'app/graphql/types/merge_request_type.rb' - - 'app/graphql/types/metadata/kas_type.rb' - - 'app/graphql/types/milestone_wildcard_id_enum.rb' - - 'app/graphql/types/namespace_type.rb' - - 'app/graphql/types/notes/note_type.rb' - - 'app/graphql/types/notes/position_type_enum.rb' - - 'app/graphql/types/packages/composer/json_type.rb' - - 'app/graphql/types/packages/package_details_type.rb' - - 'app/graphql/types/packages/package_file_type.rb' - - 'app/graphql/types/packages/package_tag_type.rb' - - 'app/graphql/types/packages/package_type.rb' - - 'app/graphql/types/project_type.rb' - - 'app/graphql/types/prometheus_alert_type.rb' - - 'app/graphql/types/query_type.rb' - - 'app/graphql/types/range_input_type.rb' - - 'app/graphql/types/release_asset_link_shared_input_arguments.rb' - - 'app/graphql/types/release_assets_input_type.rb' - - 'app/graphql/types/release_type.rb' - - 'app/graphql/types/repository/blob_type.rb' - - 'app/graphql/types/root_storage_statistics_type.rb' - - 'app/graphql/types/snippet_type.rb' - - 'app/graphql/types/snippets/blob_type.rb' - - 'app/graphql/types/snippets/visibility_scopes_enum.rb' - - 'app/graphql/types/terraform/state_type.rb' - - 'app/graphql/types/terraform/state_version_type.rb' - - 'app/graphql/types/timelog_type.rb' - - 'app/graphql/types/todo_state_enum.rb' - - 'app/graphql/types/todo_target_enum.rb' - - 'app/graphql/types/todo_type.rb' - - 'app/graphql/types/user_interface.rb' - - 'app/graphql/types/user_merge_request_interaction_type.rb' - - 'app/graphql/types/user_state_enum.rb' - - 'ee/app/graphql/ee/mutations/alert_management/http_integration/create.rb' - - 'ee/app/graphql/ee/mutations/alert_management/http_integration/update.rb' - - 'ee/app/graphql/ee/mutations/boards/issues/issue_move_list.rb' - - 'ee/app/graphql/ee/mutations/issues/create.rb' - - 'ee/app/graphql/ee/mutations/issues/update.rb' - - 'ee/app/graphql/ee/types/alert_management/http_integration_type.rb' - - 'ee/app/graphql/ee/types/board_list_type.rb' - - 'ee/app/graphql/ee/types/board_type.rb' - - 'ee/app/graphql/ee/types/group_type.rb' - - 'ee/app/graphql/ee/types/project_type.rb' - - 'ee/app/graphql/ee/types/query_type.rb' - - 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb' - - 'ee/app/graphql/mutations/boards/epic_boards/create.rb' - - 'ee/app/graphql/mutations/boards/epic_boards/epic_move_list.rb' - - 'ee/app/graphql/mutations/boards/epic_boards/update.rb' - - 'ee/app/graphql/mutations/boards/epic_lists/destroy.rb' - - 'ee/app/graphql/mutations/boards/lists/update_limit_metrics.rb' - - 'ee/app/graphql/mutations/boards/update_epic_user_preferences.rb' - - 'ee/app/graphql/mutations/compliance_management/frameworks/create.rb' - - 'ee/app/graphql/mutations/compliance_management/frameworks/destroy.rb' - - 'ee/app/graphql/mutations/compliance_management/frameworks/update.rb' - - 'ee/app/graphql/mutations/concerns/mutations/shared_epic_arguments.rb' - - 'ee/app/graphql/mutations/dast/profiles/create.rb' - - 'ee/app/graphql/mutations/dast/profiles/update.rb' - - 'ee/app/graphql/mutations/dast_on_demand_scans/create.rb' - - 'ee/app/graphql/mutations/dast_scanner_profiles/create.rb' - - 'ee/app/graphql/mutations/dast_scanner_profiles/update.rb' - - 'ee/app/graphql/mutations/dast_site_profiles/create.rb' - - 'ee/app/graphql/mutations/dast_site_profiles/delete.rb' - - 'ee/app/graphql/mutations/dast_site_profiles/update.rb' - - 'ee/app/graphql/mutations/dast_site_tokens/create.rb' - - 'ee/app/graphql/mutations/dast_site_validations/create.rb' - - 'ee/app/graphql/mutations/dast_site_validations/revoke.rb' - - 'ee/app/graphql/mutations/epic_tree/reorder.rb' - - 'ee/app/graphql/mutations/epics/add_issue.rb' - - 'ee/app/graphql/mutations/epics/base.rb' - - 'ee/app/graphql/mutations/epics/create.rb' - - 'ee/app/graphql/mutations/epics/set_subscription.rb' - - 'ee/app/graphql/mutations/gitlab_subscriptions/activate.rb' - - 'ee/app/graphql/mutations/incident_management/escalation_policy/base.rb' - - 'ee/app/graphql/mutations/incident_management/escalation_policy/create.rb' - - 'ee/app/graphql/mutations/incident_management/escalation_policy/destroy.rb' - - 'ee/app/graphql/mutations/incident_management/escalation_policy/update.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_rotation/create.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_rotation/destroy.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_rotation/update.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_schedule/create.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_schedule/destroy.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_schedule/oncall_schedule_base.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_schedule/update.rb' - - 'ee/app/graphql/mutations/issues/common_ee_mutation_arguments.rb' - - 'ee/app/graphql/mutations/issues/promote_to_epic.rb' - - 'ee/app/graphql/mutations/issues/set_iteration.rb' - - 'ee/app/graphql/mutations/iterations/cadences/create.rb' - - 'ee/app/graphql/mutations/iterations/cadences/update.rb' - - 'ee/app/graphql/mutations/iterations/create.rb' - - 'ee/app/graphql/mutations/namespaces/base.rb' - - 'ee/app/graphql/mutations/quality_management/test_cases/create.rb' - - 'ee/app/graphql/mutations/requirements_management/update_requirement.rb' - - 'ee/app/graphql/mutations/vulnerabilities/confirm.rb' - - 'ee/app/graphql/mutations/vulnerabilities/create_external_issue_link.rb' - - 'ee/app/graphql/mutations/vulnerabilities/destroy_external_issue_link.rb' - - 'ee/app/graphql/mutations/vulnerabilities/dismiss.rb' - - 'ee/app/graphql/mutations/vulnerabilities/resolve.rb' - - 'ee/app/graphql/mutations/vulnerabilities/revert_to_detected.rb' - - 'ee/app/graphql/resolvers/dora_metrics_resolver.rb' - - 'ee/app/graphql/resolvers/geo/geo_node_resolver.rb' - - 'ee/app/graphql/resolvers/network_policy_resolver.rb' - - 'ee/app/graphql/resolvers/requirements_management/requirements_resolver.rb' - - 'ee/app/graphql/types/alert_management/payload_alert_field_input_type.rb' - - 'ee/app/graphql/types/alert_management/payload_alert_mapping_field_type.rb' - - 'ee/app/graphql/types/analytics/devops_adoption/snapshot_type.rb' - - 'ee/app/graphql/types/app_sec/fuzzing/api/scan_profile_type.rb' - - 'ee/app/graphql/types/ci/code_quality_degradation_type.rb' - - 'ee/app/graphql/types/ci/minutes/namespace_monthly_usage_type.rb' - - 'ee/app/graphql/types/ci/minutes/project_monthly_usage_type.rb' - - 'ee/app/graphql/types/clusters/agent_token_type.rb' - - 'ee/app/graphql/types/clusters/agent_type.rb' - - 'ee/app/graphql/types/dast/profile_branch_type.rb' - - 'ee/app/graphql/types/dast/profile_type.rb' - - 'ee/app/graphql/types/dast/site_profile_auth_input_type.rb' - - 'ee/app/graphql/types/dast/site_profile_auth_type.rb' - - 'ee/app/graphql/types/dast_scanner_profile_type.rb' - - 'ee/app/graphql/types/dast_site_profile_type.rb' - - 'ee/app/graphql/types/epic_tree/epic_tree_node_input_type.rb' - - 'ee/app/graphql/types/epic_type.rb' - - 'ee/app/graphql/types/geo/geo_node_type.rb' - - 'ee/app/graphql/types/incident_management/escalation_policy_type.rb' - - 'ee/app/graphql/types/incident_management/escalation_rule_input_type.rb' - - 'ee/app/graphql/types/incident_management/escalation_rule_type.rb' - - 'ee/app/graphql/types/incident_management/oncall_participant_type.rb' - - 'ee/app/graphql/types/incident_management/oncall_rotation_active_period_input_type.rb' - - 'ee/app/graphql/types/incident_management/oncall_rotation_active_period_type.rb' - - 'ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb' - - 'ee/app/graphql/types/incident_management/oncall_rotation_length_input_type.rb' - - 'ee/app/graphql/types/incident_management/oncall_user_input_type.rb' - - 'ee/app/graphql/types/move_type_enum.rb' - - 'ee/app/graphql/types/network_policy_kind_enum.rb' - - 'ee/app/graphql/types/path_lock_type.rb' - - 'ee/app/graphql/types/pipeline_security_report_finding_type.rb' - - 'ee/app/graphql/types/scanned_resource_type.rb' - - 'ee/app/graphql/types/security_report_summary_section_type.rb' - - 'ee/app/graphql/types/timebox_metrics_type.rb' - - 'ee/app/graphql/types/vulnerability/issue_link_type.rb' - - 'ee/app/graphql/types/vulnerability_details/commit_type.rb' - - 'ee/app/graphql/types/vulnerability_type.rb' - - 'ee/app/graphql/types/vulnerable_dependency_type.rb' - - 'ee/app/graphql/types/vulnerable_package_type.rb' - # WIP: See https://gitlab.com/gitlab-org/gitlab/-/issues/220040 Rails/SaveBang: Exclude: @@ -939,7 +754,6 @@ RSpec/AnyInstanceOf: - 'spec/requests/api/ci/runner/runners_verify_post_spec.rb' - 'spec/requests/api/graphql/gitlab_schema_spec.rb' - 'spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb' - - 'spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb' - 'spec/requests/api/graphql_spec.rb' - 'spec/requests/api/helpers_spec.rb' - 'spec/requests/api/internal/base_spec.rb' @@ -2137,6 +1951,7 @@ Gitlab/NamespacedClass: - 'ee/app/models/weight_note.rb' - 'ee/app/policies/approval_merge_request_rule_policy.rb' - 'ee/app/policies/approval_project_rule_policy.rb' + - 'ee/app/policies/approval_state_policy.rb' - 'ee/app/policies/dast_scanner_profile_policy.rb' - 'ee/app/policies/dast_site_profile_policy.rb' - 'ee/app/policies/dast_site_validation_policy.rb' @@ -2572,8 +2387,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/views/projects/settings/operations/_status_page.html.haml' - 'ee/app/views/projects/settings/repository/_protected_branches.html.haml' - 'ee/app/views/projects/sidebar/_repository_locked_files.html.haml' - - 'ee/app/views/shared/issuable/_board_create_list_dropdown.html.haml' - - 'ee/app/views/shared/issuable/_board_create_list_dropdown.html.haml' - 'ee/app/views/shared/issuable/_group_bulk_update_sidebar.html.haml' - 'ee/app/views/shared/issuable/form/_default_templates.html.haml' - 'ee/app/views/shared/labels/_create_label_help_text.html.haml' @@ -2688,3 +2501,116 @@ Database/MultipleDatabases: - 'spec/support/helpers/usage_data_helpers.rb' - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' + +# WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/339787 +Performance/ActiveRecordSubtransactionMethods: + Exclude: + - 'app/controllers/clusters/clusters_controller.rb' + - 'app/controllers/repositories/lfs_storage_controller.rb' + - 'app/controllers/search_controller.rb' + - 'app/models/application_record.rb' + - 'app/models/ci/ref.rb' + - 'app/models/container_repository.rb' + - 'app/models/design_management/design_collection.rb' + - 'app/models/error_tracking/error.rb' + - 'app/models/external_pull_request.rb' + - 'app/models/gpg_signature.rb' + - 'app/models/merge_request.rb' + - 'app/models/plan.rb' + - 'app/models/project.rb' + - 'app/models/shard.rb' + - 'app/models/x509_certificate.rb' + - 'app/models/x509_commit_signature.rb' + - 'app/models/x509_issuer.rb' + - 'app/services/bulk_imports/relation_export_service.rb' + - 'app/services/ci/update_build_state_service.rb' + - 'app/services/event_create_service.rb' + - 'app/services/groups/import_export/import_service.rb' + - 'app/services/lfs/file_transformer.rb' + - 'app/services/merge_requests/approval_service.rb' + - 'app/services/namespaces/statistics_refresher_service.rb' + - 'app/services/packages/rubygems/create_dependencies_service.rb' + - 'app/services/packages/rubygems/metadata_extraction_service.rb' + - 'app/services/projects/create_service.rb' + - 'app/services/projects/lfs_pointers/lfs_download_service.rb' + - 'app/services/service_desk_settings/update_service.rb' + - 'app/services/service_ping/submit_service.rb' + - 'app/services/terraform/remote_state_handler.rb' + - 'app/workers/namespaces/schedule_aggregation_worker.rb' + - 'app/workers/project_export_worker.rb' + - 'db/migrate/20200212014653_rename_security_dashboard_feature_flag_to_instance_security_dashboard.rb' + - 'db/post_migrate/20200214034836_remove_security_dashboard_feature_flag.rb' + - 'db/post_migrate/20210824174615_prepare_ci_builds_metadata_and_ci_build_async_indexes.rb' + - 'ee/app/models/ci/minutes/namespace_monthly_usage.rb' + - 'ee/app/models/ci/minutes/project_monthly_usage.rb' + - 'ee/app/models/concerns/deprecated_approvals_before_merge.rb' + - 'ee/app/models/ee/iteration.rb' + - 'ee/app/models/ee/plan.rb' + - 'ee/app/models/elastic/index_setting.rb' + - 'ee/app/models/gitlab_subscription.rb' + - 'ee/app/models/software_license.rb' + - 'ee/app/services/boards/user_preferences/update_service.rb' + - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' + - 'ee/app/services/ee/analytics/cycle_analytics/stages/base_service.rb' + - 'ee/app/services/security/store_report_service.rb' + - 'ee/app/services/security/store_scan_service.rb' + - 'ee/app/workers/import_software_licenses_worker.rb' + - 'ee/db/fixtures/production/027_plans.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' + - 'ee/lib/gitlab/elastic/indexer.rb' + - 'lib/gitlab/ci/pipeline/seed/environment.rb' + - 'lib/gitlab/ci/pipeline/seed/processable/resource_group.rb' + - 'lib/gitlab/ci/trace/chunked_io.rb' + - 'lib/gitlab/composer/cache.rb' + - 'lib/gitlab/database/async_indexes/migration_helpers.rb' + - 'lib/gitlab/issuables_count_for_state.rb' + +# WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/340567 +Rails/IncludeUrlHelper: + Exclude: + - 'app/models/integrations/asana.rb' + - 'app/models/integrations/bamboo.rb' + - 'app/models/integrations/bugzilla.rb' + - 'app/models/integrations/campfire.rb' + - 'app/models/integrations/confluence.rb' + - 'app/models/integrations/custom_issue_tracker.rb' + - 'app/models/integrations/datadog.rb' + - 'app/models/integrations/discord.rb' + - 'app/models/integrations/ewm.rb' + - 'app/models/integrations/external_wiki.rb' + - 'app/models/integrations/flowdock.rb' + - 'app/models/integrations/hangouts_chat.rb' + - 'app/models/integrations/irker.rb' + - 'app/models/integrations/jenkins.rb' + - 'app/models/integrations/mattermost.rb' + - 'app/models/integrations/pivotaltracker.rb' + - 'app/models/integrations/redmine.rb' + - 'app/models/integrations/webex_teams.rb' + - 'app/models/integrations/youtrack.rb' + - 'app/presenters/alert_management/alert_presenter.rb' + - 'app/presenters/ci/pipeline_presenter.rb' + - 'app/presenters/clusters/cluster_presenter.rb' + - 'app/presenters/environment_presenter.rb' + - 'app/presenters/gitlab/blame_presenter.rb' + - 'app/presenters/group_clusterable_presenter.rb' + - 'app/presenters/instance_clusterable_presenter.rb' + - 'app/presenters/merge_request_presenter.rb' + - 'app/presenters/project_clusterable_presenter.rb' + - 'app/presenters/project_presenter.rb' + - 'app/presenters/prometheus_alert_presenter.rb' + - 'app/presenters/release_presenter.rb' + - 'app/presenters/releases/evidence_presenter.rb' + - 'ee/app/helpers/license_helper.rb' + - 'ee/app/models/integrations/github.rb' + - 'ee/app/presenters/merge_request_approver_presenter.rb' + - 'ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb' + - 'ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb' + - 'ee/spec/lib/banzai/filter/issuable_state_filter_spec.rb' + - 'lib/gitlab/ci/badge/metadata.rb' + - 'lib/gitlab/email/message/in_product_marketing/helper.rb' + - 'spec/helpers/merge_requests_helper_spec.rb' + - 'spec/helpers/nav/top_nav_helper_spec.rb' + - 'spec/helpers/notify_helper_spec.rb' + - 'spec/lib/banzai/filter/issuable_state_filter_spec.rb' + - 'spec/lib/banzai/filter/reference_redactor_filter_spec.rb' + - 'spec/lib/banzai/reference_redactor_spec.rb' |