diff options
Diffstat (limited to '.rubocop_manual_todo.yml')
| -rw-r--r-- | .rubocop_manual_todo.yml | 130 |
1 files changed, 71 insertions, 59 deletions
diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index a646f6ec950..7b961e7ee6b 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -32,7 +32,6 @@ Rails/SaveBang: - 'ee/spec/models/approval_project_rule_spec.rb' - 'ee/spec/models/burndown_spec.rb' - 'ee/spec/models/elasticsearch_indexed_namespace_spec.rb' - - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/label_note_spec.rb' @@ -40,7 +39,6 @@ Rails/SaveBang: - 'ee/spec/models/license_spec.rb' - 'ee/spec/models/merge_request_spec.rb' - 'ee/spec/models/merge_train_spec.rb' - - 'spec/models/packages/package_spec.rb' - 'ee/spec/models/project_ci_cd_setting_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/protected_environment_spec.rb' @@ -136,32 +134,6 @@ Rails/SaveBang: - 'spec/lib/gitlab/middleware/go_spec.rb' - 'spec/lib/gitlab/shard_health_cache_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/models/clusters/applications/helm_spec.rb' - - 'spec/models/design_management/version_spec.rb' - - 'spec/models/environment_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/fork_network_spec.rb' - - 'spec/models/generic_commit_status_spec.rb' - - 'spec/models/grafana_integration_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/identity_spec.rb' - - 'spec/models/jira_import_state_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/models/note_spec.rb' - - 'spec/models/notification_setting_spec.rb' - - 'spec/models/operations/feature_flag_scope_spec.rb' - - 'spec/models/operations/feature_flags/strategy_spec.rb' - - 'spec/models/operations/feature_flags/user_list_spec.rb' - - 'spec/models/pages_domain_spec.rb' - - 'spec/models/protectable_dropdown_spec.rb' - - 'spec/models/redirect_route_spec.rb' - - 'spec/models/release_spec.rb' - - 'spec/models/remote_mirror_spec.rb' - - 'spec/models/resource_milestone_event_spec.rb' - - 'spec/models/route_spec.rb' - - 'spec/models/sentry_issue_spec.rb' - - 'spec/models/snippet_spec.rb' - - 'spec/models/upload_spec.rb' Rails/TimeZone: Enabled: true @@ -204,7 +176,6 @@ Rails/TimeZone: - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_renamed_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/reset_checksum_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/upload_deleted_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/logger_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' @@ -1165,6 +1136,7 @@ Gitlab/NamespacedClass: - 'app/models/members/group_member.rb' - 'app/models/members/last_group_owner_assigner.rb' - 'app/models/members/project_member.rb' + - 'app/models/members/member_task.rb' - 'app/models/members_preloader.rb' - 'app/models/merge_request.rb' - 'app/models/merge_request_assignee.rb' @@ -2199,21 +2171,6 @@ Cop/UserAdmin: - 'lib/gitlab/visibility_level.rb' - 'qa/qa/runtime/api/client.rb' -# WIP https://gitlab.com/gitlab-org/gitlab/-/issues/325744 -Performance/OpenStruct: - Exclude: - - 'Guardfile' - - 'app/finders/snippets_finder.rb' - - 'app/helpers/application_settings_helper.rb' - - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb' - - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb' - - 'lib/api/wikis.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/git/diff_collection.rb' - - 'lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb' - - 'lib/gitlab/testing/request_inspector_middleware.rb' - - 'lib/mattermost/session.rb' - # WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/324629 Gitlab/DelegatePredicateMethods: Exclude: @@ -2443,28 +2400,14 @@ Database/MultipleDatabases: - 'lib/gitlab/database/load_balancing/sticking.rb' - 'lib/gitlab/database/migrations/observers/migration_observer.rb' - 'lib/gitlab/database/migrations/observers/query_log.rb' - - 'lib/gitlab/database/multi_threaded_migration.rb' - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb' - - 'lib/gitlab/database/partitioning/monthly_strategy.rb' - - 'lib/gitlab/database/partitioning/partition_manager.rb' - - 'lib/gitlab/database/partitioning/partition_creator.rb' - - 'lib/gitlab/database/partitioning/replace_table.rb' - - 'lib/gitlab/database/partitioning/time_partition.rb' - - 'lib/gitlab/database/postgres_hll/batch_distinct_counter.rb' - - 'lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin.rb' - - 'lib/gitlab/database/postgresql_database_tasks/load_schema_versions_mixin.rb' - 'lib/gitlab/database.rb' - - 'lib/gitlab/database/reindexing/concurrent_reindex.rb' - - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - 'lib/gitlab/database/schema_cache_with_renamed_table.rb' - - 'lib/gitlab/database/schema_migrations/context.rb' - - 'lib/gitlab/database/schema_version_files.rb' - - 'lib/gitlab/database/unidirectional_copy_trigger.rb' - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/health_checks/db_check.rb' - 'lib/gitlab/import_export/base/relation_factory.rb' - - 'lib/gitlab/import_export/relation_tree_restorer.rb' + - 'lib/gitlab/import_export/group/relation_tree_restorer.rb' - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/metrics/samplers/database_sampler.rb' - 'lib/gitlab/seeder.rb' @@ -2604,3 +2547,72 @@ Rails/IncludeUrlHelper: - 'spec/lib/banzai/filter/issuable_state_filter_spec.rb' - 'spec/lib/banzai/filter/reference_redactor_filter_spec.rb' - 'spec/lib/banzai/reference_redactor_spec.rb' + +# TODO issue: https://gitlab.com/gitlab-org/gitlab/-/issues/344279 +Style/OpenStructUse: + Exclude: + - 'app/helpers/application_settings_helper.rb' + - 'ee/spec/db/production/license_spec.rb' + - 'ee/spec/features/projects/new_project_spec.rb' + - 'ee/spec/finders/template_finder_spec.rb' + - 'ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/board_groupings/epics_resolvers_spec.rb' + - 'ee/spec/helpers/ee/blob_helper_spec.rb' + - 'ee/spec/lib/gitlab/auth/group_saml/failure_handler_spec.rb' + - 'ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' + - 'ee/spec/requests/api/ldap_spec.rb' + - 'lib/api/wikis.rb' + - 'lib/gitlab/git/diff_collection.rb' + - 'lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb' + - 'lib/gitlab/testing/request_inspector_middleware.rb' + - 'lib/mattermost/session.rb' + - 'spec/bin/feature_flag_spec.rb' + - 'spec/controllers/admin/clusters_controller_spec.rb' + - 'spec/controllers/groups/clusters_controller_spec.rb' + - 'spec/controllers/import/fogbugz_controller_spec.rb' + - 'spec/controllers/import/gitlab_controller_spec.rb' + - 'spec/controllers/projects/clusters_controller_spec.rb' + - 'spec/dependencies/omniauth_saml_spec.rb' + - 'spec/factories/go_module_versions.rb' + - 'spec/factories/wiki_pages.rb' + - 'spec/features/projects/clusters/gcp_spec.rb' + - 'spec/features/projects/clusters_spec.rb' + - 'spec/finders/template_finder_spec.rb' + - 'spec/graphql/mutations/branches/create_spec.rb' + - 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/delete_spec.rb' + - 'spec/graphql/mutations/commits/create_spec.rb' + - 'spec/graphql/mutations/merge_requests/accept_spec.rb' + - 'spec/graphql/mutations/merge_requests/create_spec.rb' + - 'spec/graphql/types/range_input_type_spec.rb' + - 'spec/helpers/application_settings_helper_spec.rb' + - 'spec/helpers/profiles_helper_spec.rb' + - 'spec/initializers/doorkeeper_spec.rb' + - 'spec/lib/gitlab/auth/o_auth/provider_spec.rb' + - 'spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb' + - 'spec/lib/gitlab/database/migrations/runner_spec.rb' + - 'spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb' + - 'spec/lib/gitlab/gitaly_client/diff_stitcher_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/exception_logger_spec.rb' + - 'spec/lib/gitlab/graphql/pagination/keyset/connection_generic_keyset_spec.rb' + - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' + - 'spec/lib/gitlab/quick_actions/command_definition_spec.rb' + - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' + - 'spec/lib/gitlab/relative_positioning/range_spec.rb' + - 'spec/models/design_management/design_action_spec.rb' + - 'spec/models/design_management/design_at_version_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' + - 'spec/requests/api/import_github_spec.rb' + - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' + - 'spec/services/projects/import_service_spec.rb' + - 'spec/services/system_note_service_spec.rb' + - 'spec/support/helpers/import_spec_helper.rb' + - 'spec/support/helpers/login_helpers.rb' + - 'spec/support/helpers/repo_helpers.rb' + - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' + - 'spec/tooling/rspec_flaky/flaky_example_spec.rb' + - 'tooling/rspec_flaky/flaky_example.rb' |