diff options
Diffstat (limited to '.rubocop_todo/layout')
7 files changed, 2 insertions, 116 deletions
diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 35923d68b93..c7b47be48fa 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -491,22 +491,6 @@ Layout/ArgumentAlignment: - 'app/graphql/types/work_items/widgets/start_and_due_date_update_input_type.rb' - 'app/graphql/types/x509_certificate_type.rb' - 'app/graphql/types/x509_issuer_type.rb' - - 'app/services/compare_service.rb' - - 'app/services/concerns/rate_limited_service.rb' - - 'app/services/design_management/copy_design_collection/copy_service.rb' - - 'app/services/design_management/delete_designs_service.rb' - - 'app/services/design_management/runs_design_actions.rb' - - 'app/services/design_management/save_designs_service.rb' - - 'app/services/error_tracking/base_service.rb' - - 'app/services/event_create_service.rb' - - 'app/services/files/update_service.rb' - - 'app/services/google_cloud/create_cloudsql_instance_service.rb' - - 'app/services/google_cloud/fetch_google_ip_list_service.rb' - - 'app/services/issuable_base_service.rb' - - 'app/services/issues/close_service.rb' - - 'app/services/issues/create_service.rb' - - 'app/services/issues/move_service.rb' - - 'app/services/issues/referenced_merge_requests_service.rb' - 'app/services/lfs/lock_file_service.rb' - 'app/services/markdown_content_rewriter_service.rb' - 'app/services/members/base_service.rb' @@ -529,19 +513,6 @@ Layout/ArgumentAlignment: - 'app/services/security/ci_configuration/dependency_scanning_create_service.rb' - 'app/services/security/ci_configuration/sast_iac_create_service.rb' - 'app/services/security/ci_configuration/secret_detection_create_service.rb' - - 'app/services/service_response.rb' - - 'app/services/spam/akismet_service.rb' - - 'app/services/spam/spam_action_service.rb' - - 'app/services/spam/spam_verdict_service.rb' - - 'app/services/submodules/update_service.rb' - - 'app/services/suggestions/create_service.rb' - - 'app/services/users/activity_service.rb' - - 'app/services/users/build_service.rb' - - 'app/services/users/destroy_service.rb' - - 'app/services/users/migrate_records_to_ghost_user_in_batches_service.rb' - - 'app/services/users/refresh_authorized_projects_service.rb' - - 'app/services/webauthn/authenticate_service.rb' - - 'app/services/work_items/create_service.rb' - 'app/validators/feature_flag_user_xids_validator.rb' - 'config/application.rb' - 'config/initializers/hashie_mash_permitted_patch.rb' @@ -1199,35 +1170,6 @@ Layout/ArgumentAlignment: - 'ee/spec/requests/groups/two_factor_auths_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/requests/users/identity_verification_controller_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/aggregator_service_spec.rb' - - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service_spec.rb' - - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/streaming/event_type_filters/create_service_spec.rb' - - 'ee/spec/services/audit_events/streaming/event_type_filters/destroy_service_spec.rb' - - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - - 'ee/spec/services/boards/lists/update_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/move_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/create_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/max_limits_spec.rb' - - 'ee/spec/services/ee/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/update_reviewers_service_spec.rb' - - 'ee/spec/services/ee/notification_service_spec.rb' - - 'ee/spec/services/ee/users/migrate_records_to_ghost_user_service_spec.rb' - - 'ee/spec/services/ee/vulnerability_feedback_module/update_service_spec.rb' - - 'ee/spec/services/elastic/process_bookkeeping_service_spec.rb' - - 'ee/spec/services/epics/issue_promote_service_spec.rb' - - 'ee/spec/services/geo/blob_upload_service_spec.rb' - - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/hashed_storage_attachments_migration_service_spec.rb' - - 'ee/spec/services/geo/registry_consistency_service_spec.rb' - - 'ee/spec/services/geo/replication_toggle_request_service_spec.rb' - - 'ee/spec/services/geo/repository_sync_service_spec.rb' - - 'ee/spec/services/geo/wiki_sync_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/reconciliations/check_seat_usage_alerts_eligibility_service_spec.rb' - 'ee/spec/services/groups/compliance_report_csv_service_spec.rb' - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb' @@ -1879,43 +1821,6 @@ Layout/ArgumentAlignment: - 'spec/rubocop/cop/rspec/env_mocking_spec.rb' - 'spec/rubocop/cop/style/regexp_literal_mixed_preserve_spec.rb' - 'spec/rubocop/formatter/graceful_formatter_spec.rb' - - 'spec/services/design_management/save_designs_service_spec.rb' - - 'spec/services/discussions/resolve_service_spec.rb' - - 'spec/services/draft_notes/publish_service_spec.rb' - - 'spec/services/environments/stop_service_spec.rb' - - 'spec/services/environments/stop_stale_service_spec.rb' - - 'spec/services/files/delete_service_spec.rb' - - 'spec/services/files/update_service_spec.rb' - - 'spec/services/git/branch_push_service_spec.rb' - - 'spec/services/google_cloud/create_cloudsql_instance_service_spec.rb' - - 'spec/services/google_cloud/fetch_google_ip_list_service_spec.rb' - - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' - - 'spec/services/google_cloud/get_cloudsql_instances_service_spec.rb' - - 'spec/services/groups/destroy_service_spec.rb' - - 'spec/services/groups/group_links/create_service_spec.rb' - - 'spec/services/import_export_clean_up_service_spec.rb' - - 'spec/services/issuable/process_assignees_spec.rb' - - 'spec/services/issue_links/list_service_spec.rb' - - 'spec/services/issues/create_service_spec.rb' - - 'spec/services/issues/export_csv_service_spec.rb' - - 'spec/services/issues/move_service_spec.rb' - - 'spec/services/issues/resolve_discussions_spec.rb' - - 'spec/services/issues/update_service_spec.rb' - - 'spec/services/loose_foreign_keys/batch_cleaner_service_spec.rb' - - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' - - 'spec/services/note_summary_spec.rb' - - 'spec/services/notification_service_spec.rb' - - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' - - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - - 'spec/services/preview_markdown_service_spec.rb' - - 'spec/services/protected_branches/api_service_spec.rb' - - 'spec/services/push_event_payload_service_spec.rb' - - 'spec/services/quick_actions/interpret_service_spec.rb' - - 'spec/services/releases/destroy_service_spec.rb' - - 'spec/services/resource_access_tokens/revoke_service_spec.rb' - - 'spec/services/resource_events/merge_into_notes_service_spec.rb' - - 'spec/services/security/ci_configuration/dependency_scanning_create_service_spec.rb' - - 'spec/services/security/merge_reports_service_spec.rb' - 'spec/sidekiq/cron/job_gem_dependency_spec.rb' - 'spec/support/shared_examples/initializers/uses_gitlab_url_blocker_shared_examples.rb' - 'spec/support/shared_examples/integrations/integration_settings_form.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 698247e419c..35cd5f9135d 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -256,7 +256,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/lib/ee/gitlab/ci/parsers/security/validators/schema_validator.rb' - 'ee/lib/ee/gitlab/hook_data/group_member_builder.rb' - 'ee/lib/ee/gitlab/hook_data/issue_builder.rb' - - 'ee/lib/ee/gitlab/hook_data/user_builder.rb' - 'ee/lib/ee/gitlab/scim/base_deprovisioning_service.rb' - 'ee/lib/ee/gitlab/scim/base_provisioning_service.rb' - 'ee/lib/ee/gitlab/scim/provisioning_service.rb' @@ -290,7 +289,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/features/projects/settings/merge_request_approvals_settings_spec.rb' - 'ee/spec/features/projects/settings/merge_requests_settings_spec.rb' - 'ee/spec/finders/auth/group_saml_identity_finder_spec.rb' - - 'ee/spec/finders/geo/design_registry_finder_spec.rb' - 'ee/spec/finders/geo/project_registry_status_finder_spec.rb' - 'ee/spec/frontend/fixtures/analytics/charts.rb' - 'ee/spec/frontend/fixtures/analytics/metrics.rb' @@ -318,7 +316,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/graphql/mutations/vulnerabilities/revert_to_detected_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' - - 'ee/spec/helpers/ee/invite_members_helper_spec.rb' - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/saml_providers_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' @@ -332,7 +329,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/group_member_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb' - - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/snippet_search_results_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb' diff --git a/.rubocop_todo/layout/extra_spacing.yml b/.rubocop_todo/layout/extra_spacing.yml deleted file mode 100644 index 6da17195834..00000000000 --- a/.rubocop_todo/layout/extra_spacing.yml +++ /dev/null @@ -1,8 +0,0 @@ ---- -# Cop supports --autocorrect. -Layout/ExtraSpacing: - Details: grace period - Exclude: - - 'ee/spec/requests/api/debian_project_packages_spec.rb' - - 'spec/serializers/admin/abuse_report_details_entity_spec.rb' - - 'spec/services/bulk_imports/create_service_spec.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 5f586cc6206..893a6d2242b 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -229,7 +229,6 @@ Layout/FirstHashElementIndentation: - 'spec/requests/api/ml/mlflow_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/task_completion_status_spec.rb' - - 'spec/requests/groups/email_campaigns_controller_spec.rb' - 'spec/requests/pwa_controller_spec.rb' - 'spec/rubocop/cop/usage_data/distinct_count_by_large_foreign_key_spec.rb' - 'spec/rubocop/cop/usage_data/histogram_with_large_table_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 53954249ed4..0253613849e 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -125,6 +125,7 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_deployment_approvals_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environments_required_approvals_average_metric_spec.rb' + - 'ee/spec/lib/remote_development/workspaces/reconcile/input/actual_state_calculator_spec.rb' - 'ee/spec/mailers/ee/emails/identity_verification_spec.rb' - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' @@ -141,6 +142,7 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/spec/services/geo/container_repository_sync_spec.rb' - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'ee/spec/services/users/abuse/git_abuse/application_throttle_service_spec.rb' + - 'ee/spec/support/shared_contexts/remote_development/remote_development_shared_contexts.rb' - 'ee/spec/support/shared_examples/finders/geo/framework_registry_finder_shared_examples.rb' - 'ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb' - 'ee/spec/support/shared_examples/models/license_shared_examples.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 162afb96a09..9fd3d47d8f0 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -34,7 +34,6 @@ Layout/LineLength: - 'app/controllers/dashboard/todos_controller.rb' - 'app/controllers/explore/projects_controller.rb' - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' - - 'app/controllers/groups/email_campaigns_controller.rb' - 'app/controllers/groups/group_members_controller.rb' - 'app/controllers/groups/settings/applications_controller.rb' - 'app/controllers/groups/settings/ci_cd_controller.rb' @@ -346,7 +345,6 @@ Layout/LineLength: - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/bugzilla.rb' - - 'app/models/integrations/campfire.rb' - 'app/models/integrations/chat_message/deployment_message.rb' - 'app/models/integrations/chat_message/merge_message.rb' - 'app/models/integrations/chat_message/note_message.rb' @@ -690,7 +688,6 @@ Layout/LineLength: - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' - 'config/initializers/pages_storage_check.rb' - 'config/initializers/rails_host_authorization.rb' - - 'config/initializers/session_store.rb' - 'config/initializers/validate_database_config.rb' - 'config/initializers/validate_puma.rb' - 'config/initializers/zz_metrics.rb' @@ -714,7 +711,6 @@ Layout/LineLength: - 'danger/z_metadata/Dangerfile' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/licenses_controller.rb' - 'ee/app/controllers/concerns/audit_events/date_range.rb' - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' @@ -1305,7 +1301,6 @@ Layout/LineLength: - 'ee/lib/tasks/gitlab/seed/metrics.rake' - 'ee/lib/world.rb' - 'ee/spec/controllers/admin/elasticsearch_controller_spec.rb' - - 'ee/spec/controllers/admin/geo/projects_controller_spec.rb' - 'ee/spec/controllers/admin/impersonations_controller_spec.rb' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - 'ee/spec/controllers/admin/projects_controller_spec.rb' @@ -4501,7 +4496,6 @@ Layout/LineLength: - 'spec/requests/api/v3/github_spec.rb' - 'spec/requests/dashboard_controller_spec.rb' - 'spec/requests/git_http_spec.rb' - - 'spec/requests/groups/email_campaigns_controller_spec.rb' - 'spec/requests/groups/milestones_controller_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' @@ -4724,7 +4718,6 @@ Layout/LineLength: - 'spec/services/metrics/users_starred_dashboards/delete_service_spec.rb' - 'spec/services/milestones/transfer_service_spec.rb' - 'spec/services/namespace_settings/update_service_spec.rb' - - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'spec/services/notes/build_service_spec.rb' - 'spec/services/notes/copy_service_spec.rb' - 'spec/services/notes/create_service_spec.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 01189989eec..54ed188fd26 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -79,7 +79,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/packages/maven/metadatum.rb' - 'app/models/packages/package.rb' - 'app/models/packages/tag.rb' - - 'app/models/pages_deployment.rb' - 'app/models/personal_access_token.rb' - 'app/models/project.rb' - 'app/models/project_daily_statistic.rb' |