diff options
Diffstat (limited to '.rubocop_todo/lint')
| -rw-r--r-- | .rubocop_todo/lint/ambiguous_operator_precedence.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/lint/ambiguous_range.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/lint/empty_block.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/lint/no_return_in_begin_end_blocks.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/lint/redundant_cop_disable_directive.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/lint/symbol_conversion.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/lint/unused_block_argument.yml | 6 | ||||
| -rw-r--r-- | .rubocop_todo/lint/unused_method_argument.yml | 4 |
8 files changed, 2 insertions, 17 deletions
diff --git a/.rubocop_todo/lint/ambiguous_operator_precedence.yml b/.rubocop_todo/lint/ambiguous_operator_precedence.yml index ea6cadc7f8a..8b6ef5db135 100644 --- a/.rubocop_todo/lint/ambiguous_operator_precedence.yml +++ b/.rubocop_todo/lint/ambiguous_operator_precedence.yml @@ -123,7 +123,6 @@ Lint/AmbiguousOperatorPrecedence: - 'spec/lib/gitlab/regex_spec.rb' - 'spec/lib/gitlab/search/abuse_validators/no_abusive_term_length_validator_spec.rb' - 'spec/lib/gitlab/slash_commands/deploy_spec.rb' - - 'spec/lib/gitlab/url_blocker_spec.rb' - 'spec/mailers/notify_spec.rb' - 'spec/models/appearance_spec.rb' - 'spec/models/ci/build_spec.rb' diff --git a/.rubocop_todo/lint/ambiguous_range.yml b/.rubocop_todo/lint/ambiguous_range.yml index 3d6f49a4846..155c1a36128 100644 --- a/.rubocop_todo/lint/ambiguous_range.yml +++ b/.rubocop_todo/lint/ambiguous_range.yml @@ -4,7 +4,7 @@ Lint/AmbiguousRange: Details: grace period Exclude: - 'app/models/ci/runner.rb' - - 'app/models/ci/runner_machine.rb' + - 'app/models/ci/runner_manager.rb' - 'app/services/clusters/agent_tokens/track_usage_service.rb' - 'lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb' - 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb' diff --git a/.rubocop_todo/lint/empty_block.yml b/.rubocop_todo/lint/empty_block.yml index 8845fb3abe2..43289b4bfbd 100644 --- a/.rubocop_todo/lint/empty_block.yml +++ b/.rubocop_todo/lint/empty_block.yml @@ -6,7 +6,6 @@ Lint/EmptyBlock: - 'app/controllers/projects/boards_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' - 'app/experiments/logged_out_marketing_header_experiment.rb' - - 'app/experiments/security_reports_mr_widget_prompt_experiment.rb' - 'config/application.rb' - 'ee/app/controllers/projects/learn_gitlab_controller.rb' - 'ee/spec/factories/incident_management/escalation_rules.rb' diff --git a/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml b/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml index 04115b12600..1d724ccc783 100644 --- a/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml +++ b/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml @@ -5,7 +5,6 @@ Lint/NoReturnInBeginEndBlocks: - 'app/models/concerns/metric_image_uploading.rb' - 'app/models/merge_request.rb' - 'app/services/security/ci_configuration/sast_parser_service.rb' - - 'app/services/work_items/parent_links/create_service.rb' - 'ee/app/services/epic_issues/create_service.rb' - 'ee/app/services/gitlab_subscriptions/preview_billable_user_change_service.rb' - 'ee/app/services/security/token_revocation_service.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index b5870b251b5..1ae433adc05 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -50,7 +50,6 @@ Lint/RedundantCopDisableDirective: - 'app/services/issues/export_csv_service.rb' - 'app/services/labels/transfer_service.rb' - 'app/services/members/create_service.rb' - - 'app/services/members/creator_service.rb' - 'app/services/members/projects/creator_service.rb' - 'app/services/members/standard_member_builder.rb' - 'app/services/projects/auto_devops/disable_service.rb' @@ -96,7 +95,6 @@ Lint/RedundantCopDisableDirective: - 'ee/app/controllers/ee/groups/group_members_controller.rb' - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' - 'ee/app/controllers/groups/todos_controller.rb' - - 'ee/app/experiments/cart_abandonment_modal_experiment.rb' - 'ee/app/finders/epics/with_issues_finder.rb' - 'ee/app/finders/geo/file_registry_finder.rb' - 'ee/app/finders/geo/project_registry_finder.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml index 537b32d856d..da56c283180 100644 --- a/.rubocop_todo/lint/symbol_conversion.yml +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -84,7 +84,6 @@ Lint/SymbolConversion: - 'spec/controllers/jira_connect/branches_controller_spec.rb' - 'spec/factories/ci/reports/codequality_degradations.rb' - 'spec/factories/evidences.rb' - - 'spec/factories/packages/debian/file_metadatum.rb' - 'spec/factories/packages/helm/file_metadatum.rb' - 'spec/factories/packages/npm/metadata.rb' - 'spec/features/file_uploads/graphql_add_design_spec.rb' @@ -140,7 +139,6 @@ Lint/SymbolConversion: - 'spec/lib/service_ping/devops_report_spec.rb' - 'spec/models/integrations/prometheus_spec.rb' - 'spec/models/merge_request_diff_commit_spec.rb' - - 'spec/models/packages/debian/file_metadatum_spec.rb' - 'spec/models/packages/helm/file_metadatum_spec.rb' - 'spec/models/packages/npm/metadatum_spec.rb' - 'spec/presenters/packages/npm/package_presenter_spec.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index b9013f03bfa..c09dc939ef4 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -122,7 +122,6 @@ Lint/UnusedBlockArgument: - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/lib/tasks/gitlab/indexer.rake' - 'ee/lib/tasks/gitlab/seed/insights.rake' - - 'ee/spec/config/metrics/every_metric_definition_spec.rb' - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' @@ -202,7 +201,6 @@ Lint/UnusedBlockArgument: - 'lib/api/helpers/snippets_helpers.rb' - 'lib/api/search.rb' - 'lib/atlassian/jira_connect/serializers/repository_entity.rb' - - 'lib/backup/database.rb' - 'lib/banzai/filter/autolink_filter.rb' - 'lib/banzai/filter/emoji_filter.rb' - 'lib/banzai/filter/inline_metrics_redactor_filter.rb' @@ -260,7 +258,6 @@ Lint/UnusedBlockArgument: - 'lib/tasks/contracts/pipeline_schedules.rake' - 'lib/tasks/contracts/pipelines.rake' - 'lib/tasks/frontend.rake' - - 'lib/tasks/gitlab/background_migrations.rake' - 'lib/tasks/gitlab/bulk_add_permission.rake' - 'lib/tasks/gitlab/db.rake' - 'lib/tasks/gitlab/external_diffs.rake' @@ -332,7 +329,6 @@ Lint/UnusedBlockArgument: - 'spec/graphql/types/base_object_spec.rb' - 'spec/initializers/secret_token_spec.rb' - 'spec/lib/api/helpers/pagination_strategies_spec.rb' - - 'spec/lib/backup/database_spec.rb' - 'spec/lib/banzai/filter/audio_link_filter_spec.rb' - 'spec/lib/banzai/filter/video_link_filter_spec.rb' - 'spec/lib/feature_spec.rb' @@ -377,7 +373,6 @@ Lint/UnusedBlockArgument: - 'spec/models/concerns/each_batch_spec.rb' - 'spec/models/container_repository_spec.rb' - 'spec/models/network/graph_spec.rb' - - 'spec/models/packages/debian/file_metadatum_spec.rb' - 'spec/requests/api/ci/pipeline_schedules_spec.rb' - 'spec/requests/api/graphql/gitlab_schema_spec.rb' - 'spec/requests/api/internal/container_registry/migration_spec.rb' @@ -443,5 +438,4 @@ Lint/UnusedBlockArgument: - 'spec/tooling/lib/tooling/find_codeowners_spec.rb' - 'spec/tooling/rspec_flaky/config_spec.rb' - 'spec/workers/projects/git_garbage_collect_worker_spec.rb' - - 'tooling/danger/specs.rb' - 'tooling/lib/tooling/find_codeowners.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index a4e48b35248..0d6f91336cb 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -264,10 +264,10 @@ Lint/UnusedMethodArgument: - 'ee/app/models/concerns/geo/repository_replicator_strategy.rb' - 'ee/app/models/concerns/geo/verifiable_replicator.rb' - 'ee/app/models/concerns/geo/verification_state.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/group_wiki.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/iteration_note.rb' - 'ee/app/replicators/geo/container_repository_replicator.rb' - 'ee/app/replicators/geo/pipeline_replicator.rb' @@ -294,7 +294,6 @@ Lint/UnusedMethodArgument: - 'ee/lib/ee/api/ci/helpers/runner.rb' - 'ee/lib/ee/api/entities/project.rb' - 'ee/lib/ee/backup/repositories.rb' - - 'ee/lib/ee/banzai/reference_parser/iteration_parser.rb' - 'ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb' - 'ee/lib/ee/gitlab/geo_git_access.rb' - 'ee/lib/ee/gitlab/tracking.rb' @@ -612,7 +611,6 @@ Lint/UnusedMethodArgument: - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' - - 'spec/lib/gitlab/url_blocker_spec.rb' - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb' |