diff options
Diffstat (limited to '.rubocop_todo/naming')
| -rw-r--r-- | .rubocop_todo/naming/heredoc_delimiter_naming.yml | 141 | ||||
| -rw-r--r-- | .rubocop_todo/naming/rescued_exceptions_variable_name.yml | 222 |
2 files changed, 363 insertions, 0 deletions
diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml new file mode 100644 index 00000000000..86d9ae2f24d --- /dev/null +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -0,0 +1,141 @@ +--- +Naming/HeredocDelimiterNaming: + # Offense count: 388 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/models/ci/build_trace_chunks/redis_base.rb' + - 'app/models/concerns/counter_attribute.rb' + - 'app/models/concerns/legacy_bulk_insert.rb' + - 'app/models/trending_project.rb' + - 'app/services/ci/ensure_stage_service.rb' + - 'app/services/packages/debian/generate_distribution_key_service.rb' + - 'app/workers/concerns/limited_capacity/job_tracker.rb' + - 'config/initializers/01_secret_token.rb' + - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' + - 'ee/db/geo/migrate/20180322062741_migrate_ci_job_artifacts_to_separate_registry.rb' + - 'ee/db/geo/migrate/20191010204941_migrate_lfs_objects_to_separate_registry.rb' + - 'ee/lib/api/elasticsearch_indexed_namespaces.rb' + - 'ee/spec/lib/ee/gitlab/ci/config_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/templates/templates_spec.rb' + - 'ee/spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' + - 'ee/spec/lib/gitlab/elastic/search_results_spec.rb' + - 'ee/spec/lib/gitlab/patch/database_config_spec.rb' + - 'ee/spec/lib/gitlab/sitemaps/sitemap_file_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/needs_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/runnable_builds_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/policy_commit_service_spec.rb' + - 'ee/spec/support/helpers/ee/ldap_helpers.rb' + - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' + - 'lib/api/version.rb' + - 'lib/backup/helper.rb' + - 'lib/feature/shared.rb' + - 'lib/gitlab/cache/import/caching.rb' + - 'lib/gitlab/conflict/file_collection.rb' + - 'lib/gitlab/database.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/database/migration_helpers/v2.rb' + - 'lib/gitlab/exclusive_lease.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' + - 'lib/gitlab/sql/set_operator.rb' + - 'lib/gitlab/utils/delegator_override/validator.rb' + - 'lib/tasks/gitlab/docs/compile_deprecations.rake' + - 'lib/tasks/gitlab/password.rake' + - 'qa/qa/scenario/test/sanity/selectors.rb' + - 'qa/qa/service/docker_run/gitlab_runner.rb' + - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' + - 'qa/qa/specs/features/browser_ui/4_verify/testing/view_code_coverage_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' + - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' + - 'rubocop/cop/database/multiple_databases.rb' + - 'rubocop/cop/default_scope.rb' + - 'rubocop/cop/file_decompression.rb' + - 'rubocop/cop/gitlab/httparty.rb' + - 'rubocop/cop/gitlab/json.rb' + - 'rubocop/cop/gitlab/module_with_instance_variables.rb' + - 'rubocop/cop/gitlab/predicate_memoization.rb' + - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/deprecation_toolkit_env.rb' + - 'spec/factories/packages/debian/distribution.rb' + - 'spec/factories/packages/debian/file_metadatum.rb' + - 'spec/features/projects/commit/user_comments_on_commit_spec.rb' + - 'spec/features/task_lists_spec.rb' + - 'spec/helpers/markup_helper_spec.rb' + - 'spec/initializers/100_patch_omniauth_oauth2_spec.rb' + - 'spec/initializers/rack_multipart_patch_spec.rb' + - 'spec/initializers/secret_token_spec.rb' + - 'spec/initializers/validate_database_config_spec.rb' + - 'spec/lib/banzai/filter/footnote_filter_spec.rb' + - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' + - 'spec/lib/gitlab/auth/ldap/config_spec.rb' + - 'spec/lib/gitlab/ci/config_spec.rb' + - 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb' + - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' + - 'spec/lib/gitlab/ci/templates/templates_spec.rb' + - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' + - 'spec/lib/gitlab/cluster/mixins/puma_cluster_spec.rb' + - 'spec/lib/gitlab/conflict/file_collection_spec.rb' + - 'spec/lib/gitlab/diff/file_spec.rb' + - 'spec/lib/gitlab/diff/pair_selector_spec.rb' + - 'spec/lib/gitlab/diff/parser_spec.rb' + - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' + - 'spec/lib/gitlab/file_hook_spec.rb' + - 'spec/lib/gitlab/form_builders/gitlab_ui_form_builder_spec.rb' + - 'spec/lib/gitlab/git/diff_spec.rb' + - 'spec/lib/gitlab/git_post_receive_spec.rb' + - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' + - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' + - 'spec/lib/gitlab/import_export/config_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v2/delete_command_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v2/install_command_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v2/patch_command_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v2/reset_command_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v3/delete_command_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v3/install_command_spec.rb' + - 'spec/lib/gitlab/kubernetes/helm/v3/patch_command_spec.rb' + - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' + - 'spec/lib/gitlab/patch/database_config_spec.rb' + - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb' + - 'spec/lib/gitlab/quick_actions/substitution_definition_spec.rb' + - 'spec/lib/gitlab/static_site_editor/config/file_config_spec.rb' + - 'spec/lib/gitlab/web_ide/config_spec.rb' + - 'spec/lib/gitlab/webpack/file_loader_spec.rb' + - 'spec/lib/gitlab/webpack/graphql_known_operations_spec.rb' + - 'spec/lib/gitlab/webpack/manifest_spec.rb' + - 'spec/lib/gitlab/word_diff/parser_spec.rb' + - 'spec/models/ci/bridge_spec.rb' + - 'spec/models/clusters/applications/cert_manager_spec.rb' + - 'spec/models/concerns/ci/maskable_spec.rb' + - 'spec/models/integrations/asana_spec.rb' + - 'spec/models/ssh_host_key_spec.rb' + - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' + - 'spec/services/ci/after_requeue_job_service_spec.rb' + - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' + - 'spec/services/ci/create_pipeline_service/cache_spec.rb' + - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' + - 'spec/services/ci/create_pipeline_service/include_spec.rb' + - 'spec/services/ci/create_pipeline_service/merge_requests_spec.rb' + - 'spec/services/ci/create_pipeline_service/parallel_spec.rb' + - 'spec/services/ci/create_pipeline_service/parameter_content_spec.rb' + - 'spec/services/ci/create_pipeline_service/rules_spec.rb' + - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/ci/create_web_ide_terminal_service_spec.rb' + - 'spec/services/ci/parse_dotenv_artifact_service_spec.rb' + - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' + - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' + - 'spec/services/task_list_toggle_service_spec.rb' + - 'spec/support/helpers/seed_helper.rb' + - 'spec/support/helpers/stub_object_storage.rb' + - 'spec/support/shared_examples/helm_commands_shared_examples.rb' + - 'spec/support/shared_examples/models/taskable_shared_examples.rb' + - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' + - 'spec/support/test_reports/test_reports_helper.rb' + - 'spec/workers/post_receive_spec.rb' diff --git a/.rubocop_todo/naming/rescued_exceptions_variable_name.yml b/.rubocop_todo/naming/rescued_exceptions_variable_name.yml new file mode 100644 index 00000000000..8d4d2da29ac --- /dev/null +++ b/.rubocop_todo/naming/rescued_exceptions_variable_name.yml @@ -0,0 +1,222 @@ +--- +# Cop supports --auto-correct. +Naming/RescuedExceptionsVariableName: + # Offense count: 269 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/controllers/admin/projects_controller.rb' + - 'app/controllers/projects/google_cloud/deployments_controller.rb' + - 'app/controllers/projects/google_cloud/service_accounts_controller.rb' + - 'app/controllers/projects/merge_requests/drafts_controller.rb' + - 'app/controllers/projects/milestones_controller.rb' + - 'app/controllers/projects/mirrors_controller.rb' + - 'app/controllers/projects/repositories_controller.rb' + - 'app/controllers/projects_controller.rb' + - 'app/finders/repositories/changelog_tag_finder.rb' + - 'app/graphql/mutations/issues/move.rb' + - 'app/graphql/resolvers/ci/config_resolver.rb' + - 'app/graphql/resolvers/environments_resolver.rb' + - 'app/helpers/application_helper.rb' + - 'app/models/application_setting.rb' + - 'app/models/blob_viewer/metrics_dashboard_yml.rb' + - 'app/models/ci/build.rb' + - 'app/models/ci/deleted_object.rb' + - 'app/models/clusters/concerns/elasticsearch_client.rb' + - 'app/models/concerns/prometheus_adapter.rb' + - 'app/models/concerns/repository_storage_movable.rb' + - 'app/models/concerns/x509_serial_number_attribute.rb' + - 'app/models/integrations/base_issue_tracker.rb' + - 'app/models/integrations/discord.rb' + - 'app/models/integrations/jenkins.rb' + - 'app/models/integrations/jira.rb' + - 'app/models/integrations/packagist.rb' + - 'app/models/integrations/pipelines_email.rb' + - 'app/models/integrations/prometheus.rb' + - 'app/models/performance_monitoring/prometheus_dashboard.rb' + - 'app/models/personal_access_token.rb' + - 'app/models/project.rb' + - 'app/models/repository.rb' + - 'app/models/snippet_repository.rb' + - 'app/models/u2f_registration.rb' + - 'app/models/wiki.rb' + - 'app/services/branches/delete_service.rb' + - 'app/services/branches/validate_new_service.rb' + - 'app/services/ci/job_artifacts/create_service.rb' + - 'app/services/ci/parse_dotenv_artifact_service.rb' + - 'app/services/ci/register_job_service.rb' + - 'app/services/ci/stuck_builds/drop_helpers.rb' + - 'app/services/clusters/applications/prometheus_update_service.rb' + - 'app/services/commits/change_service.rb' + - 'app/services/commits/create_service.rb' + - 'app/services/dependency_proxy/head_manifest_service.rb' + - 'app/services/dependency_proxy/request_token_service.rb' + - 'app/services/design_management/copy_design_collection/copy_service.rb' + - 'app/services/git/base_hooks_service.rb' + - 'app/services/grafana/proxy_service.rb' + - 'app/services/groups/update_shared_runners_service.rb' + - 'app/services/issues/relative_position_rebalancing_service.rb' + - 'app/services/jira/requests/base.rb' + - 'app/services/jira_import/start_import_service.rb' + - 'app/services/jira_import/users_importer.rb' + - 'app/services/lfs/lock_file_service.rb' + - 'app/services/lfs/locks_finder_service.rb' + - 'app/services/lfs/push_service.rb' + - 'app/services/lfs/unlock_file_service.rb' + - 'app/services/merge_requests/merge_to_ref_service.rb' + - 'app/services/merge_requests/mergeability_check_service.rb' + - 'app/services/metrics/dashboard/base_service.rb' + - 'app/services/metrics/dashboard/panel_preview_service.rb' + - 'app/services/projects/cleanup_service.rb' + - 'app/services/projects/destroy_service.rb' + - 'app/services/projects/hashed_storage/base_repository_service.rb' + - 'app/services/projects/transfer_service.rb' + - 'app/services/prometheus/proxy_service.rb' + - 'app/services/resource_access_tokens/revoke_service.rb' + - 'app/services/tags/create_service.rb' + - 'app/services/tags/destroy_service.rb' + - 'app/services/users/validate_manual_otp_service.rb' + - 'app/services/users/validate_push_otp_service.rb' + - 'app/services/verify_pages_domain_service.rb' + - 'app/validators/js_regex_validator.rb' + - 'app/workers/concerns/limited_capacity/worker.rb' + - 'app/workers/gitlab/jira_import/import_issue_worker.rb' + - 'app/workers/issuable_export_csv_worker.rb' + - 'app/workers/namespaces/root_statistics_worker.rb' + - 'app/workers/namespaces/schedule_aggregation_worker.rb' + - 'app/workers/packages/go/sync_packages_worker.rb' + - 'app/workers/project_destroy_worker.rb' + - 'app/workers/project_service_worker.rb' + - 'app/workers/projects/git_garbage_collect_worker.rb' + - 'app/workers/remove_expired_members_worker.rb' + - 'app/workers/users/create_statistics_worker.rb' + - 'config/initializers/rspec_profiling.rb' + - 'config/initializers/wikicloth_redos_patch.rb' + - 'db/post_migrate/20210606143426_add_index_for_container_registry_access_level.rb' + - 'db/post_migrate/20211206162601_cleanup_after_add_primary_email_to_emails_if_user_confirmed.rb' + - 'db/post_migrate/20220318111729_cleanup_after_fixing_issue_when_admin_changed_primary_email.rb' + - 'db/post_migrate/20220504083836_cleanup_after_fixing_regression_with_new_users_emails.rb' + - 'ee/app/finders/projects/integrations/jira/by_ids_finder.rb' + - 'ee/app/graphql/mutations/issues/promote_to_epic.rb' + - 'ee/app/graphql/mutations/issues/set_epic.rb' + - 'ee/app/helpers/ee/kerberos_spnego_helper.rb' + - 'ee/app/models/concerns/geo/replicable_model.rb' + - 'ee/app/models/integrations/github.rb' + - 'ee/app/services/app_sec/dast/profiles/create_service.rb' + - 'ee/app/services/app_sec/dast/profiles/update_service.rb' + - 'ee/app/services/app_sec/dast/scans/create_service.rb' + - 'ee/app/services/app_sec/dast/site_validations/find_or_create_service.rb' + - 'ee/app/services/app_sec/dast/site_validations/revoke_service.rb' + - 'ee/app/services/app_sec/fuzzing/coverage/corpuses/create_service.rb' + - 'ee/app/services/arkose/user_verification_service.rb' + - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' + - 'ee/app/services/elastic/process_bookkeeping_service.rb' + - 'ee/app/services/geo/file_registry_removal_service.rb' + - 'ee/app/services/geo/framework_repository_sync_service.rb' + - 'ee/app/services/geo/move_repository_service.rb' + - 'ee/app/services/geo/repository_base_sync_service.rb' + - 'ee/app/services/incident_management/oncall_rotations/create_service.rb' + - 'ee/app/services/incident_management/oncall_rotations/edit_service.rb' + - 'ee/app/services/namespaces/deactivate_members_over_limit_service.rb' + - 'ee/app/services/namespaces/remove_project_group_links_outside_hierarchy_service.rb' + - 'ee/app/services/namespaces/update_prevent_sharing_outside_hierarchy_service.rb' + - 'ee/app/services/projects/licenses/create_policy_service.rb' + - 'ee/app/services/projects/licenses/update_policy_service.rb' + - 'ee/app/services/security/ingestion/ingest_report_service.rb' + - 'ee/app/services/security/orchestration/assign_service.rb' + - 'ee/app/services/security/store_grouped_scans_service.rb' + - 'ee/app/services/security/store_scan_service.rb' + - 'ee/app/services/security/token_revocation_service.rb' + - 'ee/app/services/software_license_policies/create_service.rb' + - 'ee/app/services/software_license_policies/update_service.rb' + - 'ee/app/workers/adjourned_project_deletion_worker.rb' + - 'ee/app/workers/geo/file_removal_worker.rb' + - 'ee/app/workers/geo/repositories_clean_up_worker.rb' + - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' + - 'ee/app/workers/namespaces/free_user_cap_worker.rb' + - 'ee/app/workers/refresh_license_compliance_checks_worker.rb' + - 'ee/app/workers/repository_update_mirror_worker.rb' + - 'ee/app/workers/sync_seat_link_request_worker.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' + - 'ee/lib/elastic/instance_proxy_util.rb' + - 'ee/lib/gitlab/audit/auditor.rb' + - 'ee/lib/gitlab/auth/smartcard/base.rb' + - 'ee/lib/gitlab/ci/parsers/license_compliance/license_scanning.rb' + - 'ee/lib/gitlab/elastic/bulk_indexer.rb' + - 'ee/lib/gitlab/spdx/catalogue_gateway.rb' + - 'ee/lib/tasks/gitlab/seed/metrics.rake' + - 'lib/api/environments.rb' + - 'lib/api/helpers.rb' + - 'lib/api/helpers/label_helpers.rb' + - 'lib/api/issues.rb' + - 'lib/api/project_milestones.rb' + - 'lib/api/projects.rb' + - 'lib/api/repositories.rb' + - 'lib/api/v3/github.rb' + - 'lib/gitaly/server.rb' + - 'lib/gitlab/auth/ldap/adapter.rb' + - 'lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp.rb' + - 'lib/gitlab/auth/otp/strategies/forti_authenticator/push_otp.rb' + - 'lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans.rb' + - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' + - 'lib/gitlab/ci/config/external/file/artifact.rb' + - 'lib/gitlab/ci/pipeline/chain/config/process.rb' + - 'lib/gitlab/ci/pipeline/chain/validate/external.rb' + - 'lib/gitlab/ci/reports/codequality_reports.rb' + - 'lib/gitlab/database/background_migration/batched_job.rb' + - 'lib/gitlab/database/background_migration/batched_migration_wrapper.rb' + - 'lib/gitlab/database/batch_counter.rb' + - 'lib/gitlab/database/load_balancing/load_balancer.rb' + - 'lib/gitlab/database/load_balancing/service_discovery.rb' + - 'lib/gitlab/database/reindexing/grafana_notifier.rb' + - 'lib/gitlab/git/keep_around.rb' + - 'lib/gitlab/gitaly_client/call.rb' + - 'lib/gitlab/gitaly_client/commit_service.rb' + - 'lib/gitlab/gitaly_client/operation_service.rb' + - 'lib/gitlab/gitaly_client/ref_service.rb' + - 'lib/gitlab/gitaly_client/repository_service.rb' + - 'lib/gitlab/hashed_storage/migrator.rb' + - 'lib/gitlab/health_checks/base_abstract_check.rb' + - 'lib/gitlab/import_export/merge_request_parser.rb' + - 'lib/gitlab/instrumentation/redis_interceptor.rb' + - 'lib/gitlab/issuables_count_for_state.rb' + - 'lib/gitlab/jira_import/issues_importer.rb' + - 'lib/gitlab/json.rb' + - 'lib/gitlab/jwt_token.rb' + - 'lib/gitlab/kubernetes/namespace.rb' + - 'lib/gitlab/metrics/dashboard/stages/panel_ids_inserter.rb' + - 'lib/gitlab/metrics/rack_middleware.rb' + - 'lib/gitlab/middleware/handle_ip_spoof_attack_error.rb' + - 'lib/gitlab/prometheus/queries/validate_query.rb' + - 'lib/gitlab/prometheus_client.rb' + - 'lib/gitlab/sanitizers/exif.rb' + - 'lib/gitlab/sidekiq_logging/structured_logger.rb' + - 'lib/gitlab/tcp_checker.rb' + - 'lib/gitlab/template_parser/parser.rb' + - 'lib/gitlab/tracking.rb' + - 'lib/gitlab/url_blocker.rb' + - 'lib/gitlab/usage/metrics/aggregates/aggregate.rb' + - 'lib/gitlab/usage_data.rb' + - 'lib/gitlab/utils/usage_data.rb' + - 'lib/gitlab/verify/batch_verifier.rb' + - 'lib/gitlab/wiki_pages/front_matter_parser.rb' + - 'lib/microsoft_teams/notifier.rb' + - 'lib/system_check/incoming_email/imap_authentication_check.rb' + - 'lib/tasks/gitlab/db/validate_config.rake' + - 'lib/tasks/gitlab/setup.rake' + - 'lib/tasks/gitlab/storage.rake' + - 'lib/tasks/lint.rake' + - 'qa/qa/resource/user_gpg.rb' + - 'scripts/review_apps/automated_cleanup.rb' + - 'scripts/trigger-build.rb' + - 'spec/commands/metrics_server/metrics_server_spec.rb' + - 'spec/db/docs_spec.rb' + - 'spec/lib/bulk_imports/network_error_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' + - 'spec/lib/gitlab/error_tracking_spec.rb' + - 'spec/lib/gitlab/sanitizers/exception_message_spec.rb' + - 'spec/support/capybara.rb' + - 'spec/support/helpers/capybara_helpers.rb' + - 'tooling/lib/tooling/helm3_client.rb' + - 'tooling/lib/tooling/kubernetes_client.rb' |