diff options
Diffstat (limited to '.rubocop_todo/rspec/expect_change.yml')
| -rw-r--r-- | .rubocop_todo/rspec/expect_change.yml | 52 |
1 files changed, 39 insertions, 13 deletions
diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index b08830bd5a3..03066626883 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. RSpec/ExpectChange: - # Offense count: 1707 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/admin/applications_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' @@ -28,8 +25,10 @@ RSpec/ExpectChange: - 'ee/spec/controllers/registrations/groups_controller_spec.rb' - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/projects_spec.rb' + - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/graphql/ee/mutations/ci/runner/update_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' @@ -38,9 +37,9 @@ RSpec/ExpectChange: - 'ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_site_validations/revoke_spec.rb' - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' - - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' - 'ee/spec/lib/audit/changes_spec.rb' - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/push_rule_pipeline_spec.rb' @@ -52,14 +51,17 @@ RSpec/ExpectChange: - 'ee/spec/lib/ee/audit/project_setting_changes_auditor_spec.rb' - 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/create_security_setting_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/repo_restorer_spec.rb' + - 'ee/spec/lib/ee/gitlab/issuable/clone/copy_resource_events_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/deprovision_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' + - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/identity_linker_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' - 'ee/spec/lib/gitlab/auth/o_auth/user_spec.rb' @@ -75,6 +77,7 @@ RSpec/ExpectChange: - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - 'ee/spec/models/dast/profile_schedule_spec.rb' - 'ee/spec/models/dast_site_spec.rb' + - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'ee/spec/models/ee/event_spec.rb' - 'ee/spec/models/ee/lfs_object_spec.rb' - 'ee/spec/models/ee/merge_request_diff_spec.rb' @@ -96,6 +99,7 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/epic_issues_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' + - 'ee/spec/requests/api/graphql/audit_events/streaming/headers/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' @@ -108,6 +112,7 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/graphql/mutations/dast_site_validations/revoke_spec.rb' - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/update_requirement_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'ee/spec/requests/api/group_push_rule_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' - 'ee/spec/requests/api/invitations_spec.rb' @@ -121,6 +126,7 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/todos_spec.rb' - 'ee/spec/requests/api/users_spec.rb' - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' + - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb' @@ -135,6 +141,9 @@ RSpec/ExpectChange: - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb' - 'ee/spec/services/approval_rules/update_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/create_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/destroy_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/update_service_spec.rb' - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - 'ee/spec/services/boards/epics/create_service_spec.rb' @@ -146,14 +155,17 @@ RSpec/ExpectChange: - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/destroy_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' + - 'ee/spec/services/deploy_keys/create_service_spec.rb' - 'ee/spec/services/deployments/approval_service_spec.rb' - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' + - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' + - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - 'ee/spec/services/ee/members/create_service_spec.rb' - 'ee/spec/services/ee/members/destroy_service_spec.rb' - 'ee/spec/services/ee/members/invite_service_spec.rb' @@ -163,6 +175,7 @@ RSpec/ExpectChange: - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/projects/deploy_tokens/destroy_service_spec.rb' - 'ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb' + - 'ee/spec/services/ee/two_factor/destroy_service_spec.rb' - 'ee/spec/services/ee/users/approve_service_spec.rb' - 'ee/spec/services/ee/users/block_service_spec.rb' - 'ee/spec/services/ee/users/reject_service_spec.rb' @@ -196,8 +209,12 @@ RSpec/ExpectChange: - 'ee/spec/services/keys/create_service_spec.rb' - 'ee/spec/services/lfs/lock_file_service_spec.rb' - 'ee/spec/services/lfs/unlock_file_service_spec.rb' + - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' + - 'ee/spec/services/namespaces/free_user_cap/update_prevent_sharing_outside_hierarchy_service_spec.rb' + - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb' + - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/import_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' @@ -215,6 +232,7 @@ RSpec/ExpectChange: - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - 'ee/spec/services/security/override_uuids_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb' - 'ee/spec/services/security/store_scan_service_spec.rb' - 'ee/spec/services/start_pull_mirroring_service_spec.rb' - 'ee/spec/services/system_notes/epics_service_spec.rb' @@ -235,16 +253,15 @@ RSpec/ExpectChange: - 'ee/spec/support/shared_examples/services/update_issuable_health_status_shared_examples.rb' - 'ee/spec/tasks/geo/git_rake_spec.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' + - 'ee/spec/workers/ee/projects/inactive_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker_spec.rb' - 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'spec/controllers/admin/clusters_controller_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/admin/spam_logs_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/controllers/groups/clusters_controller_spec.rb' - 'spec/controllers/groups/runners_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/import/bitbucket_controller_spec.rb' @@ -254,7 +271,6 @@ RSpec/ExpectChange: - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/profiles/gpg_keys_controller_spec.rb' - 'spec/controllers/profiles/keys_controller_spec.rb' - - 'spec/controllers/projects/clusters_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' @@ -277,7 +293,6 @@ RSpec/ExpectChange: - 'spec/features/groups/import_export/import_file_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/invites_spec.rb' - - 'spec/features/profiles/personal_access_tokens_spec.rb' - 'spec/features/projects/import_export/import_file_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/users/signup_spec.rb' @@ -294,11 +309,13 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/auth/saml/identity_linker_spec.rb' - 'spec/lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_projects_with_coverage_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' + - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' @@ -314,6 +331,7 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/config/entry/validatable_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' - 'spec/lib/gitlab/database/async_indexes/index_creator_spec.rb' + - 'spec/lib/gitlab/database/async_indexes/index_destructor_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' @@ -325,6 +343,8 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' - 'spec/lib/gitlab/git_access_project_spec.rb' + - 'spec/lib/gitlab/github_import/importer/events/changed_assignee_spec.rb' + - 'spec/lib/gitlab/github_import/importer/events/renamed_spec.rb' - 'spec/lib/gitlab/github_import/importer/releases_importer_spec.rb' - 'spec/lib/gitlab/hashed_storage/migrator_spec.rb' - 'spec/lib/gitlab/import/merge_request_creator_spec.rb' @@ -353,7 +373,9 @@ RSpec/ExpectChange: - 'spec/migrations/20220124130028_dedup_runner_projects_spec.rb' - 'spec/migrations/20220202105733_delete_service_template_records_spec.rb' - 'spec/migrations/20220222192525_remove_null_releases_spec.rb' + - 'spec/migrations/20220629184402_unset_escalation_policies_for_alert_incidents_spec.rb' - 'spec/migrations/backfill_cycle_analytics_aggregations_spec.rb' + - 'spec/migrations/bulk_insert_cluster_enabled_grants_spec.rb' - 'spec/migrations/cleanup_after_add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - 'spec/migrations/cleanup_after_fixing_regression_with_new_users_emails_spec.rb' @@ -363,6 +385,7 @@ RSpec/ExpectChange: - 'spec/models/alert_management/alert_spec.rb' - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' - 'spec/models/analytics/cycle_analytics/stage_event_hash_spec.rb' + - 'spec/models/application_setting_spec.rb' - 'spec/models/broadcast_message_spec.rb' - 'spec/models/chat_name_spec.rb' - 'spec/models/ci/bridge_spec.rb' @@ -375,8 +398,6 @@ RSpec/ExpectChange: - 'spec/models/ci/ref_spec.rb' - 'spec/models/ci/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - - 'spec/models/commit_signatures/gpg_signature_spec.rb' - - 'spec/models/commit_signatures/x509_commit_signature_spec.rb' - 'spec/models/commit_status_spec.rb' - 'spec/models/concerns/atomic_internal_id_spec.rb' - 'spec/models/concerns/bulk_insert_safe_spec.rb' @@ -384,6 +405,7 @@ RSpec/ExpectChange: - 'spec/models/concerns/delete_with_limit_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/concerns/require_email_verification_spec.rb' - 'spec/models/concerns/resolvable_discussion_spec.rb' - 'spec/models/concerns/resolvable_note_spec.rb' - 'spec/models/concerns/routable_spec.rb' @@ -449,7 +471,6 @@ RSpec/ExpectChange: - 'spec/requests/api/projects_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/system_hooks_spec.rb' - 'spec/requests/api/users_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/import/gitlab_groups_controller_spec.rb' @@ -504,6 +525,7 @@ RSpec/ExpectChange: - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issues/close_service_spec.rb' - 'spec/services/issues/create_service_spec.rb' + - 'spec/services/issues/import_csv_service_spec.rb' - 'spec/services/issues/move_service_spec.rb' - 'spec/services/issues/reopen_service_spec.rb' - 'spec/services/issues/update_service_spec.rb' @@ -526,6 +548,7 @@ RSpec/ExpectChange: - 'spec/services/notes/create_service_spec.rb' - 'spec/services/notes/destroy_service_spec.rb' - 'spec/services/notes/quick_actions_service_spec.rb' + - 'spec/services/packages/cleanup/update_policy_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/mark_package_for_destruction_service_spec.rb' - 'spec/services/packages/update_package_file_service_spec.rb' @@ -534,7 +557,6 @@ RSpec/ExpectChange: - 'spec/services/pages_domains/retry_acme_order_service_spec.rb' - 'spec/services/personal_access_tokens/last_used_service_spec.rb' - 'spec/services/projects/auto_devops/disable_service_spec.rb' - - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/fetch_statistics_increment_service_spec.rb' - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' @@ -562,6 +584,7 @@ RSpec/ExpectChange: - 'spec/services/todos/destroy/group_private_service_spec.rb' - 'spec/services/todos/destroy/project_private_service_spec.rb' - 'spec/services/todos/destroy/unauthorized_features_service_spec.rb' + - 'spec/services/uploads/destroy_service_spec.rb' - 'spec/services/users/approve_service_spec.rb' - 'spec/services/users/ban_service_spec.rb' - 'spec/services/users/batch_status_cleaner_service_spec.rb' @@ -571,7 +594,7 @@ RSpec/ExpectChange: - 'spec/services/users/update_highest_member_role_service_spec.rb' - 'spec/services/users/update_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - - 'spec/services/web_hooks/destroy_service_spec.rb' + - 'spec/services/work_items/parent_links/create_service_spec.rb' - 'spec/support/services/deploy_token_shared_examples.rb' - 'spec/support/services/issuable_import_csv_service_shared_examples.rb' - 'spec/support/shared_contexts/email_shared_context.rb' @@ -581,6 +604,7 @@ RSpec/ExpectChange: - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - 'spec/support/shared_examples/incident_management/issuable_escalation_statuses/build_examples.rb' - 'spec/support/shared_examples/loose_foreign_keys/have_loose_foreign_key.rb' + - 'spec/support/shared_examples/models/commit_signature_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/bulk_insert_safe_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/can_move_repository_storage_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/cron_schedulable_shared_examples.rb' @@ -613,6 +637,7 @@ RSpec/ExpectChange: - 'spec/workers/destroy_pages_deployments_worker_spec.rb' - 'spec/workers/environments/auto_delete_cron_worker_spec.rb' - 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb' + - 'spec/workers/gitlab_service_ping_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - 'spec/workers/new_issue_worker_spec.rb' @@ -627,3 +652,4 @@ RSpec/ExpectChange: - 'spec/workers/update_highest_role_worker_spec.rb' - 'spec/workers/user_status_cleanup/batch_worker_spec.rb' - 'spec/workers/users/create_statistics_worker_spec.rb' + - 'spec/workers/web_hooks/log_destroy_worker_spec.rb' |