diff options
Diffstat (limited to '.rubocop_todo/rspec/expect_in_hook.yml')
| -rw-r--r-- | .rubocop_todo/rspec/expect_in_hook.yml | 54 |
1 files changed, 41 insertions, 13 deletions
diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index cd73b76b14e..d138ea806f8 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -1,8 +1,5 @@ --- RSpec/ExpectInHook: - # Offense count: 1074 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' @@ -13,11 +10,15 @@ RSpec/ExpectInHook: - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/features/boards/new_issue_spec.rb' - 'ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - 'ee/spec/features/registrations/combined_registration_spec.rb' + - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/features/registrations/trial_during_signup_flow_spec.rb' - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' @@ -29,10 +30,14 @@ RSpec/ExpectInHook: - 'ee/spec/graphql/mutations/gitlab_subscriptions/activate_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' + - 'ee/spec/helpers/ee/groups_helper_spec.rb' + - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/kerberos_spnego_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' + - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/gon_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' @@ -44,7 +49,6 @@ RSpec/ExpectInHook: - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' @@ -57,14 +61,15 @@ RSpec/ExpectInHook: - 'ee/spec/models/concerns/geo/replicable_model_spec.rb' - 'ee/spec/models/container_repository_spec.rb' - 'ee/spec/models/dora/daily_metrics_spec.rb' + - 'ee/spec/models/ee/namespace/storage/notification_spec.rb' - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/member_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/presenters/group_member_presenter_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' - - 'ee/spec/requests/api/graphql/ci/runner_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/groups/analytics/devops_adoption_controller_spec.rb' - 'ee/spec/requests/omniauth_kerberos_spnego_spec.rb' @@ -74,26 +79,32 @@ RSpec/ExpectInHook: - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - 'ee/spec/services/ci/runners/assign_runner_service_spec.rb' - 'ee/spec/services/ci/runners/register_runner_service_spec.rb' + - 'ee/spec/services/ci/runners/reset_registration_token_service_spec.rb' - 'ee/spec/services/ci/runners/unassign_runner_service_spec.rb' - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' - 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' - - 'ee/spec/services/ee/post_receive_service_spec.rb' - 'ee/spec/services/ee/protected_branches/destroy_service_spec.rb' - 'ee/spec/services/geo/blob_download_service_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' - - 'ee/spec/services/members/activate_service_spec.rb' + - 'ee/spec/services/members/await_service_spec.rb' - 'ee/spec/services/merge_requests/approval_service_spec.rb' + - 'ee/spec/services/merge_requests/mergeability/check_approved_service_spec.rb' + - 'ee/spec/services/merge_requests/mergeability/check_blocked_by_other_mrs_service_spec.rb' + - 'ee/spec/services/merge_requests/mergeability/check_denied_policies_service_spec.rb' - 'ee/spec/services/projects/create_from_template_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - 'ee/spec/services/security/findings/cleanup_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' + - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/elastic/cannot_read_cross_project_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' @@ -112,11 +123,13 @@ RSpec/ExpectInHook: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_to_secondary_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' + - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb' @@ -153,13 +166,11 @@ RSpec/ExpectInHook: - 'spec/features/file_uploads/maven_package_spec.rb' - 'spec/features/groups/container_registry_spec.rb' - 'spec/features/groups/group_settings_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_hint_spec.rb' - 'spec/features/markdown/markdown_spec.rb' - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb' - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/features/oauth_login_spec.rb' - 'spec/features/profiles/password_spec.rb' - - 'spec/features/projects/clusters/gcp_spec.rb' - 'spec/features/projects/container_registry_spec.rb' - 'spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'spec/features/projects/files/user_creates_files_spec.rb' @@ -172,17 +183,20 @@ RSpec/ExpectInHook: - 'spec/features/users/login_spec.rb' - 'spec/graphql/mutations/design_management/move_spec.rb' - 'spec/helpers/commits_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' - 'spec/helpers/invite_members_helper_spec.rb' - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - - 'spec/initializers/omniauth_spec.rb' + - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/validate_database_config_spec.rb' - 'spec/lib/api/entities/merge_request_changes_spec.rb' - 'spec/lib/api/helpers/variables_helpers_spec.rb' - 'spec/lib/api/helpers_spec.rb' - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/banzai/reference_redactor_spec.rb' + - 'spec/lib/bulk_imports/common/extractors/json_extractor_spec.rb' + - 'spec/lib/bulk_imports/common/extractors/ndjson_extractor_spec.rb' - 'spec/lib/bulk_imports/ndjson_pipeline_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/file_size_validator_spec.rb' @@ -207,7 +221,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' - - 'spec/lib/gitlab/ci/trace/archive_spec.rb' - 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb' @@ -216,14 +229,18 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/contributions_calendar_spec.rb' - 'spec/lib/gitlab/current_settings_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' + - 'spec/lib/gitlab/database/background_migration/health_status_spec.rb' - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/runner_spec.rb' + - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning_spec.rb' + - 'spec/lib/gitlab/database/postgres_autovacuum_activity_spec.rb' - 'spec/lib/gitlab/database/query_analyzer_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' @@ -251,10 +268,12 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/health_checks/gitaly_check_spec.rb' - 'spec/lib/gitlab/health_checks/probes/collection_spec.rb' - 'spec/lib/gitlab/health_checks/puma_check_spec.rb' + - 'spec/lib/gitlab/health_checks/server_spec.rb' - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_object_saver_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' + - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/import_failure_service_spec.rb' - 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb' @@ -271,12 +290,14 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' + - 'spec/lib/gitlab/memory/jemalloc_spec.rb' - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' - 'spec/lib/gitlab/metrics/exporter/metrics_middleware_spec.rb' - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' - 'spec/lib/gitlab/middleware/memory_report_spec.rb' - 'spec/lib/gitlab/middleware/multipart_spec.rb' - 'spec/lib/gitlab/omniauth_initializer_spec.rb' + - 'spec/lib/gitlab/pages/deployment_update_spec.rb' - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' - 'spec/lib/gitlab/patch/database_config_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' @@ -338,6 +359,7 @@ RSpec/ExpectInHook: - 'spec/models/ssh_host_key_spec.rb' - 'spec/models/user_spec.rb' - 'spec/policies/ci/bridge_policy_spec.rb' + - 'spec/policies/project_policy_spec.rb' - 'spec/presenters/ci/build_presenter_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' - 'spec/presenters/commit_presenter_spec.rb' @@ -352,6 +374,7 @@ RSpec/ExpectInHook: - 'spec/requests/api/graphql/mutations/jira_import/import_users_spec.rb' - 'spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb' - 'spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb' + - 'spec/requests/api/graphql/terraform/state/delete_spec.rb' - 'spec/requests/api/graphql/terraform/state/lock_spec.rb' - 'spec/requests/api/graphql/terraform/state/unlock_spec.rb' - 'spec/requests/api/group_export_spec.rb' @@ -375,6 +398,7 @@ RSpec/ExpectInHook: - 'spec/rubocop/cop/performance/ar_count_each_spec.rb' - 'spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb' - 'spec/scripts/setup/find_jh_branch_spec.rb' + - 'spec/scripts/trigger-build_spec.rb' - 'spec/serializers/diffs_metadata_entity_spec.rb' - 'spec/serializers/merge_request_diff_entity_spec.rb' - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' @@ -406,6 +430,7 @@ RSpec/ExpectInHook: - 'spec/services/design_management/save_designs_service_spec.rb' - 'spec/services/discussions/capture_diff_note_position_service_spec.rb' - 'spec/services/environments/reset_auto_stop_service_spec.rb' + - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/git/base_hooks_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' - 'spec/services/git/wiki_push_service/change_spec.rb' @@ -434,6 +459,7 @@ RSpec/ExpectInHook: - 'spec/services/notes/quick_actions_service_spec.rb' - 'spec/services/notification_recipients/builder/default_spec.rb' - 'spec/services/notification_recipients/builder/new_note_spec.rb' + - 'spec/services/packages/cleanup/execute_policy_service_spec.rb' - 'spec/services/packages/debian/process_changes_service_spec.rb' - 'spec/services/packages/generic/create_package_file_service_spec.rb' - 'spec/services/packages/helm/extract_file_metadata_service_spec.rb' @@ -465,7 +491,6 @@ RSpec/ExpectInHook: - 'spec/services/protected_branches/create_service_spec.rb' - 'spec/services/protected_branches/destroy_service_spec.rb' - 'spec/services/protected_branches/update_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/search_service_spec.rb' - 'spec/services/serverless/associate_domain_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' @@ -481,6 +506,7 @@ RSpec/ExpectInHook: - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/database/reestablished_connection_stack_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/diff_file_collections_shared_examples.rb' - 'spec/support/shared_examples/lib/wikis_api_examples.rb' - 'spec/support/shared_examples/metrics/sampler_shared_examples.rb' @@ -515,6 +541,7 @@ RSpec/ExpectInHook: - 'spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb' - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/workers/build_finished_worker_spec.rb' + - 'spec/workers/bulk_imports/pipeline_worker_spec.rb' - 'spec/workers/ci/build_finished_worker_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' - 'spec/workers/concerns/limited_capacity/job_tracker_spec.rb' @@ -525,6 +552,7 @@ RSpec/ExpectInHook: - 'spec/workers/gitlab/jira_import/stage/finish_import_worker_spec.rb' - 'spec/workers/gitlab_performance_bar_stats_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' + - 'spec/workers/incident_management/close_incident_worker_spec.rb' - 'spec/workers/integrations/create_external_cross_reference_worker_spec.rb' - 'spec/workers/packages/helm/extraction_worker_spec.rb' - 'spec/workers/packages/nuget/extraction_worker_spec.rb' |