diff options
Diffstat (limited to '.rubocop_todo/rspec')
| -rw-r--r-- | .rubocop_todo/rspec/be.yml | 22 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/context_wording.yml | 635 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/empty_line_after_hook.yml | 60 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/expect_change.yml | 52 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/expect_in_hook.yml | 54 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/hooks_before_examples.yml | 76 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/predicate_matcher.yml | 27 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/repeated_example_group_description.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/return_from_stub.yml | 12 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/scattered_let.yml | 21 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/verified_doubles.yml | 1 |
11 files changed, 410 insertions, 551 deletions
diff --git a/.rubocop_todo/rspec/be.yml b/.rubocop_todo/rspec/be.yml new file mode 100644 index 00000000000..dad8a7d730b --- /dev/null +++ b/.rubocop_todo/rspec/be.yml @@ -0,0 +1,22 @@ +--- +RSpec/Be: + Exclude: + - 'ee/spec/services/groups/transfer_service_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' + - 'spec/lib/gitlab/lets_encrypt/client_spec.rb' + - 'spec/lib/gitlab/search_context/builder_spec.rb' + - 'spec/migrations/20220503035221_add_gitlab_schema_to_batched_background_migrations_spec.rb' + - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/identity_spec.rb' + - 'spec/models/snippet_repository_spec.rb' + - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' + - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' + - 'spec/requests/api/pages_domains_spec.rb' + - 'spec/services/pages/delete_service_spec.rb' + - 'spec/services/pages/destroy_deployments_service_spec.rb' + - 'spec/services/pages/migrate_from_legacy_storage_service_spec.rb' + - 'spec/services/projects/update_pages_service_spec.rb' + - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' + - 'spec/uploaders/file_uploader_spec.rb' + - 'spec/uploaders/namespace_file_uploader_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 724aa420d89..163533621a6 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -1,9 +1,7 @@ --- RSpec/ContextWording: - # Offense count: 18360 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'ee/spec/components/namespaces/free_user_cap/personal_usage_quota_limitations_alert_component_spec.rb' - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - 'ee/spec/controllers/admin/audit_logs_controller_spec.rb' - 'ee/spec/controllers/admin/dev_ops_report_controller_spec.rb' @@ -15,19 +13,15 @@ RSpec/ContextWording: - 'ee/spec/controllers/autocomplete_controller_spec.rb' - 'ee/spec/controllers/boards/lists_controller_spec.rb' - 'ee/spec/controllers/dashboard_controller_spec.rb' - - 'ee/spec/controllers/ee/dashboard/projects_controller_spec.rb' - 'ee/spec/controllers/ee/groups/variables_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' - - 'ee/spec/controllers/ee/profiles/preferences_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' - 'ee/spec/controllers/ee/registrations_controller_spec.rb' - 'ee/spec/controllers/ee/root_controller_spec.rb' - 'ee/spec/controllers/ee/search_controller_spec.rb' - 'ee/spec/controllers/ee/sent_notifications_controller_spec.rb' - - 'ee/spec/controllers/ee/sessions_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/cycle_analytics_controller_spec.rb' - - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' - 'ee/spec/controllers/groups/billings_controller_spec.rb' - 'ee/spec/controllers/groups/boards_controller_spec.rb' @@ -42,21 +36,15 @@ RSpec/ContextWording: - 'ee/spec/controllers/groups/push_rules_controller_spec.rb' - 'ee/spec/controllers/groups/saml_providers_controller_spec.rb' - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' - - 'ee/spec/controllers/groups/security/compliance_dashboards_controller_spec.rb' - - 'ee/spec/controllers/groups/security/dashboard_controller_spec.rb' - 'ee/spec/controllers/groups/security/merge_commit_reports_controller_spec.rb' - - 'ee/spec/controllers/groups/security/vulnerabilities_controller_spec.rb' - 'ee/spec/controllers/groups/sso_controller_spec.rb' - 'ee/spec/controllers/ldap/omniauth_callbacks_controller_spec.rb' - 'ee/spec/controllers/oauth/applications_controller_spec.rb' - 'ee/spec/controllers/oauth/geo_auth_controller_spec.rb' - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/controllers/profiles_controller_spec.rb' - - 'ee/spec/controllers/projects/approver_groups_controller_spec.rb' - - 'ee/spec/controllers/projects/approvers_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - 'ee/spec/controllers/projects/boards_controller_spec.rb' - - 'ee/spec/controllers/projects/branches_controller_spec.rb' - 'ee/spec/controllers/projects/environments_controller_spec.rb' - 'ee/spec/controllers/projects/imports_controller_spec.rb' - 'ee/spec/controllers/projects/incident_management/escalation_policies_controller_spec.rb' @@ -76,29 +64,27 @@ RSpec/ContextWording: - 'ee/spec/controllers/projects/settings/repository_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/registrations/company_controller_spec.rb' - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/registrations/welcome_controller_spec.rb' - 'ee/spec/controllers/repositories/git_http_controller_spec.rb' - 'ee/spec/controllers/security/dashboard_controller_spec.rb' - - 'ee/spec/controllers/security/projects_controller_spec.rb' - 'ee/spec/controllers/security/vulnerabilities_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/controllers/trial_registrations_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/controllers/users_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/elastic/migrate/20220512150000_pause_indexing_for_unsupported_es_versions_spec.rb' + - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' + - 'ee/spec/elastic/migrate/20220713103500_delete_commits_from_original_index_spec.rb' - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/elastic_integration/global_search_spec.rb' - 'ee/spec/features/admin/admin_audit_logs_spec.rb' - 'ee/spec/features/admin/admin_credentials_inventory_spec.rb' - - 'ee/spec/features/admin/admin_dashboard_spec.rb' - 'ee/spec/features/admin/admin_dev_ops_reports_spec.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/admin/geo/admin_geo_nodes_spec.rb' - - 'ee/spec/features/admin/geo/admin_geo_sidebar_spec.rb' - - 'ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb' - 'ee/spec/features/admin/licenses/admin_adds_license_spec.rb' - - 'ee/spec/features/admin/licenses/show_user_count_threshold_spec.rb' - 'ee/spec/features/analytics/code_analytics_spec.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/features/boards/boards_licensed_features_spec.rb' @@ -109,9 +95,8 @@ RSpec/ContextWording: - 'ee/spec/features/boards/swimlanes/epics_swimlanes_drag_drop_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_labels_spec.rb' - - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_spec.rb' - - 'ee/spec/features/boards/user_visits_board_spec.rb' + - 'ee/spec/features/dashboards/todos_spec.rb' - 'ee/spec/features/discussion_comments/epic_quick_actions_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_spec.rb' @@ -120,25 +105,19 @@ RSpec/ContextWording: - 'ee/spec/features/epics/epic_issues_spec.rb' - 'ee/spec/features/epics/epics_list_spec.rb' - 'ee/spec/features/epics/gfm_autocomplete_spec.rb' - - 'ee/spec/features/epics/issue_promotion_spec.rb' - 'ee/spec/features/epics/referencing_epics_spec.rb' - 'ee/spec/features/epics/update_epic_spec.rb' - - 'ee/spec/features/epics/user_uses_quick_actions_spec.rb' - 'ee/spec/features/geo_node_spec.rb' - - 'ee/spec/features/google_analytics_datalayer_spec.rb' - - 'ee/spec/features/groups/active_tabs_spec.rb' + - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb' - 'ee/spec/features/groups/audit_events_spec.rb' - - 'ee/spec/features/groups/group_overview_spec.rb' - 'ee/spec/features/groups/group_roadmap_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/groups/groups_security_credentials_spec.rb' - 'ee/spec/features/groups/issues_spec.rb' - 'ee/spec/features/groups/iteration_spec.rb' - - 'ee/spec/features/groups/iterations/iterations_list_spec.rb' - - 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb' - 'ee/spec/features/groups/iterations/user_edits_iteration_spec.rb' - 'ee/spec/features/groups/ldap_group_links_spec.rb' - 'ee/spec/features/groups/members/manage_groups_spec.rb' @@ -148,13 +127,11 @@ RSpec/ContextWording: - 'ee/spec/features/groups/saml_providers_spec.rb' - 'ee/spec/features/groups/seat_usage/seat_usage_spec.rb' - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - - 'ee/spec/features/groups/settings/user_searches_in_settings_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - 'ee/spec/features/groups/usage_quotas_spec.rb' - - 'ee/spec/features/groups/wiki/user_views_wiki_empty_spec.rb' - 'ee/spec/features/groups_spec.rb' + - 'ee/spec/features/ide/user_commits_changes_spec.rb' - 'ee/spec/features/ide/user_opens_ide_spec.rb' - - 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb' - 'ee/spec/features/issues/epic_in_issue_sidebar_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb' - 'ee/spec/features/issues/form_spec.rb' @@ -180,20 +157,19 @@ RSpec/ContextWording: - 'ee/spec/features/merge_requests/user_filters_by_approvers_spec.rb' - 'ee/spec/features/oncall_schedules/user_creates_schedule_spec.rb' - 'ee/spec/features/profiles/account_spec.rb' + - 'ee/spec/features/profiles/usage_quotas_spec.rb' - 'ee/spec/features/projects/active_tabs_spec.rb' - 'ee/spec/features/projects/audit_events_spec.rb' - 'ee/spec/features/projects/custom_projects_template_spec.rb' - - 'ee/spec/features/projects/issues/user_creates_issue_spec.rb' - - 'ee/spec/features/projects/iterations/iteration_cadences_list_spec.rb' - - 'ee/spec/features/projects/iterations/iterations_list_spec.rb' - 'ee/spec/features/projects/iterations/user_views_iteration_spec.rb' - 'ee/spec/features/projects/jobs_spec.rb' - 'ee/spec/features/projects/kerberos_clone_instructions_spec.rb' - - 'ee/spec/features/projects/members/invite_group_and_members_spec.rb' + - 'ee/spec/features/projects/members/manage_groups_spec.rb' - 'ee/spec/features/projects/members/member_leaves_project_spec.rb' - 'ee/spec/features/projects/milestones/milestone_spec.rb' - 'ee/spec/features/projects/new_project_from_template_spec.rb' - 'ee/spec/features/projects/new_project_spec.rb' + - 'ee/spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - 'ee/spec/features/projects/push_rules_spec.rb' - 'ee/spec/features/projects/quality/test_case_create_spec.rb' @@ -206,25 +182,18 @@ RSpec/ContextWording: - 'ee/spec/features/projects/settings/merge_requests_settings_spec.rb' - 'ee/spec/features/projects/settings/protected_environments_spec.rb' - 'ee/spec/features/projects/settings/push_rules_settings_spec.rb' - - 'ee/spec/features/projects/settings/user_manages_members_spec.rb' - - 'ee/spec/features/projects/show_project_spec.rb' - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/protected_branches_spec.rb' - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/features/registrations/welcome_spec.rb' - 'ee/spec/features/search/elastic/global_search_spec.rb' - - 'ee/spec/features/search/elastic/snippet_search_spec.rb' - - 'ee/spec/features/security/project/snippet/internal_access_spec.rb' - - 'ee/spec/features/security/project/snippet/public_access_spec.rb' - 'ee/spec/features/signup_spec.rb' - - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' - 'ee/spec/features/trials/select_namespace_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/features/users/signup_spec.rb' + - 'ee/spec/finders/approval_rules/group_finder_spec.rb' - 'ee/spec/finders/audit_event_finder_spec.rb' - - 'ee/spec/finders/autocomplete/vulnerabilities_autocomplete_finder_spec.rb' - - 'ee/spec/finders/billed_users_finder_spec.rb' - 'ee/spec/finders/clusters/environments_finder_spec.rb' - 'ee/spec/finders/compliance_management/merge_requests/compliance_violations_finder_spec.rb' - 'ee/spec/finders/custom_project_templates_finder_spec.rb' @@ -234,6 +203,7 @@ RSpec/ContextWording: - 'ee/spec/finders/dast_site_validations_finder_spec.rb' - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/ee/clusters/agent_authorizations_finder_spec.rb' + - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' - 'ee/spec/finders/ee/namespaces/projects_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' @@ -260,7 +230,6 @@ RSpec/ContextWording: - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - 'ee/spec/finders/snippets_finder_spec.rb' - 'ee/spec/finders/software_license_policies_finder_spec.rb' - - 'ee/spec/finders/status_page/incidents_finder_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' @@ -269,11 +238,12 @@ RSpec/ContextWording: - 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' - 'ee/spec/graphql/ee/types/projects/service_type_enum_spec.rb' + - 'ee/spec/graphql/mutations/audit_events/streaming/headers/create_spec.rb' + - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/destroy_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/update_spec.rb' - - 'ee/spec/graphql/mutations/boards/epic_lists/update_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/create_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' @@ -294,12 +264,11 @@ RSpec/ContextWording: - 'ee/spec/graphql/mutations/security_policy/assign_security_policy_project_spec.rb' - 'ee/spec/graphql/mutations/security_policy/commit_scan_execution_policy_spec.rb' - 'ee/spec/graphql/mutations/security_policy/create_security_policy_project_spec.rb' - - 'ee/spec/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' - - 'ee/spec/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb' - 'ee/spec/graphql/resolvers/admin/cloud_licenses/subscription_future_entries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver_spec.rb' - 'ee/spec/graphql/resolvers/boards/board_list_epics_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/dora_metrics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/oncall_schedule_resolver_spec.rb' - 'ee/spec/graphql/resolvers/instance_security_dashboard/projects_resolver_spec.rb' @@ -308,7 +277,6 @@ RSpec/ContextWording: - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb' - 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' - 'ee/spec/graphql/types/global_id_type_spec.rb' - 'ee/spec/graphql/types/incident_management/escalation_rule_input_type_spec.rb' - 'ee/spec/graphql/types/issue_type_spec.rb' @@ -320,42 +288,32 @@ RSpec/ContextWording: - 'ee/spec/helpers/application_helper_spec.rb' - 'ee/spec/helpers/boards_helper_spec.rb' - 'ee/spec/helpers/compliance_management/compliance_framework/group_settings_helper_spec.rb' - - 'ee/spec/helpers/ee/application_settings_helper_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - - 'ee/spec/helpers/ee/dashboard_helper_spec.rb' - 'ee/spec/helpers/ee/environments_helper_spec.rb' - - 'ee/spec/helpers/ee/events_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' + - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/issuables_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' - - 'ee/spec/helpers/ee/learn_gitlab_helper_spec.rb' - 'ee/spec/helpers/ee/lock_helper_spec.rb' - - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/operations_helper_spec.rb' - 'ee/spec/helpers/ee/personal_access_tokens_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb' - - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - - 'ee/spec/helpers/ee/system_note_helper_spec.rb' - - 'ee/spec/helpers/ee/version_check_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/groups/security_features_helper_spec.rb' - 'ee/spec/helpers/license_helper_spec.rb' - 'ee/spec/helpers/license_monitoring_helper_spec.rb' - - 'ee/spec/helpers/notes_helper_spec.rb' - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' + - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - 'ee/spec/initializers/1_settings_spec.rb' - - 'ee/spec/initializers/database_config_spec.rb' - 'ee/spec/initializers/session_store_spec.rb' - - 'ee/spec/lib/analytics/devops_adoption/snapshot_calculator_spec.rb' - - 'ee/spec/lib/analytics/refresh_comments_data_spec.rb' - 'ee/spec/lib/audit/details_spec.rb' - 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb' - 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb' @@ -370,10 +328,10 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb' - 'ee/spec/lib/ee/api/helpers/variables_helpers_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' + - 'ee/spec/lib/ee/backup/repositories_spec.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/groups_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' @@ -382,9 +340,7 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/needs_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/templates/templates_spec.rb' - 'ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_batch_spec.rb' @@ -395,7 +351,6 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/gon_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/group_search_results_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/group_member_builder_spec.rb' - - 'ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_saver_spec.rb' @@ -403,24 +358,18 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/ip_restriction/enforcer_spec.rb' + - 'ee/spec/lib/ee/gitlab/issuable/clone/copy_resource_events_service_spec.rb' - 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb' - - 'ee/spec/lib/ee/gitlab/metrics/samplers/database_sampler_spec.rb' - - 'ee/spec/lib/ee/gitlab/omniauth_initializer_spec.rb' - - 'ee/spec/lib/ee/gitlab/prometheus/metric_group_spec.rb' - 'ee/spec/lib/ee/gitlab/repo_path_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - 'ee/spec/lib/ee/gitlab/usage/service_ping/payload_keys_processor_spec.rb' - - 'ee/spec/lib/ee/gitlab/usage/service_ping_report_spec.rb' - - 'ee/spec/lib/ee/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' + - 'ee/spec/lib/ee/service_ping/build_payload_spec.rb' - 'ee/spec/lib/elastic/multi_version_class_proxy_spec.rb' - 'ee/spec/lib/elastic/multi_version_instance_proxy_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/lead_time_for_changes_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/lead_time_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/gma_membership_enforcer_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/group_lookup_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/identity_linker_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/sso_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/token_actor_spec.rb' @@ -432,18 +381,12 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - - 'ee/spec/lib/gitlab/cache_spec.rb' - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/runners_availability_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/create_cross_database_associations_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/dependency_list/dependency_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Jobs/browser_performance_testing_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_testing_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/api_security_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/api_security_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb' @@ -454,6 +397,7 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/license_scanning_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/sast_iac_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_iac_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/secret_detection_gitlab_ci_yaml_spec.rb' @@ -487,53 +431,38 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - 'ee/spec/lib/gitlab/geo/signed_data_spec.rb' - - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/git_access_wiki_spec.rb' - 'ee/spec/lib/gitlab/gl_repository/identifier_spec.rb' - 'ee/spec/lib/gitlab/gl_repository/repo_type_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/epic_node_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerabilities/lazy_user_notes_count_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - - 'ee/spec/lib/gitlab/import_export/group/group_and_descendants_repo_restorer_spec.rb' - - 'ee/spec/lib/gitlab/import_export/group/group_and_descendants_repo_saver_spec.rb' - 'ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb' - 'ee/spec/lib/gitlab/import_export/project/object_builder_spec.rb' - 'ee/spec/lib/gitlab/insights/finders/issuable_finder_spec.rb' - 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb' - 'ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' - 'ee/spec/lib/gitlab/pagination_delegate_spec.rb' - - 'ee/spec/lib/gitlab/patch/database_config_spec.rb' - - 'ee/spec/lib/gitlab/reference_extractor_spec.rb' - 'ee/spec/lib/gitlab/search/aggregation_parser_spec.rb' - - 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/url_extractor_spec.rb' - 'ee/spec/lib/gitlab/slash_commands/presenters/issue_show_spec.rb' - 'ee/spec/lib/gitlab/status_page/filter/image_filter_spec.rb' - 'ee/spec/lib/gitlab/status_page/storage/s3_client_spec.rb' - - 'ee/spec/lib/gitlab/status_page/storage/s3_multipart_upload_spec.rb' - 'ee/spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'ee/spec/lib/gitlab/tracking/standard_context_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/build_type_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/distribution_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/lucene_version_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/version_metric_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/approval_project_rules_with_user_metric_spec.rb' - 'ee/spec/lib/gitlab/usage_data_counters/epic_activity_unique_counter_spec.rb' - 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb' - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' - - 'ee/spec/lib/system_check/app/search_check_spec.rb' - 'ee/spec/lib/system_check/geo/authorized_keys_check_spec.rb' - 'ee/spec/lib/system_check/geo/http_connection_check_spec.rb' - 'ee/spec/lib/system_check/rake_task/geo_task_spec.rb' - 'ee/spec/mailers/ee/emails/issues_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/migrations/schedule_requirements_migration_spec.rb' - - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - 'ee/spec/models/alert_management/alert_payload_field_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/group_stage_spec.rb' @@ -542,21 +471,18 @@ RSpec/ContextWording: - 'ee/spec/models/approval_merge_request_rule_spec.rb' - 'ee/spec/models/approval_project_rule_spec.rb' - 'ee/spec/models/approval_state_spec.rb' + - 'ee/spec/models/audit_events/external_audit_event_destination_spec.rb' - 'ee/spec/models/board_spec.rb' - 'ee/spec/models/boards/epic_board_position_spec.rb' - - 'ee/spec/models/broadcast_message_spec.rb' - 'ee/spec/models/ci/build_spec.rb' - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' - - 'ee/spec/models/ci/pipeline_spec.rb' - 'ee/spec/models/ci/sources/project_spec.rb' - 'ee/spec/models/ci/subscriptions/project_spec.rb' - - 'ee/spec/models/compliance_management/framework_spec.rb' - 'ee/spec/models/concerns/approval_rule_like_spec.rb' - 'ee/spec/models/concerns/approver_migrate_hook_spec.rb' - 'ee/spec/models/concerns/deprecated_approvals_before_merge_spec.rb' - 'ee/spec/models/concerns/ee/issuable_spec.rb' - - 'ee/spec/models/concerns/ee/milestoneable_spec.rb' - 'ee/spec/models/concerns/ee/participable_spec.rb' - 'ee/spec/models/concerns/elastic/issue_spec.rb' - 'ee/spec/models/concerns/elastic/note_spec.rb' @@ -571,38 +497,27 @@ RSpec/ContextWording: - 'ee/spec/models/dast_site_profile_spec.rb' - 'ee/spec/models/dast_site_validation_spec.rb' - 'ee/spec/models/deployment_spec.rb' - - 'ee/spec/models/dora/change_failure_rate_metric_spec.rb' - - 'ee/spec/models/dora/time_to_restore_service_metric_spec.rb' - 'ee/spec/models/ee/audit_event_spec.rb' - 'ee/spec/models/ee/award_emoji_spec.rb' - - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - - 'ee/spec/models/ee/ci/runner_spec.rb' + - 'ee/spec/models/ee/event_collection_spec.rb' - 'ee/spec/models/ee/event_spec.rb' + - 'ee/spec/models/ee/group_group_link_spec.rb' - 'ee/spec/models/ee/group_spec.rb' - 'ee/spec/models/ee/incident_management/project_incident_management_setting_spec.rb' - - 'ee/spec/models/ee/integrations/jira_spec.rb' - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - - 'ee/spec/models/ee/key_spec.rb' - - 'ee/spec/models/ee/merge_request_diff_spec.rb' - - 'ee/spec/models/ee/namespace/root_storage_size_spec.rb' - 'ee/spec/models/ee/namespace_ci_cd_setting_spec.rb' - - 'ee/spec/models/ee/namespace_limit_spec.rb' - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/ee/notification_setting_spec.rb' - 'ee/spec/models/ee/personal_access_token_spec.rb' - 'ee/spec/models/ee/project_group_link_spec.rb' - 'ee/spec/models/ee/protected_branch_spec.rb' - - 'ee/spec/models/ee/protected_ref_spec.rb' - - 'ee/spec/models/ee/service_desk_setting_spec.rb' - 'ee/spec/models/ee/user_spec.rb' - - 'ee/spec/models/environment_spec.rb' - 'ee/spec/models/epic_issue_spec.rb' - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/geo/container_repository_registry_spec.rb' - 'ee/spec/models/geo/design_registry_spec.rb' - - 'ee/spec/models/geo/job_artifact_registry_spec.rb' - 'ee/spec/models/geo/project_registry_spec.rb' - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - 'ee/spec/models/geo_node_spec.rb' @@ -611,13 +526,10 @@ RSpec/ContextWording: - 'ee/spec/models/gitlab_subscriptions/features_spec.rb' - 'ee/spec/models/group_member_spec.rb' - 'ee/spec/models/group_wiki_repository_spec.rb' - - 'ee/spec/models/group_wiki_spec.rb' - 'ee/spec/models/incident_management/escalation_rule_spec.rb' - 'ee/spec/models/incident_management/oncall_rotation_spec.rb' - - 'ee/spec/models/incident_management/oncall_shift_spec.rb' - 'ee/spec/models/incident_management/pending_escalations/alert_spec.rb' - 'ee/spec/models/incident_management/pending_escalations/issue_spec.rb' - - 'ee/spec/models/integrations/github/remote_project_spec.rb' - 'ee/spec/models/integrations/github_spec.rb' - 'ee/spec/models/ip_restriction_spec.rb' - 'ee/spec/models/issuable_metric_image_spec.rb' @@ -633,7 +545,6 @@ RSpec/ContextWording: - 'ee/spec/models/note_spec.rb' - 'ee/spec/models/packages/package_file_spec.rb' - 'ee/spec/models/path_lock_spec.rb' - - 'ee/spec/models/productivity_analytics_spec.rb' - 'ee/spec/models/project_import_data_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/project_member_spec.rb' @@ -643,19 +554,13 @@ RSpec/ContextWording: - 'ee/spec/models/protected_environments/approval_summary_spec.rb' - 'ee/spec/models/push_rule_spec.rb' - 'ee/spec/models/release_highlight_spec.rb' - - 'ee/spec/models/remote_mirror_spec.rb' - - 'ee/spec/models/repository_spec.rb' - - 'ee/spec/models/requirements_management/requirement_spec.rb' - 'ee/spec/models/requirements_management/test_report_spec.rb' - 'ee/spec/models/saml_group_link_spec.rb' - 'ee/spec/models/saml_provider_spec.rb' - 'ee/spec/models/status_page/project_setting_spec.rb' - - 'ee/spec/models/uploads/local_spec.rb' - - 'ee/spec/models/vulnerabilities/export_spec.rb' - 'ee/spec/models/vulnerabilities/feedback_spec.rb' - 'ee/spec/models/vulnerabilities/finding_pipeline_spec.rb' - 'ee/spec/models/vulnerabilities/finding_spec.rb' - - 'ee/spec/models/vulnerabilities/read_spec.rb' - 'ee/spec/models/vulnerabilities/statistic_spec.rb' - 'ee/spec/policies/app_sec/fuzzing/coverage/corpus_policy_spec.rb' - 'ee/spec/policies/compliance_management/framework_policy_spec.rb' @@ -669,12 +574,10 @@ RSpec/ContextWording: - 'ee/spec/policies/incident_management/oncall_shift_policy_spec.rb' - 'ee/spec/policies/issuable_policy_spec.rb' - 'ee/spec/policies/merge_request_policy_spec.rb' - - 'ee/spec/policies/note_policy_spec.rb' - 'ee/spec/policies/project_policy_spec.rb' - 'ee/spec/policies/project_snippet_policy_spec.rb' - 'ee/spec/policies/protected_branch_policy_spec.rb' - 'ee/spec/policies/saml_provider_policy_spec.rb' - - 'ee/spec/policies/user_policy_spec.rb' - 'ee/spec/presenters/approval_rule_presenter_spec.rb' - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/ci/build_runner_presenter_spec.rb' @@ -686,18 +589,16 @@ RSpec/ContextWording: - 'ee/spec/requests/admin/geo/replicables_controller_spec.rb' - 'ee/spec/requests/api/analytics/group_activity_analytics_spec.rb' - 'ee/spec/requests/api/audit_events_spec.rb' - - 'ee/spec/requests/api/award_emoji_spec.rb' - 'ee/spec/requests/api/boards_spec.rb' - 'ee/spec/requests/api/ci/jobs_spec.rb' - 'ee/spec/requests/api/ci/pipelines_spec.rb' - 'ee/spec/requests/api/ci/runner_spec.rb' - - 'ee/spec/requests/api/ci/triggers_spec.rb' - 'ee/spec/requests/api/commits_spec.rb' - 'ee/spec/requests/api/deployments_spec.rb' + - 'ee/spec/requests/api/dora/metrics_spec.rb' - 'ee/spec/requests/api/epic_issues_spec.rb' - 'ee/spec/requests/api/epic_links_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' - - 'ee/spec/requests/api/experiments_spec.rb' - 'ee/spec/requests/api/geo_nodes_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' - 'ee/spec/requests/api/graphql/boards/epic_boards_query_spec.rb' @@ -720,15 +621,14 @@ RSpec/ContextWording: - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epics/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/incident_management/escalation_policy/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/issuable_resource_link/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/issues/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/security_policy/assign_security_policy_project_spec.rb' - 'ee/spec/requests/api/graphql/mutations/security_policy/commit_scan_execution_policy_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/security_policy/create_security_policy_project_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb' - 'ee/spec/requests/api/graphql/project/code_coverage_summary_spec.rb' - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policies_spec.rb' - 'ee/spec/requests/api/graphql/project/incident_management/oncall_participants_spec.rb' @@ -739,7 +639,6 @@ RSpec/ContextWording: - 'ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb' - 'ee/spec/requests/api/graphql/vulnerabilities/sort_spec.rb' - 'ee/spec/requests/api/group_clusters_spec.rb' - - 'ee/spec/requests/api/group_hooks_spec.rb' - 'ee/spec/requests/api/group_push_rule_spec.rb' - 'ee/spec/requests/api/group_variables_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' @@ -753,7 +652,6 @@ RSpec/ContextWording: - 'ee/spec/requests/api/members_spec.rb' - 'ee/spec/requests/api/merge_request_approval_rules_spec.rb' - 'ee/spec/requests/api/merge_request_approval_settings_spec.rb' - - 'ee/spec/requests/api/merge_request_approvals_spec.rb' - 'ee/spec/requests/api/merge_requests_spec.rb' - 'ee/spec/requests/api/namespaces_spec.rb' - 'ee/spec/requests/api/project_aliases_spec.rb' @@ -773,19 +671,13 @@ RSpec/ContextWording: - 'ee/spec/requests/api/status_checks_spec.rb' - 'ee/spec/requests/api/users_spec.rb' - 'ee/spec/requests/api/v3/github_spec.rb' - - 'ee/spec/requests/api/visual_review_discussions_spec.rb' - - 'ee/spec/requests/api/vulnerabilities_spec.rb' - - 'ee/spec/requests/api/vulnerability_exports_spec.rb' - 'ee/spec/requests/api/vulnerability_findings_spec.rb' - 'ee/spec/requests/git_http_geo_spec.rb' - - 'ee/spec/requests/groups/group_members_controller_spec.rb' - 'ee/spec/requests/groups/roadmap_controller_spec.rb' - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' - - 'ee/spec/requests/groups/usage_quotas_spec.rb' + - 'ee/spec/requests/groups/settings/reporting_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - 'ee/spec/requests/jwt_controller_spec.rb' - - 'ee/spec/requests/lfs_http_spec.rb' - - 'ee/spec/requests/projects/analytics/code_reviews_controller_spec.rb' - 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb' - 'ee/spec/requests/projects/requirements_management/requirements_controller_spec.rb' - 'ee/spec/requests/projects/security/corpus_management_controller_spec.rb' @@ -796,7 +688,6 @@ RSpec/ContextWording: - 'ee/spec/requests/projects/security/scanned_resources_controller_spec.rb' - 'ee/spec/requests/rack_attack_spec.rb' - 'ee/spec/requests/repositories/git_http_controller_spec.rb' - - 'ee/spec/requests/search_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/routing/user_routing_spec.rb' - 'ee/spec/serializers/analytics/cycle_analytics/value_stream_errors_serializer_spec.rb' @@ -804,25 +695,19 @@ RSpec/ContextWording: - 'ee/spec/serializers/board_serializer_spec.rb' - 'ee/spec/serializers/clusters/environment_entity_spec.rb' - 'ee/spec/serializers/dashboard_operations_project_entity_spec.rb' - - 'ee/spec/serializers/ee/blob_entity_spec.rb' - 'ee/spec/serializers/ee/group_child_entity_spec.rb' - - 'ee/spec/serializers/ee/issue_sidebar_basic_entity_spec.rb' - 'ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb' - 'ee/spec/serializers/ee/merge_request_poll_cached_widget_entity_spec.rb' - 'ee/spec/serializers/ee/user_serializer_spec.rb' - 'ee/spec/serializers/environment_entity_spec.rb' - - 'ee/spec/serializers/epic_note_entity_spec.rb' - 'ee/spec/serializers/issue_serializer_spec.rb' - 'ee/spec/serializers/member_entity_spec.rb' - 'ee/spec/serializers/member_user_entity_spec.rb' - 'ee/spec/serializers/merge_request_widget_entity_spec.rb' - 'ee/spec/serializers/project_mirror_entity_spec.rb' - 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb' - - 'ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/stages/delete_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' - - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/create_service_spec.rb' - 'ee/spec/services/app_sec/dast/builds/associate_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - 'ee/spec/services/application_settings/update_service_spec.rb' @@ -833,29 +718,20 @@ RSpec/ContextWording: - 'ee/spec/services/approval_rules/update_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - 'ee/spec/services/audit_events/export_csv_service_spec.rb' - - 'ee/spec/services/audit_events/register_runner_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/runners_token_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/unregister_runner_audit_event_service_spec.rb' - - 'ee/spec/services/award_emojis/add_service_spec.rb' - 'ee/spec/services/boards/create_service_spec.rb' - 'ee/spec/services/boards/epic_boards/create_service_spec.rb' - 'ee/spec/services/boards/epics/move_service_spec.rb' - - 'ee/spec/services/boards/epics/position_create_service_spec.rb' - 'ee/spec/services/boards/lists/update_service_spec.rb' - 'ee/spec/services/ci/copy_cross_database_associations_service_spec.rb' - 'ee/spec/services/ci/create_pipeline_service_spec.rb' - - 'ee/spec/services/ci/minutes/update_build_minutes_service_spec.rb' - 'ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb' - - 'ee/spec/services/ci/process_build_service_spec.rb' + - 'ee/spec/services/ci/pipeline_trigger_service_spec.rb' - 'ee/spec/services/ci/register_job_service_spec.rb' - 'ee/spec/services/ci/retry_job_service_spec.rb' - - 'ee/spec/services/ci/runners/unregister_runner_service_spec.rb' - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' - 'ee/spec/services/ci_cd/setup_project_spec.rb' - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' - - 'ee/spec/services/compliance_management/merge_requests/create_compliance_violations_service_spec.rb' - - 'ee/spec/services/dashboard/projects/list_service_spec.rb' - 'ee/spec/services/deployments/approval_service_spec.rb' - 'ee/spec/services/dora/aggregate_metrics_service_spec.rb' - 'ee/spec/services/ee/alert_management/alerts/update_service_spec.rb' @@ -871,16 +747,16 @@ RSpec/ContextWording: - 'ee/spec/services/ee/integrations/test/project_service_spec.rb' - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' - - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/clone_service_spec.rb' - 'ee/spec/services/ee/issues/close_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/issues/move_service_spec.rb' - 'ee/spec/services/ee/issues/reopen_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' - - 'ee/spec/services/ee/labels/create_service_spec.rb' + - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - 'ee/spec/services/ee/members/create_service_spec.rb' - 'ee/spec/services/ee/members/destroy_service_spec.rb' + - 'ee/spec/services/ee/members/import_project_team_service_spec.rb' - 'ee/spec/services/ee/members/invite_service_spec.rb' - 'ee/spec/services/ee/merge_requests/base_service_spec.rb' - 'ee/spec/services/ee/merge_requests/create_service_spec.rb' @@ -888,16 +764,13 @@ RSpec/ContextWording: - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - - 'ee/spec/services/ee/namespace_settings/update_service_spec.rb' - 'ee/spec/services/ee/notes/create_service_spec.rb' - 'ee/spec/services/ee/notes/post_process_service_spec.rb' - 'ee/spec/services/ee/notes/quick_actions_service_spec.rb' - - 'ee/spec/services/ee/notes/update_service_spec.rb' - 'ee/spec/services/ee/notification_service_spec.rb' - 'ee/spec/services/ee/personal_access_tokens/revoke_service_spec.rb' - 'ee/spec/services/ee/preview_markdown_service_spec.rb' - 'ee/spec/services/ee/protected_branches/create_service_spec.rb' - - 'ee/spec/services/ee/quick_actions/target_service_spec.rb' - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb' - 'ee/spec/services/ee/users/build_service_spec.rb' - 'ee/spec/services/ee/users/create_service_spec.rb' @@ -915,7 +788,6 @@ RSpec/ContextWording: - 'ee/spec/services/epic_issues/update_service_spec.rb' - 'ee/spec/services/epics/create_service_spec.rb' - 'ee/spec/services/epics/epic_links/list_service_spec.rb' - - 'ee/spec/services/epics/issue_promote_service_spec.rb' - 'ee/spec/services/epics/related_epic_links/create_service_spec.rb' - 'ee/spec/services/epics/related_epic_links/destroy_service_spec.rb' - 'ee/spec/services/epics/update_dates_service_spec.rb' @@ -936,13 +808,13 @@ RSpec/ContextWording: - 'ee/spec/services/geo/repository_created_event_store_spec.rb' - 'ee/spec/services/geo/repository_sync_service_spec.rb' - 'ee/spec/services/geo/repository_verification_reset_spec.rb' - - 'ee/spec/services/geo/repository_verification_secondary_service_spec.rb' - 'ee/spec/services/geo/wiki_sync_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/activate_awaiting_users_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/extend_reactivate_trial_service_spec.rb' - - 'ee/spec/services/group_saml/group_managed_accounts/clean_up_members_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' - 'ee/spec/services/group_saml/group_managed_accounts/transfer_membership_service_spec.rb' - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/destroy_service_spec.rb' @@ -975,10 +847,9 @@ RSpec/ContextWording: - 'ee/spec/services/merge_requests/approval_service_spec.rb' - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' + - 'ee/spec/services/merge_requests/reload_merge_head_diff_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - 'ee/spec/services/milestones/update_service_spec.rb' - - 'ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - - 'ee/spec/services/namespaces/storage/email_notification_service_spec.rb' - 'ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb' - 'ee/spec/services/personal_access_tokens/rotation_verifier_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' @@ -988,7 +859,7 @@ RSpec/ContextWording: - 'ee/spec/services/projects/gitlab_projects_import_service_spec.rb' - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' - - 'ee/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' + - 'ee/spec/services/projects/group_links/update_service_spec.rb' - 'ee/spec/services/projects/import_export/export_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/operations/update_service_spec.rb' @@ -1011,13 +882,12 @@ RSpec/ContextWording: - 'ee/spec/services/search/snippet_service_spec.rb' - 'ee/spec/services/search_service_spec.rb' - 'ee/spec/services/security/dependency_list_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities/create_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' - - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - - 'ee/spec/services/security/orchestration/unassign_service_spec.rb' - 'ee/spec/services/security/report_summary_service_spec.rb' - 'ee/spec/services/security/scanned_resources_counting_service_spec.rb' - 'ee/spec/services/security/scanned_resources_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/policy_commit_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/process_policy_service_spec.rb' - 'ee/spec/services/security/store_grouped_scans_service_spec.rb' @@ -1027,16 +897,12 @@ RSpec/ContextWording: - 'ee/spec/services/software_license_policies/update_service_spec.rb' - 'ee/spec/services/status_page/publish_attachments_service_spec.rb' - 'ee/spec/services/status_page/publish_details_service_spec.rb' - - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' - 'ee/spec/services/system_notes/epics_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/services/user_permissions/export_service_spec.rb' - - 'ee/spec/services/vulnerabilities/create_service_spec.rb' - - 'ee/spec/services/vulnerabilities/historical_statistics/deletion_service_spec.rb' - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' - 'ee/spec/support/features/manual_quarterly_co_term_banner_examples.rb' - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' - 'ee/spec/support/shared_contexts/audit_event_not_licensed_shared_context.rb' @@ -1046,25 +912,22 @@ RSpec/ContextWording: - 'ee/spec/support/shared_contexts/gitlab_team_member_shared_context.rb' - 'ee/spec/support/shared_contexts/graphql/resolvers/security_orchestration/resolves_orchestration_policy_shared_contexts.rb' - 'ee/spec/support/shared_contexts/lib/gitlab/insights/reducers/reducers_shared_contexts.rb' + - 'ee/spec/support/shared_contexts/lib/gitlab/insights/serializers/serializers_shared_context.rb' - 'ee/spec/support/shared_contexts/push_rules_checks_shared_context.rb' - 'ee/spec/support/shared_contexts/requests/api/members_shared_contexts.rb' - 'ee/spec/support/shared_contexts/status_page/status_page_enabled_context.rb' - 'ee/spec/support/shared_contexts/status_page/status_page_list_objects.rb' - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/analytics/issues_analytics/shared_issues_analytics_examples.rb' - 'ee/spec/support/shared_examples/controllers/boards_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/registrations/groups_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/security/application_controller_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/credentials_inventory_shared_examples.rb' - 'ee/spec/support/shared_examples/features/insights_shared_examples.rb' + - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - 'ee/spec/support/shared_examples/features/sidebar_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/ultimate_trial_callout_shared_examples.rb' - 'ee/spec/support/shared_examples/graphql/mutations/epics/permission_check_shared_examples.rb' - - 'ee/spec/support/shared_examples/graphql/mutations/update_health_status_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/git_access_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/middleware/allowlisted_admin_geo_requests_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/middleware/maintenance_mode_gitlab_ee_instance_shared_examples.rb' @@ -1076,18 +939,13 @@ RSpec/ContextWording: - 'ee/spec/support/shared_examples/models/concerns/replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/repository_replicator_strategy_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/geo_batcher_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_framework_registry_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' - 'ee/spec/support/shared_examples/models/member_shared_examples.rb' - 'ee/spec/support/shared_examples/models/mentionable_shared_examples.rb' - 'ee/spec/support/shared_examples/models/protected_environments/authorizable_examples.rb' - 'ee/spec/support/shared_examples/quick_actions/issue/status_page_quick_actions_shared_examples.rb' - - 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/credentials_inventory_shared_examples.rb' - - 'ee/spec/support/shared_examples/requests/security/security_dashboard_json_endpoint_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_recovery_shared_examples.rb' - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/boards/base_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/merge_merge_requests_shared_examples.rb' @@ -1095,66 +953,56 @@ RSpec/ContextWording: - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - 'ee/spec/support/shared_examples/services/search_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/update_issuable_health_status_shared_examples.rb' - - 'ee/spec/support/shared_examples/views/registration_features_prompt_settings_link_shared_examples.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'ee/spec/tasks/gitlab/license_rake_spec.rb' - - 'ee/spec/tasks/gitlab/uploads/migrate_rake_spec.rb' - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' - 'ee/spec/views/admin/users/show.html.haml_spec.rb' - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' - 'ee/spec/views/groups/edit.html.haml_spec.rb' - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_new_dropdown.haml_spec.rb' + - 'ee/spec/views/layouts/header/_read_only_banner.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_admin.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_push_rules_link.html.haml_spec.rb' - 'ee/spec/views/profiles/preferences/show.html.haml_spec.rb' - 'ee/spec/views/projects/edit.html.haml_spec.rb' - - 'ee/spec/views/projects/issues/show.html.haml_spec.rb' - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/registrations/groups/new.html.haml_spec.rb' - - 'ee/spec/views/registrations/projects/new.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/search/_category.html.haml_spec.rb' - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' - 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/_expiry_date.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/gpg_keys/_gpg_key.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/project_access_tokens/_project_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/ssh_keys/_ssh_key.html.haml_spec.rb' - 'ee/spec/views/shared/issuable/_sidebar.html.haml_spec.rb' - - 'ee/spec/views/shared/labels/_create_label_help_text.html.haml_spec.rb' - - 'ee/spec/views/shared/promotions/_promotion_link_project.html.haml_spec.rb' - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/workers/active_user_count_threshold_worker_spec.rb' - 'ee/spec/workers/adjourned_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/admin_emails_worker_spec.rb' - - 'ee/spec/workers/analytics/code_review_metrics_worker_spec.rb' - 'ee/spec/workers/audit_events/audit_event_streaming_worker_spec.rb' - 'ee/spec/workers/ci/minutes/refresh_cached_data_worker_spec.rb' - 'ee/spec/workers/ci/minutes/update_project_and_namespace_usage_worker_spec.rb' - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb' - 'ee/spec/workers/ci/upstream_projects_subscriptions_cleanup_worker_spec.rb' - - 'ee/spec/workers/compliance_management/merge_requests/compliance_violations_worker_spec.rb' - 'ee/spec/workers/ee/repository_check/batch_worker_spec.rb' - 'ee/spec/workers/ee/repository_check/single_repository_worker_spec.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - 'ee/spec/workers/elastic_association_indexer_worker_spec.rb' - 'ee/spec/workers/elastic_index_bulk_cron_worker_spec.rb' - 'ee/spec/workers/elastic_indexing_control_worker_spec.rb' - - 'ee/spec/workers/geo/create_repository_updated_event_worker_spec.rb' - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' - 'ee/spec/workers/geo/repository_sync_worker_spec.rb' - 'ee/spec/workers/geo/repository_verification/primary/shard_worker_spec.rb' - 'ee/spec/workers/geo/repository_verification/secondary/shard_worker_spec.rb' - 'ee/spec/workers/geo/verification_timeout_worker_spec.rb' + - 'ee/spec/workers/group_saml_group_sync_worker_spec.rb' - 'ee/spec/workers/incident_management/apply_incident_sla_exceeded_label_worker_spec.rb' - 'ee/spec/workers/incident_management/oncall_rotations/persist_shifts_job_spec.rb' - - 'ee/spec/workers/iterations/cadences/schedule_create_iterations_worker_spec.rb' - - 'ee/spec/workers/iterations_update_status_worker_spec.rb' - 'ee/spec/workers/merge_request_reset_approvals_worker_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/personal_access_tokens/groups/policy_worker_spec.rb' @@ -1163,12 +1011,8 @@ RSpec/ContextWording: - 'ee/spec/workers/project_import_schedule_worker_spec.rb' - 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb' - 'ee/spec/workers/security/track_secure_scans_worker_spec.rb' - - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/automatic_failover_and_recovery_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/backend_node_recovery_spec.rb' @@ -1179,19 +1023,16 @@ RSpec/ContextWording: - 'qa/qa/specs/features/api/3_create/gitaly/praefect_replication_queue_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/praefect_repo_sync_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/milestone/assign_milestone_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/add_design_content_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/archive_design_content_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/modify_design_content_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/batch_suggestion_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/custom_commit_suggestion_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/file/create_file_via_web_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/file/delete_file_via_web_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/file/edit_file_via_web_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/server_hooks_custom_error_message_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/wiki/content_editor_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_content_creation_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_content_manipulation_spec.rb' @@ -1200,11 +1041,13 @@ RSpec/ContextWording: - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_page_deletion_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/mr_event_rule_pipeline_spec.rb' + - 'qa/qa/specs/features/browser_ui/4_verify/testing/endpoint_coverage_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/7_configure/kubernetes/kubernetes_integration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_tier_group_namespace_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_spec.rb' @@ -1215,18 +1058,14 @@ RSpec/ContextWording: - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_ssh_push_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_2_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/insights/default_insights_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/epic/epics_management_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_root_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_subgroup_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/wiki/create_group_wiki_page_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' @@ -1235,7 +1074,6 @@ RSpec/ContextWording: - 'qa/spec/service/docker_run/gitlab_runner_spec.rb' - 'qa/spec/service/docker_run/k3s_spec.rb' - 'qa/spec/specs/helpers/context_selector_spec.rb' - - 'qa/spec/specs/helpers/feature_flag_spec.rb' - 'qa/spec/specs/helpers/quarantine_spec.rb' - 'qa/spec/specs/runner_spec.rb' - 'qa/spec/support/loglinking_spec.rb' @@ -1245,29 +1083,26 @@ RSpec/ContextWording: - 'spec/commands/sidekiq_cluster/cli_spec.rb' - 'spec/components/diffs/overflow_warning_component_spec.rb' - 'spec/components/pajamas/alert_component_spec.rb' + - 'spec/components/pajamas/banner_component_spec.rb' + - 'spec/components/pajamas/button_component_spec.rb' + - 'spec/components/pajamas/card_component_spec.rb' + - 'spec/components/pajamas/spinner_component_spec.rb' - 'spec/config/object_store_settings_spec.rb' - 'spec/controllers/admin/application_settings_controller_spec.rb' - - 'spec/controllers/admin/clusters_controller_spec.rb' - - 'spec/controllers/admin/dev_ops_report_controller_spec.rb' - - 'spec/controllers/admin/impersonations_controller_spec.rb' - 'spec/controllers/admin/instance_review_controller_spec.rb' - 'spec/controllers/admin/integrations_controller_spec.rb' - 'spec/controllers/admin/runner_projects_controller_spec.rb' - 'spec/controllers/admin/sessions_controller_spec.rb' - - 'spec/controllers/admin/topics_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - - 'spec/controllers/boards/issues_controller_spec.rb' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/controllers/concerns/enforces_admin_authentication_spec.rb' - - 'spec/controllers/concerns/graceful_timeout_handling_spec.rb' - 'spec/controllers/concerns/group_tree_spec.rb' - 'spec/controllers/concerns/import_url_params_spec.rb' - 'spec/controllers/concerns/issuable_collections_spec.rb' - 'spec/controllers/concerns/metrics_dashboard_spec.rb' - 'spec/controllers/concerns/renders_commits_spec.rb' - - 'spec/controllers/concerns/send_file_upload_spec.rb' - 'spec/controllers/confirmations_controller_spec.rb' - 'spec/controllers/dashboard/milestones_controller_spec.rb' - 'spec/controllers/dashboard/projects_controller_spec.rb' @@ -1290,7 +1125,6 @@ RSpec/ContextWording: - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - 'spec/controllers/groups/settings/integrations_controller_spec.rb' - 'spec/controllers/groups/settings/repository_controller_spec.rb' - - 'spec/controllers/groups/uploads_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/help_controller_spec.rb' - 'spec/controllers/import/bitbucket_controller_spec.rb' @@ -1308,8 +1142,7 @@ RSpec/ContextWording: - 'spec/controllers/passwords_controller_spec.rb' - 'spec/controllers/profiles/emails_controller_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' - - 'spec/controllers/profiles/preferences_controller_spec.rb' - - 'spec/controllers/profiles/two_factor_auths_controller_spec.rb' + - 'spec/controllers/profiles/personal_access_tokens_controller_spec.rb' - 'spec/controllers/projects/alerting/notifications_controller_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/badges_controller_spec.rb' @@ -1328,11 +1161,9 @@ RSpec/ContextWording: - 'spec/controllers/projects/discussions_controller_spec.rb' - 'spec/controllers/projects/environments_controller_spec.rb' - 'spec/controllers/projects/feature_flags_clients_controller_spec.rb' - - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/find_file_controller_spec.rb' - 'spec/controllers/projects/forks_controller_spec.rb' - 'spec/controllers/projects/import/jira_controller_spec.rb' - - 'spec/controllers/projects/incidents_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/labels_controller_spec.rb' @@ -1358,7 +1189,6 @@ RSpec/ContextWording: - 'spec/controllers/projects/prometheus/metrics_controller_spec.rb' - 'spec/controllers/projects/raw_controller_spec.rb' - 'spec/controllers/projects/releases_controller_spec.rb' - - 'spec/controllers/projects/repositories_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects/settings/operations_controller_spec.rb' - 'spec/controllers/projects/settings/repository_controller_spec.rb' @@ -1367,44 +1197,36 @@ RSpec/ContextWording: - 'spec/controllers/projects/tags_controller_spec.rb' - 'spec/controllers/projects/todos_controller_spec.rb' - 'spec/controllers/projects/tree_controller_spec.rb' - - 'spec/controllers/projects/uploads_controller_spec.rb' - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/controllers/registrations/welcome_controller_spec.rb' - 'spec/controllers/registrations_controller_spec.rb' - - 'spec/controllers/repositories/git_http_controller_spec.rb' - 'spec/controllers/root_controller_spec.rb' - 'spec/controllers/search_controller_spec.rb' - - 'spec/controllers/sent_notifications_controller_spec.rb' - 'spec/controllers/sessions_controller_spec.rb' - 'spec/controllers/snippets/notes_controller_spec.rb' - 'spec/controllers/snippets_controller_spec.rb' - 'spec/controllers/uploads_controller_spec.rb' - 'spec/controllers/users/terms_controller_spec.rb' - - 'spec/db/docs_spec.rb' - 'spec/db/production/settings_spec.rb' - 'spec/db/schema_spec.rb' - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' - 'spec/experiments/application_experiment_spec.rb' - 'spec/experiments/ios_specific_templates_experiment_spec.rb' - - 'spec/features/admin/admin_abuse_reports_spec.rb' - 'spec/features/admin/admin_appearance_spec.rb' - 'spec/features/admin/admin_disables_git_access_protocol_spec.rb' + - 'spec/features/admin/admin_hook_logs_spec.rb' - 'spec/features/admin/admin_hooks_spec.rb' - 'spec/features/admin/admin_jobs_spec.rb' - 'spec/features/admin/admin_mode/login_spec.rb' - - 'spec/features/admin/admin_mode/logout_spec.rb' - - 'spec/features/admin/admin_mode/workers_spec.rb' - 'spec/features/admin/admin_mode_spec.rb' - - 'spec/features/admin/admin_search_settings_spec.rb' - 'spec/features/admin/admin_settings_spec.rb' - 'spec/features/admin/dashboard_spec.rb' - 'spec/features/admin/users/user_spec.rb' - 'spec/features/admin/users/users_spec.rb' - 'spec/features/atom/dashboard_issues_spec.rb' - 'spec/features/atom/dashboard_spec.rb' - - 'spec/features/atom/issues_spec.rb' - 'spec/features/atom/merge_requests_spec.rb' - 'spec/features/atom/users_spec.rb' - 'spec/features/boards/boards_spec.rb' @@ -1417,12 +1239,9 @@ RSpec/ContextWording: - 'spec/features/boards/sidebar_labels_spec.rb' - 'spec/features/boards/user_visits_board_spec.rb' - 'spec/features/calendar_spec.rb' - - 'spec/features/clusters/cluster_detail_page_spec.rb' - 'spec/features/clusters/cluster_health_dashboard_spec.rb' - 'spec/features/commits_spec.rb' - - 'spec/features/cycle_analytics_spec.rb' - 'spec/features/dashboard/activity_spec.rb' - - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' - 'spec/features/dashboard/groups_list_spec.rb' - 'spec/features/dashboard/issues_filter_spec.rb' - 'spec/features/dashboard/label_filter_spec.rb' @@ -1436,7 +1255,6 @@ RSpec/ContextWording: - 'spec/features/dashboard/user_filters_projects_spec.rb' - 'spec/features/expand_collapse_diffs_spec.rb' - 'spec/features/file_uploads/multipart_invalid_uploads_spec.rb' - - 'spec/features/frequently_visited_projects_and_groups_spec.rb' - 'spec/features/groups/board_sidebar_spec.rb' - 'spec/features/groups/board_spec.rb' - 'spec/features/groups/clusters/user_spec.rb' @@ -1450,11 +1268,8 @@ RSpec/ContextWording: - 'spec/features/groups/merge_requests_spec.rb' - 'spec/features/groups/milestone_spec.rb' - 'spec/features/groups/packages_spec.rb' - - 'spec/features/groups/settings/ci_cd_spec.rb' - 'spec/features/groups/settings/group_badges_spec.rb' - - 'spec/features/groups/settings/packages_and_registries_spec.rb' - 'spec/features/groups/settings/repository_spec.rb' - - 'spec/features/groups/settings/user_searches_in_settings_spec.rb' - 'spec/features/groups/share_lock_spec.rb' - 'spec/features/groups/show_spec.rb' - 'spec/features/groups/user_sees_package_sidebar_spec.rb' @@ -1492,8 +1307,6 @@ RSpec/ContextWording: - 'spec/features/issues/user_creates_issue_spec.rb' - 'spec/features/issues/user_edits_issue_spec.rb' - 'spec/features/issues/user_interacts_with_awards_spec.rb' - - 'spec/features/issues/user_scrolls_to_deeplinked_note_spec.rb' - - 'spec/features/issues/user_sorts_issue_comments_spec.rb' - 'spec/features/issues/user_toggles_subscription_spec.rb' - 'spec/features/issues/user_uses_quick_actions_spec.rb' - 'spec/features/issues/user_views_issues_spec.rb' @@ -1504,14 +1317,15 @@ RSpec/ContextWording: - 'spec/features/markdown/metrics_spec.rb' - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/close_reopen_report_toggle_spec.rb' + - 'spec/features/merge_request/merge_request_discussion_lock_spec.rb' - 'spec/features/merge_request/user_accepts_merge_request_spec.rb' - 'spec/features/merge_request/user_assigns_themselves_spec.rb' - - 'spec/features/merge_request/user_comments_on_diff_spec.rb' - 'spec/features/merge_request/user_creates_image_diff_notes_spec.rb' - 'spec/features/merge_request/user_creates_merge_request_spec.rb' - 'spec/features/merge_request/user_creates_mr_spec.rb' - 'spec/features/merge_request/user_edits_mr_spec.rb' - 'spec/features/merge_request/user_interacts_with_batched_mr_diffs_spec.rb' + - 'spec/features/merge_request/user_manages_subscription_spec.rb' - 'spec/features/merge_request/user_merges_merge_request_spec.rb' - 'spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb' - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb' @@ -1522,15 +1336,11 @@ RSpec/ContextWording: - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/merge_request/user_sees_cherry_pick_modal_spec.rb' - 'spec/features/merge_request/user_sees_closing_issues_message_spec.rb' - - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb' - - 'spec/features/merge_request/user_sees_diff_spec.rb' - 'spec/features/merge_request/user_sees_discussions_spec.rb' - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' - - 'spec/features/merge_request/user_sees_mini_pipeline_graph_spec.rb' - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' - 'spec/features/merge_request/user_uses_quick_actions_spec.rb' - 'spec/features/merge_request/user_views_open_merge_request_spec.rb' - - 'spec/features/merge_request/user_views_user_status_on_merge_request_spec.rb' - 'spec/features/merge_requests/filters_generic_behavior_spec.rb' - 'spec/features/merge_requests/user_exports_as_csv_spec.rb' - 'spec/features/merge_requests/user_filters_by_approvals_spec.rb' @@ -1539,7 +1349,6 @@ RSpec/ContextWording: - 'spec/features/merge_requests/user_filters_by_target_branch_spec.rb' - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' - 'spec/features/merge_requests/user_mass_updates_spec.rb' - - 'spec/features/merge_requests/user_sees_empty_state_spec.rb' - 'spec/features/milestones/user_views_milestone_spec.rb' - 'spec/features/monitor_sidebar_link_spec.rb' - 'spec/features/nav/top_nav_responsive_spec.rb' @@ -1550,7 +1359,6 @@ RSpec/ContextWording: - 'spec/features/profiles/keys_spec.rb' - 'spec/features/profiles/password_spec.rb' - 'spec/features/profiles/user_edit_profile_spec.rb' - - 'spec/features/profiles/user_search_settings_spec.rb' - 'spec/features/projects/active_tabs_spec.rb' - 'spec/features/projects/activity/user_sees_design_activity_spec.rb' - 'spec/features/projects/artifacts/file_spec.rb' @@ -1565,6 +1373,7 @@ RSpec/ContextWording: - 'spec/features/projects/commits/multi_view_diff_spec.rb' - 'spec/features/projects/commits/user_browses_commits_spec.rb' - 'spec/features/projects/compare_spec.rb' + - 'spec/features/projects/deploy_keys_spec.rb' - 'spec/features/projects/diffs/diff_show_spec.rb' - 'spec/features/projects/environments/environment_spec.rb' - 'spec/features/projects/environments/environments_spec.rb' @@ -1575,6 +1384,7 @@ RSpec/ContextWording: - 'spec/features/projects/files/user_creates_directory_spec.rb' - 'spec/features/projects/fork_spec.rb' - 'spec/features/projects/graph_spec.rb' + - 'spec/features/projects/hook_logs/user_reads_log_spec.rb' - 'spec/features/projects/import_export/export_file_spec.rb' - 'spec/features/projects/infrastructure_registry_spec.rb' - 'spec/features/projects/integrations/disable_triggers_spec.rb' @@ -1582,15 +1392,12 @@ RSpec/ContextWording: - 'spec/features/projects/issuable_templates_spec.rb' - 'spec/features/projects/issues/design_management/user_links_to_designs_in_issue_spec.rb' - 'spec/features/projects/issues/design_management/user_views_designs_spec.rb' - - 'spec/features/projects/issues/email_participants_spec.rb' + - 'spec/features/projects/jobs/user_browses_job_spec.rb' - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/labels/search_labels_spec.rb' - - 'spec/features/projects/labels/update_prioritization_spec.rb' - - 'spec/features/projects/labels/user_creates_labels_spec.rb' - 'spec/features/projects/members/group_members_spec.rb' - 'spec/features/projects/members/groups_with_access_list_spec.rb' - - 'spec/features/projects/members/manage_groups_spec.rb' - 'spec/features/projects/members/manage_members_spec.rb' - 'spec/features/projects/members/tabs_spec.rb' - 'spec/features/projects/members/user_requests_access_spec.rb' @@ -1601,21 +1408,20 @@ RSpec/ContextWording: - 'spec/features/projects/packages_spec.rb' - 'spec/features/projects/pages/user_edits_settings_spec.rb' - 'spec/features/projects/pipeline_schedules_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/pipelines/pipelines_spec.rb' - 'spec/features/projects/releases/user_views_releases_spec.rb' + - 'spec/features/projects/settings/branch_rules_settings_spec.rb' - 'spec/features/projects/settings/lfs_settings_spec.rb' - 'spec/features/projects/settings/packages_settings_spec.rb' - - 'spec/features/projects/settings/pipelines_settings_spec.rb' - 'spec/features/projects/settings/project_badges_spec.rb' - 'spec/features/projects/settings/project_settings_spec.rb' - - 'spec/features/projects/settings/registry_settings_spec.rb' - 'spec/features/projects/settings/repository_settings_spec.rb' + - 'spec/features/projects/settings/secure_files_spec.rb' - 'spec/features/projects/settings/service_desk_setting_spec.rb' - 'spec/features/projects/settings/user_interacts_with_deploy_keys_spec.rb' - - 'spec/features/projects/settings/user_renames_a_project_spec.rb' - - 'spec/features/projects/settings/user_searches_in_settings_spec.rb' - - 'spec/features/projects/settings/user_transfers_a_project_spec.rb' - 'spec/features/projects/settings/visibility_settings_spec.rb' - 'spec/features/projects/settings/webhooks_settings_spec.rb' - 'spec/features/projects/show/user_manages_notifications_spec.rb' @@ -1625,34 +1431,25 @@ RSpec/ContextWording: - 'spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb' - 'spec/features/projects/snippets/user_views_snippets_spec.rb' - 'spec/features/projects/sourcegraph_csp_spec.rb' - - 'spec/features/projects/tags/user_edits_tags_spec.rb' - 'spec/features/projects/tags/user_views_tags_spec.rb' - 'spec/features/projects/tree/tree_show_spec.rb' - - 'spec/features/projects/user_creates_project_spec.rb' - - 'spec/features/projects/user_sees_sidebar_spec.rb' - 'spec/features/projects/user_sorts_projects_spec.rb' - 'spec/features/projects/user_uses_shortcuts_spec.rb' - - 'spec/features/projects/view_on_env_spec.rb' - - 'spec/features/projects/wiki/user_views_wiki_empty_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/protected_branches_spec.rb' - 'spec/features/reportable_note/commit_spec.rb' - 'spec/features/reportable_note/merge_request_spec.rb' - 'spec/features/runners_spec.rb' - 'spec/features/search/user_searches_for_code_spec.rb' - - 'spec/features/search/user_uses_header_search_field_spec.rb' - - 'spec/features/security/project/snippet/internal_access_spec.rb' - - 'spec/features/security/project/snippet/public_access_spec.rb' - 'spec/features/signed_commits_spec.rb' - 'spec/features/snippets/explore_spec.rb' - 'spec/features/tags/developer_creates_tag_spec.rb' - 'spec/features/tags/developer_deletes_tag_spec.rb' - - 'spec/features/tags/developer_updates_tag_spec.rb' + - 'spec/features/tags/maintainer_deletes_protected_tag_spec.rb' - 'spec/features/uploads/user_uploads_file_to_note_spec.rb' - 'spec/features/user_can_display_performance_bar_spec.rb' - 'spec/features/user_opens_link_to_comment_spec.rb' - 'spec/features/users/login_spec.rb' - - 'spec/features/users/logout_spec.rb' - 'spec/features/users/overview_spec.rb' - 'spec/features/users/show_spec.rb' - 'spec/features/users/snippets_spec.rb' @@ -1664,14 +1461,12 @@ RSpec/ContextWording: - 'spec/finders/applications_finder_spec.rb' - 'spec/finders/autocomplete/acts_as_taggable_on/tags_finder_spec.rb' - 'spec/finders/autocomplete/move_to_project_finder_spec.rb' - - 'spec/finders/autocomplete/routes_finder_spec.rb' - 'spec/finders/autocomplete/users_finder_spec.rb' - 'spec/finders/branches_finder_spec.rb' - 'spec/finders/ci/commit_statuses_finder_spec.rb' - 'spec/finders/ci/jobs_finder_spec.rb' - 'spec/finders/ci/pipelines_finder_spec.rb' - 'spec/finders/ci/runners_finder_spec.rb' - - 'spec/finders/ci/variables_finder_spec.rb' - 'spec/finders/cluster_ancestors_finder_spec.rb' - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' - 'spec/finders/clusters/agents_finder_spec.rb' @@ -1679,7 +1474,6 @@ RSpec/ContextWording: - 'spec/finders/contributed_projects_finder_spec.rb' - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' - 'spec/finders/deployments_finder_spec.rb' - - 'spec/finders/design_management/designs_finder_spec.rb' - 'spec/finders/environments/environment_names_finder_spec.rb' - 'spec/finders/environments/environments_by_deployments_finder_spec.rb' - 'spec/finders/environments/environments_finder_spec.rb' @@ -1690,7 +1484,6 @@ RSpec/ContextWording: - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_transfer_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - - 'spec/finders/issues_finder_spec.rb' - 'spec/finders/joined_groups_finder_spec.rb' - 'spec/finders/keys_finder_spec.rb' - 'spec/finders/labels_finder_spec.rb' @@ -1703,8 +1496,6 @@ RSpec/ContextWording: - 'spec/finders/metrics/users_starred_dashboards_finder_spec.rb' - 'spec/finders/milestones_finder_spec.rb' - 'spec/finders/notes_finder_spec.rb' - - 'spec/finders/packages/conan/package_finder_spec.rb' - - 'spec/finders/packages/go/version_finder_spec.rb' - 'spec/finders/packages/group_packages_finder_spec.rb' - 'spec/finders/packages/helm/packages_finder_spec.rb' - 'spec/finders/packages/maven/package_finder_spec.rb' @@ -1738,7 +1529,6 @@ RSpec/ContextWording: - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - 'spec/graphql/features/feature_flag_spec.rb' - - 'spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb' - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' - 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb' - 'spec/graphql/mutations/alert_management/http_integration/destroy_spec.rb' @@ -1748,14 +1538,12 @@ RSpec/ContextWording: - 'spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb' - 'spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb' - 'spec/graphql/mutations/alert_management/update_alert_status_spec.rb' - - 'spec/graphql/mutations/boards/lists/update_spec.rb' - 'spec/graphql/mutations/clusters/agent_tokens/revoke_spec.rb' - 'spec/graphql/mutations/clusters/agents/create_spec.rb' - 'spec/graphql/mutations/custom_emoji/destroy_spec.rb' - 'spec/graphql/mutations/design_management/delete_spec.rb' - 'spec/graphql/mutations/design_management/move_spec.rb' - 'spec/graphql/mutations/groups/update_spec.rb' - - 'spec/graphql/mutations/issues/set_severity_spec.rb' - 'spec/graphql/mutations/merge_requests/update_spec.rb' - 'spec/graphql/mutations/release_asset_links/update_spec.rb' - 'spec/graphql/mutations/releases/delete_spec.rb' @@ -1780,7 +1568,6 @@ RSpec/ContextWording: - 'spec/graphql/resolvers/design_management/design_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/designs_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/version/design_at_version_resolver_spec.rb' - - 'spec/graphql/resolvers/design_management/version/designs_at_version_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/version_in_collection_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/version_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/versions_resolver_spec.rb' @@ -1793,7 +1580,6 @@ RSpec/ContextWording: - 'spec/graphql/resolvers/kas/agent_configurations_resolver_spec.rb' - 'spec/graphql/resolvers/kas/agent_connections_resolver_spec.rb' - 'spec/graphql/resolvers/last_commit_resolver_spec.rb' - - 'spec/graphql/resolvers/metrics/dashboard_resolver_spec.rb' - 'spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb' - 'spec/graphql/resolvers/namespace_projects_resolver_spec.rb' - 'spec/graphql/resolvers/project_merge_requests_resolver_spec.rb' @@ -1802,16 +1588,13 @@ RSpec/ContextWording: - 'spec/graphql/resolvers/snippets/blobs_resolver_spec.rb' - 'spec/graphql/resolvers/snippets_resolver_spec.rb' - 'spec/graphql/resolvers/terraform/states_resolver_spec.rb' - - 'spec/graphql/resolvers/timelog_resolver_spec.rb' - 'spec/graphql/resolvers/user_resolver_spec.rb' - 'spec/graphql/resolvers/users/group_count_resolver_spec.rb' - 'spec/graphql/resolvers/users/participants_resolver_spec.rb' - 'spec/graphql/subscriptions/issuable_updated_spec.rb' - 'spec/graphql/types/base_field_spec.rb' - 'spec/graphql/types/global_id_type_spec.rb' - - 'spec/graphql/types/invitation_interface_spec.rb' - 'spec/graphql/types/issue_type_spec.rb' - - 'spec/graphql/types/member_interface_spec.rb' - 'spec/graphql/types/range_input_type_spec.rb' - 'spec/graphql/types/release_links_type_spec.rb' - 'spec/graphql/types/user_type_spec.rb' @@ -1826,13 +1609,12 @@ RSpec/ContextWording: - 'spec/helpers/award_emoji_helper_spec.rb' - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/boards_helper_spec.rb' - - 'spec/helpers/ci/runners_helper_spec.rb' + - 'spec/helpers/ci/secure_files_helper_spec.rb' - 'spec/helpers/clusters_helper_spec.rb' - 'spec/helpers/colors_helper_spec.rb' - 'spec/helpers/commits_helper_spec.rb' - 'spec/helpers/diff_helper_spec.rb' - 'spec/helpers/emails_helper_spec.rb' - - 'spec/helpers/environment_helper_spec.rb' - 'spec/helpers/environments_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/git_helper_spec.rb' @@ -1842,7 +1624,6 @@ RSpec/ContextWording: - 'spec/helpers/ide_helper_spec.rb' - 'spec/helpers/integrations_helper_spec.rb' - 'spec/helpers/invite_members_helper_spec.rb' - - 'spec/helpers/issues_helper_spec.rb' - 'spec/helpers/jira_connect_helper_spec.rb' - 'spec/helpers/labels_helper_spec.rb' - 'spec/helpers/listbox_helper_spec.rb' @@ -1853,34 +1634,32 @@ RSpec/ContextWording: - 'spec/helpers/notes_helper_spec.rb' - 'spec/helpers/operations_helper_spec.rb' - 'spec/helpers/projects/cluster_agents_helper_spec.rb' + - 'spec/helpers/projects/project_members_helper_spec.rb' - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/releases_helper_spec.rb' - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - - 'spec/helpers/snippets_helper_spec.rb' - 'spec/helpers/sorting_helper_spec.rb' - 'spec/helpers/storage_helper_spec.rb' - 'spec/helpers/submodule_helper_spec.rb' - 'spec/helpers/timeboxes_helper_spec.rb' - - 'spec/helpers/timeboxes_routing_helper_spec.rb' - 'spec/helpers/todos_helper_spec.rb' - 'spec/helpers/tree_helper_spec.rb' - - 'spec/helpers/users/group_callouts_helper_spec.rb' + - 'spec/helpers/users/callouts_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - 'spec/helpers/visibility_level_helper_spec.rb' + - 'spec/helpers/web_hooks/web_hooks_helper_spec.rb' - 'spec/helpers/whats_new_helper_spec.rb' - 'spec/helpers/wiki_helper_spec.rb' - 'spec/initializers/00_rails_disable_joins_spec.rb' - - 'spec/initializers/0_log_deprecations_spec.rb' + - 'spec/initializers/1_acts_as_taggable_spec.rb' - 'spec/initializers/carrierwave_patch_spec.rb' - - 'spec/initializers/lograge_spec.rb' + - 'spec/initializers/enumerator_next_patch_spec.rb' - 'spec/initializers/mail_encoding_patch_spec.rb' - - 'spec/initializers/net_http_patch_spec.rb' - 'spec/initializers/rack_multipart_patch_spec.rb' - 'spec/initializers/secret_token_spec.rb' - 'spec/initializers/settings_spec.rb' - 'spec/initializers/validate_database_config_spec.rb' - - 'spec/initializers/validate_puma_spec.rb' - 'spec/lib/api/entities/application_setting_spec.rb' - 'spec/lib/api/entities/basic_project_details_spec.rb' - 'spec/lib/api/entities/clusters/agent_authorization_spec.rb' @@ -1911,14 +1690,12 @@ RSpec/ContextWording: - 'spec/lib/atlassian/jira_connect/serializers/deployment_entity_spec.rb' - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - 'spec/lib/atlassian/jira_connect_spec.rb' - - 'spec/lib/backup/files_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/backup/repositories_spec.rb' - 'spec/lib/banzai/color_parser_spec.rb' - 'spec/lib/banzai/filter/absolute_link_filter_spec.rb' - 'spec/lib/banzai/filter/asset_proxy_filter_spec.rb' - - 'spec/lib/banzai/filter/audio_link_filter_spec.rb' - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_placeholders_filter_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb' @@ -1927,7 +1704,6 @@ RSpec/ContextWording: - 'spec/lib/banzai/filter/front_matter_filter_spec.rb' - 'spec/lib/banzai/filter/gollum_tags_filter_spec.rb' - 'spec/lib/banzai/filter/inline_metrics_redactor_filter_spec.rb' - - 'spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb' - 'spec/lib/banzai/filter/markdown_filter_spec.rb' - 'spec/lib/banzai/filter/reference_redactor_filter_spec.rb' - 'spec/lib/banzai/filter/references/abstract_reference_filter_spec.rb' @@ -1949,12 +1725,10 @@ RSpec/ContextWording: - 'spec/lib/banzai/filter/table_of_contents_filter_spec.rb' - 'spec/lib/banzai/filter/table_of_contents_tag_filter_spec.rb' - 'spec/lib/banzai/filter/upload_link_filter_spec.rb' - - 'spec/lib/banzai/filter/video_link_filter_spec.rb' - 'spec/lib/banzai/filter/wiki_link_filter_spec.rb' - 'spec/lib/banzai/pipeline/broadcast_message_pipeline_spec.rb' - 'spec/lib/banzai/pipeline_spec.rb' - 'spec/lib/banzai/reference_parser/alert_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - 'spec/lib/banzai/reference_parser/commit_range_parser_spec.rb' - 'spec/lib/banzai/reference_parser/design_parser_spec.rb' - 'spec/lib/banzai/reference_parser/feature_flag_parser_spec.rb' @@ -1984,7 +1758,6 @@ RSpec/ContextWording: - 'spec/lib/constraints/group_url_constrainer_spec.rb' - 'spec/lib/constraints/project_url_constrainer_spec.rb' - 'spec/lib/constraints/user_url_constrainer_spec.rb' - - 'spec/lib/container_registry/blob_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/container_registry/migration_spec.rb' - 'spec/lib/container_registry/registry_spec.rb' @@ -1999,11 +1772,7 @@ RSpec/ContextWording: - 'spec/lib/feature/definition_spec.rb' - 'spec/lib/feature_spec.rb' - 'spec/lib/generators/gitlab/snowplow_event_definition_generator_spec.rb' - - 'spec/lib/generators/gitlab/usage_metric_generator_spec.rb' - - 'spec/lib/gitlab/alert_management/alert_status_counts_spec.rb' - 'spec/lib/gitlab/alert_management/fingerprint_spec.rb' - - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' - - 'spec/lib/gitlab/alert_management/payload_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/average_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/sorting_spec.rb' @@ -2011,19 +1780,13 @@ RSpec/ContextWording: - 'spec/lib/gitlab/asciidoc_spec.rb' - 'spec/lib/gitlab/asset_proxy_spec.rb' - 'spec/lib/gitlab/auth/atlassian/identity_linker_spec.rb' - - 'spec/lib/gitlab/auth/atlassian/user_spec.rb' - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - 'spec/lib/gitlab/auth/current_user_mode_spec.rb' - - 'spec/lib/gitlab/auth/key_status_checker_spec.rb' - - 'spec/lib/gitlab/auth/ldap/access_spec.rb' - 'spec/lib/gitlab/auth/ldap/adapter_spec.rb' - - 'spec/lib/gitlab/auth/ldap/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/ldap/dn_spec.rb' - - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - 'spec/lib/gitlab/auth/o_auth/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/o_auth/identity_linker_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/provider_spec.rb' - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/forti_authenticator/push_otp_spec.rb' @@ -2038,16 +1801,12 @@ RSpec/ContextWording: - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_with_corrected_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/bare_repository_import/repository_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' @@ -2056,17 +1815,14 @@ RSpec/ContextWording: - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' - 'spec/lib/gitlab/cache/helpers_spec.rb' - 'spec/lib/gitlab/chat/responder_spec.rb' - - 'spec/lib/gitlab/chat_name_token_spec.rb' - 'spec/lib/gitlab/checks/branch_check_spec.rb' - 'spec/lib/gitlab/checks/lfs_integrity_spec.rb' - - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' - 'spec/lib/gitlab/checks/push_file_count_check_spec.rb' - 'spec/lib/gitlab/checks/snippet_check_spec.rb' - 'spec/lib/gitlab/checks/tag_check_spec.rb' - 'spec/lib/gitlab/ci/ansi2html_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/style_spec.rb' - 'spec/lib/gitlab/ci/ansi2json_spec.rb' - - 'spec/lib/gitlab/ci/badge/coverage/report_spec.rb' - 'spec/lib/gitlab/ci/badge/pipeline/status_spec.rb' - 'spec/lib/gitlab/ci/badge/release/template_spec.rb' - 'spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb' @@ -2074,13 +1830,13 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/build/prerequisite/factory_spec.rb' - 'spec/lib/gitlab/ci/build/prerequisite/kubernetes_namespace_spec.rb' - 'spec/lib/gitlab/ci/build/releaser_spec.rb' + - 'spec/lib/gitlab/ci/build/rules/rule/clause/changes_spec.rb' - 'spec/lib/gitlab/ci/build/rules/rule/clause/exists_spec.rb' - 'spec/lib/gitlab/ci/build/rules_spec.rb' - 'spec/lib/gitlab/ci/charts_spec.rb' - 'spec/lib/gitlab/ci/config/entry/default_spec.rb' - 'spec/lib/gitlab/ci/config/entry/environment_spec.rb' - 'spec/lib/gitlab/ci/config/entry/include/rules/rule_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/include_spec.rb' - 'spec/lib/gitlab/ci/config/entry/inherit/default_spec.rb' - 'spec/lib/gitlab/ci/config/entry/inherit/variables_spec.rb' - 'spec/lib/gitlab/ci/config/entry/job_spec.rb' @@ -2089,8 +1845,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/config/entry/port_spec.rb' - 'spec/lib/gitlab/ci/config/entry/ports_spec.rb' - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/release_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/reports_spec.rb' - 'spec/lib/gitlab/ci/config/entry/retry_spec.rb' - 'spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb' - 'spec/lib/gitlab/ci/config/entry/trigger/forward_spec.rb' @@ -2100,9 +1854,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/jwt_spec.rb' - 'spec/lib/gitlab/ci/lint_spec.rb' - 'spec/lib/gitlab/ci/matching/runner_matcher_spec.rb' - - 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/create_spec.rb' @@ -2113,27 +1865,23 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/pipeline/expression/parser_spec.rb' - 'spec/lib/gitlab/ci/pipeline/quota/deployments_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb' - 'spec/lib/gitlab/ci/pipeline_object_hierarchy_spec.rb' - 'spec/lib/gitlab/ci/reports/reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/security/aggregated_report_spec.rb' - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/test_suite_comparer_spec.rb' - 'spec/lib/gitlab/ci/runner_instructions_spec.rb' + - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb' - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' - 'spec/lib/gitlab/ci/status/composite_spec.rb' - 'spec/lib/gitlab/ci/status/factory_spec.rb' - - 'spec/lib/gitlab/ci/status/stage/play_manual_spec.rb' - 'spec/lib/gitlab/ci/templates/5_minute_production_app_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/Jobs/build_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/code_quality_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/Jobs/deploy_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_latest_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/test_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/npm_spec.rb' - 'spec/lib/gitlab/ci/templates/templates_spec.rb' - 'spec/lib/gitlab/ci/templates/terraform_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/terraform_latest_gitlab_ci_yaml_spec.rb' @@ -2156,16 +1904,15 @@ RSpec/ContextWording: - 'spec/lib/gitlab/config/entry/composable_array_spec.rb' - 'spec/lib/gitlab/config/entry/composable_hash_spec.rb' - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' - - 'spec/lib/gitlab/console_spec.rb' - 'spec/lib/gitlab/consul/internal_spec.rb' - 'spec/lib/gitlab/content_security_policy/config_loader_spec.rb' - - 'spec/lib/gitlab/current_settings_spec.rb' - 'spec/lib/gitlab/cycle_analytics/permissions_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' - 'spec/lib/gitlab/data_builder/build_spec.rb' - 'spec/lib/gitlab/data_builder/issuable_spec.rb' - 'spec/lib/gitlab/data_builder/pipeline_spec.rb' - 'spec/lib/gitlab/database/background_migration/batch_optimizer_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - 'spec/lib/gitlab/database/batch_count_spec.rb' - 'spec/lib/gitlab/database/bulk_update_spec.rb' @@ -2173,7 +1920,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/database/count/tablesample_count_strategy_spec.rb' - 'spec/lib/gitlab/database/count_spec.rb' - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' @@ -2200,9 +1946,9 @@ RSpec/ContextWording: - 'spec/lib/gitlab/database/postgres_hll/batch_distinct_counter_spec.rb' - 'spec/lib/gitlab/database/query_analyzer_spec.rb' - 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_metrics_spec.rb' + - 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection_spec.rb' - 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb' - 'spec/lib/gitlab/database/query_analyzers/restrict_allowed_schemas_spec.rb' - - 'spec/lib/gitlab/database/reflection_spec.rb' - 'spec/lib/gitlab/database/reindexing/coordinator_spec.rb' - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' - 'spec/lib/gitlab/database/reindexing/reindex_action_spec.rb' @@ -2223,6 +1969,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/diff/lines_unfolder_spec.rb' - 'spec/lib/gitlab/diff/position_spec.rb' - 'spec/lib/gitlab/diff/position_tracer_spec.rb' + - 'spec/lib/gitlab/diff/rendered/notebook/diff_file_helper_spec.rb' - 'spec/lib/gitlab/diff/rendered/notebook/diff_file_spec.rb' - 'spec/lib/gitlab/diff/suggestions_parser_spec.rb' - 'spec/lib/gitlab/email/failure_handler_spec.rb' @@ -2234,18 +1981,17 @@ RSpec/ContextWording: - 'spec/lib/gitlab/email/handler_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/experience_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/team_short_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/team_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/trial_short_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/trial_spec.rb' - 'spec/lib/gitlab/email/message/repository_push_spec.rb' + - 'spec/lib/gitlab/email/reply_parser_spec.rb' - 'spec/lib/gitlab/encoding_helper_spec.rb' - 'spec/lib/gitlab/error_tracking/context_payload_generator_spec.rb' - 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb' - 'spec/lib/gitlab/error_tracking_spec.rb' - - 'spec/lib/gitlab/exceptions_app_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - 'spec/lib/gitlab/experimentation_spec.rb' @@ -2266,7 +2012,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/git/cross_repo_comparer_spec.rb' - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - - 'spec/lib/gitlab/git/keep_around_spec.rb' - 'spec/lib/gitlab/git/merge_base_spec.rb' - 'spec/lib/gitlab/git/raw_diff_change_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' @@ -2284,6 +2029,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/releases_importer_spec.rb' - 'spec/lib/gitlab/github_import/representation/diff_note_spec.rb' + - 'spec/lib/gitlab/github_import/representation/issue_event_spec.rb' - 'spec/lib/gitlab/github_import/representation/issue_spec.rb' - 'spec/lib/gitlab/github_import/representation/note_spec.rb' - 'spec/lib/gitlab/github_import/representation/pull_request_spec.rb' @@ -2296,18 +2042,16 @@ RSpec/ContextWording: - 'spec/lib/gitlab/graphql/loaders/issuable_loader_spec.rb' - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' - 'spec/lib/gitlab/graphql/pagination/externally_paginated_array_connection_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/order_info_spec.rb' - 'spec/lib/gitlab/graphql/queries_spec.rb' - 'spec/lib/gitlab/graphql_logger_spec.rb' + - 'spec/lib/gitlab/harbor/client_spec.rb' + - 'spec/lib/gitlab/harbor/query_spec.rb' - 'spec/lib/gitlab/health_checks/gitaly_check_spec.rb' - 'spec/lib/gitlab/health_checks/middleware_spec.rb' - - 'spec/lib/gitlab/health_checks/puma_check_spec.rb' - 'spec/lib/gitlab/health_checks/simple_check_shared.rb' - 'spec/lib/gitlab/highlight_spec.rb' - 'spec/lib/gitlab/hook_data/group_builder_spec.rb' - 'spec/lib/gitlab/hook_data/group_member_builder_spec.rb' - - 'spec/lib/gitlab/hook_data/issue_builder_spec.rb' - 'spec/lib/gitlab/hook_data/key_builder_spec.rb' - 'spec/lib/gitlab/hook_data/project_builder_spec.rb' - 'spec/lib/gitlab/hook_data/project_member_builder_spec.rb' @@ -2315,10 +2059,10 @@ RSpec/ContextWording: - 'spec/lib/gitlab/hook_data/user_builder_spec.rb' - 'spec/lib/gitlab/hotlinking_detector_spec.rb' - 'spec/lib/gitlab/http_spec.rb' - - 'spec/lib/gitlab/i18n/po_linter_spec.rb' - 'spec/lib/gitlab/import/merge_request_creator_spec.rb' - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' + - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' - 'spec/lib/gitlab/import_export/file_importer_spec.rb' - 'spec/lib/gitlab/import_export/group/legacy_tree_restorer_spec.rb' @@ -2345,9 +2089,10 @@ RSpec/ContextWording: - 'spec/lib/gitlab/incoming_email_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_base_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_cluster_validator_spec.rb' + - 'spec/lib/gitlab/instrumentation_helper_spec.rb' - 'spec/lib/gitlab/internal_post_receive/response_spec.rb' + - 'spec/lib/gitlab/issuable/clone/attributes_rewriter_spec.rb' - 'spec/lib/gitlab/issuable_metadata_spec.rb' - - 'spec/lib/gitlab/issuable_sorter_spec.rb' - 'spec/lib/gitlab/issuables_count_for_state_spec.rb' - 'spec/lib/gitlab/issues/rebalancing/state_spec.rb' - 'spec/lib/gitlab/jira/dvcs_spec.rb' @@ -2359,28 +2104,23 @@ RSpec/ContextWording: - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/lfs_token_spec.rb' - - 'spec/lib/gitlab/logger_spec.rb' - 'spec/lib/gitlab/lograge/custom_options_spec.rb' - 'spec/lib/gitlab/mail_room/authenticator_spec.rb' - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' - 'spec/lib/gitlab/manifest_import/manifest_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' + - 'spec/lib/gitlab/memory/reports_daemon_spec.rb' + - 'spec/lib/gitlab/memory/watchdog_spec.rb' - 'spec/lib/gitlab/merge_requests/commit_message_generator_spec.rb' - - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/cache_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/finder_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importer_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/stages/url_validator_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/transformers/yml/v1/prometheus_metrics_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/url_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator/errors_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator/post_schema_validator_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator_spec.rb' @@ -2388,7 +2128,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/metrics/method_call_spec.rb' - 'spec/lib/gitlab/metrics/methods_spec.rb' - 'spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb' - - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' - 'spec/lib/gitlab/metrics/samplers/threads_sampler_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/rack_attack_spec.rb' @@ -2396,9 +2135,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/middleware/basic_health_check_spec.rb' - 'spec/lib/gitlab/middleware/compressed_json_spec.rb' - 'spec/lib/gitlab/middleware/go_spec.rb' - - 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb' - 'spec/lib/gitlab/middleware/multipart_spec.rb' - - 'spec/lib/gitlab/middleware/rack_multipart_tempfile_factory_spec.rb' - 'spec/lib/gitlab/middleware/request_context_spec.rb' - 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb' - 'spec/lib/gitlab/namespaced_session_store_spec.rb' @@ -2410,22 +2147,18 @@ RSpec/ContextWording: - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' - 'spec/lib/gitlab/pagination/keyset/pager_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/paginator_spec.rb' - 'spec/lib/gitlab/pagination/keyset/simple_order_builder_spec.rb' - 'spec/lib/gitlab/pagination/offset_header_builder_spec.rb' - - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/performance_bar_spec.rb' - 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/process_supervisor_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/project_authorizations_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - 'spec/lib/gitlab/prometheus/adapter_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/additional_metrics_environment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' @@ -2438,7 +2171,8 @@ RSpec/ContextWording: - 'spec/lib/gitlab/rack_attack_spec.rb' - 'spec/lib/gitlab/reactive_cache_set_cache_spec.rb' - 'spec/lib/gitlab/redis/boolean_spec.rb' - - 'spec/lib/gitlab/redis/hll_spec.rb' + - 'spec/lib/gitlab/redis/duplicate_jobs_spec.rb' + - 'spec/lib/gitlab/regex_requires_app_spec.rb' - 'spec/lib/gitlab/regex_spec.rb' - 'spec/lib/gitlab/relative_positioning/item_context_spec.rb' - 'spec/lib/gitlab/relative_positioning/mover_spec.rb' @@ -2452,12 +2186,12 @@ RSpec/ContextWording: - 'spec/lib/gitlab/runtime_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/gitlab/sanitizers/svg_spec.rb' - - 'spec/lib/gitlab/search/params_spec.rb' - 'spec/lib/gitlab/search/sort_options_spec.rb' - 'spec/lib/gitlab/search_context/controller_concern_spec.rb' - 'spec/lib/gitlab/search_results_spec.rb' + - 'spec/lib/gitlab/service_desk_email_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/monitor_spec.rb' + - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/client_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/server_spec.rb' @@ -2467,12 +2201,12 @@ RSpec/ContextWording: - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/compressor_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/validator_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/worker_context/client_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb' - 'spec/lib/gitlab/sidekiq_signals_spec.rb' - 'spec/lib/gitlab/slash_commands/command_spec.rb' - - 'spec/lib/gitlab/slash_commands/deploy_spec.rb' - 'spec/lib/gitlab/slash_commands/issue_close_spec.rb' - 'spec/lib/gitlab/slash_commands/issue_new_spec.rb' - 'spec/lib/gitlab/slash_commands/issue_search_spec.rb' @@ -2480,9 +2214,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/slash_commands/presenters/issue_close_spec.rb' - 'spec/lib/gitlab/slash_commands/presenters/issue_show_spec.rb' - 'spec/lib/gitlab/slash_commands/run_spec.rb' - - 'spec/lib/gitlab/sourcegraph_spec.rb' - 'spec/lib/gitlab/spamcheck/client_spec.rb' - - 'spec/lib/gitlab/sql/pattern_spec.rb' - 'spec/lib/gitlab/ssh_public_key_spec.rb' - 'spec/lib/gitlab/submodule_links_spec.rb' - 'spec/lib/gitlab/subscription_portal_spec.rb' @@ -2493,30 +2225,26 @@ RSpec/ContextWording: - 'spec/lib/gitlab/tracking/incident_management_spec.rb' - 'spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'spec/lib/gitlab/tracking/standard_context_spec.rb' + - 'spec/lib/gitlab/tracking_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/gitlab/untrusted_regexp/ruby_syntax_spec.rb' - 'spec/lib/gitlab/untrusted_regexp_spec.rb' - 'spec/lib/gitlab/url_blocker_spec.rb' - - 'spec/lib/gitlab/url_builder_spec.rb' - 'spec/lib/gitlab/url_sanitizer_spec.rb' - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - 'spec/lib/gitlab/usage/metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/aggregate_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/count_users_creating_issues_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_hll_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/snowplow_configured_to_gitlab_collector_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/snowplow_enabled_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - 'spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb' - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' - 'spec/lib/gitlab/usage_data_counters/ci_template_unique_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/editor_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' + - 'spec/lib/gitlab/usage_data_counters/ipynb_diff_activity_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/quick_action_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/search_counter_spec.rb' @@ -2527,8 +2255,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' - 'spec/lib/gitlab/utils/usage_data_spec.rb' - 'spec/lib/gitlab/utils_spec.rb' - - 'spec/lib/gitlab/uuid_spec.rb' - - 'spec/lib/gitlab/version_info_spec.rb' - 'spec/lib/gitlab/view/presenter/base_spec.rb' - 'spec/lib/gitlab/visibility_level_checker_spec.rb' - 'spec/lib/gitlab/visibility_level_spec.rb' @@ -2545,14 +2271,11 @@ RSpec/ContextWording: - 'spec/lib/json_web_token/token_spec.rb' - 'spec/lib/kramdown/parser/atlassian_document_format_spec.rb' - 'spec/lib/mattermost/client_spec.rb' - - 'spec/lib/mattermost/command_spec.rb' - 'spec/lib/mattermost/session_spec.rb' - - 'spec/lib/mattermost/team_spec.rb' - 'spec/lib/object_storage/direct_upload_spec.rb' - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - 'spec/lib/peek/views/bullet_detailed_spec.rb' - 'spec/lib/product_analytics/event_params_spec.rb' - - 'spec/lib/prometheus/pid_provider_spec.rb' - 'spec/lib/safe_zip/entry_spec.rb' - 'spec/lib/security/ci_configuration/container_scanning_build_action_spec.rb' - 'spec/lib/security/ci_configuration/sast_build_action_spec.rb' @@ -2571,19 +2294,15 @@ RSpec/ContextWording: - 'spec/lib/system_check/orphans/repository_check_spec.rb' - 'spec/lib/uploaded_file_spec.rb' - 'spec/lib/version_check_spec.rb' + - 'spec/mailers/devise_mailer_spec.rb' - 'spec/mailers/emails/profile_spec.rb' - 'spec/mailers/emails/projects_spec.rb' - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/metrics_server/metrics_server_spec.rb' - 'spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb' - - 'spec/migrations/20220426185933_backfill_deployments_finished_at_spec.rb' - - 'spec/migrations/backfill_cadence_id_for_boards_scoped_to_iteration_spec.rb' - 'spec/migrations/finalize_traversal_ids_background_migrations_spec.rb' - - 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb' - 'spec/migrations/rename_services_to_integrations_spec.rb' - - 'spec/migrations/schedule_security_setting_creation_spec.rb' - 'spec/models/ability_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/alert_management/alert_spec.rb' @@ -2600,11 +2319,9 @@ RSpec/ContextWording: - 'spec/models/badges/project_badge_spec.rb' - 'spec/models/blob_spec.rb' - 'spec/models/blob_viewer/package_json_spec.rb' - - 'spec/models/board_spec.rb' - 'spec/models/bulk_imports/entity_spec.rb' - 'spec/models/ci/artifact_blob_spec.rb' - 'spec/models/ci/bridge_spec.rb' - - 'spec/models/ci/build_dependencies_spec.rb' - 'spec/models/ci/build_metadata_spec.rb' - 'spec/models/ci/build_runner_session_spec.rb' - 'spec/models/ci/build_spec.rb' @@ -2620,7 +2337,6 @@ RSpec/ContextWording: - 'spec/models/ci/processable_spec.rb' - 'spec/models/ci/project_mirror_spec.rb' - 'spec/models/ci/ref_spec.rb' - - 'spec/models/ci/resource_spec.rb' - 'spec/models/ci/runner_project_spec.rb' - 'spec/models/ci/runner_spec.rb' - 'spec/models/ci/running_build_spec.rb' @@ -2643,7 +2359,6 @@ RSpec/ContextWording: - 'spec/models/clusters/kubernetes_namespace_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' - 'spec/models/clusters/providers/aws_spec.rb' - - 'spec/models/commit_signatures/x509_commit_signature_spec.rb' - 'spec/models/commit_spec.rb' - 'spec/models/commit_status_spec.rb' - 'spec/models/compare_spec.rb' @@ -2651,18 +2366,15 @@ RSpec/ContextWording: - 'spec/models/concerns/awardable_spec.rb' - 'spec/models/concerns/bulk_insert_safe_spec.rb' - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - - 'spec/models/concerns/cache_markdown_field_spec.rb' - 'spec/models/concerns/cacheable_attributes_spec.rb' - - 'spec/models/concerns/cascading_namespace_setting_attribute_spec.rb' - 'spec/models/concerns/ci/artifactable_spec.rb' - 'spec/models/concerns/ci/has_ref_spec.rb' - 'spec/models/concerns/ci/has_status_spec.rb' - - 'spec/models/concerns/cron_schedulable_spec.rb' - 'spec/models/concerns/cross_database_modification_spec.rb' - 'spec/models/concerns/deployment_platform_spec.rb' - - 'spec/models/concerns/group_descendant_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/concerns/loose_index_scan_spec.rb' - 'spec/models/concerns/mentionable_spec.rb' - 'spec/models/concerns/milestoneable_spec.rb' - 'spec/models/concerns/noteable_spec.rb' @@ -2671,20 +2383,16 @@ RSpec/ContextWording: - 'spec/models/concerns/protected_ref_access_spec.rb' - 'spec/models/concerns/reactive_caching_spec.rb' - 'spec/models/concerns/resolvable_note_spec.rb' - - 'spec/models/concerns/routable_spec.rb' - - 'spec/models/concerns/schedulable_spec.rb' - 'spec/models/concerns/sensitive_serializable_hash_spec.rb' - - 'spec/models/concerns/spammable_spec.rb' - 'spec/models/concerns/token_authenticatable_spec.rb' - 'spec/models/concerns/triggerable_hooks_spec.rb' - 'spec/models/concerns/usage_statistics_spec.rb' - 'spec/models/container_expiration_policy_spec.rb' - 'spec/models/container_repository_spec.rb' - - 'spec/models/customer_relations/issue_contact_spec.rb' - 'spec/models/dependency_proxy/manifest_spec.rb' - 'spec/models/dependency_proxy/registry_spec.rb' - - 'spec/models/deploy_key_spec.rb' - 'spec/models/deploy_token_spec.rb' + - 'spec/models/deployment_cluster_spec.rb' - 'spec/models/deployment_metrics_spec.rb' - 'spec/models/deployment_spec.rb' - 'spec/models/design_management/action_spec.rb' @@ -2697,25 +2405,21 @@ RSpec/ContextWording: - 'spec/models/diff_note_spec.rb' - 'spec/models/environment_spec.rb' - 'spec/models/environment_status_spec.rb' - - 'spec/models/error_tracking/error_event_spec.rb' - 'spec/models/error_tracking/error_spec.rb' - 'spec/models/event_collection_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/experiment_spec.rb' - - 'spec/models/external_issue_spec.rb' - 'spec/models/external_pull_request_spec.rb' - - 'spec/models/fork_network_spec.rb' - 'spec/models/gpg_key_spec.rb' - 'spec/models/grafana_integration_spec.rb' - - 'spec/models/group_deploy_token_spec.rb' - 'spec/models/group_label_spec.rb' - 'spec/models/group_spec.rb' - 'spec/models/hooks/active_hook_filter_spec.rb' + - 'spec/models/hooks/project_hook_spec.rb' - 'spec/models/hooks/system_hook_spec.rb' - 'spec/models/identity_spec.rb' - 'spec/models/import_export_upload_spec.rb' - 'spec/models/import_failure_spec.rb' - - 'spec/models/incident_management/timeline_event_spec.rb' - 'spec/models/integration_spec.rb' - 'spec/models/integrations/asana_spec.rb' - 'spec/models/integrations/bamboo_spec.rb' @@ -2791,45 +2495,36 @@ RSpec/ContextWording: - 'spec/models/project_metrics_setting_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/project_team_spec.rb' - - 'spec/models/projects/repository_storage_move_spec.rb' - 'spec/models/prometheus_alert_event_spec.rb' - - 'spec/models/protectable_dropdown_spec.rb' - 'spec/models/protected_branch_spec.rb' - 'spec/models/raw_usage_data_spec.rb' - 'spec/models/release_highlight_spec.rb' - 'spec/models/release_spec.rb' - - 'spec/models/releases/link_spec.rb' - 'spec/models/remote_mirror_spec.rb' - 'spec/models/repository_spec.rb' - 'spec/models/resource_label_event_spec.rb' - 'spec/models/resource_state_event_spec.rb' - 'spec/models/route_spec.rb' - - 'spec/models/sent_notification_spec.rb' - 'spec/models/sentry_issue_spec.rb' - 'spec/models/snippet_input_action_spec.rb' - 'spec/models/snippet_repository_spec.rb' - 'spec/models/snippet_spec.rb' - 'spec/models/spam_log_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - - 'spec/models/suggestion_spec.rb' - 'spec/models/terraform/state_spec.rb' - 'spec/models/terraform/state_version_spec.rb' - - 'spec/models/todo_spec.rb' - 'spec/models/upload_spec.rb' - 'spec/models/uploads/fog_spec.rb' - 'spec/models/uploads/local_spec.rb' - - 'spec/models/user_interacted_project_spec.rb' - 'spec/models/user_preference_spec.rb' - 'spec/models/user_spec.rb' - 'spec/models/users/in_product_marketing_email_spec.rb' - 'spec/models/wiki_page/meta_spec.rb' - 'spec/models/wiki_page/slug_spec.rb' - 'spec/models/wiki_page_spec.rb' + - 'spec/models/work_item_spec.rb' - 'spec/models/x509_certificate_spec.rb' - - 'spec/models/zoom_meeting_spec.rb' - - 'spec/policies/application_setting/term_policy_spec.rb' - 'spec/policies/application_setting_policy_spec.rb' - - 'spec/policies/base_policy_spec.rb' - 'spec/policies/board_policy_spec.rb' - 'spec/policies/ci/build_policy_spec.rb' - 'spec/policies/clusters/agents/activity_event_policy_spec.rb' @@ -2837,18 +2532,13 @@ RSpec/ContextWording: - 'spec/policies/custom_emoji_policy_spec.rb' - 'spec/policies/deploy_key_policy_spec.rb' - 'spec/policies/deploy_keys_project_policy_spec.rb' - - 'spec/policies/design_management/design_policy_spec.rb' - 'spec/policies/global_policy_spec.rb' - 'spec/policies/group_member_policy_spec.rb' - 'spec/policies/group_policy_spec.rb' - - 'spec/policies/instance_metadata_policy_spec.rb' - 'spec/policies/issuable_policy_spec.rb' - 'spec/policies/issue_policy_spec.rb' - - 'spec/policies/merge_request_policy_spec.rb' - 'spec/policies/metrics/dashboard/annotation_policy_spec.rb' - - 'spec/policies/namespaces/project_namespace_policy_spec.rb' - 'spec/policies/namespaces/user_namespace_policy_spec.rb' - - 'spec/policies/note_policy_spec.rb' - 'spec/policies/personal_access_token_policy_spec.rb' - 'spec/policies/personal_snippet_policy_spec.rb' - 'spec/policies/project_policy_spec.rb' @@ -2863,12 +2553,9 @@ RSpec/ContextWording: - 'spec/presenters/clusters/cluster_presenter_spec.rb' - 'spec/presenters/commit_status_presenter_spec.rb' - 'spec/presenters/gitlab/blame_presenter_spec.rb' - - 'spec/presenters/group_member_presenter_spec.rb' - 'spec/presenters/merge_request_presenter_spec.rb' - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/npm/package_presenter_spec.rb' - - 'spec/presenters/packages/nuget/service_index_presenter_spec.rb' - - 'spec/presenters/project_member_presenter_spec.rb' - 'spec/presenters/project_presenter_spec.rb' - 'spec/presenters/projects/import_export/project_export_presenter_spec.rb' - 'spec/presenters/projects/security/configuration_presenter_spec.rb' @@ -2888,10 +2575,8 @@ RSpec/ContextWording: - 'spec/requests/api/appearance_spec.rb' - 'spec/requests/api/applications_spec.rb' - 'spec/requests/api/avatar_spec.rb' - - 'spec/requests/api/award_emoji_spec.rb' - 'spec/requests/api/badges_spec.rb' - 'spec/requests/api/branches_spec.rb' - - 'spec/requests/api/broadcast_messages_spec.rb' - 'spec/requests/api/bulk_imports_spec.rb' - 'spec/requests/api/ci/job_artifacts_spec.rb' - 'spec/requests/api/ci/jobs_spec.rb' @@ -2919,10 +2604,8 @@ RSpec/ContextWording: - 'spec/requests/api/environments_spec.rb' - 'spec/requests/api/error_tracking/collector_spec.rb' - 'spec/requests/api/error_tracking/project_settings_spec.rb' - - 'spec/requests/api/events_spec.rb' - 'spec/requests/api/files_spec.rb' - 'spec/requests/api/generic_packages_spec.rb' - - 'spec/requests/api/go_proxy_spec.rb' - 'spec/requests/api/graphql/ci/runner_spec.rb' - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/requests/api/graphql/container_repository/container_repository_details_spec.rb' @@ -2933,6 +2616,7 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/group/group_members_spec.rb' - 'spec/requests/api/graphql/group/issues_spec.rb' - 'spec/requests/api/graphql/group/milestones_spec.rb' + - 'spec/requests/api/graphql/issue/issue_spec.rb' - 'spec/requests/api/graphql/metadata_query_spec.rb' - 'spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb' - 'spec/requests/api/graphql/metrics/dashboard_query_spec.rb' @@ -2942,7 +2626,6 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/mutations/branches/create_spec.rb' - 'spec/requests/api/graphql/mutations/ci/runners_registration_token/reset_spec.rb' - 'spec/requests/api/graphql/mutations/commits/create_spec.rb' - - 'spec/requests/api/graphql/mutations/container_expiration_policy/update_spec.rb' - 'spec/requests/api/graphql/mutations/custom_emoji/destroy_spec.rb' - 'spec/requests/api/graphql/mutations/design_management/delete_spec.rb' - 'spec/requests/api/graphql/mutations/design_management/move_spec.rb' @@ -2951,9 +2634,7 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/mutations/issues/update_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/create_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/request_attention_spec.rb' - - 'spec/requests/api/graphql/mutations/namespace/package_settings/update_spec.rb' - 'spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb' - - 'spec/requests/api/graphql/mutations/notes/create/note_spec.rb' - 'spec/requests/api/graphql/mutations/releases/create_spec.rb' - 'spec/requests/api/graphql/mutations/releases/delete_spec.rb' - 'spec/requests/api/graphql/mutations/releases/update_spec.rb' @@ -2963,10 +2644,11 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/mutations/work_items/create_spec.rb' - 'spec/requests/api/graphql/mutations/work_items/delete_task_spec.rb' - 'spec/requests/api/graphql/mutations/work_items/update_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/update_task_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/update_widgets_spec.rb' - 'spec/requests/api/graphql/namespace_query_spec.rb' - 'spec/requests/api/graphql/packages/maven_spec.rb' - 'spec/requests/api/graphql/packages/package_spec.rb' - - 'spec/requests/api/graphql/project/alert_management/alert/notes_spec.rb' - 'spec/requests/api/graphql/project/alert_management/alerts_spec.rb' - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' - 'spec/requests/api/graphql/project/container_repositories_spec.rb' @@ -2981,7 +2663,6 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/project/pipeline_spec.rb' - 'spec/requests/api/graphql/project/project_members_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - - 'spec/requests/api/graphql/project/repository_spec.rb' - 'spec/requests/api/graphql/project/terraform/state_spec.rb' - 'spec/requests/api/graphql/project/terraform/states_spec.rb' - 'spec/requests/api/graphql/project_query_spec.rb' @@ -2990,7 +2671,6 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/user_query_spec.rb' - 'spec/requests/api/graphql/users_spec.rb' - 'spec/requests/api/graphql_spec.rb' - - 'spec/requests/api/group_avatar_spec.rb' - 'spec/requests/api/group_clusters_spec.rb' - 'spec/requests/api/group_labels_spec.rb' - 'spec/requests/api/group_packages_spec.rb' @@ -2998,6 +2678,7 @@ RSpec/ContextWording: - 'spec/requests/api/groups_spec.rb' - 'spec/requests/api/helm_packages_spec.rb' - 'spec/requests/api/helpers_spec.rb' + - 'spec/requests/api/integrations/jira_connect/subscriptions_spec.rb' - 'spec/requests/api/integrations_spec.rb' - 'spec/requests/api/internal/base_spec.rb' - 'spec/requests/api/internal/container_registry/migration_spec.rb' @@ -3005,6 +2686,7 @@ RSpec/ContextWording: - 'spec/requests/api/internal/lfs_spec.rb' - 'spec/requests/api/internal/mail_room_spec.rb' - 'spec/requests/api/internal/pages_spec.rb' + - 'spec/requests/api/internal/workhorse_spec.rb' - 'spec/requests/api/invitations_spec.rb' - 'spec/requests/api/issue_links_spec.rb' - 'spec/requests/api/issues/get_group_issues_spec.rb' @@ -3013,11 +2695,9 @@ RSpec/ContextWording: - 'spec/requests/api/issues/post_projects_issues_spec.rb' - 'spec/requests/api/issues/put_projects_issues_spec.rb' - 'spec/requests/api/keys_spec.rb' - - 'spec/requests/api/labels_spec.rb' - 'spec/requests/api/lint_spec.rb' - 'spec/requests/api/maven_packages_spec.rb' - 'spec/requests/api/members_spec.rb' - - 'spec/requests/api/merge_request_approvals_spec.rb' - 'spec/requests/api/merge_request_diffs_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/metrics/user_starred_dashboards_spec.rb' @@ -3034,8 +2714,6 @@ RSpec/ContextWording: - 'spec/requests/api/project_container_repositories_spec.rb' - 'spec/requests/api/project_events_spec.rb' - 'spec/requests/api/project_export_spec.rb' - - 'spec/requests/api/project_hooks_spec.rb' - - 'spec/requests/api/project_import_spec.rb' - 'spec/requests/api/project_packages_spec.rb' - 'spec/requests/api/project_snippets_spec.rb' - 'spec/requests/api/projects_spec.rb' @@ -3046,6 +2724,7 @@ RSpec/ContextWording: - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/search_spec.rb' - 'spec/requests/api/settings_spec.rb' + - 'spec/requests/api/snippets_spec.rb' - 'spec/requests/api/tags_spec.rb' - 'spec/requests/api/task_completion_status_spec.rb' - 'spec/requests/api/templates_spec.rb' @@ -3053,7 +2732,6 @@ RSpec/ContextWording: - 'spec/requests/api/terraform/state_spec.rb' - 'spec/requests/api/terraform/state_version_spec.rb' - 'spec/requests/api/todos_spec.rb' - - 'spec/requests/api/topics_spec.rb' - 'spec/requests/api/usage_data_spec.rb' - 'spec/requests/api/user_counts_spec.rb' - 'spec/requests/api/users_preferences_spec.rb' @@ -3066,31 +2744,32 @@ RSpec/ContextWording: - 'spec/requests/groups/clusters/integrations_controller_spec.rb' - 'spec/requests/groups/crm/contacts_controller_spec.rb' - 'spec/requests/groups/crm/organizations_controller_spec.rb' - - 'spec/requests/groups/email_campaigns_controller_spec.rb' - 'spec/requests/groups/milestones_controller_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' - 'spec/requests/health_controller_spec.rb' - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jira_connect/installations_controller_spec.rb' + - 'spec/requests/jira_connect/oauth_application_ids_controller_spec.rb' - 'spec/requests/jira_routing_spec.rb' - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' + - 'spec/requests/mailgun/webhooks_controller_spec.rb' - 'spec/requests/oauth_tokens_spec.rb' - 'spec/requests/openid_connect_spec.rb' - 'spec/requests/product_analytics/collector_app_attack_spec.rb' - 'spec/requests/product_analytics/collector_app_spec.rb' - 'spec/requests/projects/clusters/integrations_controller_spec.rb' - 'spec/requests/projects/commits_controller_spec.rb' + - 'spec/requests/projects/google_cloud/configuration_controller_spec.rb' + - 'spec/requests/projects/google_cloud/databases_controller_spec.rb' - 'spec/requests/projects/google_cloud/deployments_controller_spec.rb' - 'spec/requests/projects/google_cloud/gcp_regions_controller_spec.rb' - 'spec/requests/projects/google_cloud/service_accounts_controller_spec.rb' - - 'spec/requests/projects/google_cloud_controller_spec.rb' - 'spec/requests/projects/issues/discussions_spec.rb' - 'spec/requests/projects/issues_controller_spec.rb' - 'spec/requests/projects/merge_requests_controller_spec.rb' - 'spec/requests/projects/merge_requests_discussions_spec.rb' - - 'spec/requests/projects/merge_requests_spec.rb' - 'spec/requests/projects/metrics/dashboards/builder_spec.rb' - 'spec/requests/projects/releases_controller_spec.rb' - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' @@ -3098,13 +2777,11 @@ RSpec/ContextWording: - 'spec/requests/projects/usage_quotas_spec.rb' - 'spec/requests/projects_controller_spec.rb' - 'spec/requests/rack_attack_global_spec.rb' - - 'spec/requests/search_controller_spec.rb' - 'spec/requests/sessions_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/git_http_routing_spec.rb' - 'spec/routing/group_routing_spec.rb' - 'spec/routing/project_routing_spec.rb' - - 'spec/rubocop/cop/gitlab/avoid_feature_category_not_owned_spec.rb' - 'spec/rubocop/cop/gitlab/change_timezone_spec.rb' - 'spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb' - 'spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb' @@ -3116,7 +2793,6 @@ RSpec/ContextWording: - 'spec/rubocop/cop/graphql/old_types_spec.rb' - 'spec/rubocop/cop/lint/last_keyword_argument_spec.rb' - 'spec/rubocop/cop/migration/add_index_spec.rb' - - 'spec/rubocop/cop/migration/add_limit_to_text_columns_spec.rb' - 'spec/rubocop/cop/migration/background_migration_record_spec.rb' - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' - 'spec/rubocop/cop/migration/migration_record_spec.rb' @@ -3127,45 +2803,31 @@ RSpec/ContextWording: - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/rubocop/cop/migration/versioned_migration_class_spec.rb' - 'spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb' - - 'spec/rubocop/cop/performance/readlines_each_spec.rb' - 'spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb' - 'spec/rubocop/cop/qa/element_with_pattern_spec.rb' - 'spec/rubocop/cop/qa/selector_usage_spec.rb' - 'spec/rubocop/cop/rspec/factory_bot/inline_association_spec.rb' - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - - 'spec/serializers/blob_entity_spec.rb' - 'spec/serializers/board_serializer_spec.rb' - - 'spec/serializers/ci/job_serializer_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - 'spec/serializers/cluster_application_entity_spec.rb' - - 'spec/serializers/cluster_entity_spec.rb' - - 'spec/serializers/context_commits_diff_entity_spec.rb' + - 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb' - 'spec/serializers/diff_file_base_entity_spec.rb' - 'spec/serializers/diff_file_entity_spec.rb' - - 'spec/serializers/diff_file_metadata_entity_spec.rb' - 'spec/serializers/diffs_entity_spec.rb' - - 'spec/serializers/diffs_metadata_entity_spec.rb' - 'spec/serializers/environment_entity_spec.rb' - 'spec/serializers/environment_serializer_spec.rb' - 'spec/serializers/group_child_entity_spec.rb' - - 'spec/serializers/group_child_serializer_spec.rb' - 'spec/serializers/group_link/group_group_link_entity_spec.rb' - - 'spec/serializers/integrations/project_entity_spec.rb' - 'spec/serializers/issue_serializer_spec.rb' - - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' - 'spec/serializers/member_entity_spec.rb' - 'spec/serializers/member_serializer_spec.rb' - - 'spec/serializers/merge_request_current_user_entity_spec.rb' - 'spec/serializers/merge_request_diff_entity_spec.rb' - - 'spec/serializers/merge_request_for_pipeline_entity_spec.rb' - 'spec/serializers/merge_request_serializer_spec.rb' - 'spec/serializers/merge_request_user_entity_spec.rb' - - 'spec/serializers/merge_request_widget_commit_entity_spec.rb' - - 'spec/serializers/merge_request_widget_entity_spec.rb' - 'spec/serializers/paginated_diff_entity_spec.rb' - 'spec/serializers/pipeline_details_entity_spec.rb' - - 'spec/serializers/stage_entity_spec.rb' - 'spec/serializers/user_serializer_spec.rb' - 'spec/services/access_token_validation_service_spec.rb' - 'spec/services/alert_management/alerts/update_service_spec.rb' @@ -3178,7 +2840,6 @@ RSpec/ContextWording: - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'spec/services/boards/issues/list_service_spec.rb' - 'spec/services/boards/issues/move_service_spec.rb' - - 'spec/services/boards/lists/update_service_spec.rb' - 'spec/services/branches/delete_merged_service_spec.rb' - 'spec/services/branches/validate_new_service_spec.rb' - 'spec/services/bulk_create_integration_service_spec.rb' @@ -3186,7 +2847,6 @@ RSpec/ContextWording: - 'spec/services/ci/after_requeue_job_service_spec.rb' - 'spec/services/ci/append_build_trace_service_spec.rb' - 'spec/services/ci/archive_trace_service_spec.rb' - - 'spec/services/ci/build_report_result_service_spec.rb' - 'spec/services/ci/compare_test_reports_service_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service/cache_spec.rb' @@ -3209,14 +2869,11 @@ RSpec/ContextWording: - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - 'spec/services/ci/pipelines/add_job_service_spec.rb' - - 'spec/services/ci/play_build_service_spec.rb' - 'spec/services/ci/prepare_build_service_spec.rb' - - 'spec/services/ci/process_sync_events_service_spec.rb' - 'spec/services/ci/prometheus_metrics/observe_histograms_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' - 'spec/services/ci/retry_job_service_spec.rb' - - 'spec/services/ci/stuck_builds/drop_pending_service_spec.rb' - - 'spec/services/ci/stuck_builds/drop_scheduled_service_spec.rb' + - 'spec/services/ci/runners/reconcile_existing_runner_versions_service_spec.rb' - 'spec/services/ci/update_build_queue_service_spec.rb' - 'spec/services/ci/update_pending_build_service_spec.rb' - 'spec/services/clusters/agent_tokens/track_usage_service_spec.rb' @@ -3253,18 +2910,16 @@ RSpec/ContextWording: - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' - 'spec/services/dependency_proxy/head_manifest_service_spec.rb' - 'spec/services/dependency_proxy/request_token_service_spec.rb' - - 'spec/services/deployments/older_deployments_drop_service_spec.rb' - 'spec/services/deployments/update_environment_service_spec.rb' - 'spec/services/design_management/delete_designs_service_spec.rb' - 'spec/services/design_management/generate_image_versions_service_spec.rb' - 'spec/services/design_management/move_designs_service_spec.rb' - 'spec/services/discussions/capture_diff_note_position_service_spec.rb' - - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' - - 'spec/services/discussions/resolve_service_spec.rb' - 'spec/services/draft_notes/create_service_spec.rb' - 'spec/services/draft_notes/destroy_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' + - 'spec/services/environments/stop_service_spec.rb' - 'spec/services/error_tracking/collect_error_service_spec.rb' - 'spec/services/error_tracking/list_issues_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' @@ -3295,12 +2950,13 @@ RSpec/ContextWording: - 'spec/services/ide/schemas_config_service_spec.rb' - 'spec/services/ide/terminal_config_service_spec.rb' - 'spec/services/import/bitbucket_server_service_spec.rb' + - 'spec/services/import/fogbugz_service_spec.rb' - 'spec/services/import/github_service_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' - 'spec/services/incident_management/incidents/create_service_spec.rb' - 'spec/services/incident_management/issuable_escalation_statuses/create_service_spec.rb' - - 'spec/services/integrations/propagate_service_spec.rb' + - 'spec/services/incident_management/timeline_events/destroy_service_spec.rb' - 'spec/services/integrations/test/project_service_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issue_links/list_service_spec.rb' @@ -3317,17 +2973,17 @@ RSpec/ContextWording: - 'spec/services/issues/set_crm_contacts_service_spec.rb' - 'spec/services/issues/update_service_spec.rb' - 'spec/services/issues/zoom_link_service_spec.rb' - - 'spec/services/jira_connect_installations/destroy_service_spec.rb' - 'spec/services/jira_connect_subscriptions/create_service_spec.rb' - 'spec/services/keys/create_service_spec.rb' - 'spec/services/keys/expiry_notification_service_spec.rb' - - 'spec/services/labels/create_service_spec.rb' - - 'spec/services/lfs/file_transformer_spec.rb' - 'spec/services/lfs/locks_finder_service_spec.rb' - 'spec/services/lfs/push_service_spec.rb' - 'spec/services/lfs/unlock_file_service_spec.rb' - 'spec/services/members/approve_access_request_service_spec.rb' - 'spec/services/members/destroy_service_spec.rb' + - 'spec/services/members/groups/creator_service_spec.rb' + - 'spec/services/members/projects/creator_service_spec.rb' + - 'spec/services/members/update_service_spec.rb' - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb' - 'spec/services/merge_requests/after_create_service_spec.rb' - 'spec/services/merge_requests/approval_service_spec.rb' @@ -3351,7 +3007,6 @@ RSpec/ContextWording: - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/merge_requests/reload_diffs_service_spec.rb' - 'spec/services/merge_requests/reopen_service_spec.rb' - - 'spec/services/merge_requests/retarget_chain_service_spec.rb' - 'spec/services/merge_requests/squash_service_spec.rb' - 'spec/services/merge_requests/toggle_attention_requested_service_spec.rb' - 'spec/services/merge_requests/update_assignees_service_spec.rb' @@ -3379,7 +3034,6 @@ RSpec/ContextWording: - 'spec/services/milestones/promote_service_spec.rb' - 'spec/services/milestones/update_service_spec.rb' - 'spec/services/namespace_settings/update_service_spec.rb' - - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'spec/services/note_summary_spec.rb' - 'spec/services/notes/build_service_spec.rb' - 'spec/services/notes/copy_service_spec.rb' @@ -3388,12 +3042,11 @@ RSpec/ContextWording: - 'spec/services/notes/quick_actions_service_spec.rb' - 'spec/services/notes/update_service_spec.rb' - 'spec/services/notification_recipients/builder/default_spec.rb' - - 'spec/services/notification_recipients/builder/new_note_spec.rb' - 'spec/services/notification_service_spec.rb' + - 'spec/services/packages/cleanup/execute_policy_service_spec.rb' - 'spec/services/packages/composer/create_package_service_spec.rb' - 'spec/services/packages/conan/create_package_file_service_spec.rb' - 'spec/services/packages/conan/create_package_service_spec.rb' - - 'spec/services/packages/create_event_service_spec.rb' - 'spec/services/packages/create_package_file_service_spec.rb' - 'spec/services/packages/debian/create_distribution_service_spec.rb' - 'spec/services/packages/debian/create_package_file_service_spec.rb' @@ -3404,18 +3057,15 @@ RSpec/ContextWording: - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/maven/create_package_service_spec.rb' - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' - - 'spec/services/packages/maven/metadata/create_plugins_xml_service_spec.rb' - 'spec/services/packages/maven/metadata/create_versions_xml_service_spec.rb' - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - 'spec/services/packages/npm/create_package_service_spec.rb' - - 'spec/services/packages/npm/create_tag_service_spec.rb' - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' - 'spec/services/packages/nuget/search_service_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/packages/rubygems/dependency_resolver_service_spec.rb' - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - - 'spec/services/packages/update_tags_service_spec.rb' - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/personal_access_tokens/create_service_spec.rb' - 'spec/services/personal_access_tokens/revoke_service_spec.rb' @@ -3450,7 +3100,6 @@ RSpec/ContextWording: - 'spec/services/projects/record_target_platforms_service_spec.rb' - 'spec/services/projects/transfer_service_spec.rb' - 'spec/services/projects/unlink_fork_service_spec.rb' - - 'spec/services/projects/update_pages_service_spec.rb' - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_repository_storage_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' @@ -3458,10 +3107,8 @@ RSpec/ContextWording: - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb' - 'spec/services/protected_tags/create_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' - - 'spec/services/quick_actions/target_service_spec.rb' - 'spec/services/releases/create_service_spec.rb' - 'spec/services/releases/update_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/resource_access_tokens/create_service_spec.rb' - 'spec/services/search/global_service_spec.rb' - 'spec/services/search/group_service_spec.rb' @@ -3480,18 +3127,18 @@ RSpec/ContextWording: - 'spec/services/submodules/update_service_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' - - 'spec/services/system_notes/commit_service_spec.rb' - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/system_notes/issuables_service_spec.rb' - 'spec/services/system_notes/merge_requests_service_spec.rb' - 'spec/services/tasks_to_be_done/base_service_spec.rb' - 'spec/services/terraform/remote_state_handler_spec.rb' + - 'spec/services/terraform/states/destroy_service_spec.rb' + - 'spec/services/terraform/states/trigger_destroy_service_spec.rb' - 'spec/services/test_hooks/project_service_spec.rb' - 'spec/services/test_hooks/system_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/services/todos/destroy/entity_leave_service_spec.rb' - 'spec/services/two_factor/destroy_service_spec.rb' - - 'spec/services/upload_service_spec.rb' - 'spec/services/user_preferences/update_service_spec.rb' - 'spec/services/users/activity_service_spec.rb' - 'spec/services/users/approve_service_spec.rb' @@ -3514,10 +3161,9 @@ RSpec/ContextWording: - 'spec/services/wiki_pages/event_create_service_spec.rb' - 'spec/services/wikis/create_attachment_service_spec.rb' - 'spec/services/work_items/create_service_spec.rb' - - 'spec/services/x509_certificate_revoke_service_spec.rb' + - 'spec/services/work_items/parent_links/create_service_spec.rb' - 'spec/support/banzai/reference_filter_shared_examples.rb' - 'spec/support/prometheus/additional_metrics_shared_examples.rb' - - 'spec/support/redis/redis_new_instance_shared_examples.rb' - 'spec/support/redis/redis_shared_examples.rb' - 'spec/support/services/clusters/create_service_shared.rb' - 'spec/support/services/deploy_token_shared_examples.rb' @@ -3546,6 +3192,7 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/finders/merge_requests_finder_shared_contexts.rb' - 'spec/support/shared_contexts/finders/packages/npm/package_finder_shared_context.rb' - 'spec/support/shared_contexts/finders/users_finder_shared_contexts.rb' + - 'spec/support/shared_contexts/finders/work_items_finder_shared_contexts.rb' - 'spec/support/shared_contexts/fixtures/analytics_shared_context.rb' - 'spec/support/shared_contexts/graphql/requests/packages_shared_context.rb' - 'spec/support/shared_contexts/graphql/resolvers/runners_resolver_shared_context.rb' @@ -3569,6 +3216,7 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/policies/group_policy_shared_context.rb' - 'spec/support/shared_contexts/policies/project_policy_shared_context.rb' - 'spec/support/shared_contexts/policies/project_policy_table_shared_context.rb' + - 'spec/support/shared_contexts/project_features_shared_context.rb' - 'spec/support/shared_contexts/prometheus/alert_shared_context.rb' - 'spec/support/shared_contexts/rack_attack_shared_context.rb' - 'spec/support/shared_contexts/read_ci_configuration_shared_context.rb' @@ -3592,18 +3240,13 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/unique_ip_check_shared_context.rb' - 'spec/support/shared_contexts/upload_type_check_shared_context.rb' - 'spec/support/shared_contexts/url_shared_context.rb' - - 'spec/support/shared_examples/banzai/filters/inline_embeds_shared_examples.rb' - 'spec/support/shared_examples/banzai/filters/inline_metrics_redactor_shared_examples.rb' - 'spec/support/shared_examples/boards/multiple_issue_boards_shared_examples.rb' - 'spec/support/shared_examples/controllers/clusters_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/hotlink_interceptor_shared_examples.rb' - 'spec/support/shared_examples/controllers/issuables_list_metadata_shared_examples.rb' - - 'spec/support/shared_examples/controllers/milestone_tabs_shared_examples.rb' - - 'spec/support/shared_examples/controllers/repository_lfs_file_load_shared_examples.rb' - 'spec/support/shared_examples/controllers/snippet_blob_shared_examples.rb' - - 'spec/support/shared_examples/controllers/uploads_actions_shared_examples.rb' - - 'spec/support/shared_examples/controllers/variables_shared_examples.rb' - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - 'spec/support/shared_examples/csp.rb' - 'spec/support/shared_examples/features/access_tokens_shared_examples.rb' @@ -3622,6 +3265,7 @@ RSpec/ContextWording: - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_views_wiki_pages_shared_examples.rb' - 'spec/support/shared_examples/finders/assignees_filter_shared_examples.rb' + - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' - 'spec/support/shared_examples/finders/packages/debian/distributions_finder_shared_examples.rb' - 'spec/support/shared_examples/finders/packages_shared_examples.rb' - 'spec/support/shared_examples/finders/snippet_visibility_shared_examples.rb' @@ -3632,14 +3276,13 @@ RSpec/ContextWording: - 'spec/support/shared_examples/graphql/notes_on_noteables_shared_examples.rb' - 'spec/support/shared_examples/graphql/resolvers/packages_resolvers_shared_examples.rb' - 'spec/support/shared_examples/graphql/resolves_issuable_shared_examples.rb' - - 'spec/support/shared_examples/graphql/spam_protection_shared_examples.rb' + - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb' - 'spec/support/shared_examples/helm_commands_shared_examples.rb' - 'spec/support/shared_examples/helpers/issuable_description_templates_shared_examples.rb' - 'spec/support/shared_examples/lib/api/internal_base_shared_examples.rb' - 'spec/support/shared_examples/lib/cache_helpers_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/config/inheritable_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/import_export/relation_factory_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/database/reestablished_connection_stack_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/middleware/multipart_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_instance_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/search_confidential_filter_shared_examples.rb' @@ -3649,7 +3292,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/lib/gitlab/sidekiq_middleware/strategy_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/chat_integration_shared_examples.rb' - - 'spec/support/shared_examples/models/cluster_application_helm_cert_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_status_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_version_shared_examples.rb' - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' @@ -3657,7 +3299,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/models/concerns/composite_id_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/integrations/slack_mattermost_notifier_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/issuable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/repository_storage_movable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/timebox_shared_examples.rb' - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' @@ -3680,7 +3321,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/debian_common_shared_examples.rb' - 'spec/support/shared_examples/requests/api/debian_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/mutations/boards/update_list_shared_examples.rb' @@ -3688,6 +3328,7 @@ RSpec/ContextWording: - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/read_only_instance_shared_examples.rb' - 'spec/support/shared_examples/requests/api/helm_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - 'spec/support/shared_examples/requests/api/issues_shared_examples.rb' - 'spec/support/shared_examples/requests/api/multiple_and_scoped_issue_boards_shared_examples.rb' - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' @@ -3696,17 +3337,12 @@ RSpec/ContextWording: - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/read_user_shared_examples.rb' - 'spec/support/shared_examples/requests/api/repositories_shared_context.rb' - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/status_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/terraform/modules/v1/packages_shared_examples.rb' - 'spec/support/shared_examples/requests/clusters/certificate_based_clusters_feature_flag_shared_examples.rb' - 'spec/support/shared_examples/requests/lfs_http_shared_examples.rb' - 'spec/support/shared_examples/requests/releases_shared_examples.rb' - 'spec/support/shared_examples/routing/git_http_routing_shared_examples.rb' - - 'spec/support/shared_examples/sends_git_audit_streaming_event_shared_examples.rb' - 'spec/support/shared_examples/serializers/diff_file_entity_shared_examples.rb' - 'spec/support/shared_examples/serializers/note_entity_shared_examples.rb' - 'spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' @@ -3726,42 +3362,36 @@ RSpec/ContextWording: - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' - 'spec/support/shared_examples/services/schedule_bulk_repository_shard_moves_shared_examples.rb' - 'spec/support/shared_examples/services/security/ci_configuration/create_service_shared_examples.rb' - - 'spec/support/shared_examples/services/updating_mentions_shared_examples.rb' - 'spec/support/shared_examples/services/wiki_pages/create_service_shared_examples.rb' - 'spec/support/shared_examples/services/wiki_pages/update_service_shared_examples.rb' - 'spec/support/shared_examples/services/wikis/create_attachment_service_shared_examples.rb' - - 'spec/support/shared_examples/snippet_blob_shared_examples.rb' - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - 'spec/support/shared_examples/validators/url_validator_shared_examples.rb' - 'spec/support/shared_examples/views/pipeline_status_changes_email.rb' + - 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb' - 'spec/support/shared_examples/workers/concerns/git_garbage_collect_methods_shared_examples.rb' - 'spec/support/shared_examples/workers/project_export_shared_examples.rb' - - 'spec/support_specs/database/multiple_databases_spec.rb' - 'spec/support_specs/helpers/migrations_helpers_spec.rb' - 'spec/support_specs/helpers/stub_feature_flags_spec.rb' + - 'spec/support_specs/helpers/stub_method_calls_spec.rb' - 'spec/tasks/cache/clear/redis_spec.rb' - 'spec/tasks/dev_rake_spec.rb' - 'spec/tasks/gettext_rake_spec.rb' - - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb' - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' + - 'spec/tasks/gitlab/db/lock_writes_rake_spec.rb' - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/tasks/gitlab/dependency_proxy/migrate_rake_spec.rb' - 'spec/tasks/gitlab/gitaly_rake_spec.rb' - 'spec/tasks/gitlab/lfs/migrate_rake_spec.rb' - 'spec/tasks/gitlab/packages/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/pages_rake_spec.rb' - 'spec/tasks/gitlab/storage_rake_spec.rb' - 'spec/tasks/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/uploads/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/user_management_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' - - 'spec/tooling/danger/feature_flag_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' - 'spec/tooling/lib/tooling/parallel_rspec_runner_spec.rb' - - 'spec/tooling/rspec_flaky/listener_spec.rb' - 'spec/uploaders/attachment_uploader_spec.rb' - 'spec/uploaders/avatar_uploader_spec.rb' - 'spec/uploaders/content_type_whitelist_spec.rb' @@ -3782,7 +3412,6 @@ RSpec/ContextWording: - 'spec/uploaders/packages/package_file_uploader_spec.rb' - 'spec/uploaders/personal_file_uploader_spec.rb' - 'spec/uploaders/terraform/state_uploader_spec.rb' - - 'spec/uploaders/workers/object_storage/background_move_worker_spec.rb' - 'spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb' - 'spec/validators/addressable_url_validator_spec.rb' - 'spec/validators/array_members_validator_spec.rb' @@ -3804,7 +3433,6 @@ RSpec/ContextWording: - 'spec/views/layouts/_header_search.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - 'spec/views/layouts/header/_new_dropdown.haml_spec.rb' - - 'spec/views/layouts/nav/sidebar/_admin.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/notify/changed_milestone_email.html.haml_spec.rb' - 'spec/views/profiles/keys/_key.html.haml_spec.rb' @@ -3817,15 +3445,13 @@ RSpec/ContextWording: - 'spec/views/projects/hooks/edit.html.haml_spec.rb' - 'spec/views/projects/hooks/index.html.haml_spec.rb' - 'spec/views/projects/pipeline_schedules/_pipeline_schedule.html.haml_spec.rb' + - 'spec/views/projects/settings/integrations/edit.html.haml_spec.rb' - 'spec/views/projects/settings/operations/show.html.haml_spec.rb' - 'spec/views/projects/tags/index.html.haml_spec.rb' - - 'spec/views/projects/tree/show.html.haml_spec.rb' - 'spec/views/search/_results.html.haml_spec.rb' - 'spec/views/search/show.html.haml_spec.rb' - - 'spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'spec/views/shared/issuable/_sidebar.html.haml_spec.rb' - 'spec/views/shared/milestones/_issuable.html.haml_spec.rb' - - 'spec/views/shared/projects/_list.html.haml_spec.rb' - 'spec/views/shared/snippets/_snippet.html.haml_spec.rb' - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' - 'spec/workers/admin_email_worker_spec.rb' @@ -3834,12 +3460,12 @@ RSpec/ContextWording: - 'spec/workers/authorized_project_update/project_recalculate_per_user_worker_spec.rb' - 'spec/workers/authorized_project_update/project_recalculate_worker_spec.rb' - 'spec/workers/authorized_project_update/user_refresh_over_user_range_worker_spec.rb' - - 'spec/workers/bulk_imports/entity_worker_spec.rb' - 'spec/workers/ci/build_prepare_worker_spec.rb' - 'spec/workers/cleanup_container_repository_worker_spec.rb' - 'spec/workers/cluster_update_app_worker_spec.rb' - 'spec/workers/clusters/agents/delete_expired_events_worker_spec.rb' - 'spec/workers/concerns/application_worker_spec.rb' + - 'spec/workers/concerns/waitable_worker_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - 'spec/workers/container_expiration_policy_worker_spec.rb' - 'spec/workers/container_registry/migration/enqueuer_worker_spec.rb' @@ -3852,6 +3478,7 @@ RSpec/ContextWording: - 'spec/workers/deployments/update_environment_worker_spec.rb' - 'spec/workers/design_management/new_version_worker_spec.rb' - 'spec/workers/every_sidekiq_worker_spec.rb' + - 'spec/workers/gitlab_service_ping_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - 'spec/workers/integrations/create_external_cross_reference_worker_spec.rb' @@ -3868,11 +3495,11 @@ RSpec/ContextWording: - 'spec/workers/project_export_worker_spec.rb' - 'spec/workers/projects/git_garbage_collect_worker_spec.rb' - 'spec/workers/projects/post_creation_worker_spec.rb' - - 'spec/workers/projects/refresh_build_artifacts_size_statistics_worker_spec.rb' - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' - 'spec/workers/remove_expired_group_links_worker_spec.rb' - 'spec/workers/remove_expired_members_worker_spec.rb' - 'spec/workers/remove_unaccepted_member_invites_worker_spec.rb' - 'spec/workers/repository_fork_worker_spec.rb' - 'spec/workers/stuck_merge_jobs_worker_spec.rb' + - 'spec/workers/terraform/states/destroy_worker_spec.rb' - 'spec/workers/x509_issuer_crl_check_worker_spec.rb' diff --git a/.rubocop_todo/rspec/empty_line_after_hook.yml b/.rubocop_todo/rspec/empty_line_after_hook.yml new file mode 100644 index 00000000000..4b1c4299b20 --- /dev/null +++ b/.rubocop_todo/rspec/empty_line_after_hook.yml @@ -0,0 +1,60 @@ +--- +# Cop supports --auto-correct. +RSpec/EmptyLineAfterHook: + Exclude: + - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' + - 'ee/spec/controllers/projects/push_rules_controller_spec.rb' + - 'ee/spec/features/groups/usage_quotas_spec.rb' + - 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb' + - 'ee/spec/features/profiles/usage_quotas_spec.rb' + - 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb' + - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' + - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' + - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' + - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' + - 'ee/spec/lib/gitlab/proxy_spec.rb' + - 'ee/spec/lib/gitlab/vulnerabilities/container_scanning_vulnerability_spec.rb' + - 'ee/spec/models/ee/key_spec.rb' + - 'ee/spec/models/project_spec.rb' + - 'ee/spec/requests/api/users_spec.rb' + - 'ee/spec/requests/search_controller_spec.rb' + - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' + - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' + - 'ee/spec/services/ee/two_factor/destroy_service_spec.rb' + - 'ee/spec/services/external_status_checks/update_service_spec.rb' + - 'ee/spec/services/group_saml/saml_group_links/destroy_service_spec.rb' + - 'ee/spec/services/groups/memberships/export_service_spec.rb' + - 'ee/spec/services/merge_requests/approval_service_spec.rb' + - 'ee/spec/support/shared_examples/policies/protected_environments_shared_examples.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' + - 'qa/spec/specs/helpers/quarantine_spec.rb' + - 'qa/spec/support/page_error_checker_spec.rb' + - 'spec/controllers/admin/spam_logs_controller_spec.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/features/admin/admin_mode/login_spec.rb' + - 'spec/features/calendar_spec.rb' + - 'spec/features/projects/blobs/user_views_pipeline_editor_button_spec.rb' + - 'spec/features/users/overview_spec.rb' + - 'spec/lib/gitlab/auth/ldap/person_spec.rb' + - 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' + - 'spec/mailers/emails/pages_domains_spec.rb' + - 'spec/models/application_record_spec.rb' + - 'spec/models/integrations/chat_message/merge_message_spec.rb' + - 'spec/models/integrations/microsoft_teams_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb' + - 'spec/requests/api/issues/issues_spec.rb' + - 'spec/requests/api/pages/internal_access_spec.rb' + - 'spec/requests/api/pages/private_access_spec.rb' + - 'spec/requests/api/pages/public_access_spec.rb' + - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' + - 'spec/services/merge_requests/execute_approval_hooks_service_spec.rb' + - 'spec/services/notes/create_service_spec.rb' + - 'spec/services/notes/quick_actions_service_spec.rb' + - 'spec/services/projects/fork_service_spec.rb' + - 'spec/support/redis/redis_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/milestones_shared_examples.rb' + - 'spec/support/shared_examples/sends_git_audit_streaming_event_shared_examples.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index b08830bd5a3..03066626883 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. RSpec/ExpectChange: - # Offense count: 1707 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/admin/applications_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' @@ -28,8 +25,10 @@ RSpec/ExpectChange: - 'ee/spec/controllers/registrations/groups_controller_spec.rb' - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/projects_spec.rb' + - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/graphql/ee/mutations/ci/runner/update_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' @@ -38,9 +37,9 @@ RSpec/ExpectChange: - 'ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_site_validations/revoke_spec.rb' - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' - - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' - 'ee/spec/lib/audit/changes_spec.rb' - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/push_rule_pipeline_spec.rb' @@ -52,14 +51,17 @@ RSpec/ExpectChange: - 'ee/spec/lib/ee/audit/project_setting_changes_auditor_spec.rb' - 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/create_security_setting_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/repo_restorer_spec.rb' + - 'ee/spec/lib/ee/gitlab/issuable/clone/copy_resource_events_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/deprovision_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' + - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/identity_linker_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' - 'ee/spec/lib/gitlab/auth/o_auth/user_spec.rb' @@ -75,6 +77,7 @@ RSpec/ExpectChange: - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - 'ee/spec/models/dast/profile_schedule_spec.rb' - 'ee/spec/models/dast_site_spec.rb' + - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'ee/spec/models/ee/event_spec.rb' - 'ee/spec/models/ee/lfs_object_spec.rb' - 'ee/spec/models/ee/merge_request_diff_spec.rb' @@ -96,6 +99,7 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/epic_issues_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' + - 'ee/spec/requests/api/graphql/audit_events/streaming/headers/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' @@ -108,6 +112,7 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/graphql/mutations/dast_site_validations/revoke_spec.rb' - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/update_requirement_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'ee/spec/requests/api/group_push_rule_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' - 'ee/spec/requests/api/invitations_spec.rb' @@ -121,6 +126,7 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/todos_spec.rb' - 'ee/spec/requests/api/users_spec.rb' - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' + - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb' @@ -135,6 +141,9 @@ RSpec/ExpectChange: - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb' - 'ee/spec/services/approval_rules/update_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/create_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/destroy_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/update_service_spec.rb' - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - 'ee/spec/services/boards/epics/create_service_spec.rb' @@ -146,14 +155,17 @@ RSpec/ExpectChange: - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/destroy_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' + - 'ee/spec/services/deploy_keys/create_service_spec.rb' - 'ee/spec/services/deployments/approval_service_spec.rb' - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' + - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' + - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - 'ee/spec/services/ee/members/create_service_spec.rb' - 'ee/spec/services/ee/members/destroy_service_spec.rb' - 'ee/spec/services/ee/members/invite_service_spec.rb' @@ -163,6 +175,7 @@ RSpec/ExpectChange: - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/projects/deploy_tokens/destroy_service_spec.rb' - 'ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb' + - 'ee/spec/services/ee/two_factor/destroy_service_spec.rb' - 'ee/spec/services/ee/users/approve_service_spec.rb' - 'ee/spec/services/ee/users/block_service_spec.rb' - 'ee/spec/services/ee/users/reject_service_spec.rb' @@ -196,8 +209,12 @@ RSpec/ExpectChange: - 'ee/spec/services/keys/create_service_spec.rb' - 'ee/spec/services/lfs/lock_file_service_spec.rb' - 'ee/spec/services/lfs/unlock_file_service_spec.rb' + - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' + - 'ee/spec/services/namespaces/free_user_cap/update_prevent_sharing_outside_hierarchy_service_spec.rb' + - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb' + - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/import_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' @@ -215,6 +232,7 @@ RSpec/ExpectChange: - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - 'ee/spec/services/security/override_uuids_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb' - 'ee/spec/services/security/store_scan_service_spec.rb' - 'ee/spec/services/start_pull_mirroring_service_spec.rb' - 'ee/spec/services/system_notes/epics_service_spec.rb' @@ -235,16 +253,15 @@ RSpec/ExpectChange: - 'ee/spec/support/shared_examples/services/update_issuable_health_status_shared_examples.rb' - 'ee/spec/tasks/geo/git_rake_spec.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' + - 'ee/spec/workers/ee/projects/inactive_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker_spec.rb' - 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'spec/controllers/admin/clusters_controller_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/admin/spam_logs_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/controllers/groups/clusters_controller_spec.rb' - 'spec/controllers/groups/runners_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/import/bitbucket_controller_spec.rb' @@ -254,7 +271,6 @@ RSpec/ExpectChange: - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/profiles/gpg_keys_controller_spec.rb' - 'spec/controllers/profiles/keys_controller_spec.rb' - - 'spec/controllers/projects/clusters_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' @@ -277,7 +293,6 @@ RSpec/ExpectChange: - 'spec/features/groups/import_export/import_file_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/invites_spec.rb' - - 'spec/features/profiles/personal_access_tokens_spec.rb' - 'spec/features/projects/import_export/import_file_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/users/signup_spec.rb' @@ -294,11 +309,13 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/auth/saml/identity_linker_spec.rb' - 'spec/lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_projects_with_coverage_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' + - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' @@ -314,6 +331,7 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/config/entry/validatable_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' - 'spec/lib/gitlab/database/async_indexes/index_creator_spec.rb' + - 'spec/lib/gitlab/database/async_indexes/index_destructor_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' @@ -325,6 +343,8 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' - 'spec/lib/gitlab/git_access_project_spec.rb' + - 'spec/lib/gitlab/github_import/importer/events/changed_assignee_spec.rb' + - 'spec/lib/gitlab/github_import/importer/events/renamed_spec.rb' - 'spec/lib/gitlab/github_import/importer/releases_importer_spec.rb' - 'spec/lib/gitlab/hashed_storage/migrator_spec.rb' - 'spec/lib/gitlab/import/merge_request_creator_spec.rb' @@ -353,7 +373,9 @@ RSpec/ExpectChange: - 'spec/migrations/20220124130028_dedup_runner_projects_spec.rb' - 'spec/migrations/20220202105733_delete_service_template_records_spec.rb' - 'spec/migrations/20220222192525_remove_null_releases_spec.rb' + - 'spec/migrations/20220629184402_unset_escalation_policies_for_alert_incidents_spec.rb' - 'spec/migrations/backfill_cycle_analytics_aggregations_spec.rb' + - 'spec/migrations/bulk_insert_cluster_enabled_grants_spec.rb' - 'spec/migrations/cleanup_after_add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - 'spec/migrations/cleanup_after_fixing_regression_with_new_users_emails_spec.rb' @@ -363,6 +385,7 @@ RSpec/ExpectChange: - 'spec/models/alert_management/alert_spec.rb' - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' - 'spec/models/analytics/cycle_analytics/stage_event_hash_spec.rb' + - 'spec/models/application_setting_spec.rb' - 'spec/models/broadcast_message_spec.rb' - 'spec/models/chat_name_spec.rb' - 'spec/models/ci/bridge_spec.rb' @@ -375,8 +398,6 @@ RSpec/ExpectChange: - 'spec/models/ci/ref_spec.rb' - 'spec/models/ci/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - - 'spec/models/commit_signatures/gpg_signature_spec.rb' - - 'spec/models/commit_signatures/x509_commit_signature_spec.rb' - 'spec/models/commit_status_spec.rb' - 'spec/models/concerns/atomic_internal_id_spec.rb' - 'spec/models/concerns/bulk_insert_safe_spec.rb' @@ -384,6 +405,7 @@ RSpec/ExpectChange: - 'spec/models/concerns/delete_with_limit_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/concerns/require_email_verification_spec.rb' - 'spec/models/concerns/resolvable_discussion_spec.rb' - 'spec/models/concerns/resolvable_note_spec.rb' - 'spec/models/concerns/routable_spec.rb' @@ -449,7 +471,6 @@ RSpec/ExpectChange: - 'spec/requests/api/projects_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/system_hooks_spec.rb' - 'spec/requests/api/users_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/import/gitlab_groups_controller_spec.rb' @@ -504,6 +525,7 @@ RSpec/ExpectChange: - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issues/close_service_spec.rb' - 'spec/services/issues/create_service_spec.rb' + - 'spec/services/issues/import_csv_service_spec.rb' - 'spec/services/issues/move_service_spec.rb' - 'spec/services/issues/reopen_service_spec.rb' - 'spec/services/issues/update_service_spec.rb' @@ -526,6 +548,7 @@ RSpec/ExpectChange: - 'spec/services/notes/create_service_spec.rb' - 'spec/services/notes/destroy_service_spec.rb' - 'spec/services/notes/quick_actions_service_spec.rb' + - 'spec/services/packages/cleanup/update_policy_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/mark_package_for_destruction_service_spec.rb' - 'spec/services/packages/update_package_file_service_spec.rb' @@ -534,7 +557,6 @@ RSpec/ExpectChange: - 'spec/services/pages_domains/retry_acme_order_service_spec.rb' - 'spec/services/personal_access_tokens/last_used_service_spec.rb' - 'spec/services/projects/auto_devops/disable_service_spec.rb' - - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/fetch_statistics_increment_service_spec.rb' - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' @@ -562,6 +584,7 @@ RSpec/ExpectChange: - 'spec/services/todos/destroy/group_private_service_spec.rb' - 'spec/services/todos/destroy/project_private_service_spec.rb' - 'spec/services/todos/destroy/unauthorized_features_service_spec.rb' + - 'spec/services/uploads/destroy_service_spec.rb' - 'spec/services/users/approve_service_spec.rb' - 'spec/services/users/ban_service_spec.rb' - 'spec/services/users/batch_status_cleaner_service_spec.rb' @@ -571,7 +594,7 @@ RSpec/ExpectChange: - 'spec/services/users/update_highest_member_role_service_spec.rb' - 'spec/services/users/update_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - - 'spec/services/web_hooks/destroy_service_spec.rb' + - 'spec/services/work_items/parent_links/create_service_spec.rb' - 'spec/support/services/deploy_token_shared_examples.rb' - 'spec/support/services/issuable_import_csv_service_shared_examples.rb' - 'spec/support/shared_contexts/email_shared_context.rb' @@ -581,6 +604,7 @@ RSpec/ExpectChange: - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - 'spec/support/shared_examples/incident_management/issuable_escalation_statuses/build_examples.rb' - 'spec/support/shared_examples/loose_foreign_keys/have_loose_foreign_key.rb' + - 'spec/support/shared_examples/models/commit_signature_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/bulk_insert_safe_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/can_move_repository_storage_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/cron_schedulable_shared_examples.rb' @@ -613,6 +637,7 @@ RSpec/ExpectChange: - 'spec/workers/destroy_pages_deployments_worker_spec.rb' - 'spec/workers/environments/auto_delete_cron_worker_spec.rb' - 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb' + - 'spec/workers/gitlab_service_ping_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - 'spec/workers/new_issue_worker_spec.rb' @@ -627,3 +652,4 @@ RSpec/ExpectChange: - 'spec/workers/update_highest_role_worker_spec.rb' - 'spec/workers/user_status_cleanup/batch_worker_spec.rb' - 'spec/workers/users/create_statistics_worker_spec.rb' + - 'spec/workers/web_hooks/log_destroy_worker_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index cd73b76b14e..d138ea806f8 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -1,8 +1,5 @@ --- RSpec/ExpectInHook: - # Offense count: 1074 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' @@ -13,11 +10,15 @@ RSpec/ExpectInHook: - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/features/boards/new_issue_spec.rb' - 'ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - 'ee/spec/features/registrations/combined_registration_spec.rb' + - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/features/registrations/trial_during_signup_flow_spec.rb' - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' @@ -29,10 +30,14 @@ RSpec/ExpectInHook: - 'ee/spec/graphql/mutations/gitlab_subscriptions/activate_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' + - 'ee/spec/helpers/ee/groups_helper_spec.rb' + - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/kerberos_spnego_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' + - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/gon_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' @@ -44,7 +49,6 @@ RSpec/ExpectInHook: - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' @@ -57,14 +61,15 @@ RSpec/ExpectInHook: - 'ee/spec/models/concerns/geo/replicable_model_spec.rb' - 'ee/spec/models/container_repository_spec.rb' - 'ee/spec/models/dora/daily_metrics_spec.rb' + - 'ee/spec/models/ee/namespace/storage/notification_spec.rb' - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/member_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/presenters/group_member_presenter_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' - - 'ee/spec/requests/api/graphql/ci/runner_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/groups/analytics/devops_adoption_controller_spec.rb' - 'ee/spec/requests/omniauth_kerberos_spnego_spec.rb' @@ -74,26 +79,32 @@ RSpec/ExpectInHook: - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - 'ee/spec/services/ci/runners/assign_runner_service_spec.rb' - 'ee/spec/services/ci/runners/register_runner_service_spec.rb' + - 'ee/spec/services/ci/runners/reset_registration_token_service_spec.rb' - 'ee/spec/services/ci/runners/unassign_runner_service_spec.rb' - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' - 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' - - 'ee/spec/services/ee/post_receive_service_spec.rb' - 'ee/spec/services/ee/protected_branches/destroy_service_spec.rb' - 'ee/spec/services/geo/blob_download_service_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' - - 'ee/spec/services/members/activate_service_spec.rb' + - 'ee/spec/services/members/await_service_spec.rb' - 'ee/spec/services/merge_requests/approval_service_spec.rb' + - 'ee/spec/services/merge_requests/mergeability/check_approved_service_spec.rb' + - 'ee/spec/services/merge_requests/mergeability/check_blocked_by_other_mrs_service_spec.rb' + - 'ee/spec/services/merge_requests/mergeability/check_denied_policies_service_spec.rb' - 'ee/spec/services/projects/create_from_template_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - 'ee/spec/services/security/findings/cleanup_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' + - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/elastic/cannot_read_cross_project_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' @@ -112,11 +123,13 @@ RSpec/ExpectInHook: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_to_secondary_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' + - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb' @@ -153,13 +166,11 @@ RSpec/ExpectInHook: - 'spec/features/file_uploads/maven_package_spec.rb' - 'spec/features/groups/container_registry_spec.rb' - 'spec/features/groups/group_settings_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_hint_spec.rb' - 'spec/features/markdown/markdown_spec.rb' - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb' - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/features/oauth_login_spec.rb' - 'spec/features/profiles/password_spec.rb' - - 'spec/features/projects/clusters/gcp_spec.rb' - 'spec/features/projects/container_registry_spec.rb' - 'spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'spec/features/projects/files/user_creates_files_spec.rb' @@ -172,17 +183,20 @@ RSpec/ExpectInHook: - 'spec/features/users/login_spec.rb' - 'spec/graphql/mutations/design_management/move_spec.rb' - 'spec/helpers/commits_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' - 'spec/helpers/invite_members_helper_spec.rb' - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - - 'spec/initializers/omniauth_spec.rb' + - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/validate_database_config_spec.rb' - 'spec/lib/api/entities/merge_request_changes_spec.rb' - 'spec/lib/api/helpers/variables_helpers_spec.rb' - 'spec/lib/api/helpers_spec.rb' - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/banzai/reference_redactor_spec.rb' + - 'spec/lib/bulk_imports/common/extractors/json_extractor_spec.rb' + - 'spec/lib/bulk_imports/common/extractors/ndjson_extractor_spec.rb' - 'spec/lib/bulk_imports/ndjson_pipeline_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/file_size_validator_spec.rb' @@ -207,7 +221,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' - - 'spec/lib/gitlab/ci/trace/archive_spec.rb' - 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb' @@ -216,14 +229,18 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/contributions_calendar_spec.rb' - 'spec/lib/gitlab/current_settings_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' + - 'spec/lib/gitlab/database/background_migration/health_status_spec.rb' - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/runner_spec.rb' + - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning_spec.rb' + - 'spec/lib/gitlab/database/postgres_autovacuum_activity_spec.rb' - 'spec/lib/gitlab/database/query_analyzer_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' @@ -251,10 +268,12 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/health_checks/gitaly_check_spec.rb' - 'spec/lib/gitlab/health_checks/probes/collection_spec.rb' - 'spec/lib/gitlab/health_checks/puma_check_spec.rb' + - 'spec/lib/gitlab/health_checks/server_spec.rb' - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_object_saver_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' + - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/import_failure_service_spec.rb' - 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb' @@ -271,12 +290,14 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' + - 'spec/lib/gitlab/memory/jemalloc_spec.rb' - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' - 'spec/lib/gitlab/metrics/exporter/metrics_middleware_spec.rb' - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' - 'spec/lib/gitlab/middleware/memory_report_spec.rb' - 'spec/lib/gitlab/middleware/multipart_spec.rb' - 'spec/lib/gitlab/omniauth_initializer_spec.rb' + - 'spec/lib/gitlab/pages/deployment_update_spec.rb' - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' - 'spec/lib/gitlab/patch/database_config_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' @@ -338,6 +359,7 @@ RSpec/ExpectInHook: - 'spec/models/ssh_host_key_spec.rb' - 'spec/models/user_spec.rb' - 'spec/policies/ci/bridge_policy_spec.rb' + - 'spec/policies/project_policy_spec.rb' - 'spec/presenters/ci/build_presenter_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' - 'spec/presenters/commit_presenter_spec.rb' @@ -352,6 +374,7 @@ RSpec/ExpectInHook: - 'spec/requests/api/graphql/mutations/jira_import/import_users_spec.rb' - 'spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb' - 'spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb' + - 'spec/requests/api/graphql/terraform/state/delete_spec.rb' - 'spec/requests/api/graphql/terraform/state/lock_spec.rb' - 'spec/requests/api/graphql/terraform/state/unlock_spec.rb' - 'spec/requests/api/group_export_spec.rb' @@ -375,6 +398,7 @@ RSpec/ExpectInHook: - 'spec/rubocop/cop/performance/ar_count_each_spec.rb' - 'spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb' - 'spec/scripts/setup/find_jh_branch_spec.rb' + - 'spec/scripts/trigger-build_spec.rb' - 'spec/serializers/diffs_metadata_entity_spec.rb' - 'spec/serializers/merge_request_diff_entity_spec.rb' - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' @@ -406,6 +430,7 @@ RSpec/ExpectInHook: - 'spec/services/design_management/save_designs_service_spec.rb' - 'spec/services/discussions/capture_diff_note_position_service_spec.rb' - 'spec/services/environments/reset_auto_stop_service_spec.rb' + - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/git/base_hooks_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' - 'spec/services/git/wiki_push_service/change_spec.rb' @@ -434,6 +459,7 @@ RSpec/ExpectInHook: - 'spec/services/notes/quick_actions_service_spec.rb' - 'spec/services/notification_recipients/builder/default_spec.rb' - 'spec/services/notification_recipients/builder/new_note_spec.rb' + - 'spec/services/packages/cleanup/execute_policy_service_spec.rb' - 'spec/services/packages/debian/process_changes_service_spec.rb' - 'spec/services/packages/generic/create_package_file_service_spec.rb' - 'spec/services/packages/helm/extract_file_metadata_service_spec.rb' @@ -465,7 +491,6 @@ RSpec/ExpectInHook: - 'spec/services/protected_branches/create_service_spec.rb' - 'spec/services/protected_branches/destroy_service_spec.rb' - 'spec/services/protected_branches/update_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/search_service_spec.rb' - 'spec/services/serverless/associate_domain_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' @@ -481,6 +506,7 @@ RSpec/ExpectInHook: - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/database/reestablished_connection_stack_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/diff_file_collections_shared_examples.rb' - 'spec/support/shared_examples/lib/wikis_api_examples.rb' - 'spec/support/shared_examples/metrics/sampler_shared_examples.rb' @@ -515,6 +541,7 @@ RSpec/ExpectInHook: - 'spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb' - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/workers/build_finished_worker_spec.rb' + - 'spec/workers/bulk_imports/pipeline_worker_spec.rb' - 'spec/workers/ci/build_finished_worker_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' - 'spec/workers/concerns/limited_capacity/job_tracker_spec.rb' @@ -525,6 +552,7 @@ RSpec/ExpectInHook: - 'spec/workers/gitlab/jira_import/stage/finish_import_worker_spec.rb' - 'spec/workers/gitlab_performance_bar_stats_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' + - 'spec/workers/incident_management/close_incident_worker_spec.rb' - 'spec/workers/integrations/create_external_cross_reference_worker_spec.rb' - 'spec/workers/packages/helm/extraction_worker_spec.rb' - 'spec/workers/packages/nuget/extraction_worker_spec.rb' diff --git a/.rubocop_todo/rspec/hooks_before_examples.yml b/.rubocop_todo/rspec/hooks_before_examples.yml new file mode 100644 index 00000000000..0de9ff4b6c0 --- /dev/null +++ b/.rubocop_todo/rspec/hooks_before_examples.yml @@ -0,0 +1,76 @@ +--- +# Cop supports --auto-correct. +RSpec/HooksBeforeExamples: + Exclude: + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_spec.rb' + - 'ee/spec/graphql/mutations/boards/epic_boards/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/escalation_policy/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/issuable_resource_link/create_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/issuable_resource_link/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb' + - 'ee/spec/graphql/mutations/issues/set_escalation_policy_spec.rb' + - 'ee/spec/graphql/types/app_sec/fuzzing/coverage/corpus_type_spec.rb' + - 'ee/spec/graphql/types/dast/profile_schedule_type_spec.rb' + - 'ee/spec/graphql/types/dast/profile_type_spec.rb' + - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' + - 'ee/spec/lib/ee/gitlab/usage_data_counters/hll_redis_counter_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb' + - 'ee/spec/models/ee/merge_request_diff_spec.rb' + - 'ee/spec/models/merge_train_spec.rb' + - 'ee/spec/requests/api/boards_spec.rb' + - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' + - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' + - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' + - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' + - 'ee/spec/services/ee/projects/deploy_tokens/destroy_service_spec.rb' + - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' + - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' + - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' + - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/user/user_inherited_access_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_fork_in_web_ide_spec.rb' + - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' + - 'qa/spec/resource/reusable_collection_spec.rb' + - 'qa/spec/specs/runner_spec.rb' + - 'spec/controllers/import/github_controller_spec.rb' + - 'spec/features/projects/pages/user_configures_pages_pipeline_spec.rb' + - 'spec/graphql/resolvers/design_management/design_resolver_spec.rb' + - 'spec/graphql/resolvers/design_management/designs_resolver_spec.rb' + - 'spec/graphql/resolvers/project_pipeline_resolver_spec.rb' + - 'spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb' + - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' + - 'spec/lib/feature/definition_spec.rb' + - 'spec/lib/gitlab/auth/saml/user_spec.rb' + - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' + - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' + - 'spec/lib/gitlab/tracking/event_definition_spec.rb' + - 'spec/lib/gitlab/usage/metric_definition_spec.rb' + - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' + - 'spec/lib/mattermost/session_spec.rb' + - 'spec/models/ci/build_trace_chunk_spec.rb' + - 'spec/models/clusters/applications/ingress_spec.rb' + - 'spec/models/clusters/applications/knative_spec.rb' + - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/serializers/pipeline_details_entity_spec.rb' + - 'spec/services/feature_flags/hook_service_spec.rb' + - 'spec/services/projects/container_repository/gitlab/delete_tags_service_spec.rb' + - 'spec/support/shared_examples/lib/gitlab/cycle_analytics/deployment_metrics.rb' diff --git a/.rubocop_todo/rspec/predicate_matcher.yml b/.rubocop_todo/rspec/predicate_matcher.yml index c6a75708ae8..7b31ca3622c 100644 --- a/.rubocop_todo/rspec/predicate_matcher.yml +++ b/.rubocop_todo/rspec/predicate_matcher.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. RSpec/PredicateMatcher: - # Offense count: 2480 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/admin/elasticsearch_controller_spec.rb' - 'ee/spec/controllers/admin/geo/projects_controller_spec.rb' @@ -11,11 +8,16 @@ RSpec/PredicateMatcher: - 'ee/spec/controllers/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/groups/ldaps_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' + - 'ee/spec/elastic/migrate/20220713103500_delete_commits_from_original_index_spec.rb' - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/projects/members/member_is_removed_from_project_spec.rb' - 'ee/spec/features/projects/mirror_spec.rb' - 'ee/spec/features/signup_spec.rb' + - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' @@ -70,6 +72,7 @@ RSpec/PredicateMatcher: - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/saml_provider_spec.rb' - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' + - 'ee/spec/presenters/ci/minutes/usage_presenter_spec.rb' - 'ee/spec/requests/api/boards_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/set_subscription_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' @@ -96,6 +99,8 @@ RSpec/PredicateMatcher: - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' - 'ee/spec/services/milestones/promote_service_spec.rb' - 'ee/spec/services/protected_environments/create_service_spec.rb' + - 'ee/spec/services/vulnerabilities/create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/findings/create_from_security_finding_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - 'ee/spec/support/shared_examples/graphql/mutations/dast_on_demand_scans_shared_examples.rb' @@ -113,7 +118,6 @@ RSpec/PredicateMatcher: - 'qa/qa/specs/features/ee/browser_ui/12_geo/database_delete_replication_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/epic/roadmap_spec.rb' - 'qa/spec/runtime/env_spec.rb' - - 'qa/spec/runtime/feature_spec.rb' - 'qa/spec/specs/helpers/context_selector_spec.rb' - 'spec/components/diffs/overflow_warning_component_spec.rb' - 'spec/controllers/admin/dev_ops_report_controller_spec.rb' @@ -123,6 +127,7 @@ RSpec/PredicateMatcher: - 'spec/controllers/concerns/checks_collaboration_spec.rb' - 'spec/controllers/groups/avatars_controller_spec.rb' - 'spec/controllers/groups/clusters_controller_spec.rb' + - 'spec/controllers/groups/group_links_controller_spec.rb' - 'spec/controllers/groups/group_members_controller_spec.rb' - 'spec/controllers/groups/settings/applications_controller_spec.rb' - 'spec/controllers/omniauth_callbacks_controller_spec.rb' @@ -157,7 +162,6 @@ RSpec/PredicateMatcher: - 'spec/features/unsubscribe_links_spec.rb' - 'spec/features/users/signup_spec.rb' - 'spec/finders/group_descendants_finder_spec.rb' - - 'spec/finders/issues_finder_spec.rb' - 'spec/finders/merge_request_target_project_finder_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' @@ -169,6 +173,7 @@ RSpec/PredicateMatcher: - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/recaptcha_helper_spec.rb' - 'spec/helpers/sessions_helper_spec.rb' + - 'spec/helpers/sorting_helper_spec.rb' - 'spec/lib/backup/files_spec.rb' - 'spec/lib/bitbucket/connection_spec.rb' - 'spec/lib/bitbucket/page_spec.rb' @@ -260,7 +265,6 @@ RSpec/PredicateMatcher: - 'spec/lib/gitlab/fake_application_settings_spec.rb' - 'spec/lib/gitlab/git/blob_spec.rb' - 'spec/lib/gitlab/git/branch_spec.rb' - - 'spec/lib/gitlab/git/commit_spec.rb' - 'spec/lib/gitlab/git/keep_around_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' @@ -273,6 +277,7 @@ RSpec/PredicateMatcher: - 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb' - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' - 'spec/lib/gitlab/gpg/commit_spec.rb' + - 'spec/lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer_spec.rb' - 'spec/lib/gitlab/hashed_storage/migrator_spec.rb' - 'spec/lib/gitlab/i18n/translation_entry_spec.rb' - 'spec/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy_spec.rb' @@ -308,6 +313,7 @@ RSpec/PredicateMatcher: - 'spec/lib/gitlab/user_access_snippet_spec.rb' - 'spec/lib/gitlab/user_access_spec.rb' - 'spec/lib/gitlab/utils/sanitize_node_link_spec.rb' + - 'spec/lib/gitlab/version_info_spec.rb' - 'spec/lib/gitlab/view/presenter/base_spec.rb' - 'spec/lib/gitlab/visibility_level_spec.rb' - 'spec/lib/object_storage/direct_upload_spec.rb' @@ -400,7 +406,6 @@ RSpec/PredicateMatcher: - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/project_clusters_spec.rb' - 'spec/requests/api/project_export_spec.rb' - - 'spec/requests/api/project_hooks_spec.rb' - 'spec/requests/api/project_snippets_spec.rb' - 'spec/requests/api/projects_spec.rb' - 'spec/requests/api/resource_access_tokens_spec.rb' @@ -425,11 +430,13 @@ RSpec/PredicateMatcher: - 'spec/services/container_expiration_policies/update_service_spec.rb' - 'spec/services/customer_relations/contacts/update_service_spec.rb' - 'spec/services/customer_relations/organizations/update_service_spec.rb' + - 'spec/services/deployments/create_for_build_service_spec.rb' - 'spec/services/deployments/older_deployments_drop_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' - 'spec/services/groups/destroy_service_spec.rb' - 'spec/services/groups/group_links/create_service_spec.rb' + - 'spec/services/groups/group_links/destroy_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' - 'spec/services/issuable/bulk_update_service_spec.rb' @@ -449,6 +456,7 @@ RSpec/PredicateMatcher: - 'spec/services/note_summary_spec.rb' - 'spec/services/notes/build_service_spec.rb' - 'spec/services/notes/quick_actions_service_spec.rb' + - 'spec/services/packages/cleanup/update_policy_service_spec.rb' - 'spec/services/packages/debian/find_or_create_incoming_service_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/projects/after_rename_service_spec.rb' @@ -478,6 +486,7 @@ RSpec/PredicateMatcher: - 'spec/services/users/destroy_service_spec.rb' - 'spec/support/shared_contexts/email_shared_context.rb' - 'spec/support/shared_examples/ci/auto_merge_merge_requests_shared_examples.rb' + - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_core_shared_examples.rb' @@ -486,6 +495,7 @@ RSpec/PredicateMatcher: - 'spec/support/shared_examples/models/member_shared_examples.rb' - 'spec/support/shared_examples/models/note_access_check_shared_examples.rb' - 'spec/support/shared_examples/requests/access_tokens_controller_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb' - 'spec/tasks/gitlab/backup_rake_spec.rb' @@ -497,12 +507,13 @@ RSpec/PredicateMatcher: - 'spec/validators/namespace_path_validator_spec.rb' - 'spec/validators/project_path_validator_spec.rb' - 'spec/workers/bulk_imports/entity_worker_spec.rb' + - 'spec/workers/bulk_imports/pipeline_worker_spec.rb' - 'spec/workers/ci/delete_objects_worker_spec.rb' - - 'spec/workers/concerns/worker_attributes_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - 'spec/workers/group_destroy_worker_spec.rb' - 'spec/workers/hashed_storage/migrator_worker_spec.rb' - 'spec/workers/hashed_storage/rollbacker_worker_spec.rb' - 'spec/workers/project_destroy_worker_spec.rb' - 'spec/workers/remote_mirror_notification_worker_spec.rb' + - 'spec/workers/remove_expired_group_links_worker_spec.rb' - 'spec/workers/x509_issuer_crl_check_worker_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml index b5c4ac090ae..31c17c994a6 100644 --- a/.rubocop_todo/rspec/repeated_example_group_description.yml +++ b/.rubocop_todo/rspec/repeated_example_group_description.yml @@ -44,7 +44,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'spec/features/security/project/private_access_spec.rb' - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - - 'spec/frontend/fixtures/runner.rb' - 'spec/frontend/fixtures/startup_css.rb' - 'spec/helpers/admin/user_actions_helper_spec.rb' - 'spec/helpers/dropdowns_helper_spec.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 21cd26a0a6f..215660f31d3 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. RSpec/ReturnFromStub: - # Offense count: 703 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/admin/geo/nodes_controller_spec.rb' - 'ee/spec/controllers/groups/billings_controller_spec.rb' @@ -18,6 +15,7 @@ RSpec/ReturnFromStub: - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - 'ee/spec/features/projects/milestones/milestone_spec.rb' - 'ee/spec/features/projects/new_project_spec.rb' + - 'ee/spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - 'ee/spec/features/promotion_spec.rb' @@ -39,9 +37,9 @@ RSpec/ReturnFromStub: - 'ee/spec/lib/ee/feature_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/database_spec.rb' + - 'ee/spec/lib/ee/gitlab/git_access_project_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/build_consumption_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - - 'ee/spec/lib/gitlab/code_owners_spec.rb' - 'ee/spec/lib/gitlab/geo/health_check_spec.rb' - 'ee/spec/lib/gitlab/geo/logger_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' @@ -62,6 +60,7 @@ RSpec/ReturnFromStub: - 'ee/spec/presenters/ci/build_presenter_spec.rb' - 'ee/spec/presenters/merge_request_presenter_spec.rb' - 'ee/spec/requests/admin/credentials_controller_spec.rb' + - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' @@ -88,6 +87,7 @@ RSpec/ReturnFromStub: - 'ee/spec/support/shared_examples/services/geo_event_store_shared_examples.rb' - 'ee/spec/support/shared_examples/services/merge_merge_requests_shared_examples.rb' - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' + - 'ee/spec/views/admin/application_settings/_git_abuse_rate_limit.html.haml_spec.rb' - 'ee/spec/views/admin/groups/_form.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' @@ -191,13 +191,15 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/instrumentation/redis_base_spec.rb' - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' - - 'spec/lib/gitlab/metrics/rails_slis_spec.rb' + - 'spec/lib/gitlab/memory/reports_daemon_spec.rb' - 'spec/lib/gitlab/metrics/system_spec.rb' - 'spec/lib/gitlab/middleware/read_only_spec.rb' - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' - 'spec/lib/gitlab/prometheus_client_spec.rb' - 'spec/lib/gitlab/redis/cache_spec.rb' + - 'spec/lib/gitlab/redis/duplicate_jobs_spec.rb' - 'spec/lib/gitlab/redis/shared_state_spec.rb' + - 'spec/lib/gitlab/redis/sidekiq_status_spec.rb' - 'spec/lib/gitlab/relative_positioning/range_spec.rb' - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 069f9a15fff..93f373b0a9e 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. RSpec/ScatteredLet: - # Offense count: 720 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/features/groups/group_roadmap_spec.rb' - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb' @@ -19,10 +16,10 @@ RSpec/ScatteredLet: - 'ee/spec/graphql/types/instance_security_dashboard_type_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/trial_status_widget_helper_spec.rb' - - 'ee/spec/lib/banzai/reference_parser/iteration_parser_spec.rb' - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config_spec.rb' - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' + - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/formatters/dependency_list_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb' @@ -44,7 +41,6 @@ RSpec/ScatteredLet: - 'ee/spec/models/ci/minutes/notification_spec.rb' - 'ee/spec/models/ci/pipeline_spec.rb' - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - - 'ee/spec/models/ee/namespace/root_storage_size_spec.rb' - 'ee/spec/models/label_note_spec.rb' - 'ee/spec/models/sca/license_compliance_spec.rb' - 'ee/spec/policies/merge_request_policy_spec.rb' @@ -62,9 +58,12 @@ RSpec/ScatteredLet: - 'ee/spec/requests/api/graphql/project/pipelines/dast_profile_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/api/projects_spec.rb' + - 'ee/spec/requests/api/settings_spec.rb' - 'ee/spec/requests/api/vulnerability_findings_spec.rb' - 'ee/spec/requests/git_http_geo_spec.rb' + - 'ee/spec/serializers/license_compliance/collapsed_comparer_entity_spec.rb' - 'ee/spec/serializers/status_page/incident_serializer_spec.rb' + - 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb' - 'ee/spec/services/app_sec/dast/scanner_profiles/update_service_spec.rb' - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - 'ee/spec/services/arkose/user_verification_service_spec.rb' @@ -88,13 +87,13 @@ RSpec/ScatteredLet: - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb' - 'ee/spec/services/search/group_service_spec.rb' - 'ee/spec/services/search/project_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/workers/compliance_management/merge_requests/compliance_violations_worker_spec.rb' - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - 'spec/controllers/projects/environments_controller_spec.rb' @@ -126,14 +125,19 @@ RSpec/ScatteredLet: - 'spec/lib/banzai/reference_parser/project_parser_spec.rb' - 'spec/lib/banzai/reference_parser/snippet_parser_spec.rb' - 'spec/lib/banzai/reference_parser/user_parser_spec.rb' + - 'spec/lib/bulk_imports/pipeline/runner_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb' - 'spec/lib/gitlab/asciidoc/include_processor_spec.rb' - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans_spec.rb' + - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' + - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' + - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb' @@ -162,6 +166,7 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/git/blame_spec.rb' - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git_access_spec.rb' + - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_events_importer_spec.rb' - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' - 'spec/lib/gitlab/import_export/group/relation_tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/export_task_spec.rb' @@ -182,7 +187,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/spamcheck/client_spec.rb' - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/lib/gitlab/usage_data_metrics_spec.rb' - 'spec/lib/gitlab/utils/measuring_spec.rb' - 'spec/lib/gitlab/zentao/client_spec.rb' @@ -236,6 +240,7 @@ RSpec/ScatteredLet: - 'spec/requests/api/project_clusters_spec.rb' - 'spec/requests/api/project_export_spec.rb' - 'spec/requests/api/rubygem_packages_spec.rb' + - 'spec/requests/jira_routing_spec.rb' - 'spec/requests/projects/releases_controller_spec.rb' - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/scripts/pipeline_test_report_builder_spec.rb' @@ -277,6 +282,8 @@ RSpec/ScatteredLet: - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/system_notes/merge_requests_service_spec.rb' - 'spec/services/todo_service_spec.rb' + - 'spec/services/web_hook_service_spec.rb' + - 'spec/services/work_items/update_service_spec.rb' - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb' - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 84e862ff48b..70b54d5bc7f 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -210,6 +210,7 @@ RSpec/VerifiedDoubles: - ee/spec/views/layouts/header/_ee_subscribable_banner.html.haml_spec.rb - ee/spec/workers/ci/sync_reports_to_report_approval_rules_worker_spec.rb - ee/spec/workers/geo/container_repository_sync_worker_spec.rb + - ee/spec/workers/compliance_management/chain_of_custody_report_worker_spec.rb - ee/spec/workers/geo/design_repository_sync_worker_spec.rb - ee/spec/workers/geo/destroy_worker_spec.rb - ee/spec/workers/geo/event_worker_spec.rb |