diff options
Diffstat (limited to '.rubocop_todo/rspec')
| -rw-r--r-- | .rubocop_todo/rspec/any_instance_of.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/context_wording.yml | 5 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/described_class.yml | 282 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/empty_line_after_example_group.yml | 39 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/expect_change.yml | 5 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/expect_in_hook.yml | 10 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/missing_example_group_argument.yml | 16 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/predicate_matcher.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/shared_examples.yml | 24 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/verified_doubles.yml | 4 |
10 files changed, 368 insertions, 20 deletions
diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index 2cc2478e530..e7855e84b28 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -73,7 +73,7 @@ RSpec/AnyInstanceOf: - ee/spec/requests/api/projects_spec.rb - ee/spec/requests/git_http_spec.rb - ee/spec/requests/groups_controller_spec.rb - - ee/spec/requests/omniauth_kerberos_spnego_spec.rb + - ee/spec/requests/omniauth_kerberos_spec.rb - ee/spec/requests/repositories/git_http_controller_spec.rb - ee/spec/services/ee/git/branch_push_service_spec.rb - ee/spec/services/ee/merge_requests/create_from_vulnerability_data_service_spec.rb diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 163533621a6..97480a0e0ba 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -64,7 +64,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/projects/settings/repository_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/registrations/welcome_controller_spec.rb' - 'ee/spec/controllers/repositories/git_http_controller_spec.rb' - 'ee/spec/controllers/security/dashboard_controller_spec.rb' @@ -921,8 +920,6 @@ RSpec/ContextWording: - 'ee/spec/support/shared_examples/controllers/boards_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/groups_controller_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/features/insights_shared_examples.rb' - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' @@ -968,7 +965,6 @@ RSpec/ContextWording: - 'ee/spec/views/profiles/preferences/show.html.haml_spec.rb' - 'ee/spec/views/projects/edit.html.haml_spec.rb' - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' - - 'ee/spec/views/registrations/groups/new.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/search/_category.html.haml_spec.rb' - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' @@ -2470,7 +2466,6 @@ RSpec/ContextWording: - 'spec/models/note_spec.rb' - 'spec/models/notification_recipient_spec.rb' - 'spec/models/notification_setting_spec.rb' - - 'spec/models/onboarding_progress_spec.rb' - 'spec/models/operations/feature_flag_spec.rb' - 'spec/models/packages/conan/file_metadatum_spec.rb' - 'spec/models/packages/debian/file_metadatum_spec.rb' diff --git a/.rubocop_todo/rspec/described_class.yml b/.rubocop_todo/rspec/described_class.yml new file mode 100644 index 00000000000..8304704985b --- /dev/null +++ b/.rubocop_todo/rspec/described_class.yml @@ -0,0 +1,282 @@ +--- +# Cop supports --auto-correct. +RSpec/DescribedClass: + Exclude: + - 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb' + - 'ee/spec/controllers/concerns/registrations/verification_spec.rb' + - 'ee/spec/controllers/concerns/routable_actions_spec.rb' + - 'ee/spec/controllers/repositories/git_http_controller_spec.rb' + - 'ee/spec/frontend/fixtures/epic.rb' + - 'ee/spec/graphql/ee/types/todoable_interface_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners_spec.rb' + - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' + - 'ee/spec/lib/gitlab/auth/saml/config_spec.rb' + - 'ee/spec/lib/gitlab/checks/changes_access_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb' + - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' + - 'ee/spec/lib/gitlab/geo_spec.rb' + - 'ee/spec/lib/gitlab/gl_repository/repo_type_spec.rb' + - 'ee/spec/lib/gitlab/instrumentation/elasticsearch_transport_spec.rb' + - 'ee/spec/lib/gitlab/vulnerabilities/findings_preloader_spec.rb' + - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' + - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' + - 'ee/spec/models/ci/processable_spec.rb' + - 'ee/spec/models/concerns/elastic/issue_spec.rb' + - 'ee/spec/models/concerns/elastic/merge_request_spec.rb' + - 'ee/spec/models/concerns/elastic/note_spec.rb' + - 'ee/spec/models/concerns/elastic/project_spec.rb' + - 'ee/spec/models/concerns/elastic/repository_spec.rb' + - 'ee/spec/models/concerns/elastic/snippet_spec.rb' + - 'ee/spec/models/dast_scanner_profile_spec.rb' + - 'ee/spec/models/dast_site_profile_spec.rb' + - 'ee/spec/models/ee/ci/job_artifact_spec.rb' + - 'ee/spec/models/ee/ci/pending_build_spec.rb' + - 'ee/spec/models/ee/ci/runner_spec.rb' + - 'ee/spec/models/ee/gpg_key_spec.rb' + - 'ee/spec/models/ee/group_spec.rb' + - 'ee/spec/models/ee/iteration_spec.rb' + - 'ee/spec/models/ee/merge_request_diff_spec.rb' + - 'ee/spec/models/ee/namespace/storage/notification_spec.rb' + - 'ee/spec/models/ee/vulnerability_spec.rb' + - 'ee/spec/models/epic_issue_spec.rb' + - 'ee/spec/models/epic_spec.rb' + - 'ee/spec/models/geo/container_repository_registry_spec.rb' + - 'ee/spec/models/geo/design_registry_spec.rb' + - 'ee/spec/models/geo/package_file_registry_spec.rb' + - 'ee/spec/models/geo/project_registry_spec.rb' + - 'ee/spec/models/geo/secondary_usage_data_spec.rb' + - 'ee/spec/models/incident_management/escalation_policy_spec.rb' + - 'ee/spec/models/issuable_metric_image_spec.rb' + - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/merge_train_spec.rb' + - 'ee/spec/models/plan_spec.rb' + - 'ee/spec/models/project_import_state_spec.rb' + - 'ee/spec/models/project_spec.rb' + - 'ee/spec/models/release_highlight_spec.rb' + - 'ee/spec/models/requirements_management/requirement_spec.rb' + - 'ee/spec/models/requirements_management/test_report_spec.rb' + - 'ee/spec/models/resource_weight_event_spec.rb' + - 'ee/spec/models/uploads/local_spec.rb' + - 'ee/spec/models/vulnerabilities/finding_spec.rb' + - 'ee/spec/models/vulnerabilities/flag_spec.rb' + - 'ee/spec/models/vulnerabilities/read_spec.rb' + - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' + - 'ee/spec/services/arkose/user_verification_service_spec.rb' + - 'ee/spec/services/ee/resource_events/synthetic_weight_notes_builder_service_spec.rb' + - 'ee/spec/services/ee/users/reject_service_spec.rb' + - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' + - 'ee/spec/services/users/captcha_challenge_service_spec.rb' + - 'ee/spec/services/vulnerabilities/create_from_security_finding_service_spec.rb' + - 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb' + - 'ee/spec/workers/elastic/migration_worker_spec.rb' + - 'ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb' + - 'ee/spec/workers/geo/verification_state_backfill_worker_spec.rb' + - 'qa/spec/service/docker_run/base_spec.rb' + - 'qa/spec/support/formatters/test_stats_formatter_spec.rb' + - 'qa/spec/support/loglinking_spec.rb' + - 'qa/spec/support/page_error_checker_spec.rb' + - 'spec/config/settings_spec.rb' + - 'spec/controllers/concerns/confirm_email_warning_spec.rb' + - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' + - 'spec/controllers/concerns/enforces_admin_authentication_spec.rb' + - 'spec/controllers/concerns/graceful_timeout_handling_spec.rb' + - 'spec/controllers/concerns/group_tree_spec.rb' + - 'spec/controllers/concerns/metrics_dashboard_spec.rb' + - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' + - 'spec/controllers/concerns/redirects_for_missing_path_on_tree_spec.rb' + - 'spec/controllers/concerns/redis_tracking_spec.rb' + - 'spec/controllers/concerns/renders_commits_spec.rb' + - 'spec/controllers/concerns/routable_actions_spec.rb' + - 'spec/controllers/concerns/sourcegraph_decorator_spec.rb' + - 'spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb' + - 'spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb' + - 'spec/controllers/concerns/spammable_actions/captcha_check/json_format_actions_support_spec.rb' + - 'spec/controllers/concerns/static_object_external_storage_spec.rb' + - 'spec/controllers/repositories/git_http_controller_spec.rb' + - 'spec/experiments/application_experiment_spec.rb' + - 'spec/experiments/concerns/project_commit_count_spec.rb' + - 'spec/frontend/fixtures/metrics_dashboard.rb' + - 'spec/frontend/fixtures/timezones.rb' + - 'spec/frontend/fixtures/u2f.rb' + - 'spec/frontend/fixtures/webauthn.rb' + - 'spec/graphql/gitlab_schema_spec.rb' + - 'spec/graphql/graphql_triggers_spec.rb' + - 'spec/graphql/types/global_id_type_spec.rb' + - 'spec/initializers/google_api_client_spec.rb' + - 'spec/lib/api/entities/project_spec.rb' + - 'spec/lib/api/helpers_spec.rb' + - 'spec/lib/bulk_imports/groups/stage_spec.rb' + - 'spec/lib/bulk_imports/projects/stage_spec.rb' + - 'spec/lib/expand_variables_spec.rb' + - 'spec/lib/feature_spec.rb' + - 'spec/lib/gitlab/application_context_spec.rb' + - 'spec/lib/gitlab/asciidoc/html5_converter_spec.rb' + - 'spec/lib/gitlab/buffered_io_spec.rb' + - 'spec/lib/gitlab/checks/snippet_check_spec.rb' + - 'spec/lib/gitlab/ci/tags/bulk_insert_spec.rb' + - 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb' + - 'spec/lib/gitlab/ci/variables/collection/item_spec.rb' + - 'spec/lib/gitlab/ci/variables/collection/sort_spec.rb' + - 'spec/lib/gitlab/ci/variables/collection_spec.rb' + - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' + - 'spec/lib/gitlab/config/entry/composable_array_spec.rb' + - 'spec/lib/gitlab/config/entry/composable_hash_spec.rb' + - 'spec/lib/gitlab/current_settings_spec.rb' + - 'spec/lib/gitlab/database/background_migration/health_status_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/primary_host_spec.rb' + - 'spec/lib/gitlab/database/migrations/lock_retry_mixin_spec.rb' + - 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection_spec.rb' + - 'spec/lib/gitlab/database/reindexing_spec.rb' + - 'spec/lib/gitlab/database/similarity_score_spec.rb' + - 'spec/lib/gitlab/database_spec.rb' + - 'spec/lib/gitlab/email/handler_spec.rb' + - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' + - 'spec/lib/gitlab/encrypted_configuration_spec.rb' + - 'spec/lib/gitlab/error_tracking/logger_spec.rb' + - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' + - 'spec/lib/gitlab/git/blame_spec.rb' + - 'spec/lib/gitlab/git/blob_spec.rb' + - 'spec/lib/gitlab/git/commit_spec.rb' + - 'spec/lib/gitlab/git/compare_spec.rb' + - 'spec/lib/gitlab/git/diff_collection_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/git/tree_spec.rb' + - 'spec/lib/gitlab/git_access_snippet_spec.rb' + - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' + - 'spec/lib/gitlab/import_formatter_spec.rb' + - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb' + - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' + - 'spec/lib/gitlab/no_cache_headers_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' + - 'spec/lib/gitlab/relative_positioning/range_spec.rb' + - 'spec/lib/gitlab/runtime_spec.rb' + - 'spec/lib/gitlab/search_context/controller_concern_spec.rb' + - 'spec/lib/gitlab/seeder_spec.rb' + - 'spec/lib/gitlab/serverless/service_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/client_spec.rb' + - 'spec/lib/gitlab/suggestions/commit_message_spec.rb' + - 'spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb' + - 'spec/lib/gitlab/utils/measuring_spec.rb' + - 'spec/lib/gitlab/webpack/file_loader_spec.rb' + - 'spec/lib/gitlab/webpack/manifest_spec.rb' + - 'spec/lib/gitlab/x509/commit_spec.rb' + - 'spec/lib/gitlab/x509/signature_spec.rb' + - 'spec/lib/peek/views/active_record_spec.rb' + - 'spec/lib/service_ping/devops_report_spec.rb' + - 'spec/lib/sidebars/panel_spec.rb' + - 'spec/mailers/emails/service_desk_spec.rb' + - 'spec/metrics_server/metrics_server_spec.rb' + - 'spec/migrations/remove_records_without_group_from_webhooks_table_spec.rb' + - 'spec/models/active_session_spec.rb' + - 'spec/models/alert_management/alert_spec.rb' + - 'spec/models/application_record_spec.rb' + - 'spec/models/application_setting_spec.rb' + - 'spec/models/awareness_session_spec.rb' + - 'spec/models/broadcast_message_spec.rb' + - 'spec/models/chat_name_spec.rb' + - 'spec/models/ci/build_runner_session_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/group_variable_spec.rb' + - 'spec/models/ci/job_artifact_spec.rb' + - 'spec/models/ci/namespace_mirror_spec.rb' + - 'spec/models/ci/pipeline_artifact_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/processable_spec.rb' + - 'spec/models/ci/ref_spec.rb' + - 'spec/models/ci/variable_spec.rb' + - 'spec/models/ci_platform_metric_spec.rb' + - 'spec/models/clusters/cluster_spec.rb' + - 'spec/models/commit_spec.rb' + - 'spec/models/commit_status_spec.rb' + - 'spec/models/concerns/blocks_unsafe_serialization_spec.rb' + - 'spec/models/concerns/bulk_insertable_associations_spec.rb' + - 'spec/models/concerns/counter_attribute_spec.rb' + - 'spec/models/concerns/has_user_type_spec.rb' + - 'spec/models/concerns/integrations/enable_ssl_verification_spec.rb' + - 'spec/models/concerns/integrations/reset_secret_fields_spec.rb' + - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/concerns/mentionable_spec.rb' + - 'spec/models/concerns/resolvable_note_spec.rb' + - 'spec/models/concerns/token_authenticatable_spec.rb' + - 'spec/models/customer_relations/contact_spec.rb' + - 'spec/models/customer_relations/organization_spec.rb' + - 'spec/models/dependency_proxy/manifest_spec.rb' + - 'spec/models/deployment_spec.rb' + - 'spec/models/experiment_spec.rb' + - 'spec/models/group_spec.rb' + - 'spec/models/import_failure_spec.rb' + - 'spec/models/integration_spec.rb' + - 'spec/models/internal_id_spec.rb' + - 'spec/models/issue_assignee_spec.rb' + - 'spec/models/issue_spec.rb' + - 'spec/models/jira_import_state_spec.rb' + - 'spec/models/label_link_spec.rb' + - 'spec/models/lfs_objects_project_spec.rb' + - 'spec/models/loose_foreign_keys/deleted_record_spec.rb' + - 'spec/models/member_spec.rb' + - 'spec/models/merge_request_assignee_spec.rb' + - 'spec/models/merge_request_diff_commit_spec.rb' + - 'spec/models/merge_request_diff_file_spec.rb' + - 'spec/models/merge_request_spec.rb' + - 'spec/models/milestone_spec.rb' + - 'spec/models/namespace_spec.rb' + - 'spec/models/namespace_statistics_spec.rb' + - 'spec/models/oauth_access_token_spec.rb' + - 'spec/models/packages/dependency_spec.rb' + - 'spec/models/packages/maven/metadatum_spec.rb' + - 'spec/models/packages/package_spec.rb' + - 'spec/models/pages_deployment_spec.rb' + - 'spec/models/pages_domain_spec.rb' + - 'spec/models/performance_monitoring/prometheus_dashboard_spec.rb' + - 'spec/models/performance_monitoring/prometheus_metric_spec.rb' + - 'spec/models/performance_monitoring/prometheus_panel_group_spec.rb' + - 'spec/models/performance_monitoring/prometheus_panel_spec.rb' + - 'spec/models/plan_spec.rb' + - 'spec/models/postgresql/detached_partition_spec.rb' + - 'spec/models/preloaders/user_max_access_level_in_projects_preloader_spec.rb' + - 'spec/models/preloaders/users_max_access_level_in_projects_preloader_spec.rb' + - 'spec/models/project_feature_usage_spec.rb' + - 'spec/models/project_setting_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/models/projects/topic_spec.rb' + - 'spec/models/release_highlight_spec.rb' + - 'spec/models/release_spec.rb' + - 'spec/models/route_spec.rb' + - 'spec/models/todo_spec.rb' + - 'spec/models/u2f_registration_spec.rb' + - 'spec/models/user_custom_attribute_spec.rb' + - 'spec/models/user_preference_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/models/users/merge_request_interaction_spec.rb' + - 'spec/models/users_statistics_spec.rb' + - 'spec/models/wiki_directory_spec.rb' + - 'spec/models/work_items/type_spec.rb' + - 'spec/serializers/context_commits_diff_entity_spec.rb' + - 'spec/services/alert_management/alerts/todo/create_service_spec.rb' + - 'spec/services/auth/dependency_proxy_authentication_service_spec.rb' + - 'spec/services/ci/register_job_service_spec.rb' + - 'spec/services/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' + - 'spec/services/incident_management/issuable_escalation_statuses/prepare_update_service_spec.rb' + - 'spec/services/issuable/process_assignees_spec.rb' + - 'spec/services/loose_foreign_keys/cleaner_service_spec.rb' + - 'spec/services/merge_requests/update_service_spec.rb' + - 'spec/services/notification_service_spec.rb' + - 'spec/services/projects/create_service_spec.rb' + - 'spec/services/resource_access_tokens/create_service_spec.rb' + - 'spec/services/resource_events/synthetic_label_notes_builder_service_spec.rb' + - 'spec/services/service_ping/submit_service_ping_service_spec.rb' + - 'spec/services/snippets/update_service_spec.rb' + - 'spec/services/system_hooks_service_spec.rb' + - 'spec/services/user_project_access_changed_service_spec.rb' + - 'spec/services/webauthn/authenticate_service_spec.rb' + - 'spec/services/webauthn/register_service_spec.rb' + - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' + - 'spec/support_specs/helpers/graphql_helpers_spec.rb' + - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' + - 'spec/validators/html_safety_validator_spec.rb' + - 'spec/workers/bulk_imports/entity_worker_spec.rb' + - 'spec/workers/jira_connect/retry_request_worker_spec.rb' diff --git a/.rubocop_todo/rspec/empty_line_after_example_group.yml b/.rubocop_todo/rspec/empty_line_after_example_group.yml new file mode 100644 index 00000000000..80d60ee181e --- /dev/null +++ b/.rubocop_todo/rspec/empty_line_after_example_group.yml @@ -0,0 +1,39 @@ +--- +# Cop supports --auto-correct. +RSpec/EmptyLineAfterExampleGroup: + Exclude: + - 'ee/spec/controllers/groups/clusters_controller_spec.rb' + - 'ee/spec/controllers/groups/groups_controller_spec.rb' + - 'ee/spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' + - 'ee/spec/features/security/group/private_access_spec.rb' + - 'ee/spec/lib/gitlab/vulnerabilities/container_scanning_vulnerability_spec.rb' + - 'ee/spec/services/ee/gpg_keys/create_service_spec.rb' + - 'ee/spec/services/ee/issues/create_from_vulnerability_data_service_spec.rb' + - 'ee/spec/services/vulnerabilities/confirm_service_spec.rb' + - 'ee/spec/services/vulnerabilities/dismiss_service_spec.rb' + - 'ee/spec/services/vulnerabilities/resolve_service_spec.rb' + - 'ee/spec/services/vulnerabilities/revert_to_detected_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/create_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/delete_service_spec.rb' + - 'qa/spec/support/loglinking_spec.rb' + - 'spec/controllers/explore/projects_controller_spec.rb' + - 'spec/controllers/projects/notes_controller_spec.rb' + - 'spec/factories/projects/ci_feature_usages.rb' + - 'spec/features/security/group/internal_access_spec.rb' + - 'spec/features/security/group/private_access_spec.rb' + - 'spec/features/security/group/public_access_spec.rb' + - 'spec/helpers/blob_helper_spec.rb' + - 'spec/helpers/git_helper_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' + - 'spec/lib/gitlab/blob_helper_spec.rb' + - 'spec/lib/gitlab/file_type_detection_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' + - 'spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb' + - 'spec/models/note_spec.rb' + - 'spec/models/project_feature_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/models/zoom_meeting_spec.rb' + - 'spec/requests/api/graphql/project/issues_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/routing/project_routing_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 03066626883..f8962515874 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -22,8 +22,6 @@ RSpec/ExpectChange: - 'ee/spec/controllers/projects/repositories_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerabilities/notes_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' @@ -245,7 +243,6 @@ RSpec/ExpectChange: - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/destroy_service_spec.rb' - 'ee/spec/support/shared_contexts/audit_event_not_licensed_shared_context.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/graphql/mutations/update_health_status_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/replicable_model_with_separate_table_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' @@ -431,6 +428,7 @@ RSpec/ExpectChange: - 'spec/models/project_auto_devops_spec.rb' - 'spec/models/project_import_state_spec.rb' - 'spec/models/project_spec.rb' + - 'spec/models/project_statistics_spec.rb' - 'spec/models/projects/build_artifacts_size_refresh_spec.rb' - 'spec/models/projects/ci_feature_usage_spec.rb' - 'spec/models/release_spec.rb' @@ -491,6 +489,7 @@ RSpec/ExpectChange: - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/destroy_pipeline_service_spec.rb' + - 'spec/services/ci/job_artifacts/delete_service_spec.rb' - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' - 'spec/services/ci/play_build_service_spec.rb' - 'spec/services/ci/process_build_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index d138ea806f8..1551f2dc637 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -6,8 +6,6 @@ RSpec/ExpectInHook: - 'ee/spec/controllers/groups/seat_usage_controller_spec.rb' - 'ee/spec/controllers/projects/boards_controller_spec.rb' - 'ee/spec/controllers/projects/settings/slacks_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' @@ -17,7 +15,6 @@ RSpec/ExpectInHook: - 'ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/features/registrations/combined_registration_spec.rb' - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/features/registrations/trial_during_signup_flow_spec.rb' - 'ee/spec/features/signup_spec.rb' @@ -35,7 +32,7 @@ RSpec/ExpectInHook: - 'ee/spec/helpers/ee/issues_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - - 'ee/spec/helpers/kerberos_spnego_helper_spec.rb' + - 'ee/spec/helpers/kerberos_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' @@ -72,7 +69,7 @@ RSpec/ExpectInHook: - 'ee/spec/requests/api/geo_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/groups/analytics/devops_adoption_controller_spec.rb' - - 'ee/spec/requests/omniauth_kerberos_spnego_spec.rb' + - 'ee/spec/requests/omniauth_kerberos_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/stages/update_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' @@ -103,7 +100,6 @@ RSpec/ExpectInHook: - 'ee/spec/services/projects/update_mirror_service_spec.rb' - 'ee/spec/services/security/findings/cleanup_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/elastic/cannot_read_cross_project_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' @@ -315,12 +311,10 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/verify/uploads_spec.rb' - 'spec/lib/gitlab/zentao/query_spec.rb' - 'spec/lib/gitlab_spec.rb' - - 'spec/lib/learn_gitlab/onboarding_spec.rb' - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - 'spec/lib/prometheus/pid_provider_spec.rb' - 'spec/lib/sidebars/projects/menus/external_issue_tracker_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/external_wiki_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/learn_gitlab_menu_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' - 'spec/migrations/20210406144743_backfill_total_tuple_count_for_batched_migrations_spec.rb' diff --git a/.rubocop_todo/rspec/missing_example_group_argument.yml b/.rubocop_todo/rspec/missing_example_group_argument.yml new file mode 100644 index 00000000000..1506c9536a0 --- /dev/null +++ b/.rubocop_todo/rspec/missing_example_group_argument.yml @@ -0,0 +1,16 @@ +--- +RSpec/MissingExampleGroupArgument: + Exclude: + - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' + - 'ee/spec/services/ee/notification_service_spec.rb' + - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/projects/merge_requests_controller_spec.rb' + - 'spec/factories/projects/ci_feature_usages.rb' + - 'spec/lib/gitlab/background_migration/backfill_jira_tracker_deployment_type2_spec.rb' + - 'spec/lib/gitlab/git_access_spec.rb' + - 'spec/policies/award_emoji_policy_spec.rb' + - 'spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb' + - 'spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb' + - 'spec/services/notification_service_spec.rb' + - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb' diff --git a/.rubocop_todo/rspec/predicate_matcher.yml b/.rubocop_todo/rspec/predicate_matcher.yml index 7b31ca3622c..f3cfe93191d 100644 --- a/.rubocop_todo/rspec/predicate_matcher.yml +++ b/.rubocop_todo/rspec/predicate_matcher.yml @@ -340,6 +340,7 @@ RSpec/PredicateMatcher: - 'spec/models/concerns/awardable_spec.rb' - 'spec/models/concerns/chronic_duration_attribute_spec.rb' - 'spec/models/concerns/ci/has_deployment_name_spec.rb' + - 'spec/models/concerns/counter_attribute_spec.rb' - 'spec/models/concerns/featurable_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/integrations/has_data_fields_spec.rb' diff --git a/.rubocop_todo/rspec/shared_examples.yml b/.rubocop_todo/rspec/shared_examples.yml new file mode 100644 index 00000000000..612692bdb55 --- /dev/null +++ b/.rubocop_todo/rspec/shared_examples.yml @@ -0,0 +1,24 @@ +--- +# Cop supports --auto-correct. +RSpec/SharedExamples: + Exclude: + - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' + - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' + - 'ee/spec/lib/gitlab/email/handler/create_note_handler_spec.rb' + - 'ee/spec/services/approval_rules/params_filtering_service_spec.rb' + - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' + - 'spec/lib/gitlab/asciidoc_spec.rb' + - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_note_on_issuable_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb' + - 'spec/lib/gitlab/email/receiver_spec.rb' + - 'spec/lib/gitlab/git/tree_spec.rb' + - 'spec/models/design_management/version_spec.rb' + - 'spec/models/integrations/drone_ci_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' + - 'spec/rubocop/cop/performance/readlines_each_spec.rb' + - 'spec/support/shared_contexts/email_shared_context.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 70b54d5bc7f..a225dbf21ae 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -41,7 +41,7 @@ RSpec/VerifiedDoubles: - ee/spec/helpers/ee/subscribable_banner_helper_spec.rb - ee/spec/helpers/ee/trial_helper_spec.rb - ee/spec/helpers/ee/trial_registration_helper_spec.rb - - ee/spec/helpers/kerberos_spnego_helper_spec.rb + - ee/spec/helpers/kerberos_helper_spec.rb - ee/spec/helpers/license_helper_spec.rb - ee/spec/helpers/roadmaps_helper_spec.rb - ee/spec/helpers/routing/pseudonymization_helper_spec.rb @@ -90,7 +90,6 @@ RSpec/VerifiedDoubles: - ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb - ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb - - ee/spec/models/approvable_spec.rb - ee/spec/models/concerns/geo/verification_state_spec.rb - ee/spec/models/ee/ci/job_artifact_spec.rb - ee/spec/models/ee/user_spec.rb @@ -449,7 +448,6 @@ RSpec/VerifiedDoubles: - spec/lib/gitlab/ci/config/external/file/project_spec.rb - spec/lib/gitlab/ci/config/external/rules_spec.rb - spec/lib/gitlab/ci/parsers/test/junit_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/command_spec.rb - spec/lib/gitlab/ci/pipeline/chain/evaluate_workflow_rules_spec.rb - spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb - spec/lib/gitlab/ci/pipeline/chain/limit/deployments_spec.rb |