diff options
Diffstat (limited to '.rubocop_todo/style/guard_clause.yml')
| -rw-r--r-- | .rubocop_todo/style/guard_clause.yml | 37 |
1 files changed, 3 insertions, 34 deletions
diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 737d3d6f5a1..74051fa5944 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -1,6 +1,7 @@ --- # Cop supports --autocorrect. Style/GuardClause: + Details: grace period Exclude: - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' @@ -13,11 +14,9 @@ Style/GuardClause: - 'app/controllers/concerns/enforces_admin_authentication.rb' - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - 'app/controllers/concerns/impersonation.rb' - - 'app/controllers/concerns/issuable_collections.rb' - 'app/controllers/groups/application_controller.rb' - 'app/controllers/groups_controller.rb' - 'app/controllers/import/gitea_controller.rb' - - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' - 'app/controllers/passwords_controller.rb' @@ -56,7 +55,6 @@ Style/GuardClause: - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/board_list_issues_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' - - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/projects/jira_projects_resolver.rb' - 'app/graphql/types/ci/job_type.rb' - 'app/graphql/types/permission_types/base_permission_type.rb' @@ -75,7 +73,6 @@ Style/GuardClause: - 'app/models/appearance.rb' - 'app/models/application_setting.rb' - 'app/models/bulk_imports/entity.rb' - - 'app/models/ci/build.rb' - 'app/models/ci/build_trace.rb' - 'app/models/ci/job_artifact.rb' - 'app/models/ci/job_token/project_scope_link.rb' @@ -84,10 +81,12 @@ Style/GuardClause: - 'app/models/clusters/cluster.rb' - 'app/models/clusters/platforms/kubernetes.rb' - 'app/models/commit_range.rb' + - 'app/models/concerns/atomic_internal_id.rb' - 'app/models/concerns/avatarable.rb' - 'app/models/concerns/bulk_insert_safe.rb' - 'app/models/concerns/cache_markdown_field.rb' - 'app/models/concerns/cacheable_attributes.rb' + - 'app/models/concerns/cascading_namespace_setting_attribute.rb' - 'app/models/concerns/deprecated_assignee.rb' - 'app/models/concerns/has_wiki_page_meta_attributes.rb' - 'app/models/concerns/issuable_link.rb' @@ -135,14 +134,12 @@ Style/GuardClause: - 'app/models/project_import_state.rb' - 'app/models/project_label.rb' - 'app/models/project_setting.rb' - - 'app/models/protected_branch/push_access_level.rb' - 'app/models/repository.rb' - 'app/models/sent_notification.rb' - 'app/models/sentry_issue.rb' - 'app/models/service_desk_setting.rb' - 'app/models/snippet_input_action.rb' - 'app/models/user.rb' - - 'app/models/users/in_product_marketing_email.rb' - 'app/models/work_item.rb' - 'app/models/work_items/parent_link.rb' - 'app/presenters/ci/pipeline_presenter.rb' @@ -172,8 +169,6 @@ Style/GuardClause: - 'app/services/files/delete_service.rb' - 'app/services/files/multi_service.rb' - 'app/services/files/update_service.rb' - - 'app/services/git/branch_hooks_service.rb' - - 'app/services/groups/group_links/update_service.rb' - 'app/services/groups/import_export/export_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/groups/update_service.rb' @@ -190,18 +185,15 @@ Style/GuardClause: - 'app/services/merge_requests/add_spent_time_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' - - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/merge_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' - 'app/services/merge_requests/push_options_handler_service.rb' - 'app/services/merge_requests/refresh_service.rb' - - 'app/services/metrics/dashboard/base_service.rb' - 'app/services/namespace_settings/update_service.rb' - 'app/services/notes/create_service.rb' - 'app/services/notes/post_process_service.rb' - 'app/services/notification_recipients/builder/default.rb' - 'app/services/notification_service.rb' - - 'app/services/packages/create_event_service.rb' - 'app/services/packages/create_package_service.rb' - 'app/services/packages/nuget/search_service.rb' - 'app/services/post_receive_service.rb' @@ -311,8 +303,6 @@ Style/GuardClause: - 'ee/app/models/ee/project_group_link.rb' - 'ee/app/models/ee/project_member.rb' - 'ee/app/models/ee/user.rb' - - 'ee/app/models/elasticsearch_indexed_project.rb' - - 'ee/app/models/epic/related_epic_link.rb' - 'ee/app/models/epic_issue.rb' - 'ee/app/models/geo_node.rb' - 'ee/app/models/geo_node_status.rb' @@ -323,7 +313,6 @@ Style/GuardClause: - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/preloaders/environments/protected_environment_preloader.rb' - 'ee/app/models/protected_environment.rb' - - 'ee/app/models/protected_environments/deploy_access_level.rb' - 'ee/app/models/users_security_dashboard_project.rb' - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/presenters/ee/merge_request_presenter.rb' @@ -355,20 +344,16 @@ Style/GuardClause: - 'ee/app/services/ee/projects/gitlab_projects_import_service.rb' - 'ee/app/services/ee/projects/update_service.rb' - 'ee/app/services/ee/protected_branches/loggable.rb' - - 'ee/app/services/ee/wiki_pages/base_service.rb' - 'ee/app/services/epics/close_service.rb' - 'ee/app/services/epics/create_service.rb' - 'ee/app/services/epics/reopen_service.rb' - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/epics/update_service.rb' - - 'ee/app/services/geo/framework_repository_sync_service.rb' - 'ee/app/services/geo/metrics_update_service.rb' - - 'ee/app/services/geo/repository_base_sync_service.rb' - 'ee/app/services/group_saml/group_managed_accounts/transfer_membership_service.rb' - 'ee/app/services/groups/update_repository_storage_service.rb' - 'ee/app/services/incident_management/oncall_rotations/remove_participant_service.rb' - 'ee/app/services/iterations/delete_service.rb' - - 'ee/app/services/merge_trains/check_status_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/override_uuids_service.rb' @@ -422,7 +407,6 @@ Style/GuardClause: - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/support/ci/minutes_helpers.rb' - - 'haml_lint/linter/documentation_links.rb' - 'lib/api/commits.rb' - 'lib/api/feature_flags.rb' - 'lib/api/helpers.rb' @@ -436,8 +420,6 @@ Style/GuardClause: - 'lib/banzai/filter/gollum_tags_filter.rb' - 'lib/banzai/filter/references/merge_request_reference_filter.rb' - 'lib/banzai/filter/wiki_link_filter/rewriter.rb' - - 'lib/bulk_imports/clients/graphql.rb' - - 'lib/bulk_imports/pipeline/runner.rb' - 'lib/bulk_imports/projects/pipelines/project_pipeline.rb' - 'lib/container_registry/client.rb' - 'lib/feature/definition.rb' @@ -449,7 +431,6 @@ Style/GuardClause: - 'lib/gitlab/auth/unique_ips_limiter.rb' - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - 'lib/gitlab/bitbucket_import/importer.rb' - - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/changelog/config.rb' @@ -476,7 +457,6 @@ Style/GuardClause: - 'lib/gitlab/ci/pipeline/chain/validate/abilities.rb' - 'lib/gitlab/ci/pipeline/chain/validate/repository.rb' - 'lib/gitlab/ci/pipeline/expression/lexeme/base.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/pattern.rb' - 'lib/gitlab/ci/reports/codequality_reports_comparer.rb' - 'lib/gitlab/ci/runner/backoff.rb' - 'lib/gitlab/ci/runner_upgrade_check.rb' @@ -486,7 +466,6 @@ Style/GuardClause: - 'lib/gitlab/ci/yaml_processor.rb' - 'lib/gitlab/config/entry/validators.rb' - 'lib/gitlab/daemon.rb' - - 'lib/gitlab/database/background_migration/batch_optimizer.rb' - 'lib/gitlab/database/background_migration/batched_migration_wrapper.rb' - 'lib/gitlab/database/consistency_checker.rb' - 'lib/gitlab/database/load_balancing/load_balancer.rb' @@ -519,7 +498,6 @@ Style/GuardClause: - 'lib/gitlab/github_import.rb' - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - - 'lib/gitlab/github_import/importer/pull_request_review_importer.rb' - 'lib/gitlab/github_import/object_counter.rb' - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - 'lib/gitlab/i18n/po_linter.rb' @@ -541,10 +519,8 @@ Style/GuardClause: - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/marginalia.rb' - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' - - 'lib/gitlab/metrics/subscribers/action_cable.rb' - 'lib/gitlab/metrics/subscribers/active_record.rb' - 'lib/gitlab/metrics/subscribers/external_http.rb' - - 'lib/gitlab/metrics/subscribers/rails_cache.rb' - 'lib/gitlab/metrics/web_transaction.rb' - 'lib/gitlab/middleware/read_only/controller.rb' - 'lib/gitlab/pages/deployment_update.rb' @@ -557,7 +533,6 @@ Style/GuardClause: - 'lib/gitlab/patch/global_id.rb' - 'lib/gitlab/patch/sprockets_base_file_digest_key.rb' - 'lib/gitlab/process_supervisor.rb' - - 'lib/gitlab/prometheus/query_variables.rb' - 'lib/gitlab/prometheus_client.rb' - 'lib/gitlab/recaptcha.rb' - 'lib/gitlab/sanitizers/exif.rb' @@ -567,13 +542,10 @@ Style/GuardClause: - 'lib/gitlab/serializer/pagination.rb' - 'lib/gitlab/shell.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' - - 'lib/gitlab/sidekiq_middleware/extra_done_log_metadata.rb' - 'lib/gitlab/sidekiq_middleware/size_limiter/compressor.rb' - 'lib/gitlab/sql/set_operator.rb' - 'lib/gitlab/url_blocker.rb' - - 'lib/gitlab/usage/metric_definition.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric.rb' - - 'lib/gitlab/utils.rb' - 'lib/gitlab/utils/override.rb' - 'lib/gitlab/webpack/manifest.rb' - 'lib/mattermost/session.rb' @@ -596,7 +568,6 @@ Style/GuardClause: - 'qa/qa/runtime/feature.rb' - 'qa/qa/runtime/search.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/group_file_template_spec.rb' - 'qa/qa/specs/helpers/feature_flag.rb' - 'qa/qa/vendor/jenkins/job.rb' @@ -616,7 +587,6 @@ Style/GuardClause: - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - 'spec/services/packages/maven/metadata/append_package_file_service_spec.rb' - - 'spec/support/capybara.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/support/helpers/access_matchers_helpers.rb' - 'spec/support/helpers/capybara_helpers.rb' @@ -631,7 +601,6 @@ Style/GuardClause: - 'spec/support/helpers/wait_helpers.rb' - 'spec/support/import_export/export_file_helper.rb' - 'spec/support/shared_examples/features/packages_shared_examples.rb' - - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' - 'spec/tooling/lib/tooling/find_codeowners_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - 'tooling/lib/tooling/helm3_client.rb' |