diff options
Diffstat (limited to '.rubocop_todo/style/guard_clause.yml')
| -rw-r--r-- | .rubocop_todo/style/guard_clause.yml | 73 |
1 files changed, 51 insertions, 22 deletions
diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 7ee19ee164e..b07c29ca1df 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -1,8 +1,5 @@ --- Style/GuardClause: - # Offense count: 1014 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' @@ -28,6 +25,7 @@ Style/GuardClause: - 'app/controllers/dashboard/todos_controller.rb' - 'app/controllers/groups/application_controller.rb' - 'app/controllers/groups_controller.rb' + - 'app/controllers/ide_controller.rb' - 'app/controllers/import/gitea_controller.rb' - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' @@ -46,12 +44,14 @@ Style/GuardClause: - 'app/controllers/projects/google_cloud/base_controller.rb' - 'app/controllers/projects/imports_controller.rb' - 'app/controllers/projects/issues_controller.rb' + - 'app/controllers/projects/pipelines/tests_controller.rb' - 'app/controllers/projects/repositories_controller.rb' - 'app/controllers/projects/settings/operations_controller.rb' - 'app/controllers/projects/tree_controller.rb' - 'app/controllers/registrations_controller.rb' - 'app/controllers/repositories/git_http_controller.rb' - 'app/controllers/repositories/lfs_api_controller.rb' + - 'app/controllers/repositories/lfs_storage_controller.rb' - 'app/controllers/search_controller.rb' - 'app/controllers/sessions_controller.rb' - 'app/controllers/users/terms_controller.rb' @@ -65,6 +65,7 @@ Style/GuardClause: - 'app/graphql/mutations/design_management/delete.rb' - 'app/graphql/mutations/notes/create/note.rb' - 'app/graphql/mutations/notes/reposition_image_diff_note.rb' + - 'app/graphql/mutations/packages/destroy_files.rb' - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/board_list_issues_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' @@ -72,8 +73,8 @@ Style/GuardClause: - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/projects/jira_projects_resolver.rb' - 'app/graphql/types/ci/job_type.rb' + - 'app/graphql/types/permission_types/base_permission_type.rb' - 'app/helpers/admin/user_actions_helper.rb' - - 'app/helpers/appearances_helper.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/events_helper.rb' - 'app/helpers/issues_helper.rb' @@ -121,17 +122,18 @@ Style/GuardClause: - 'app/models/design_management/design_collection.rb' - 'app/models/diff_viewer/base.rb' - 'app/models/environment.rb' - - 'app/models/error_tracking/error_event.rb' - 'app/models/error_tracking/project_error_tracking_setting.rb' - 'app/models/experiment_subject.rb' - 'app/models/external_pull_request.rb' - 'app/models/generic_commit_status.rb' + - 'app/models/grafana_integration.rb' - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/base_third_party_wiki.rb' - 'app/models/integrations/confluence.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/emails_on_push.rb' + - 'app/models/integrations/field.rb' - 'app/models/integrations/harbor.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' @@ -142,8 +144,6 @@ Style/GuardClause: - 'app/models/member.rb' - 'app/models/members/project_member.rb' - 'app/models/merge_request.rb' - - 'app/models/merge_request_assignee.rb' - - 'app/models/merge_request_reviewer.rb' - 'app/models/namespace.rb' - 'app/models/namespace_setting.rb' - 'app/models/operations/feature_flags/strategy.rb' @@ -161,6 +161,7 @@ Style/GuardClause: - 'app/models/project_import_state.rb' - 'app/models/project_label.rb' - 'app/models/project_setting.rb' + - 'app/models/protected_branch.rb' - 'app/models/protected_branch/push_access_level.rb' - 'app/models/repository.rb' - 'app/models/sent_notification.rb' @@ -170,6 +171,8 @@ Style/GuardClause: - 'app/models/user.rb' - 'app/models/users/in_product_marketing_email.rb' - 'app/models/wiki.rb' + - 'app/models/work_item.rb' + - 'app/models/work_items/parent_link.rb' - 'app/presenters/ci/pipeline_presenter.rb' - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/project_presenter.rb' @@ -177,15 +180,19 @@ Style/GuardClause: - 'app/services/bulk_imports/file_download_service.rb' - 'app/services/ci/create_web_ide_terminal_service.rb' - 'app/services/ci/daily_build_group_report_result_service.rb' + - 'app/services/ci/job_artifacts/destroy_batch_service.rb' - 'app/services/ci/parse_dotenv_artifact_service.rb' - 'app/services/ci/pipelines/add_job_service.rb' - 'app/services/ci/play_build_service.rb' - 'app/services/ci/retry_job_service.rb' + - 'app/services/ci/runners/reconcile_existing_runner_versions_service.rb' + - 'app/services/ci/runners/register_runner_service.rb' - 'app/services/ci/update_build_queue_service.rb' - 'app/services/clusters/agent_tokens/track_usage_service.rb' - 'app/services/clusters/aws/fetch_credentials_service.rb' - 'app/services/commits/commit_patch_service.rb' - 'app/services/commits/create_service.rb' + - 'app/services/concerns/alert_management/alert_processing.rb' - 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb' - 'app/services/concerns/rate_limited_service.rb' - 'app/services/concerns/update_repository_storage_methods.rb' @@ -205,12 +212,12 @@ Style/GuardClause: - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/import/validate_remote_git_endpoint_service.rb' - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/issuable/clone/base_service.rb' - 'app/services/issuable/common_system_notes_service.rb' - 'app/services/issuable_base_service.rb' - 'app/services/issues/clone_service.rb' - 'app/services/issues/move_service.rb' - 'app/services/issues/update_service.rb' + - 'app/services/markdown_content_rewriter_service.rb' - 'app/services/merge_requests/add_spent_time_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' @@ -238,10 +245,10 @@ Style/GuardClause: - 'app/services/projects/import_export/export_service.rb' - 'app/services/projects/import_service.rb' - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - - 'app/services/projects/update_pages_service.rb' - 'app/services/projects/update_repository_storage_service.rb' - 'app/services/projects/update_service.rb' - 'app/services/protected_branches/legacy_api_update_service.rb' + - 'app/services/repositories/changelog_service.rb' - 'app/services/snippets/repository_validation_service.rb' - 'app/services/todo_service.rb' - 'app/services/users/build_service.rb' @@ -268,20 +275,24 @@ Style/GuardClause: - 'app/validators/rsa_key_validator.rb' - 'app/validators/top_level_group_validator.rb' - 'app/validators/x509_certificate_credentials_validator.rb' - - 'app/workers/cleanup_container_repository_worker.rb' - 'app/workers/clusters/agents/delete_expired_events_worker.rb' - 'app/workers/concerns/application_worker.rb' - 'app/workers/container_registry/migration/guard_worker.rb' - 'app/workers/deployments/hooks_worker.rb' - 'app/workers/deployments/link_merge_request_worker.rb' - 'app/workers/gitlab/github_import/refresh_import_jid_worker.rb' + - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' + - 'app/workers/packages/cleanup/execute_policy_worker.rb' - 'app/workers/packages/maven/metadata/sync_worker.rb' + - 'app/workers/projects/import_export/relation_export_worker.rb' - 'app/workers/repository_update_remote_mirror_worker.rb' + - 'app/workers/terraform/states/destroy_worker.rb' - 'config/initializers/0_inject_enterprise_edition_module.rb' - 'config/initializers/carrierwave_patch.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/google_api_client_patch.rb' - 'config/initializers/postgresql_cte.rb' + - 'config/initializers/wikicloth_redos_patch.rb' - 'config/object_store_settings.rb' - 'danger/feature_flag/Dangerfile' - 'db/migrate/20210302212623_rename_vuln_fingerprints_indexes.rb' @@ -315,6 +326,7 @@ Style/GuardClause: - 'ee/app/finders/ee/template_finder.rb' - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' + - 'ee/app/graphql/mutations/concerns/mutations/shared_epic_arguments.rb' - 'ee/app/graphql/mutations/iterations/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' @@ -322,13 +334,16 @@ Style/GuardClause: - 'ee/app/graphql/resolvers/epics_resolver.rb' - 'ee/app/graphql/resolvers/iterations_resolver.rb' - 'ee/app/helpers/ee/application_helper.rb' + - 'ee/app/helpers/ee/auth_helper.rb' - 'ee/app/helpers/ee/award_emoji_helper.rb' - 'ee/app/helpers/ee/nav/new_dropdown_helper.rb' - 'ee/app/helpers/ee/nav/top_nav_helper.rb' + - 'ee/app/helpers/ee/projects/pipeline_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/models/allowed_email_domain.rb' - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - 'ee/app/models/approval_merge_request_rule_source.rb' + - 'ee/app/models/audit_events/external_audit_event_destination.rb' - 'ee/app/models/concerns/app_sec/dast/buildable.rb' - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/concerns/elastic/application_versioned_search.rb' @@ -338,6 +353,7 @@ Style/GuardClause: - 'ee/app/models/dast_site_profile.rb' - 'ee/app/models/ee/application_setting.rb' - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/group_group_link.rb' - 'ee/app/models/ee/group_member.rb' - 'ee/app/models/ee/incident_management/issuable_escalation_status.rb' - 'ee/app/models/ee/issue.rb' @@ -347,6 +363,7 @@ Style/GuardClause: - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/project.rb' + - 'ee/app/models/ee/project_group_link.rb' - 'ee/app/models/ee/project_member.rb' - 'ee/app/models/ee/user.rb' - 'ee/app/models/elasticsearch_indexed_project.rb' @@ -361,6 +378,7 @@ Style/GuardClause: - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/preloaders/environments/protected_environment_preloader.rb' - 'ee/app/models/protected_environment.rb' + - 'ee/app/models/sbom/occurrence.rb' - 'ee/app/models/users_security_dashboard_project.rb' - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/presenters/ee/merge_request_presenter.rb' @@ -384,8 +402,8 @@ Style/GuardClause: - 'ee/app/services/ee/groups/update_service.rb' - 'ee/app/services/ee/issuable/common_system_notes_service.rb' - 'ee/app/services/ee/issues/base_service.rb' + - 'ee/app/services/ee/issues/clone_service.rb' - 'ee/app/services/ee/merge_requests/merge_base_service.rb' - - 'ee/app/services/ee/merge_requests/post_merge_service.rb' - 'ee/app/services/ee/merge_requests/refresh_service.rb' - 'ee/app/services/ee/namespace_settings/update_service.rb' - 'ee/app/services/ee/projects/create_service.rb' @@ -409,11 +427,12 @@ Style/GuardClause: - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - 'ee/app/services/merge_trains/refresh_service.rb' - 'ee/app/services/namespaces/storage/email_notification_service.rb' - - 'ee/app/services/projects/slack_application_install_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/override_uuids_service.rb' - 'ee/app/services/timebox_report_service.rb' + - 'ee/app/services/vulnerabilities/security_finding/create_issue_service.rb' - 'ee/app/validators/host_validator.rb' + - 'ee/app/validators/user_existence_validator.rb' - 'ee/app/workers/ee/ci/build_finished_worker.rb' - 'ee/app/workers/ee/post_receive.rb' - 'ee/app/workers/elastic/migration_worker.rb' @@ -462,6 +481,7 @@ Style/GuardClause: - 'ee/lib/omni_auth/strategies/group_saml.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' + - 'ee/spec/support/ci/minutes_helpers.rb' - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'haml_lint/linter/documentation_links.rb' - 'lib/api/commits.rb' @@ -481,6 +501,7 @@ Style/GuardClause: - 'lib/banzai/filter/wiki_link_filter/rewriter.rb' - 'lib/bulk_imports/clients/graphql.rb' - 'lib/bulk_imports/clients/http.rb' + - 'lib/bulk_imports/pipeline/runner.rb' - 'lib/bulk_imports/projects/pipelines/project_pipeline.rb' - 'lib/container_registry/client.rb' - 'lib/feature/definition.rb' @@ -525,21 +546,24 @@ Style/GuardClause: - 'lib/gitlab/ci/reports/codequality_reports_comparer.rb' - 'lib/gitlab/ci/reports/security/vulnerability_reports_comparer.rb' - 'lib/gitlab/ci/runner/backoff.rb' + - 'lib/gitlab/ci/runner_upgrade_check.rb' - 'lib/gitlab/ci/trace.rb' - 'lib/gitlab/ci/trace/archive.rb' - 'lib/gitlab/ci/trace/stream.rb' - 'lib/gitlab/ci/yaml_processor.rb' - 'lib/gitlab/config/entry/validators.rb' + - 'lib/gitlab/daemon.rb' - 'lib/gitlab/database/background_migration/batch_optimizer.rb' - 'lib/gitlab/database/background_migration/batched_migration_wrapper.rb' - 'lib/gitlab/database/consistency_checker.rb' - - 'lib/gitlab/database/load_balancing/configuration.rb' - 'lib/gitlab/database/load_balancing/load_balancer.rb' + - 'lib/gitlab/database/lock_writes_manager.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/database/migration_helpers/v2.rb' - 'lib/gitlab/database/partitioning/partition_manager.rb' - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb' - 'lib/gitlab/database/postgresql_adapter/force_disconnectable_mixin.rb' + - 'lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection.rb' - 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb' - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/highlight.rb' @@ -550,7 +574,6 @@ Style/GuardClause: - 'lib/gitlab/email/hook/email_template_interceptor.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/endpoint_attributes/config.rb' - - 'lib/gitlab/error_tracking.rb' - 'lib/gitlab/event_store/event.rb' - 'lib/gitlab/event_store/store.rb' - 'lib/gitlab/exception_log_formatter.rb' @@ -571,10 +594,7 @@ Style/GuardClause: - 'lib/gitlab/github_import/object_counter.rb' - 'lib/gitlab/gitlab_import/client.rb' - 'lib/gitlab/gitlab_import/importer.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/null_condition.rb' - - 'lib/gitlab/graphql/pagination/keyset/order_info.rb' - - 'lib/gitlab/graphql/pagination/keyset/query_builder.rb' + - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - 'lib/gitlab/i18n/metadata_entry.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' @@ -583,14 +603,19 @@ Style/GuardClause: - 'lib/gitlab/import_export/command_line_util.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - 'lib/gitlab/import_export/importer.rb' + - 'lib/gitlab/import_export/project/relation_factory.rb' - 'lib/gitlab/import_export/repo_restorer.rb' - 'lib/gitlab/import_export/snippet_repo_restorer.rb' - 'lib/gitlab/import_export/version_checker.rb' + - 'lib/gitlab/instrumentation/global_search_api.rb' + - 'lib/gitlab/instrumentation/rate_limiting_gates.rb' - 'lib/gitlab/instrumentation/redis_cluster_validator.rb' - 'lib/gitlab/instrumentation/uploads.rb' + - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' - 'lib/gitlab/legacy_github_import/client.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/marginalia.rb' + - 'lib/gitlab/memory/watchdog.rb' - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' - 'lib/gitlab/metrics/subscribers/action_cable.rb' - 'lib/gitlab/metrics/subscribers/active_record.rb' @@ -598,6 +623,7 @@ Style/GuardClause: - 'lib/gitlab/metrics/subscribers/rails_cache.rb' - 'lib/gitlab/metrics/web_transaction.rb' - 'lib/gitlab/middleware/read_only/controller.rb' + - 'lib/gitlab/pages/deployment_update.rb' - 'lib/gitlab/pagination/gitaly_keyset_pager.rb' - 'lib/gitlab/pagination/keyset/column_order_definition.rb' - 'lib/gitlab/pagination/keyset/in_operator_optimization/array_scope_columns.rb' @@ -626,6 +652,7 @@ Style/GuardClause: - 'lib/gitlab/ssh_public_key.rb' - 'lib/gitlab/url_blocker.rb' - 'lib/gitlab/usage/metric_definition.rb' + - 'lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric.rb' - 'lib/gitlab/usage_data_counters/ci_template_unique_counter.rb' - 'lib/gitlab/utils.rb' - 'lib/gitlab/utils/override.rb' @@ -633,6 +660,7 @@ Style/GuardClause: - 'lib/mattermost/session.rb' - 'lib/release_highlights/validator/entry.rb' - 'lib/safe_zip/entry.rb' + - 'lib/service_ping/devops_report.rb' - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' - 'lib/system_check/incoming_email/mail_room_running_check.rb' - 'lib/tasks/config_lint.rake' @@ -647,22 +675,22 @@ Style/GuardClause: - 'qa/qa/page/component/snippet.rb' - 'qa/qa/page/mattermost/login.rb' - 'qa/qa/page/page_concern.rb' + - 'qa/qa/page/project/settings/deploy_tokens.rb' - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/package.rb' + - 'qa/qa/resource/project.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/reusable.rb' - 'qa/qa/resource/user_gpg.rb' - 'qa/qa/runtime/feature.rb' - 'qa/qa/runtime/search.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - - 'qa/qa/service/docker_run/gitlab_runner.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_file_template_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/group_file_template_spec.rb' - 'qa/qa/specs/helpers/feature_flag.rb' - - 'qa/qa/support/page_error_checker.rb' + - 'qa/qa/vendor/jenkins/job.rb' - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/gitlab/duplicate_spec_location.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' @@ -702,6 +730,7 @@ Style/GuardClause: - 'spec/support/import_export/export_file_helper.rb' - 'spec/support/shared_examples/features/packages_shared_examples.rb' - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' + - 'spec/tooling/lib/tooling/find_codeowners_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - 'tooling/lib/tooling/helm3_client.rb' - 'tooling/lib/tooling/image.rb' |