diff options
Diffstat (limited to '.rubocop_todo/style/if_unless_modifier.yml')
| -rw-r--r-- | .rubocop_todo/style/if_unless_modifier.yml | 45 |
1 files changed, 0 insertions, 45 deletions
diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 515a9ddad6a..efdb0df8341 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -3,7 +3,6 @@ Style/IfUnlessModifier: Exclude: - 'app/controllers/concerns/uploads_actions.rb' - - 'app/controllers/concerns/verifies_with_email.rb' - 'app/controllers/concerns/wiki_actions.rb' - 'app/controllers/concerns/with_performance_bar.rb' - 'app/controllers/explore/projects_controller.rb' @@ -52,7 +51,6 @@ Style/IfUnlessModifier: - 'app/finders/labels_finder.rb' - 'app/finders/members_finder.rb' - 'app/finders/metrics/users_starred_dashboards_finder.rb' - - 'app/finders/namespaces/projects_finder.rb' - 'app/finders/notes_finder.rb' - 'app/finders/packages/helm/packages_finder.rb' - 'app/finders/personal_access_tokens_finder.rb' @@ -92,7 +90,6 @@ Style/IfUnlessModifier: - 'app/helpers/lazy_image_tag_helper.rb' - 'app/helpers/markup_helper.rb' - 'app/helpers/merge_requests_helper.rb' - - 'app/helpers/namespaces_helper.rb' - 'app/helpers/nav/top_nav_helper.rb' - 'app/helpers/nav_helper.rb' - 'app/helpers/page_layout_helper.rb' @@ -102,7 +99,6 @@ Style/IfUnlessModifier: - 'app/helpers/reminder_emails_helper.rb' - 'app/helpers/routing/artifacts_helper.rb' - 'app/helpers/search_helper.rb' - - 'app/helpers/selects_helper.rb' - 'app/helpers/snippets_helper.rb' - 'app/helpers/sorting_helper.rb' - 'app/helpers/submodule_helper.rb' @@ -113,7 +109,6 @@ Style/IfUnlessModifier: - 'app/helpers/x509_helper.rb' - 'app/mailers/emails/members.rb' - 'app/mailers/emails/merge_requests.rb' - - 'app/mailers/notify.rb' - 'app/models/ability.rb' - 'app/models/appearance.rb' - 'app/models/application_setting_implementation.rb' @@ -142,7 +137,6 @@ Style/IfUnlessModifier: - 'app/models/concerns/deprecated_assignee.rb' - 'app/models/concerns/group_descendant.rb' - 'app/models/concerns/has_wiki_page_meta_attributes.rb' - - 'app/models/concerns/id_in_ordered.rb' - 'app/models/concerns/ignorable_columns.rb' - 'app/models/concerns/issuable.rb' - 'app/models/concerns/issuable_link.rb' @@ -182,7 +176,6 @@ Style/IfUnlessModifier: - 'app/models/merge_request.rb' - 'app/models/milestone.rb' - 'app/models/namespace.rb' - - 'app/models/namespace_setting.rb' - 'app/models/namespaces/traversal/linear.rb' - 'app/models/network/graph.rb' - 'app/models/note.rb' @@ -197,7 +190,6 @@ Style/IfUnlessModifier: - 'app/models/packages/pypi/metadatum.rb' - 'app/models/packages/rubygems/metadatum.rb' - 'app/models/pages_domain.rb' - - 'app/models/performance_monitoring/prometheus_dashboard.rb' - 'app/models/project.rb' - 'app/models/project_team.rb' - 'app/models/projects/topic.rb' @@ -266,7 +258,6 @@ Style/IfUnlessModifier: - 'app/services/groups/update_statistics_service.rb' - 'app/services/ide/base_config_service.rb' - 'app/services/import/bitbucket_server_service.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/issuable/bulk_update_service.rb' - 'app/services/issuable/common_system_notes_service.rb' - 'app/services/issuable_base_service.rb' @@ -364,7 +355,6 @@ Style/IfUnlessModifier: - 'app/workers/concerns/packages/cleanup_artifact_worker.rb' - 'app/workers/concerns/project_start_import.rb' - 'app/workers/concerns/worker_attributes.rb' - - 'app/workers/delete_container_repository_worker.rb' - 'app/workers/file_hook_worker.rb' - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' - 'app/workers/issues/rebalancing_worker.rb' @@ -386,7 +376,6 @@ Style/IfUnlessModifier: - 'config/initializers/doorkeeper.rb' - 'config/initializers/geo.rb' - 'config/initializers/google_api_client.rb' - - 'config/initializers/google_api_client_patch.rb' - 'config/initializers/jira.rb' - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' - 'config/initializers/remove_active_job_execute_callback.rb' @@ -399,13 +388,8 @@ Style/IfUnlessModifier: - 'danger/pipeline/Dangerfile' - 'danger/specs/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20210709221659_add_work_item_type_id_to_issue.rb' - - 'db/migrate/20210816095826_add_unique_index_on_dast_profile_to_dast_profile_schedules.rb' - - 'db/migrate/20210818061156_remove_project_profile_compound_index_from_dast_profile_schedules.rb' - 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb' - 'db/migrate/20220324175325_add_key_data_to_secure_files.rb' - - 'db/post_migrate/20210629101712_remove_deprecated_modsecurity_columns.rb' - - 'db/post_migrate/20210713042000_fix_ci_sources_pipelines_index_names.rb' - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb' - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' @@ -460,7 +444,6 @@ Style/IfUnlessModifier: - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/models/allowed_email_domain.rb' - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - - 'ee/app/models/approval_project_rule.rb' - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/concerns/elastic/application_versioned_search.rb' - 'ee/app/models/concerns/geo/verifiable_replicator.rb' @@ -536,7 +519,6 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/notes/update_service.rb' - 'ee/app/services/ee/projects/create_service.rb' - 'ee/app/services/ee/projects/destroy_service.rb' - - 'ee/app/services/ee/projects/gitlab_projects_import_service.rb' - 'ee/app/services/ee/protected_branches/create_service.rb' - 'ee/app/services/ee/todo_service.rb' - 'ee/app/services/ee/users/update_service.rb' @@ -601,7 +583,6 @@ Style/IfUnlessModifier: - 'ee/db/geo/migrate/20170627195211_add_index_to_project_registry.rb' - 'ee/db/geo/migrate/20180402170913_add_missing_on_primary_to_job_artifact_registry..rb' - 'ee/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index.rb' - - 'ee/lib/api/epics.rb' - 'ee/lib/api/merge_request_approval_rules.rb' - 'ee/lib/api/protected_environments.rb' - 'ee/lib/audit/details.rb' @@ -621,7 +602,6 @@ Style/IfUnlessModifier: - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'ee/lib/ee/gitlab/checks/diff_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/tag_check.rb' - - 'ee/lib/ee/gitlab/ci/reports/security/reports.rb' - 'ee/lib/ee/gitlab/cleanup/orphan_job_artifact_files.rb' - 'ee/lib/ee/gitlab/git_access_wiki.rb' - 'ee/lib/ee/gitlab/quick_actions/epic_actions.rb' @@ -668,14 +648,12 @@ Style/IfUnlessModifier: - 'ee/lib/tasks/geo.rake' - 'ee/lib/tasks/gitlab/geo.rake' - 'ee/lib/tasks/gitlab/seed/insights.rake' - - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/factories/iterations.rb' - 'ee/spec/factories/vulnerabilities/external_issue_links.rb' - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/finders/custom_project_templates_finder_spec.rb' - 'ee/spec/finders/security/findings_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/elastic/search_results_spec.rb' @@ -721,7 +699,6 @@ Style/IfUnlessModifier: - 'lib/api/helpers/packages/conan/api_helpers.rb' - 'lib/api/helpers/packages/dependency_proxy_helpers.rb' - 'lib/api/helpers/projects_helpers.rb' - - 'lib/api/helpers/users_helpers.rb' - 'lib/api/helpers/version.rb' - 'lib/api/helpers/web_hooks_helpers.rb' - 'lib/api/internal/base.rb' @@ -762,10 +739,8 @@ Style/IfUnlessModifier: - 'lib/banzai/reference_parser/base_parser.rb' - 'lib/banzai/renderer.rb' - 'lib/bitbucket_server/representation/pull_request_comment.rb' - - 'lib/bulk_imports/clients/http.rb' - 'lib/bulk_imports/common/pipelines/uploads_pipeline.rb' - 'lib/bulk_imports/groups/loaders/group_loader.rb' - - 'lib/bulk_imports/projects/transformers/project_attributes_transformer.rb' - 'lib/container_registry/base_client.rb' - 'lib/container_registry/client.rb' - 'lib/feature/definition.rb' @@ -799,7 +774,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/converter.rb' - 'lib/gitlab/ci/ansi2json/style.rb' - - 'lib/gitlab/ci/artifact_file_reader.rb' - 'lib/gitlab/ci/build/artifacts/metadata.rb' - 'lib/gitlab/ci/build/artifacts/path.rb' - 'lib/gitlab/ci/build/policy/kubernetes.rb' @@ -836,7 +810,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/ci/trace/metrics.rb' - 'lib/gitlab/ci/variables/builder.rb' - 'lib/gitlab/ci/yaml_processor.rb' - - 'lib/gitlab/config/entry/attributable.rb' - 'lib/gitlab/config/entry/simplifiable.rb' - 'lib/gitlab/config/entry/validatable.rb' - 'lib/gitlab/config/entry/validators.rb' @@ -857,10 +830,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/database/partitioning/detached_partition_dropper.rb' - 'lib/gitlab/database/partitioning/monthly_strategy.rb' - 'lib/gitlab/database/partitioning/time_partition.rb' - - 'lib/gitlab/database/postgres_foreign_key.rb' - - 'lib/gitlab/database/postgres_index.rb' - - 'lib/gitlab/database/postgres_partition.rb' - - 'lib/gitlab/database/postgres_partitioned_table.rb' - 'lib/gitlab/database/reindexing.rb' - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - 'lib/gitlab/database/transaction/observer.rb' @@ -1003,7 +972,6 @@ Style/IfUnlessModifier: - 'lib/tasks/gitlab/storage.rake' - 'lib/tasks/gitlab/update_templates.rake' - 'qa/qa/ee/resource/settings/elasticsearch.rb' - - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/component/snippet.rb' - 'qa/qa/page/element.rb' - 'qa/qa/page/mattermost/login.rb' @@ -1014,13 +982,10 @@ Style/IfUnlessModifier: - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/repository/push.rb' - 'qa/qa/resource/snippet.rb' - - 'qa/qa/runtime/application_settings.rb' - - 'qa/qa/runtime/gpg.rb' - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/scenario/bootable.rb' - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' @@ -1039,14 +1004,12 @@ Style/IfUnlessModifier: - 'rubocop/cop/migration/remove_column.rb' - 'rubocop/cop/migration/sidekiq_queue_migrate.rb' - 'rubocop/routes_under_scope.rb' - - 'scripts/pipeline_test_report_builder.rb' - 'scripts/review_apps/automated_cleanup.rb' - 'scripts/setup/find-jh-branch.rb' - 'scripts/static-analysis' - 'sidekiq_cluster/cli.rb' - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/card_component_preview.rb' - - 'spec/db/docs_spec.rb' - 'spec/factories/ci/runners.rb' - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/container_repositories.rb' @@ -1058,21 +1021,17 @@ Style/IfUnlessModifier: - 'spec/factories/projects.rb' - 'spec/factories/protected_tags.rb' - 'spec/factories/users.rb' - - 'spec/features/admin/admin_users_spec.rb' - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/projects/blobs/edit_spec.rb' - 'spec/features/projects/tree/create_directory_spec.rb' - 'spec/features/projects/tree/create_file_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' - - 'spec/helpers/application_settings_helper_spec.rb' - - 'spec/helpers/invite_members_helper_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/config/entry/validators/nested_array_helpers_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' - - 'spec/lib/gitlab/database/lock_writes_manager_spec.rb' - 'spec/lib/gitlab/rack_attack/user_allowlist_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' @@ -1117,7 +1076,6 @@ Style/IfUnlessModifier: - 'spec/support/helpers/stub_gitlab_calls.rb' - 'spec/support/helpers/stubbed_feature.rb' - 'spec/support/helpers/test_env.rb' - - 'spec/support/helpers/usage_data_helpers.rb' - 'spec/support/http_io/http_io_helpers.rb' - 'spec/support/import_export/project_tree_expectations.rb' - 'spec/support/matchers/abort_matcher.rb' @@ -1136,10 +1094,7 @@ Style/IfUnlessModifier: - 'spec/support/shared_examples/views/registration_features_prompt_shared_examples.rb' - 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb' - 'spec/support/webmock.rb' - - 'spec/views/admin/application_settings/general.html.haml_spec.rb' - - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/profiles/keys/_key.html.haml_spec.rb' - - 'spec/views/projects/edit.html.haml_spec.rb' - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - 'tooling/danger/product_intelligence.rb' - 'tooling/lib/tooling/find_codeowners.rb' |