diff options
Diffstat (limited to '.rubocop_todo/style/if_unless_modifier.yml')
| -rw-r--r-- | .rubocop_todo/style/if_unless_modifier.yml | 42 |
1 files changed, 2 insertions, 40 deletions
diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index cc21860d462..8e295c68623 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -34,7 +34,6 @@ Style/IfUnlessModifier: - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - - 'app/controllers/jwt_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' - 'app/controllers/profiles/emails_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' @@ -47,7 +46,6 @@ Style/IfUnlessModifier: - 'app/controllers/projects/deploy_keys_controller.rb' - 'app/controllers/projects/design_management/designs_controller.rb' - 'app/controllers/projects/imports_controller.rb' - - 'app/controllers/projects/integrations/shimos_controller.rb' - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/merge_requests/diffs_controller.rb' - 'app/controllers/projects/merge_requests_controller.rb' @@ -94,13 +92,9 @@ Style/IfUnlessModifier: - 'app/graphql/mutations/release_asset_links/update.rb' - 'app/graphql/mutations/todos/mark_all_done.rb' - 'app/graphql/resolvers/blobs_resolver.rb' - - 'app/graphql/resolvers/ci/runner_jobs_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - - 'app/graphql/resolvers/group_packages_resolver.rb' - - 'app/graphql/resolvers/package_details_resolver.rb' - - 'app/graphql/resolvers/project_jobs_resolver.rb' - 'app/graphql/resolvers/project_pipeline_resolver.rb' - 'app/graphql/resolvers/timelog_resolver.rb' - 'app/graphql/types/ci/job_type.rb' @@ -133,7 +127,6 @@ Style/IfUnlessModifier: - 'app/helpers/selects_helper.rb' - 'app/helpers/snippets_helper.rb' - 'app/helpers/sorting_helper.rb' - - 'app/helpers/storage_helper.rb' - 'app/helpers/submodule_helper.rb' - 'app/helpers/tab_helper.rb' - 'app/helpers/timeboxes_helper.rb' @@ -168,7 +161,6 @@ Style/IfUnlessModifier: - 'app/models/concerns/bulk_users_by_email_load.rb' - 'app/models/concerns/cache_markdown_field.rb' - 'app/models/concerns/ci/artifactable.rb' - - 'app/models/concerns/counter_attribute.rb' - 'app/models/concerns/deprecated_assignee.rb' - 'app/models/concerns/group_descendant.rb' - 'app/models/concerns/has_wiki_page_meta_attributes.rb' @@ -272,7 +264,6 @@ Style/IfUnlessModifier: - 'app/services/ci/job_token_scope/remove_project_service.rb' - 'app/services/ci/parse_dotenv_artifact_service.rb' - 'app/services/ci/pipeline_processing/atomic_processing_service.rb' - - 'app/services/ci/pipelines/add_job_service.rb' - 'app/services/ci/register_job_service.rb' - 'app/services/ci/retry_job_service.rb' - 'app/services/ci/run_scheduled_build_service.rb' @@ -322,14 +313,11 @@ Style/IfUnlessModifier: - 'app/services/merge_requests/add_context_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' - - 'app/services/merge_requests/handle_assignees_change_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' - 'app/services/merge_requests/push_options_handler_service.rb' - 'app/services/merge_requests/refresh_service.rb' - - 'app/services/merge_requests/request_attention_service.rb' - 'app/services/merge_requests/squash_service.rb' - - 'app/services/merge_requests/toggle_attention_requested_service.rb' - 'app/services/merge_requests/update_service.rb' - 'app/services/metrics/dashboard/clone_dashboard_service.rb' - 'app/services/metrics/dashboard/update_dashboard_service.rb' @@ -354,7 +342,6 @@ Style/IfUnlessModifier: - 'app/services/packages/maven/find_or_create_package_service.rb' - 'app/services/packages/nuget/update_package_from_metadata_service.rb' - 'app/services/packages/pypi/create_package_service.rb' - - 'app/services/packages/rubygems/dependency_resolver_service.rb' - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/projects/container_repository/gitlab/delete_tags_service.rb' @@ -375,7 +362,6 @@ Style/IfUnlessModifier: - 'app/services/projects/update_repository_storage_service.rb' - 'app/services/protected_branches/cache_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - - 'app/services/resource_events/change_labels_service.rb' - 'app/services/snippets/create_service.rb' - 'app/services/snippets/destroy_service.rb' - 'app/services/snippets/repository_validation_service.rb' @@ -422,8 +408,6 @@ Style/IfUnlessModifier: - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' - 'app/workers/issues/rebalancing_worker.rb' - 'app/workers/merge_request_mergeability_check_worker.rb' - - 'app/workers/object_storage/migrate_uploads_worker.rb' - - 'app/workers/process_commit_worker.rb' - 'app/workers/projects/import_export/relation_export_worker.rb' - 'app/workers/remove_expired_members_worker.rb' - 'app/workers/repository_fork_worker.rb' @@ -450,8 +434,6 @@ Style/IfUnlessModifier: - 'config/initializers/sidekiq.rb' - 'config/initializers/stackprof.rb' - 'config/initializers/validate_database_config.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - - 'config/initializers/zz_metrics.rb' - 'config/initializers_before_autoloader/002_sidekiq.rb' - 'config/routes.rb' - 'danger/database/Dangerfile' @@ -603,6 +585,7 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/protected_branches/create_service.rb' - 'ee/app/services/ee/todo_service.rb' - 'ee/app/services/ee/users/update_service.rb' + - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/elastic/indexing_control_service.rb' - 'ee/app/services/elastic/process_bookkeeping_service.rb' - 'ee/app/services/epics/base_service.rb' @@ -652,7 +635,6 @@ Style/IfUnlessModifier: - 'ee/app/services/vulnerability_feedback/create_service.rb' - 'ee/app/services/vulnerability_feedback/destroy_service.rb' - 'ee/app/services/vulnerability_feedback_module/update_service.rb' - - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/validators/host_validator.rb' - 'ee/app/validators/password/complexity_validator.rb' - 'ee/app/workers/app_sec/dast/profile_schedule_worker.rb' @@ -889,7 +871,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/ci/config/normalizer.rb' - 'lib/gitlab/ci/parsers/coverage/sax_document.rb' - 'lib/gitlab/ci/parsers/security/common.rb' - - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb' - 'lib/gitlab/ci/pipeline/chain/populate.rb' - 'lib/gitlab/ci/pipeline/chain/seed.rb' - 'lib/gitlab/ci/pipeline/chain/validate/abilities.rb' @@ -991,7 +972,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/import_export/project/relation_factory.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' - 'lib/gitlab/instrumentation/rate_limiting_gates.rb' - - 'lib/gitlab/instrumentation/redis_interceptor.rb' - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' - 'lib/gitlab/legacy_github_import/client.rb' @@ -1034,7 +1014,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/search/params.rb' - 'lib/gitlab/search_context.rb' - 'lib/gitlab/search_results.rb' - - 'lib/gitlab/shell.rb' - 'lib/gitlab/sidekiq_config.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' - 'lib/gitlab/sidekiq_config/worker_router.rb' @@ -1063,7 +1042,6 @@ Style/IfUnlessModifier: - 'lib/sidebars/projects/menus/packages_registries_menu.rb' - 'lib/sidebars/projects/menus/security_compliance_menu.rb' - 'lib/sidebars/projects/menus/settings_menu.rb' - - 'lib/sidebars/projects/panel.rb' - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' - 'lib/system_check/init_helpers.rb' - 'lib/tasks/cleanup.rake' @@ -1078,7 +1056,6 @@ Style/IfUnlessModifier: - 'lib/tasks/gitlab/snippets.rake' - 'lib/tasks/gitlab/storage.rake' - 'lib/tasks/gitlab/update_templates.rake' - - 'qa/qa/ee/page/merge_request/show.rb' - 'qa/qa/ee/resource/settings/elasticsearch.rb' - 'qa/qa/flow/sign_up.rb' - 'qa/qa/page/component/select2.rb' @@ -1099,21 +1076,10 @@ Style/IfUnlessModifier: - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/scenario/bootable.rb' - 'qa/qa/service/praefect_manager.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/elasticsearch_api_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/commit_index/commit_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/issues_index/issue_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/main_index/blob_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/merge_request_index/merge_request_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/notes_index/note_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/nightly_elasticsearch_test_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_maven_package_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - 'qa/qa/support/loglinking.rb' @@ -1123,7 +1089,6 @@ Style/IfUnlessModifier: - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' - - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'rubocop/cop/gitlab/policy_rule_boolean.rb' - 'rubocop/cop/ignored_columns.rb' @@ -1131,8 +1096,6 @@ Style/IfUnlessModifier: - 'rubocop/cop/migration/add_reference.rb' - 'rubocop/cop/migration/remove_column.rb' - 'rubocop/cop/migration/sidekiq_queue_migrate.rb' - - 'rubocop/cop/performance/ar_exists_and_present_blank.rb' - - 'rubocop/cop/rspec/web_mock_enable.rb' - 'rubocop/routes_under_scope.rb' - 'scripts/pipeline_test_report_builder.rb' - 'scripts/review_apps/automated_cleanup.rb' @@ -1187,6 +1150,7 @@ Style/IfUnlessModifier: - 'spec/requests/api/integrations_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/import_routing_spec.rb' + - 'spec/rubocop_spec_helper.rb' - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - 'spec/services/clusters/applications/create_service_spec.rb' @@ -1197,7 +1161,6 @@ Style/IfUnlessModifier: - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' - 'spec/services/packages/maven/metadata/append_package_file_service_spec.rb' - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' - 'spec/services/projects/create_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/capybara.rb' @@ -1213,7 +1176,6 @@ Style/IfUnlessModifier: - 'spec/support/helpers/lets_encrypt_helpers.rb' - 'spec/support/helpers/live_debugger.rb' - 'spec/support/helpers/modal_helpers.rb' - - 'spec/support/helpers/seed_helper.rb' - 'spec/support/helpers/stub_gitlab_calls.rb' - 'spec/support/helpers/stubbed_feature.rb' - 'spec/support/helpers/test_env.rb' |