diff options
Diffstat (limited to '.rubocop_todo/style/if_unless_modifier.yml')
| -rw-r--r-- | .rubocop_todo/style/if_unless_modifier.yml | 136 |
1 files changed, 66 insertions, 70 deletions
diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 1dfedcc91c0..a58f71aee8f 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -1,14 +1,10 @@ --- # Cop supports --auto-correct. Style/IfUnlessModifier: - # Offense count: 1937 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/channels/graphql_channel.rb' - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/admin/projects_controller.rb' - - 'app/controllers/admin/runners_controller.rb' - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/concerns/controller_with_cross_project_access_check.rb' @@ -25,6 +21,8 @@ Style/IfUnlessModifier: - 'app/controllers/concerns/paginated_collection.rb' - 'app/controllers/concerns/record_user_last_activity.rb' - 'app/controllers/concerns/sorting_preference.rb' + - 'app/controllers/concerns/uploads_actions.rb' + - 'app/controllers/concerns/verifies_with_email.rb' - 'app/controllers/concerns/wiki_actions.rb' - 'app/controllers/concerns/with_performance_bar.rb' - 'app/controllers/explore/projects_controller.rb' @@ -33,9 +31,9 @@ Style/IfUnlessModifier: - 'app/controllers/groups_controller.rb' - 'app/controllers/import/fogbugz_controller.rb' - 'app/controllers/import/gitea_controller.rb' + - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - - 'app/controllers/jira_connect/application_controller.rb' - 'app/controllers/jwt_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' - 'app/controllers/profiles/emails_controller.rb' @@ -53,12 +51,15 @@ Style/IfUnlessModifier: - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/merge_requests/diffs_controller.rb' - 'app/controllers/projects/merge_requests_controller.rb' + - 'app/controllers/projects/pipelines/tests_controller.rb' - 'app/controllers/projects/protected_refs_controller.rb' - 'app/controllers/projects/releases_controller.rb' - 'app/controllers/projects/runners_controller.rb' + - 'app/controllers/projects_controller.rb' - 'app/controllers/registrations_controller.rb' - 'app/controllers/repositories/git_http_controller.rb' - 'app/controllers/repositories/lfs_api_controller.rb' + - 'app/controllers/repositories/lfs_storage_controller.rb' - 'app/controllers/sessions_controller.rb' - 'app/controllers/users/terms_controller.rb' - 'app/finders/autocomplete/users_finder.rb' @@ -92,7 +93,6 @@ Style/IfUnlessModifier: - 'app/graphql/mutations/release_asset_links/delete.rb' - 'app/graphql/mutations/release_asset_links/update.rb' - 'app/graphql/mutations/todos/mark_all_done.rb' - - 'app/graphql/mutations/work_items/create.rb' - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/ci/runner_jobs_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' @@ -105,7 +105,6 @@ Style/IfUnlessModifier: - 'app/graphql/resolvers/timelog_resolver.rb' - 'app/graphql/types/ci/job_type.rb' - 'app/helpers/admin/user_actions_helper.rb' - - 'app/helpers/appearances_helper.rb' - 'app/helpers/blob_helper.rb' - 'app/helpers/button_helper.rb' - 'app/helpers/ci/status_helper.rb' @@ -116,7 +115,6 @@ Style/IfUnlessModifier: - 'app/helpers/events_helper.rb' - 'app/helpers/form_helper.rb' - 'app/helpers/groups_helper.rb' - - 'app/helpers/issuables_description_templates_helper.rb' - 'app/helpers/issuables_helper.rb' - 'app/helpers/issues_helper.rb' - 'app/helpers/lazy_image_tag_helper.rb' @@ -135,6 +133,7 @@ Style/IfUnlessModifier: - 'app/helpers/selects_helper.rb' - 'app/helpers/snippets_helper.rb' - 'app/helpers/sorting_helper.rb' + - 'app/helpers/storage_helper.rb' - 'app/helpers/submodule_helper.rb' - 'app/helpers/tab_helper.rb' - 'app/helpers/timeboxes_helper.rb' @@ -153,6 +152,7 @@ Style/IfUnlessModifier: - 'app/models/ci/build.rb' - 'app/models/ci/build_trace_chunk.rb' - 'app/models/ci/job_artifact.rb' + - 'app/models/ci/pending_build.rb' - 'app/models/ci/pipeline.rb' - 'app/models/ci/runner.rb' - 'app/models/ci/running_build.rb' @@ -170,7 +170,6 @@ Style/IfUnlessModifier: - 'app/models/concerns/ci/artifactable.rb' - 'app/models/concerns/counter_attribute.rb' - 'app/models/concerns/deprecated_assignee.rb' - - 'app/models/concerns/diff_positionable_note.rb' - 'app/models/concerns/group_descendant.rb' - 'app/models/concerns/has_wiki_page_meta_attributes.rb' - 'app/models/concerns/id_in_ordered.rb' @@ -178,10 +177,10 @@ Style/IfUnlessModifier: - 'app/models/concerns/issuable.rb' - 'app/models/concerns/issuable_link.rb' - 'app/models/concerns/issue_available_features.rb' - - 'app/models/concerns/limitable.rb' - 'app/models/concerns/mentionable.rb' - 'app/models/concerns/noteable.rb' - 'app/models/concerns/routable.rb' + - 'app/models/concerns/sha_attribute.rb' - 'app/models/concerns/timebox.rb' - 'app/models/concerns/token_authenticatable_strategies/base.rb' - 'app/models/concerns/token_authenticatable_strategies/digest.rb' @@ -195,6 +194,7 @@ Style/IfUnlessModifier: - 'app/models/error_tracking/project_error_tracking_setting.rb' - 'app/models/external_pull_request.rb' - 'app/models/generic_commit_status.rb' + - 'app/models/grafana_integration.rb' - 'app/models/group.rb' - 'app/models/integrations/asana.rb' - 'app/models/integrations/bamboo.rb' @@ -205,6 +205,7 @@ Style/IfUnlessModifier: - 'app/models/integrations/jira.rb' - 'app/models/integrations/pushover.rb' - 'app/models/integrations/teamcity.rb' + - 'app/models/issue.rb' - 'app/models/issue_email_participant.rb' - 'app/models/label_note.rb' - 'app/models/list.rb' @@ -217,7 +218,6 @@ Style/IfUnlessModifier: - 'app/models/namespace.rb' - 'app/models/namespace_setting.rb' - 'app/models/namespaces/traversal/linear.rb' - - 'app/models/namespaces/traversal/linear_scopes.rb' - 'app/models/network/graph.rb' - 'app/models/note.rb' - 'app/models/notification_setting.rb' @@ -239,7 +239,6 @@ Style/IfUnlessModifier: - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - 'app/models/route.rb' - - 'app/models/sent_notification.rb' - 'app/models/service_desk_setting.rb' - 'app/models/snippet_input_action.rb' - 'app/models/state_note.rb' @@ -247,6 +246,8 @@ Style/IfUnlessModifier: - 'app/models/synthetic_note.rb' - 'app/models/user.rb' - 'app/models/wiki.rb' + - 'app/models/work_items/parent_link.rb' + - 'app/policies/project_policy.rb' - 'app/presenters/blob_presenter.rb' - 'app/presenters/ci/pipeline_presenter.rb' - 'app/presenters/merge_request_presenter.rb' @@ -266,7 +267,6 @@ Style/IfUnlessModifier: - 'app/services/boards/lists/base_create_service.rb' - 'app/services/boards/lists/list_service.rb' - 'app/services/branches/validate_new_service.rb' - - 'app/services/bulk_imports/file_decompression_service.rb' - 'app/services/ci/create_pipeline_service.rb' - 'app/services/ci/create_web_ide_terminal_service.rb' - 'app/services/ci/job_token_scope/remove_project_service.rb' @@ -276,6 +276,8 @@ Style/IfUnlessModifier: - 'app/services/ci/register_job_service.rb' - 'app/services/ci/retry_job_service.rb' - 'app/services/ci/run_scheduled_build_service.rb' + - 'app/services/ci/runners/reconcile_existing_runner_versions_service.rb' + - 'app/services/ci/runners/register_runner_service.rb' - 'app/services/ci/update_build_state_service.rb' - 'app/services/clusters/applications/base_service.rb' - 'app/services/clusters/applications/prometheus_update_service.rb' @@ -299,6 +301,7 @@ Style/IfUnlessModifier: - 'app/services/error_tracking/collect_error_service.rb' - 'app/services/git/process_ref_changes_service.rb' - 'app/services/google_cloud/generate_pipeline_service.rb' + - 'app/services/google_cloud/setup_cloudsql_instance_service.rb' - 'app/services/groups/create_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/groups/update_statistics_service.rb' @@ -314,7 +317,6 @@ Style/IfUnlessModifier: - 'app/services/issues/relative_position_rebalancing_service.rb' - 'app/services/issues/update_service.rb' - 'app/services/lfs/lock_file_service.rb' - - 'app/services/members/approve_access_request_service.rb' - 'app/services/members/destroy_service.rb' - 'app/services/members/update_service.rb' - 'app/services/merge_requests/add_context_service.rb' @@ -322,7 +324,6 @@ Style/IfUnlessModifier: - 'app/services/merge_requests/build_service.rb' - 'app/services/merge_requests/handle_assignees_change_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - - 'app/services/merge_requests/mergeability/run_checks_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' - 'app/services/merge_requests/push_options_handler_service.rb' - 'app/services/merge_requests/refresh_service.rb' @@ -371,8 +372,8 @@ Style/IfUnlessModifier: - 'app/services/projects/overwrite_project_service.rb' - 'app/services/projects/participants_service.rb' - 'app/services/projects/transfer_service.rb' - - 'app/services/projects/update_pages_service.rb' - 'app/services/projects/update_repository_storage_service.rb' + - 'app/services/protected_branches/cache_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - 'app/services/resource_events/change_labels_service.rb' - 'app/services/snippets/create_service.rb' @@ -388,6 +389,8 @@ Style/IfUnlessModifier: - 'app/services/users/respond_to_terms_service.rb' - 'app/services/wikis/create_attachment_service.rb' - 'app/services/work_items/create_service.rb' + - 'app/services/work_items/parent_links/create_service.rb' + - 'app/services/work_items/task_list_reference_removal_service.rb' - 'app/services/work_items/task_list_reference_replacement_service.rb' - 'app/uploaders/file_mover.rb' - 'app/uploaders/object_storage.rb' @@ -408,17 +411,20 @@ Style/IfUnlessModifier: - 'app/views/projects/merge_requests/index.atom.builder' - 'app/workers/authorized_project_update/user_refresh_from_replica_worker.rb' - 'app/workers/auto_devops/disable_worker.rb' - - 'app/workers/cleanup_container_repository_worker.rb' - 'app/workers/concerns/application_worker.rb' - 'app/workers/concerns/packages/cleanup_artifact_worker.rb' - 'app/workers/concerns/project_start_import.rb' + - 'app/workers/concerns/waitable_worker.rb' - 'app/workers/concerns/worker_attributes.rb' - 'app/workers/database/batched_background_migration/single_database_worker.rb' + - 'app/workers/delete_container_repository_worker.rb' - 'app/workers/file_hook_worker.rb' + - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' - 'app/workers/issues/rebalancing_worker.rb' - 'app/workers/merge_request_mergeability_check_worker.rb' - 'app/workers/object_storage/migrate_uploads_worker.rb' - 'app/workers/process_commit_worker.rb' + - 'app/workers/projects/import_export/relation_export_worker.rb' - 'app/workers/remove_expired_members_worker.rb' - 'app/workers/repository_fork_worker.rb' - 'app/workers/repository_update_remote_mirror_worker.rb' @@ -429,11 +435,10 @@ Style/IfUnlessModifier: - 'config/initializers/1_settings.rb' - 'config/initializers/6_validations.rb' - 'config/initializers/8_devise.rb' - - 'config/initializers/active_record_data_types.rb' - 'config/initializers/active_record_transaction_patches.rb' - - 'config/initializers/content_security_policy.rb' - 'config/initializers/default_url_options.rb' - 'config/initializers/direct_upload_support.rb' + - 'config/initializers/doorkeeper.rb' - 'config/initializers/geo.rb' - 'config/initializers/google_api_client.rb' - 'config/initializers/google_api_client_patch.rb' @@ -449,7 +454,6 @@ Style/IfUnlessModifier: - 'config/initializers/zz_metrics.rb' - 'config/initializers_before_autoloader/002_sidekiq.rb' - 'config/routes.rb' - - 'config/settings.rb' - 'danger/database/Dangerfile' - 'danger/pipeline/Dangerfile' - 'danger/specs/Dangerfile' @@ -465,7 +469,8 @@ Style/IfUnlessModifier: - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb' - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - - 'ee/app/controllers/admin/audit_logs_controller.rb' + - 'db/post_migrate/20220523171107_drop_deploy_tokens_token_column.rb' + - 'ee/app/components/namespaces/storage/limit_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' @@ -495,10 +500,11 @@ Style/IfUnlessModifier: - 'ee/app/finders/merge_trains_finder.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - - 'ee/app/graphql/ee/mutations/issues/create.rb' - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/destroy.rb' + - 'ee/app/graphql/mutations/boards/scoped_board_mutation.rb' + - 'ee/app/graphql/mutations/dast_site_profiles/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver.rb' @@ -506,39 +512,37 @@ Style/IfUnlessModifier: - 'ee/app/graphql/resolvers/boards/epic_lists_resolver.rb' - 'ee/app/graphql/resolvers/iterations/cadences_resolver.rb' - 'ee/app/helpers/billing_plans_helper.rb' - - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/dashboard_helper.rb' - - 'ee/app/helpers/ee/environments_helper.rb' - 'ee/app/helpers/ee/integrations_helper.rb' - 'ee/app/helpers/ee/issues_helper.rb' - 'ee/app/helpers/ee/labels_helper.rb' - 'ee/app/helpers/ee/merge_requests_helper.rb' - 'ee/app/helpers/ee/notes_helper.rb' - 'ee/app/helpers/ee/personal_access_tokens_helper.rb' + - 'ee/app/helpers/ee/projects/pipeline_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/models/allowed_email_domain.rb' - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' + - 'ee/app/models/approval_project_rule.rb' - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/concerns/elastic/application_versioned_search.rb' - - 'ee/app/models/concerns/geo/replicable_model.rb' - 'ee/app/models/concerns/geo/verifiable_replicator.rb' - 'ee/app/models/concerns/security/scan_execution_policy.rb' - 'ee/app/models/dast_site_profile.rb' - 'ee/app/models/ee/application_setting.rb' + - 'ee/app/models/ee/ci/job_artifact.rb' + - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/group_member.rb' - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/key.rb' - 'ee/app/models/ee/list.rb' - - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/milestone_release.rb' - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/namespace/root_storage_size.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/ee/project_feature.rb' - 'ee/app/models/ee/project_team.rb' - 'ee/app/models/ee/user.rb' - - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/geo/project_registry.rb' - 'ee/app/models/geo/tracking_base.rb' - 'ee/app/models/incident_management/escalation_rule.rb' @@ -554,6 +558,7 @@ Style/IfUnlessModifier: - 'ee/app/serializers/vulnerabilities/finding_serializer.rb' - 'ee/app/services/analytics/cycle_analytics/aggregator_service.rb' - 'ee/app/services/analytics/cycle_analytics/validations.rb' + - 'ee/app/services/app_sec/dast/pipelines/find_latest_service.rb' - 'ee/app/services/app_sec/dast/profiles/build_config_service.rb' - 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb' - 'ee/app/services/app_sec/dast/scan_configs/build_service.rb' @@ -564,7 +569,6 @@ Style/IfUnlessModifier: - 'ee/app/services/app_sec/dast/site_profiles/destroy_service.rb' - 'ee/app/services/app_sec/dast/site_profiles/update_service.rb' - 'ee/app/services/app_sec/fuzzing/api/ci_configuration_create_service.rb' - - 'ee/app/services/audit_events/runner_audit_event_service.rb' - 'ee/app/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service.rb' - 'ee/app/services/billable_members/destroy_service.rb' - 'ee/app/services/boards/epic_boards/create_service.rb' @@ -572,6 +576,7 @@ Style/IfUnlessModifier: - 'ee/app/services/boards/epics/create_service.rb' - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' - 'ee/app/services/ci/subscribe_bridge_service.rb' + - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' - 'ee/app/services/compliance_management/frameworks/create_service.rb' - 'ee/app/services/compliance_management/merge_requests/create_compliance_violations_service.rb' - 'ee/app/services/deployments/auto_rollback_service.rb' @@ -581,15 +586,13 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/audit_event_service.rb' - 'ee/app/services/ee/boards/base_service.rb' - 'ee/app/services/ee/boards/issues/move_service.rb' + - 'ee/app/services/ee/ci/runners/reset_registration_token_service.rb' - 'ee/app/services/ee/commits/create_service.rb' - 'ee/app/services/ee/deploy_keys/create_service.rb' - 'ee/app/services/ee/groups/update_service.rb' - 'ee/app/services/ee/ip_restrictions/update_service.rb' - 'ee/app/services/ee/issuable_base_service.rb' - 'ee/app/services/ee/issues/base_service.rb' - - 'ee/app/services/ee/issues/clone_service.rb' - - 'ee/app/services/ee/issues/move_service.rb' - - 'ee/app/services/ee/merge_requests/base_service.rb' - 'ee/app/services/ee/merge_requests/refresh_service.rb' - 'ee/app/services/ee/merge_requests/update_service.rb' - 'ee/app/services/ee/milestones/update_service.rb' @@ -598,16 +601,18 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/projects/destroy_service.rb' - 'ee/app/services/ee/projects/gitlab_projects_import_service.rb' - 'ee/app/services/ee/protected_branches/create_service.rb' - - 'ee/app/services/ee/resource_events/change_labels_service.rb' - 'ee/app/services/ee/todo_service.rb' - 'ee/app/services/ee/users/update_service.rb' - 'ee/app/services/elastic/indexing_control_service.rb' - 'ee/app/services/elastic/process_bookkeeping_service.rb' - 'ee/app/services/epics/base_service.rb' - 'ee/app/services/epics/create_service.rb' + - 'ee/app/services/epics/epic_links/create_service.rb' + - 'ee/app/services/epics/epic_links/update_service.rb' - 'ee/app/services/epics/update_dates_service.rb' - 'ee/app/services/epics/update_service.rb' - 'ee/app/services/external_status_checks/create_service.rb' + - 'ee/app/services/geo/file_registry_removal_service.rb' - 'ee/app/services/geo/metrics_update_service.rb' - 'ee/app/services/geo/move_repository_service.rb' - 'ee/app/services/geo/prune_event_log_service.rb' @@ -625,7 +630,6 @@ Style/IfUnlessModifier: - 'ee/app/services/merge_requests/update_blocks_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - 'ee/app/services/projects/mark_for_deletion_service.rb' - - 'ee/app/services/projects/slack_application_install_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/resource_events/change_weight_service.rb' - 'ee/app/services/security/dependency_list_service.rb' @@ -649,17 +653,18 @@ Style/IfUnlessModifier: - 'ee/app/services/vulnerability_feedback/destroy_service.rb' - 'ee/app/services/vulnerability_feedback_module/update_service.rb' - 'ee/app/validators/host_validator.rb' + - 'ee/app/validators/password/complexity_validator.rb' - 'ee/app/workers/app_sec/dast/profile_schedule_worker.rb' - 'ee/app/workers/audit_events/audit_event_streaming_worker.rb' - 'ee/app/workers/concerns/elastic/migration_helper.rb' - 'ee/app/workers/ee/ci/build_finished_worker.rb' - - 'ee/app/workers/ee/post_receive.rb' + - 'ee/app/workers/elastic/project_transfer_worker.rb' - 'ee/app/workers/epics/new_epic_issue_worker.rb' - 'ee/app/workers/geo/secondary/registry_consistency_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb' - 'ee/db/geo/migrate/20170627195211_add_index_to_project_registry.rb' - 'ee/db/geo/migrate/20180402170913_add_missing_on_primary_to_job_artifact_registry..rb' - - 'ee/lib/analytics/devops_adoption/snapshot_calculator.rb' + - 'ee/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index.rb' - 'ee/lib/api/epics.rb' - 'ee/lib/api/merge_request_approval_rules.rb' - 'ee/lib/api/protected_environments.rb' @@ -679,7 +684,6 @@ Style/IfUnlessModifier: - 'ee/lib/ee/container_registry/client.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/auth/ldap/group.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'ee/lib/ee/gitlab/checks/diff_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/tag_check.rb' @@ -713,7 +717,7 @@ Style/IfUnlessModifier: - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb' - - 'ee/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate.rb' + - 'ee/lib/gitlab/graphql/aggregations/issuables/lazy_links_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/vulnerabilities/lazy_user_notes_count_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate.rb' @@ -741,7 +745,6 @@ Style/IfUnlessModifier: - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - - 'ee/spec/lib/gitlab/elastic/project_search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/search_results_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - 'ee/spec/models/concerns/elastic/note_spec.rb' @@ -766,7 +769,6 @@ Style/IfUnlessModifier: - 'lib/api/ci/pipeline_schedules.rb' - 'lib/api/ci/runner.rb' - 'lib/api/ci/runners.rb' - - 'lib/api/ci/secure_files.rb' - 'lib/api/commits.rb' - 'lib/api/debian_project_packages.rb' - 'lib/api/deployments.rb' @@ -775,7 +777,6 @@ Style/IfUnlessModifier: - 'lib/api/entities/member_access.rb' - 'lib/api/entities/project_import_status.rb' - 'lib/api/feature_flags.rb' - - 'lib/api/feature_flags_user_lists.rb' - 'lib/api/files.rb' - 'lib/api/groups.rb' - 'lib/api/helm_packages.rb' @@ -791,14 +792,15 @@ Style/IfUnlessModifier: - 'lib/api/helpers/projects_helpers.rb' - 'lib/api/helpers/users_helpers.rb' - 'lib/api/helpers/version.rb' + - 'lib/api/helpers/web_hooks_helpers.rb' - 'lib/api/internal/base.rb' - 'lib/api/internal/container_registry/migration.rb' + - 'lib/api/internal/error_tracking.rb' - 'lib/api/invitations.rb' - 'lib/api/maven_packages.rb' - 'lib/api/merge_requests.rb' - 'lib/api/nuget_project_packages.rb' - 'lib/api/pages_domains.rb' - - 'lib/api/project_clusters.rb' - 'lib/api/project_snippets.rb' - 'lib/api/projects.rb' - 'lib/api/projects_relation_builder.rb' @@ -840,6 +842,7 @@ Style/IfUnlessModifier: - 'lib/generators/gitlab/usage_metric_generator.rb' - 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb' - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' + - 'lib/gitlab/application_context.rb' - 'lib/gitlab/auth.rb' - 'lib/gitlab/auth/auth_finders.rb' - 'lib/gitlab/auth/ldap/adapter.rb' @@ -861,6 +864,7 @@ Style/IfUnlessModifier: - 'lib/gitlab/checks/matching_merge_request.rb' - 'lib/gitlab/checks/push_check.rb' - 'lib/gitlab/checks/push_file_count_check.rb' + - 'lib/gitlab/checks/tag_check.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/converter.rb' - 'lib/gitlab/ci/ansi2json/style.rb' @@ -876,7 +880,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/ci/config/entry/jobs.rb' - 'lib/gitlab/ci/config/entry/needs.rb' - 'lib/gitlab/ci/config/entry/policy.rb' - - 'lib/gitlab/ci/config/entry/processable.rb' - 'lib/gitlab/ci/config/entry/product/matrix.rb' - 'lib/gitlab/ci/config/extendable/entry.rb' - 'lib/gitlab/ci/config/external/file/base.rb' @@ -912,6 +915,7 @@ Style/IfUnlessModifier: - 'lib/gitlab/content_security_policy/config_loader.rb' - 'lib/gitlab/cross_project_access/check_info.rb' - 'lib/gitlab/data_builder/deployment.rb' + - 'lib/gitlab/data_builder/pipeline.rb' - 'lib/gitlab/database/as_with_materialized.rb' - 'lib/gitlab/database/background_migration/batched_job.rb' - 'lib/gitlab/database/background_migration/batched_migration_wrapper.rb' @@ -932,8 +936,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - 'lib/gitlab/database/transaction/observer.rb' - 'lib/gitlab/database/with_lock_retries.rb' - - 'lib/gitlab/diff/formatters/base_formatter.rb' - - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/repository_push.rb' @@ -942,7 +944,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/encrypted_command_base.rb' - 'lib/gitlab/encrypted_configuration.rb' - 'lib/gitlab/endpoint_attributes/config.rb' - - 'lib/gitlab/error_tracking.rb' - 'lib/gitlab/error_tracking/context_payload_generator.rb' - 'lib/gitlab/error_tracking/processor/sidekiq_processor.rb' - 'lib/gitlab/etag_caching/middleware.rb' @@ -960,7 +961,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/git_access.rb' - 'lib/gitlab/git_access_project.rb' - 'lib/gitlab/git_access_snippet.rb' - - 'lib/gitlab/git_access_wiki.rb' - 'lib/gitlab/gitaly_client.rb' - 'lib/gitlab/gitaly_client/blob_service.rb' - 'lib/gitlab/gitaly_client/operation_service.rb' @@ -971,15 +971,11 @@ Style/IfUnlessModifier: - 'lib/gitlab/gitlab_import/client.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/golang.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/base_condition.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - - 'lib/gitlab/graphql/pagination/keyset/generic_keyset_pagination.rb' - - 'lib/gitlab/graphql/pagination/keyset/order_info.rb' - - 'lib/gitlab/graphql/pagination/keyset/query_builder.rb' - 'lib/gitlab/graphql/queries.rb' - 'lib/gitlab/hashed_storage/rake_helper.rb' - 'lib/gitlab/hotlinking_detector.rb' + - 'lib/gitlab/http.rb' - 'lib/gitlab/http_io.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import/import_failure_service.rb' @@ -987,12 +983,13 @@ Style/IfUnlessModifier: - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' - 'lib/gitlab/import_export/base/relation_factory.rb' - 'lib/gitlab/import_export/fast_hash_serializer.rb' - - 'lib/gitlab/import_export/file_importer.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - 'lib/gitlab/import_export/json/legacy_writer.rb' - 'lib/gitlab/import_export/merge_request_parser.rb' - 'lib/gitlab/import_export/project/export_task.rb' + - 'lib/gitlab/import_export/project/relation_factory.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' + - 'lib/gitlab/instrumentation/rate_limiting_gates.rb' - 'lib/gitlab/instrumentation/redis_interceptor.rb' - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' @@ -1000,6 +997,7 @@ Style/IfUnlessModifier: - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/legacy_github_import/project_creator.rb' + - 'lib/gitlab/lograge/custom_options.rb' - 'lib/gitlab/mail_room.rb' - 'lib/gitlab/mail_room/authenticator.rb' - 'lib/gitlab/manifest_import/manifest.rb' @@ -1011,19 +1009,19 @@ Style/IfUnlessModifier: - 'lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter.rb' - 'lib/gitlab/metrics/dashboard/stages/variable_endpoint_inserter.rb' - 'lib/gitlab/metrics/methods.rb' - - 'lib/gitlab/metrics/rails_slis.rb' + - 'lib/gitlab/metrics/subscribers/rack_attack.rb' - 'lib/gitlab/metrics/web_transaction.rb' - 'lib/gitlab/middleware/compressed_json.rb' - 'lib/gitlab/middleware/multipart.rb' - 'lib/gitlab/middleware/same_site_cookies.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/omniauth_initializer.rb' + - 'lib/gitlab/pages/deployment_update.rb' - 'lib/gitlab/pagination/keyset/in_operator_optimization/query_builder.rb' - 'lib/gitlab/patch/database_config.rb' - 'lib/gitlab/patch/prependable.rb' - 'lib/gitlab/popen.rb' - 'lib/gitlab/query_limiting/active_support_subscriber.rb' - - 'lib/gitlab/quick_actions/command_definition.rb' - 'lib/gitlab/quick_actions/extractor.rb' - 'lib/gitlab/quick_actions/issuable_actions.rb' - 'lib/gitlab/quick_actions/issue_and_merge_request_actions.rb' @@ -1044,11 +1042,9 @@ Style/IfUnlessModifier: - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' - 'lib/gitlab/slash_commands/presenters/issue_show.rb' - 'lib/gitlab/suggestions/suggestion_set.rb' - - 'lib/gitlab/template/gitlab_ci_yml_template.rb' - 'lib/gitlab/template_parser/eval_state.rb' - 'lib/gitlab/untrusted_regexp.rb' - 'lib/gitlab/url_blocker.rb' - - 'lib/gitlab/usage/metrics/aggregates/aggregate.rb' - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data_counters/base_counter.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' @@ -1084,13 +1080,12 @@ Style/IfUnlessModifier: - 'qa/qa/ee/page/merge_request/show.rb' - 'qa/qa/ee/resource/settings/elasticsearch.rb' - 'qa/qa/flow/sign_up.rb' - - 'qa/qa/git/repository.rb' - - 'qa/qa/page/component/design_management.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/component/snippet.rb' - 'qa/qa/page/element.rb' - 'qa/qa/page/mattermost/login.rb' - 'qa/qa/page/page_concern.rb' + - 'qa/qa/page/project/settings/deploy_tokens.rb' - 'qa/qa/page/project/web_ide/edit.rb' - 'qa/qa/page/view.rb' - 'qa/qa/resource/registry_repository.rb' @@ -1099,21 +1094,17 @@ Style/IfUnlessModifier: - 'qa/qa/resource/runner.rb' - 'qa/qa/resource/snippet.rb' - 'qa/qa/runtime/application_settings.rb' - - 'qa/qa/runtime/browser.rb' - 'qa/qa/runtime/gpg.rb' - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/scenario/bootable.rb' - - 'qa/qa/scenario/template.rb' - - 'qa/qa/service/docker_run/gitlab_runner.rb' - - 'qa/qa/service/docker_run/jenkins.rb' - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/elasticsearch_api_spec.rb' + - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/commit_index/commit_index_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/issues_index/issue_index_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/main_index/blob_index_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/merge_request_index/merge_request_index_spec.rb' @@ -1121,15 +1112,13 @@ Style/IfUnlessModifier: - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/nightly_elasticsearch_test_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_maven_package_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - 'qa/qa/support/loglinking.rb' - - 'qa/qa/support/page_error_checker.rb' - - 'qa/qa/support/wait_for_requests.rb' - 'qa/qa/tools/delete_projects.rb' + - 'qa/qa/tools/delete_user_projects.rb' - 'qa/qa/tools/generate_perf_testdata.rb' - - 'qa/qa/tools/test_resources_handler.rb' - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' @@ -1149,8 +1138,11 @@ Style/IfUnlessModifier: - 'scripts/setup/find-jh-branch.rb' - 'scripts/static-analysis' - 'sidekiq_cluster/cli.rb' + - 'spec/components/previews/pajamas/alert_component_preview.rb' + - 'spec/components/previews/pajamas/card_component_preview.rb' - 'spec/db/docs_spec.rb' - 'spec/factories/ci/runners.rb' + - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/container_repositories.rb' - 'spec/factories/deployments.rb' - 'spec/factories/labels.rb' @@ -1164,6 +1156,8 @@ Style/IfUnlessModifier: - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/projects/blobs/edit_spec.rb' + - 'spec/features/projects/tree/create_directory_spec.rb' + - 'spec/features/projects/tree/create_file_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' - 'spec/helpers/invite_members_helper_spec.rb' @@ -1173,6 +1167,7 @@ Style/IfUnlessModifier: - 'spec/lib/gitlab/config/entry/validators/nested_array_helpers_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' + - 'spec/lib/gitlab/database/lock_writes_manager_spec.rb' - 'spec/lib/gitlab/rack_attack/user_allowlist_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' @@ -1186,8 +1181,10 @@ Style/IfUnlessModifier: - 'spec/policies/project_statistics_policy_spec.rb' - 'spec/requests/api/ci/jobs_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' + - 'spec/requests/api/commits_spec.rb' - 'spec/requests/api/files_spec.rb' - 'spec/requests/api/integrations_spec.rb' + - 'spec/requests/users_controller_spec.rb' - 'spec/routing/import_routing_spec.rb' - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' @@ -1207,13 +1204,11 @@ Style/IfUnlessModifier: - 'spec/support/external_authorization_service_helpers.rb' - 'spec/support/flaky_tests.rb' - 'spec/support/generate-seed-repo-rb' - - 'spec/support/helpers/cycle_analytics_helpers.rb' - 'spec/support/helpers/filter_spec_helper.rb' - 'spec/support/helpers/filtered_search_helpers.rb' - 'spec/support/helpers/gitaly_setup.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' - - 'spec/support/helpers/kubernetes_helpers.rb' - 'spec/support/helpers/lets_encrypt_helpers.rb' - 'spec/support/helpers/live_debugger.rb' - 'spec/support/helpers/modal_helpers.rb' @@ -1247,6 +1242,7 @@ Style/IfUnlessModifier: - 'spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - 'tooling/danger/product_intelligence.rb' + - 'tooling/lib/tooling/find_codeowners.rb' - 'tooling/lib/tooling/image.rb' - 'tooling/lib/tooling/test_map_packer.rb' - 'tooling/rspec_flaky/flaky_example.rb' |