diff options
Diffstat (limited to '.rubocop_todo/style')
| -rw-r--r-- | .rubocop_todo/style/case_like_if.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/style/empty_method.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/explicit_block_argument.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/format_string.yml | 4 | ||||
| -rw-r--r-- | .rubocop_todo/style/guard_clause.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/if_unless_modifier.yml | 8 | ||||
| -rw-r--r-- | .rubocop_todo/style/percent_literal_delimiters.yml | 10 | ||||
| -rw-r--r-- | .rubocop_todo/style/redundant_regexp_escape.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/redundant_self.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/symbol_proc.yml | 2 |
10 files changed, 2 insertions, 29 deletions
diff --git a/.rubocop_todo/style/case_like_if.yml b/.rubocop_todo/style/case_like_if.yml index f1e349fe836..119ca3d800f 100644 --- a/.rubocop_todo/style/case_like_if.yml +++ b/.rubocop_todo/style/case_like_if.yml @@ -24,7 +24,6 @@ Style/CaseLikeIf: - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' - 'ee/app/finders/ee/notes_finder.rb' - 'ee/app/helpers/ee/branches_helper.rb' - - 'ee/app/helpers/ee/namespace_storage_limit_alert_helper.rb' - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/merge_request_approval_settings/update_service.rb' - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb' @@ -34,7 +33,6 @@ Style/CaseLikeIf: - 'ee/spec/features/projects/custom_projects_template_spec.rb' - 'ee/spec/support/matchers/ee/epic_aggregate_matchers.rb' - 'lib/api/helpers/label_helpers.rb' - - 'lib/gitlab/analytics/unique_visits.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/converter.rb' - 'lib/gitlab/ci/build/image.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index aa3972a0b22..3e6a1efec70 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -61,7 +61,6 @@ Style/EmptyMethod: - 'app/controllers/registrations/welcome_controller.rb' - 'app/controllers/search_controller.rb' - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' - - 'app/helpers/namespace_storage_limit_alert_helper.rb' - 'app/helpers/subscribable_banner_helper.rb' - 'app/helpers/users/callouts_helper.rb' - 'app/models/ci/bridge.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index f6bff468c76..e5ce2576f8c 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -16,7 +16,6 @@ Style/ExplicitBlockArgument: - 'app/models/merge_request.rb' - 'app/models/snippet_repository.rb' - 'app/services/import_export_clean_up_service.rb' - - 'app/services/issuable/clone/attributes_rewriter.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/workers/concerns/each_shard_worker.rb' - 'db/migrate/20210629031900_associate_existing_dast_builds_with_variables.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index a9065bb5932..caa293b31ae 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -165,8 +165,6 @@ Style/FormatString: - 'app/services/metrics/dashboard/update_dashboard_service.rb' - 'app/services/milestones/promote_service.rb' - 'app/services/personal_access_tokens/revoke_service.rb' - - 'app/services/pod_logs/elasticsearch_service.rb' - - 'app/services/pod_logs/kubernetes_service.rb' - 'app/services/projects/cleanup_service.rb' - 'app/services/projects/create_from_template_service.rb' - 'app/services/projects/import_service.rb' @@ -232,8 +230,6 @@ Style/FormatString: - 'ee/app/services/incident_management/escalation_policies/base_service.rb' - 'ee/app/services/issues/build_from_vulnerability_service.rb' - 'ee/app/services/merge_requests/create_from_vulnerability_data_service.rb' - - 'ee/app/services/namespaces/check_excess_storage_size_service.rb' - - 'ee/app/services/namespaces/check_storage_size_service.rb' - 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - 'ee/app/services/timebox_report_service.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index c7109639677..7ee19ee164e 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -682,7 +682,6 @@ Style/GuardClause: - 'spec/deprecation_toolkit_env.rb' - 'spec/features/issuables/issuable_list_spec.rb' - 'spec/features/projects/blobs/edit_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/edit_spec.rb' - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - 'spec/services/packages/maven/metadata/append_package_file_service_spec.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 645fc5f764c..1dfedcc91c0 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -153,7 +153,6 @@ Style/IfUnlessModifier: - 'app/models/ci/build.rb' - 'app/models/ci/build_trace_chunk.rb' - 'app/models/ci/job_artifact.rb' - - 'app/models/ci/legacy_stage.rb' - 'app/models/ci/pipeline.rb' - 'app/models/ci/runner.rb' - 'app/models/ci/running_build.rb' @@ -308,7 +307,6 @@ Style/IfUnlessModifier: - 'app/services/import/github_service.rb' - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/issuable/clone/attributes_rewriter.rb' - 'app/services/issuable/common_system_notes_service.rb' - 'app/services/issuable_base_service.rb' - 'app/services/issuable_links/create_service.rb' @@ -357,7 +355,6 @@ Style/IfUnlessModifier: - 'app/services/packages/pypi/create_package_service.rb' - 'app/services/packages/rubygems/dependency_resolver_service.rb' - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - - 'app/services/pod_logs/kubernetes_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/projects/container_repository/gitlab/delete_tags_service.rb' - 'app/services/projects/container_repository/third_party/delete_tags_service.rb' @@ -716,7 +713,7 @@ Style/IfUnlessModifier: - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb' - - 'ee/lib/gitlab/graphql/aggregations/issues/lazy_block_aggregate.rb' + - 'ee/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/vulnerabilities/lazy_user_notes_count_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate.rb' @@ -937,7 +934,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/diff/formatters/base_formatter.rb' - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - - 'lib/gitlab/elasticsearch/logs/lines.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/repository_push.rb' @@ -1168,7 +1164,6 @@ Style/IfUnlessModifier: - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/projects/blobs/edit_spec.rb' - - 'spec/features/refactor_blob_viewer_disabled/projects/blobs/edit_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' - 'spec/helpers/invite_members_helper_spec.rb' @@ -1251,7 +1246,6 @@ Style/IfUnlessModifier: - 'spec/views/projects/edit.html.haml_spec.rb' - 'spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - - 'tooling/bin/qa/check_if_qa_only_spec_changes' - 'tooling/danger/product_intelligence.rb' - 'tooling/lib/tooling/image.rb' - 'tooling/lib/tooling/test_map_packer.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 487e0e7cd20..16ae8989c97 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -20,7 +20,6 @@ Style/PercentLiteralDelimiters: - 'app/controllers/jira_connect/app_descriptor_controller.rb' - 'app/controllers/jira_connect/subscriptions_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/projects/logs_controller.rb' - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' - 'app/controllers/projects/product_analytics_controller.rb' - 'app/controllers/projects/service_desk_controller.rb' @@ -79,7 +78,6 @@ Style/PercentLiteralDelimiters: - 'app/models/bulk_imports/file_transfer/project_config.rb' - 'app/models/ci/build.rb' - 'app/models/ci/build_runner_session.rb' - - 'app/models/ci/legacy_stage.rb' - 'app/models/ci/pipeline.rb' - 'app/models/clusters/applications/cert_manager.rb' - 'app/models/clusters/platforms/kubernetes.rb' @@ -142,7 +140,6 @@ Style/PercentLiteralDelimiters: - 'app/models/resource_timebox_event.rb' - 'app/models/user.rb' - 'app/models/user_interacted_project.rb' - - 'app/models/users/in_product_marketing_email.rb' - 'app/policies/identity_provider_policy.rb' - 'app/presenters/dev_ops_report/metric_presenter.rb' - 'app/presenters/search_service_presenter.rb' @@ -166,8 +163,6 @@ Style/PercentLiteralDelimiters: - 'app/services/merge_requests/update_service.rb' - 'app/services/metrics/dashboard/default_embed_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - - 'app/services/pod_logs/base_service.rb' - - 'app/services/pod_logs/elasticsearch_service.rb' - 'app/services/preview_markdown_service.rb' - 'app/services/projects/apple_target_platform_detector_service.rb' - 'app/services/projects/container_repository/cleanup_tags_service.rb' @@ -674,7 +669,6 @@ Style/PercentLiteralDelimiters: - 'spec/factories/ci/runners.rb' - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/clusters/clusters.rb' - - 'spec/factories/clusters/integrations/elastic_stack.rb' - 'spec/factories/clusters/integrations/prometheus.rb' - 'spec/factories/clusters/providers/aws.rb' - 'spec/factories/deployments.rb' @@ -692,7 +686,6 @@ Style/PercentLiteralDelimiters: - 'spec/features/projects/artifacts/user_downloads_artifacts_spec.rb' - 'spec/features/projects/branches_spec.rb' - 'spec/features/projects/environments/environment_spec.rb' - - 'spec/features/projects/environments_pod_logs_spec.rb' - 'spec/features/projects/integrations/user_activates_jira_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/labels/issues_sorted_by_priority_spec.rb' @@ -1003,7 +996,6 @@ Style/PercentLiteralDelimiters: - 'spec/models/project_setting_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/project_team_spec.rb' - - 'spec/models/project_tracing_setting_spec.rb' - 'spec/models/projects/topic_spec.rb' - 'spec/models/prometheus_metric_spec.rb' - 'spec/models/releases/link_spec.rb' @@ -1115,8 +1107,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/packages/update_tags_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - - 'spec/services/pod_logs/base_service_spec.rb' - - 'spec/services/pod_logs/kubernetes_service_spec.rb' - 'spec/services/product_analytics/build_graph_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' diff --git a/.rubocop_todo/style/redundant_regexp_escape.yml b/.rubocop_todo/style/redundant_regexp_escape.yml index 969a23601ca..cf502711f35 100644 --- a/.rubocop_todo/style/redundant_regexp_escape.yml +++ b/.rubocop_todo/style/redundant_regexp_escape.yml @@ -109,5 +109,4 @@ Style/RedundantRegexpEscape: - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - 'spec/uploaders/personal_file_uploader_spec.rb' - 'spec/views/help/index.html.haml_spec.rb' - - 'tooling/bin/qa/check_if_qa_only_spec_changes' - 'tooling/danger/project_helper.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 1aba23c90ae..9951160ae02 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -143,7 +143,6 @@ Style/RedundantSelf: - 'app/models/project_group_link.rb' - 'app/models/project_import_data.rb' - 'app/models/project_label.rb' - - 'app/models/project_tracing_setting.rb' - 'app/models/prometheus_alert.rb' - 'app/models/protected_branch.rb' - 'app/models/protected_branch/push_access_level.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index 5e3aa10d9e5..ea3a505d2da 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -133,7 +133,7 @@ Style/SymbolProc: - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/document_reference_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_block_aggregate_spec.rb' + - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/services/groups/participants_service_spec.rb' - 'ee/spec/support/helpers/subscription_portal_helpers.rb' |