diff options
Diffstat (limited to '.rubocop_todo/style')
31 files changed, 32 insertions, 558 deletions
diff --git a/.rubocop_todo/style/accessor_grouping.yml b/.rubocop_todo/style/accessor_grouping.yml index a4fae856953..a5586813885 100644 --- a/.rubocop_todo/style/accessor_grouping.yml +++ b/.rubocop_todo/style/accessor_grouping.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/AccessorGrouping: Exclude: - 'app/finders/template_finder.rb' @@ -57,7 +57,6 @@ Style/AccessorGrouping: - 'lib/gitlab/http_io.rb' - 'lib/gitlab/import_export/group/legacy_tree_restorer.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' - - 'lib/gitlab/merge_requests/commit_message_generator.rb' - 'lib/gitlab/sidekiq_daemon/monitor.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/suggestions/file_suggestion.rb' diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml index cb40669ca02..e98660024db 100644 --- a/.rubocop_todo/style/bare_percent_literals.yml +++ b/.rubocop_todo/style/bare_percent_literals.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/BarePercentLiterals: Exclude: - 'app/models/commit.rb' @@ -75,7 +75,6 @@ Style/BarePercentLiterals: - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - - 'spec/lib/banzai/reference_parser/commit_parser_spec.rb' - 'spec/lib/banzai/reference_parser/issue_parser_spec.rb' - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' - 'spec/lib/gitlab/diff/highlight_spec.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index bff827ba5d3..2303c5a1652 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/ClassAndModuleChildren: Exclude: - 'app/components/pajamas/toggle_component.rb' @@ -8,11 +8,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/admin/application_settings/appearances_controller.rb' - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/admin/applications_controller.rb' - - 'app/controllers/admin/background_jobs_controller.rb' - - 'app/controllers/admin/background_migrations_controller.rb' - - 'app/controllers/admin/batched_jobs_controller.rb' - - 'app/controllers/admin/broadcast_messages_controller.rb' - - 'app/controllers/admin/ci/variables_controller.rb' - 'app/controllers/admin/clusters/integrations_controller.rb' - 'app/controllers/admin/clusters_controller.rb' - 'app/controllers/admin/cohorts_controller.rb' @@ -22,7 +17,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/admin/gitaly_servers_controller.rb' - 'app/controllers/admin/groups_controller.rb' - 'app/controllers/admin/health_check_controller.rb' - - 'app/controllers/admin/hook_logs_controller.rb' - 'app/controllers/admin/hooks_controller.rb' - 'app/controllers/admin/identities_controller.rb' - 'app/controllers/admin/impersonation_tokens_controller.rb' @@ -47,7 +41,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/clusters/base_controller.rb' - 'app/controllers/clusters/clusters_controller.rb' - 'app/controllers/concerns/integrations/actions.rb' - - 'app/controllers/concerns/integrations/hooks_execution.rb' - 'app/controllers/concerns/metrics/dashboard/prometheus_api_proxy.rb' - 'app/controllers/concerns/snippets/blobs_actions.rb' - 'app/controllers/concerns/snippets/send_blob.rb' @@ -149,7 +142,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/projects/ci/daily_build_group_report_results_controller.rb' - 'app/controllers/projects/ci/lints_controller.rb' - 'app/controllers/projects/ci/pipeline_editor_controller.rb' - - 'app/controllers/projects/ci/secure_files_controller.rb' - 'app/controllers/projects/cluster_agents_controller.rb' - 'app/controllers/projects/clusters/integrations_controller.rb' - 'app/controllers/projects/clusters_controller.rb' @@ -178,7 +170,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/projects/google_cloud/gcp_regions_controller.rb' - 'app/controllers/projects/google_cloud/revoke_oauth_controller.rb' - 'app/controllers/projects/google_cloud/service_accounts_controller.rb' - - 'app/controllers/projects/google_cloud_controller.rb' - 'app/controllers/projects/grafana_api_controller.rb' - 'app/controllers/projects/graphs_controller.rb' - 'app/controllers/projects/group_links_controller.rb' @@ -207,7 +198,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/projects/pipeline_schedules_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' - 'app/controllers/projects/pipelines_settings_controller.rb' - - 'app/controllers/projects/product_analytics_controller.rb' - 'app/controllers/projects/project_members_controller.rb' - 'app/controllers/projects/protected_branches_controller.rb' - 'app/controllers/projects/protected_refs_controller.rb' @@ -225,7 +215,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/projects/snippets/blobs_controller.rb' - 'app/controllers/projects/snippets_controller.rb' - 'app/controllers/projects/starrers_controller.rb' - - 'app/controllers/projects/tags/releases_controller.rb' - 'app/controllers/projects/tags_controller.rb' - 'app/controllers/projects/templates_controller.rb' - 'app/controllers/projects/terraform_controller.rb' @@ -361,7 +350,6 @@ Style/ClassAndModuleChildren: - 'app/workers/merge_requests/delete_source_branch_worker.rb' - 'app/workers/merge_requests/handle_assignees_change_worker.rb' - 'app/workers/merge_requests/resolve_todos_worker.rb' - - 'config/initializers/active_record_data_types.rb' - 'config/initializers/http_hostname_override.rb' - 'config/initializers/httpclient_patch.rb' - 'config/initializers/omniauth.rb' @@ -429,12 +417,10 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/groups/security/merge_commit_reports_controller.rb' - 'ee/app/controllers/groups/sso_controller.rb' - 'ee/app/controllers/groups/todos_controller.rb' - - 'ee/app/controllers/groups/usage_quotas_controller.rb' - 'ee/app/controllers/groups/wikis_controller.rb' - 'ee/app/controllers/oauth/geo_auth_controller.rb' - 'ee/app/controllers/profiles/billings_controller.rb' - 'ee/app/controllers/profiles/slacks_controller.rb' - - 'ee/app/controllers/profiles/usage_quotas_controller.rb' - 'ee/app/controllers/projects/analytics/issues_analytics_controller.rb' - 'ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb' - 'ee/app/controllers/projects/approver_groups_controller.rb' @@ -500,7 +486,6 @@ Style/ClassAndModuleChildren: - 'ee/app/models/geo/upload_registry.rb' - 'ee/app/models/protected_branch/required_code_owners_section.rb' - 'ee/app/models/protected_branch/unprotect_access_level.rb' - - 'ee/app/models/protected_environment/deploy_access_level.rb' - 'ee/app/serializers/vulnerabilities/feedback_entity.rb' - 'ee/app/serializers/vulnerabilities/feedback_serializer.rb' - 'ee/app/serializers/vulnerabilities/finding_diff_serializer.rb' @@ -515,9 +500,7 @@ Style/ClassAndModuleChildren: - 'ee/app/services/ee/projects/after_rename_service.rb' - 'ee/app/services/ee/projects/disable_deploy_key_service.rb' - 'ee/app/services/ee/projects/enable_deploy_key_service.rb' - - 'ee/app/services/ee/projects/update_pages_service.rb' - 'ee/db/fixtures/development/20_burndown.rb' - - 'ee/db/fixtures/development/20_vulnerabilities.rb' - 'ee/db/fixtures/development/21_dast_profiles.rb' - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb' - 'ee/db/fixtures/development/32_compliance_report_violations.rb' @@ -536,7 +519,6 @@ Style/ClassAndModuleChildren: - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/ci/badge/base.rb' - 'lib/gitlab/ci/badge/coverage/metadata.rb' - 'lib/gitlab/ci/badge/coverage/report.rb' diff --git a/.rubocop_todo/style/conditional_assignment.yml b/.rubocop_todo/style/conditional_assignment.yml index c9bbaaeb175..d16f2f7c3a7 100644 --- a/.rubocop_todo/style/conditional_assignment.yml +++ b/.rubocop_todo/style/conditional_assignment.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/ConditionalAssignment: Exclude: - 'app/helpers/icons_helper.rb' diff --git a/.rubocop_todo/style/each_for_simple_loop.yml b/.rubocop_todo/style/each_for_simple_loop.yml index 5d495f890d2..e7f99d69528 100644 --- a/.rubocop_todo/style/each_for_simple_loop.yml +++ b/.rubocop_todo/style/each_for_simple_loop.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/EachForSimpleLoop: Exclude: - 'ee/spec/lib/gitlab/insights/reducers/count_per_period_reducer_spec.rb' diff --git a/.rubocop_todo/style/empty_else.yml b/.rubocop_todo/style/empty_else.yml index 07e42692f60..bd30b4a7c50 100644 --- a/.rubocop_todo/style/empty_else.yml +++ b/.rubocop_todo/style/empty_else.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/EmptyElse: Exclude: - 'app/controllers/concerns/issuable_collections_action.rb' @@ -24,7 +24,6 @@ Style/EmptyElse: - 'app/models/resource_timebox_event.rb' - 'app/services/award_emojis/add_service.rb' - 'app/services/merge_requests/update_service.rb' - - 'app/workers/gitlab/github_import/stage/import_issue_events_worker.rb' - 'app/workers/post_receive.rb' - 'config/initializers/doorkeeper_openid_connect.rb' - 'ee/app/controllers/admin/audit_logs_controller.rb' @@ -37,7 +36,6 @@ Style/EmptyElse: - 'ee/app/services/gitlab_subscriptions/check_future_renewal_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/workers/gitlab_subscriptions/notify_seats_exceeded_worker.rb' - - 'ee/db/fixtures/development/20_vulnerabilities.rb' - 'ee/lib/elastic/latest/note_instance_proxy.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/change_failure_rate.rb' - 'ee/lib/gitlab/geo/oauth/logout_token.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 300d8678719..0c7eb5c0d92 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/EmptyMethod: Exclude: - 'app/controllers/admin/application_settings/appearances_controller.rb' @@ -11,7 +11,6 @@ Style/EmptyMethod: - 'app/controllers/admin/runners_controller.rb' - 'app/controllers/admin/topics_controller.rb' - 'app/controllers/admin/usage_trends_controller.rb' - - 'app/controllers/admin/users_controller.rb' - 'app/controllers/concerns/boards_actions.rb' - 'app/controllers/groups/milestones_controller.rb' - 'app/controllers/groups/runners_controller.rb' @@ -44,7 +43,6 @@ Style/EmptyMethod: - 'app/controllers/projects/mattermosts_controller.rb' - 'app/controllers/projects/pages_domains_controller.rb' - 'app/controllers/projects/pipeline_schedules_controller.rb' - - 'app/controllers/projects/product_analytics_controller.rb' - 'app/controllers/projects/runners_controller.rb' - 'app/controllers/projects/settings/integrations_controller.rb' - 'app/controllers/projects/settings/packages_and_registries_controller.rb' @@ -165,30 +163,3 @@ Style/EmptyMethod: - 'qa/qa/service/cluster_provider/k3d.rb' - 'qa/qa/service/cluster_provider/k3s.rb' - 'qa/qa/service/cluster_provider/minikube.rb' - - 'spec/controllers/concerns/check_rate_limit_spec.rb' - - 'spec/controllers/concerns/issuable_actions_spec.rb' - - 'spec/initializers/forbid_sidekiq_in_transactions_spec.rb' - - 'spec/lib/api/helpers/rate_limiter_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sidekiq_client_middleware_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - - 'spec/lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin_spec.rb' - - 'spec/lib/gitlab/database/postgresql_database_tasks/load_schema_versions_mixin_spec.rb' - - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' - - 'spec/lib/gitlab/repository_archive_rate_limiter_spec.rb' - - 'spec/lib/gitlab/repository_cache_adapter_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/client_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/instrumentation_logger_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/query_analyzer_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/worker_context/client_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - - 'spec/lib/gitlab/ssh_public_key_spec.rb' - - 'spec/lib/gitlab/utils/delegator_override/validator_spec.rb' - - 'spec/lib/gitlab/utils/delegator_override_spec.rb' - - 'spec/lib/gitlab/utils/override_spec.rb' - - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' - - 'spec/workers/concerns/waitable_worker_spec.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index 20e8c976fb7..50874266979 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/ExplicitBlockArgument: Exclude: - 'app/controllers/admin/background_migrations_controller.rb' @@ -38,7 +38,6 @@ Style/ExplicitBlockArgument: - 'lib/gitlab/application_context.rb' - 'lib/gitlab/authorized_keys.rb' - 'lib/gitlab/cache.rb' - - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' - 'lib/gitlab/ci/reports/test_suite.rb' - 'lib/gitlab/ci/variables/collection.rb' - 'lib/gitlab/cleanup/remote_uploads.rb' @@ -74,16 +73,6 @@ Style/ExplicitBlockArgument: - 'lib/gitlab/sidekiq_status.rb' - 'lib/gitlab/utils/measuring.rb' - 'lib/tasks/config_lint.rake' - - 'qa/qa/ee/page/insights/show.rb' - - 'qa/qa/ee/page/operations_dashboard.rb' - - 'qa/qa/ee/page/project/issue/show.rb' - - 'qa/qa/ee/page/project/show.rb' - - 'qa/qa/ee/page/project/wiki/show.rb' - - 'qa/qa/flow/login.rb' - - 'qa/qa/page/admin/menu.rb' - - 'qa/qa/page/base.rb' - - 'qa/qa/page/component/blob_content.rb' - - 'qa/qa/page/group/settings/group_deploy_tokens.rb' - 'qa/qa/page/profile/menu.rb' - 'qa/qa/page/project/settings/deploy_keys.rb' - 'qa/qa/page/project/settings/deploy_tokens.rb' diff --git a/.rubocop_todo/style/float_division.yml b/.rubocop_todo/style/float_division.yml index 7fd0cda469d..b5cc208b836 100644 --- a/.rubocop_todo/style/float_division.yml +++ b/.rubocop_todo/style/float_division.yml @@ -1,7 +1,7 @@ --- +# Cop supports --autocorrect. Style/FloatDivision: Exclude: - 'ee/app/models/geo_node_status.rb' - 'ee/app/models/namespaces/storage/root_size.rb' - - 'qa/qa/support/formatters/allure_metadata_formatter.rb' - 'qa/qa/tools/reliable_report.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 4da3c32416c..c1ba754edca 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/FormatString: Exclude: - 'app/components/diffs/overflow_warning_component.rb' @@ -14,7 +14,6 @@ Style/FormatString: - 'app/controllers/concerns/confirm_email_warning.rb' - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - 'app/controllers/concerns/integrations/actions.rb' - - 'app/controllers/concerns/integrations/hooks_execution.rb' - 'app/controllers/concerns/membership_actions.rb' - 'app/controllers/concerns/redirects_for_missing_path_on_tree.rb' - 'app/controllers/concerns/spammable_actions/akismet_mark_as_spam_action.rb' @@ -28,7 +27,6 @@ Style/FormatString: - 'app/controllers/import/gitlab_groups_controller.rb' - 'app/controllers/import/gitlab_projects_controller.rb' - 'app/controllers/invites_controller.rb' - - 'app/controllers/jwt_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' - 'app/controllers/profiles/chat_names_controller.rb' - 'app/controllers/profiles/emails_controller.rb' @@ -48,7 +46,6 @@ Style/FormatString: - 'app/finders/todos_finder.rb' - 'app/graphql/mutations/release_asset_links/create.rb' - 'app/helpers/auth_helper.rb' - - 'app/helpers/blob_helper.rb' - 'app/helpers/button_helper.rb' - 'app/helpers/ci/builds_helper.rb' - 'app/helpers/ci/pipelines_helper.rb' @@ -65,7 +62,6 @@ Style/FormatString: - 'app/helpers/members_helper.rb' - 'app/helpers/merge_requests_helper.rb' - 'app/helpers/mirror_helper.rb' - - 'app/helpers/notify_helper.rb' - 'app/helpers/preferences_helper.rb' - 'app/helpers/profiles_helper.rb' - 'app/helpers/projects/project_members_helper.rb' @@ -74,7 +70,6 @@ Style/FormatString: - 'app/helpers/reminder_emails_helper.rb' - 'app/helpers/search_helper.rb' - 'app/helpers/ssh_keys_helper.rb' - - 'app/helpers/storage_helper.rb' - 'app/helpers/tags_helper.rb' - 'app/helpers/time_helper.rb' - 'app/helpers/timeboxes_helper.rb' @@ -91,7 +86,6 @@ Style/FormatString: - 'app/models/concerns/limitable.rb' - 'app/models/concerns/metric_image_uploading.rb' - 'app/models/concerns/spammable.rb' - - 'app/models/concerns/timebox.rb' - 'app/models/concerns/token_authenticatable_strategies/encrypted.rb' - 'app/models/container_expiration_policy.rb' - 'app/models/custom_emoji.rb' @@ -111,7 +105,6 @@ Style/FormatString: - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/ewm.rb' - 'app/models/integrations/external_wiki.rb' - - 'app/models/integrations/flowdock.rb' - 'app/models/integrations/hangouts_chat.rb' - 'app/models/integrations/irker.rb' - 'app/models/integrations/jenkins.rb' @@ -126,7 +119,6 @@ Style/FormatString: - 'app/models/integrations/webex_teams.rb' - 'app/models/integrations/youtrack.rb' - 'app/models/integrations/zentao.rb' - - 'app/models/merge_request.rb' - 'app/models/merge_request_diff.rb' - 'app/models/milestone.rb' - 'app/models/pages_domain.rb' @@ -134,30 +126,25 @@ Style/FormatString: - 'app/models/resource_event.rb' - 'app/models/sent_notification.rb' - 'app/models/serverless/domain.rb' - - 'app/models/snippet.rb' - 'app/models/user.rb' - 'app/models/wiki.rb' - 'app/models/wiki_page.rb' - 'app/models/work_items/parent_link.rb' - 'app/presenters/ci/pipeline_presenter.rb' + - 'app/presenters/key_presenter.rb' - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/project_presenter.rb' - - 'app/presenters/key_presenter.rb' - 'app/serializers/build_details_entity.rb' - 'app/services/alert_management/alerts/update_service.rb' - 'app/services/boards/lists/base_create_service.rb' - - 'app/services/bulk_imports/file_download_service.rb' - 'app/services/clusters/applications/check_progress_service.rb' - - 'app/services/clusters/applications/check_uninstall_progress_service.rb' - 'app/services/clusters/applications/install_service.rb' - - 'app/services/clusters/applications/patch_service.rb' - 'app/services/clusters/applications/upgrade_service.rb' - 'app/services/clusters/aws/authorize_role_service.rb' - 'app/services/clusters/aws/finalize_creation_service.rb' - 'app/services/clusters/aws/verify_provision_status_service.rb' - 'app/services/clusters/gcp/finalize_creation_service.rb' - 'app/services/clusters/gcp/verify_provision_status_service.rb' - - 'app/services/clusters/kubernetes/configure_istio_ingress_service.rb' - 'app/services/concerns/update_repository_storage_methods.rb' - 'app/services/concerns/validates_classification_label.rb' - 'app/services/gravatar_service.rb' @@ -195,12 +182,8 @@ Style/FormatString: - 'config/initializers/rack_lineprof.rb' - 'danger/roulette/Dangerfile' - 'ee/app/components/billing/plan_component.rb' - - 'ee/app/components/namespaces/free_user_cap/alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/personable.rb' - - 'ee/app/components/namespaces/free_user_cap/personal_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/personal_preview_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/personal_usage_quota_limitations_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/preview_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/notification_alert_component.rb' - 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb' - 'ee/app/components/namespaces/free_user_cap/usage_quota_trial_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' @@ -213,7 +196,6 @@ Style/FormatString: - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' - 'ee/app/controllers/ee/repositories/lfs_api_controller.rb' - 'ee/app/controllers/groups/saml_group_links_controller.rb' - - 'ee/app/controllers/groups/settings/reporting_controller.rb' - 'ee/app/controllers/groups/sso_controller.rb' - 'ee/app/controllers/projects/requirements_management/requirements_controller.rb' - 'ee/app/controllers/subscriptions/groups_controller.rb' @@ -221,7 +203,6 @@ Style/FormatString: - 'ee/app/helpers/billing_plans_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/helpers/ee/groups/reporting_helper.rb' - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/import_helper.rb' @@ -271,8 +252,6 @@ Style/FormatString: - 'ee/app/services/vulnerability_external_issue_links/create_service.rb' - 'ee/app/validators/user_existence_validator.rb' - 'ee/lib/audit/details.rb' - - 'ee/lib/ee/audit/project_changes_auditor.rb' - - 'ee/lib/ee/audit/project_setting_changes_auditor.rb' - 'ee/lib/ee/gitlab/checks/push_rules/branch_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb' - 'ee/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb' @@ -301,7 +280,6 @@ Style/FormatString: - 'lib/api/helpers/packages/conan/api_helpers.rb' - 'lib/bulk_imports/network_error.rb' - 'lib/bulk_imports/users_mapper.rb' - - 'lib/flowdock/git/builder.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/checks/push_file_count_check.rb' - 'lib/gitlab/ci/ansi2json/line.rb' @@ -314,7 +292,6 @@ Style/FormatString: - 'lib/gitlab/console.rb' - 'lib/gitlab/database/async_indexes/index_creator.rb' - 'lib/gitlab/database/background_migration/batched_migration.rb' - - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb' - 'lib/gitlab/database/partitioning/time_partition.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' @@ -371,7 +348,6 @@ Style/FormatString: - 'spec/models/integrations/datadog_spec.rb' - 'spec/models/serverless/domain_spec.rb' - 'spec/requests/api/graphql/project/jira_projects_spec.rb' - - 'spec/services/clusters/applications/patch_service_spec.rb' - 'spec/services/clusters/applications/upgrade_service_spec.rb' - 'spec/services/groups/import_export/export_service_spec.rb' - 'spec/services/projects/import_export/export_service_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index f46f8c8f4f6..59aa38fc9f5 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -1,4 +1,5 @@ --- +# Cop supports --autocorrect. Style/GuardClause: Exclude: - 'app/controllers/admin/users_controller.rb' @@ -16,18 +17,9 @@ Style/GuardClause: - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/concerns/issuable_collections.rb' - 'app/controllers/concerns/oauth_applications.rb' - - 'app/controllers/concerns/page_limiter.rb' - - 'app/controllers/concerns/product_analytics_tracking.rb' - - 'app/controllers/concerns/record_user_last_activity.rb' - - 'app/controllers/concerns/routable_actions.rb' - - 'app/controllers/concerns/snippets/blobs_actions.rb' - - 'app/controllers/concerns/uploads_actions.rb' - - 'app/controllers/dashboard/todos_controller.rb' - 'app/controllers/groups/application_controller.rb' - 'app/controllers/groups_controller.rb' - - 'app/controllers/ide_controller.rb' - 'app/controllers/import/gitea_controller.rb' - - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' @@ -35,7 +27,6 @@ Style/GuardClause: - 'app/controllers/profiles/two_factor_auths_controller.rb' - 'app/controllers/projects/application_controller.rb' - 'app/controllers/projects/blob_controller.rb' - - 'app/controllers/projects/branches_controller.rb' - 'app/controllers/projects/commit_controller.rb' - 'app/controllers/projects/compare_controller.rb' - 'app/controllers/projects/design_management/designs/resized_image_controller.rb' @@ -69,7 +60,6 @@ Style/GuardClause: - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/board_list_issues_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/projects/jira_projects_resolver.rb' - 'app/graphql/types/ci/job_type.rb' @@ -123,22 +113,17 @@ Style/GuardClause: - 'app/models/diff_viewer/base.rb' - 'app/models/environment.rb' - 'app/models/error_tracking/project_error_tracking_setting.rb' - - 'app/models/experiment_subject.rb' - 'app/models/external_pull_request.rb' - 'app/models/generic_commit_status.rb' - 'app/models/grafana_integration.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/base_third_party_wiki.rb' - 'app/models/integrations/confluence.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/field.rb' - - 'app/models/integrations/harbor.rb' - - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' - - 'app/models/integrations/teamcity.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' - 'app/models/member.rb' @@ -170,7 +155,6 @@ Style/GuardClause: - 'app/models/snippet_input_action.rb' - 'app/models/user.rb' - 'app/models/users/in_product_marketing_email.rb' - - 'app/models/wiki.rb' - 'app/models/work_item.rb' - 'app/models/work_items/parent_link.rb' - 'app/presenters/ci/pipeline_presenter.rb' @@ -194,7 +178,6 @@ Style/GuardClause: - 'app/services/commits/create_service.rb' - 'app/services/concerns/alert_management/alert_processing.rb' - 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb' - - 'app/services/concerns/rate_limited_service.rb' - 'app/services/concerns/update_repository_storage_methods.rb' - 'app/services/concerns/validates_classification_label.rb' - 'app/services/deployments/update_environment_service.rb' @@ -221,7 +204,6 @@ Style/GuardClause: - 'app/services/merge_requests/add_spent_time_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' - - 'app/services/merge_requests/handle_assignees_change_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/merge_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' @@ -260,8 +242,6 @@ Style/GuardClause: - 'app/uploaders/file_uploader.rb' - 'app/validators/abstract_path_validator.rb' - 'app/validators/any_field_validator.rb' - - 'app/validators/array_members_validator.rb' - - 'app/validators/branch_filter_validator.rb' - 'app/validators/certificate_fingerprint_validator.rb' - 'app/validators/certificate_key_validator.rb' - 'app/validators/certificate_validator.rb' @@ -292,7 +272,6 @@ Style/GuardClause: - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/google_api_client_patch.rb' - 'config/initializers/postgresql_cte.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'config/object_store_settings.rb' - 'danger/feature_flag/Dangerfile' - 'db/migrate/20210302212623_rename_vuln_fingerprints_indexes.rb' @@ -322,13 +301,11 @@ Style/GuardClause: - 'ee/app/controllers/projects/security/policies_controller.rb' - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/controllers/smartcard_controller.rb' - - 'ee/app/finders/ee/notes_finder.rb' - 'ee/app/finders/ee/template_finder.rb' - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - 'ee/app/graphql/mutations/concerns/mutations/shared_epic_arguments.rb' - 'ee/app/graphql/mutations/iterations/create.rb' - - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver.rb' - 'ee/app/graphql/resolvers/epics_resolver.rb' @@ -374,12 +351,10 @@ Style/GuardClause: - 'ee/app/models/incident_management/escalation_rule.rb' - 'ee/app/models/incident_management/oncall_rotation.rb' - 'ee/app/models/ip_restriction.rb' - - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/preloaders/environments/protected_environment_preloader.rb' - 'ee/app/models/protected_environment.rb' - 'ee/app/models/protected_environments/deploy_access_level.rb' - - 'ee/app/models/sbom/occurrence.rb' - 'ee/app/models/users_security_dashboard_project.rb' - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/presenters/ee/merge_request_presenter.rb' @@ -426,7 +401,6 @@ Style/GuardClause: - 'ee/app/services/iterations/delete_service.rb' - 'ee/app/services/merge_trains/check_status_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - - 'ee/app/services/merge_trains/refresh_service.rb' - 'ee/app/services/namespaces/storage/email_notification_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/override_uuids_service.rb' @@ -445,12 +419,10 @@ Style/GuardClause: - 'ee/db/geo/migrate/20180314175612_add_partial_index_to_project_registy_verification_failure_columns.rb' - 'ee/db/geo/migrate/20180315222132_add_partial_index_to_project_registy_checksum_columns.rb' - 'ee/db/geo/migrate/20180412213305_add_index_to_artifact_id_on_job_artifact_registry.rb' - - 'ee/lib/ee/api/ci/job_artifacts.rb' - 'ee/lib/ee/api/features.rb' - 'ee/lib/ee/api/helpers/projects_helpers.rb' - 'ee/lib/ee/api/projects.rb' - 'ee/lib/ee/api/search.rb' - - 'ee/lib/ee/audit/project_ci_cd_setting_changes_auditor.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/auth/ldap/sync/group.rb' - 'ee/lib/ee/gitlab/auth/o_auth/user.rb' @@ -586,7 +558,6 @@ Style/GuardClause: - 'lib/gitlab/gitaly_client/blobs_stitcher.rb' - 'lib/gitlab/gitaly_client/conflicts_service.rb' - 'lib/gitlab/gitaly_client/operation_service.rb' - - 'lib/gitlab/gitaly_client/wiki_service.rb' - 'lib/gitlab/github_import.rb' - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' @@ -596,7 +567,6 @@ Style/GuardClause: - 'lib/gitlab/gitlab_import/client.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - - 'lib/gitlab/i18n/metadata_entry.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' - 'lib/gitlab/import_export/base/object_builder.rb' @@ -616,7 +586,6 @@ Style/GuardClause: - 'lib/gitlab/legacy_github_import/client.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/marginalia.rb' - - 'lib/gitlab/memory/watchdog.rb' - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' - 'lib/gitlab/metrics/subscribers/action_cable.rb' - 'lib/gitlab/metrics/subscribers/active_record.rb' @@ -659,7 +628,6 @@ Style/GuardClause: - 'lib/gitlab/utils/override.rb' - 'lib/gitlab/webpack/manifest.rb' - 'lib/mattermost/session.rb' - - 'lib/release_highlights/validator/entry.rb' - 'lib/safe_zip/entry.rb' - 'lib/service_ping/devops_report.rb' - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' @@ -670,7 +638,6 @@ Style/GuardClause: - 'qa/qa/ee/resource/license.rb' - 'qa/qa/mobile/page/main/menu.rb' - 'qa/qa/mobile/page/sub_menus/common.rb' - - 'qa/qa/page/base.rb' - 'qa/qa/page/component/invite_members_modal.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/component/snippet.rb' @@ -679,7 +646,6 @@ Style/GuardClause: - 'qa/qa/page/project/settings/deploy_tokens.rb' - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/package.rb' - - 'qa/qa/resource/project.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/reusable.rb' - 'qa/qa/resource/user_gpg.rb' @@ -688,20 +654,15 @@ Style/GuardClause: - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/group_file_template_spec.rb' - 'qa/qa/specs/helpers/feature_flag.rb' - 'qa/qa/vendor/jenkins/job.rb' - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' - - 'rubocop/cop/gitlab/finder_with_find_by.rb' - - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - 'rubocop/cop/gitlab/policy_rule_boolean.rb' - 'rubocop/cop/ignored_columns.rb' - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - - 'rubocop/cop/migration/update_column_in_batches.rb' - 'rubocop/cop/rspec/web_mock_enable.rb' - - 'rubocop/cop/usage_data/histogram_with_large_table.rb' - 'rubocop/cop/usage_data/large_table.rb' - 'rubocop/routes_under_scope.rb' - 'scripts/lint_templates_bash.rb' diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml index aa22e9ed82b..911ed2f02c4 100644 --- a/.rubocop_todo/style/hash_as_last_array_item.yml +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -1,11 +1,10 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/HashAsLastArrayItem: Exclude: - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/admin/groups_controller.rb' - 'app/controllers/admin/users_controller.rb' - - 'app/controllers/boards/issues_controller.rb' - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/concerns/issuable_collections.rb' - 'app/controllers/profiles_controller.rb' @@ -17,7 +16,6 @@ Style/HashAsLastArrayItem: - 'app/controllers/projects/settings/operations_controller.rb' - 'app/controllers/projects_controller.rb' - 'app/graphql/resolvers/clusters/agents_resolver.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/types/boards/board_issuable_input_base_type.rb' - 'app/graphql/types/boards/board_issue_input_base_type.rb' - 'app/helpers/namespaces_helper.rb' @@ -35,7 +33,6 @@ Style/HashAsLastArrayItem: - 'ee/app/controllers/ee/admin/groups_controller.rb' - 'ee/app/controllers/ee/admin/users_controller.rb' - 'ee/app/controllers/groups/epics_controller.rb' - - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - 'ee/app/graphql/types/epics/negated_epic_filter_input_type.rb' - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/vulnerability.rb' @@ -43,7 +40,6 @@ Style/HashAsLastArrayItem: - 'ee/app/serializers/dashboard_environments_serializer.rb' - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/needs_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/container_repository_updated_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'lib/api/entities/project.rb' diff --git a/.rubocop_todo/style/hash_each_methods.yml b/.rubocop_todo/style/hash_each_methods.yml index cebfe5c0c7d..41e6c4608cc 100644 --- a/.rubocop_todo/style/hash_each_methods.yml +++ b/.rubocop_todo/style/hash_each_methods.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/HashEachMethods: Exclude: - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' @@ -52,7 +52,6 @@ Style/HashEachMethods: - 'ee/spec/helpers/application_helper_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' - 'lib/api/todos.rb' - - 'lib/backup/manager.rb' - 'lib/gitlab/changelog/release.rb' - 'lib/gitlab/ci/parsers.rb' - 'lib/gitlab/ci/reports/test_suite.rb' @@ -60,16 +59,12 @@ Style/HashEachMethods: - 'lib/gitlab/metrics/subscribers/active_record.rb' - 'lib/gitlab/metrics/subscribers/load_balancing.rb' - 'lib/gitlab/middleware/multipart.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - - 'lib/gitlab/usage_data.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/factories/ci/reports/codequality_degradations.rb' - 'spec/finders/packages/group_packages_finder_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' - 'spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb' - - 'spec/lib/gitlab/usage_data_spec.rb' - - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' - 'spec/models/ci/resource_group_spec.rb' - 'spec/models/clusters/cluster_spec.rb' diff --git a/.rubocop_todo/style/if_inside_else.yml b/.rubocop_todo/style/if_inside_else.yml deleted file mode 100644 index 40b71d7de04..00000000000 --- a/.rubocop_todo/style/if_inside_else.yml +++ /dev/null @@ -1,48 +0,0 @@ ---- -Style/IfInsideElse: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/controllers/passwords_controller.rb' - - 'app/finders/projects_finder.rb' - - 'app/helpers/diff_helper.rb' - - 'app/helpers/issuables_helper.rb' - - 'app/helpers/members_helper.rb' - - 'app/helpers/search_helper.rb' - - 'app/models/namespace.rb' - - 'app/presenters/project_presenter.rb' - - 'app/services/system_notes/commit_service.rb' - - 'app/services/task_list_toggle_service.rb' - - 'app/services/user_project_access_changed_service.rb' - - 'app/uploaders/gitlab_uploader.rb' - - 'config/settings.rb' - - 'ee/app/controllers/ee/registrations/welcome_controller.rb' - - 'ee/app/controllers/groups/omniauth_callbacks_controller.rb' - - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/iterations/cadence.rb' - - 'ee/app/models/protected_environments/authorizable.rb' - - 'ee/app/policies/ee/group_policy.rb' - - 'ee/app/services/app_sec/dast/site_profiles/audit/update_service.rb' - - 'ee/app/services/deployments/approval_service.rb' - - 'ee/app/services/geo/framework_repository_sync_service.rb' - - 'ee/app/services/geo/repository_base_sync_service.rb' - - 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb' - - 'ee/app/services/vulnerability_external_issue_links/create_service.rb' - - 'ee/app/workers/elastic/project_transfer_worker.rb' - - 'ee/app/workers/project_import_schedule_worker.rb' - - 'ee/lib/gitlab/geo/base_batcher.rb' - - 'lib/api/projects.rb' - - 'lib/gitlab/auth.rb' - - 'lib/gitlab/conflict/file.rb' - - 'lib/gitlab/sql/pattern.rb' - - 'lib/gitlab/usage/service_ping/payload_keys_processor.rb' - - 'lib/service_ping/build_payload.rb' - - 'lib/tasks/gitlab/cleanup.rake' - - 'lib/tasks/gitlab/shell.rake' - - 'qa/qa/resource/protected_branch.rb' - - 'qa/qa/specs/helpers/feature_flag.rb' - - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - - 'scripts/review_apps/automated_cleanup.rb' - - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' - - 'spec/support/import_export/export_file_helper.rb' - - 'spec/support/shared_examples/finders/snippet_visibility_shared_examples.rb' - - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index fc05a8bc163..5804fda39e1 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -1,26 +1,7 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/IfUnlessModifier: Exclude: - - 'app/channels/graphql_channel.rb' - - 'app/controllers/admin/application_settings_controller.rb' - - 'app/controllers/admin/projects_controller.rb' - - 'app/controllers/admin/users_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/controllers/concerns/controller_with_cross_project_access_check.rb' - - 'app/controllers/concerns/cycle_analytics_params.rb' - - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/concerns/issuable_collections.rb' - - 'app/controllers/concerns/issues_calendar.rb' - - 'app/controllers/concerns/labels_as_hash.rb' - - 'app/controllers/concerns/metrics/dashboard/prometheus_api_proxy.rb' - - 'app/controllers/concerns/metrics_dashboard.rb' - - 'app/controllers/concerns/notes_actions.rb' - - 'app/controllers/concerns/oauth_applications.rb' - - 'app/controllers/concerns/paginated_collection.rb' - - 'app/controllers/concerns/record_user_last_activity.rb' - - 'app/controllers/concerns/sorting_preference.rb' - 'app/controllers/concerns/uploads_actions.rb' - 'app/controllers/concerns/verifies_with_email.rb' - 'app/controllers/concerns/wiki_actions.rb' @@ -31,7 +12,6 @@ Style/IfUnlessModifier: - 'app/controllers/groups_controller.rb' - 'app/controllers/import/fogbugz_controller.rb' - 'app/controllers/import/gitea_controller.rb' - - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' @@ -43,7 +23,6 @@ Style/IfUnlessModifier: - 'app/controllers/projects/branches_controller.rb' - 'app/controllers/projects/commits_controller.rb' - 'app/controllers/projects/cycle_analytics_controller.rb' - - 'app/controllers/projects/deploy_keys_controller.rb' - 'app/controllers/projects/design_management/designs_controller.rb' - 'app/controllers/projects/imports_controller.rb' - 'app/controllers/projects/issues_controller.rb' @@ -93,7 +72,6 @@ Style/IfUnlessModifier: - 'app/graphql/mutations/todos/mark_all_done.rb' - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/project_pipeline_resolver.rb' - 'app/graphql/resolvers/timelog_resolver.rb' @@ -189,14 +167,10 @@ Style/IfUnlessModifier: - 'app/models/grafana_integration.rb' - 'app/models/group.rb' - 'app/models/integrations/asana.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/datadog.rb' - - 'app/models/integrations/harbor.rb' - - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pushover.rb' - - 'app/models/integrations/teamcity.rb' - 'app/models/issue.rb' - 'app/models/issue_email_participant.rb' - 'app/models/label_note.rb' @@ -259,7 +233,6 @@ Style/IfUnlessModifier: - 'app/services/boards/lists/base_create_service.rb' - 'app/services/boards/lists/list_service.rb' - 'app/services/branches/validate_new_service.rb' - - 'app/services/ci/create_pipeline_service.rb' - 'app/services/ci/create_web_ide_terminal_service.rb' - 'app/services/ci/job_token_scope/remove_project_service.rb' - 'app/services/ci/parse_dotenv_artifact_service.rb' @@ -271,7 +244,6 @@ Style/IfUnlessModifier: - 'app/services/ci/runners/register_runner_service.rb' - 'app/services/ci/update_build_state_service.rb' - 'app/services/clusters/applications/base_service.rb' - - 'app/services/clusters/applications/prometheus_update_service.rb' - 'app/services/clusters/aws/fetch_credentials_service.rb' - 'app/services/clusters/gcp/provision_service.rb' - 'app/services/clusters/update_service.rb' @@ -292,13 +264,11 @@ Style/IfUnlessModifier: - 'app/services/error_tracking/collect_error_service.rb' - 'app/services/git/process_ref_changes_service.rb' - 'app/services/google_cloud/generate_pipeline_service.rb' - - 'app/services/google_cloud/setup_cloudsql_instance_service.rb' - 'app/services/groups/create_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/groups/update_statistics_service.rb' - 'app/services/ide/base_config_service.rb' - 'app/services/import/bitbucket_server_service.rb' - - 'app/services/import/github_service.rb' - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/issuable/bulk_update_service.rb' - 'app/services/issuable/common_system_notes_service.rb' @@ -368,12 +338,10 @@ Style/IfUnlessModifier: - 'app/services/spam/spam_verdict_service.rb' - 'app/services/system_notes/issuables_service.rb' - 'app/services/tags/destroy_service.rb' - - 'app/services/two_factor/destroy_service.rb' - 'app/services/users/approve_service.rb' - 'app/services/users/build_service.rb' - 'app/services/users/respond_to_terms_service.rb' - 'app/services/wikis/create_attachment_service.rb' - - 'app/services/work_items/create_service.rb' - 'app/services/work_items/parent_links/create_service.rb' - 'app/services/work_items/task_list_reference_removal_service.rb' - 'app/services/work_items/task_list_reference_replacement_service.rb' @@ -382,7 +350,6 @@ Style/IfUnlessModifier: - 'app/validators/abstract_path_validator.rb' - 'app/validators/addressable_url_validator.rb' - 'app/validators/any_field_validator.rb' - - 'app/validators/branch_filter_validator.rb' - 'app/validators/certificate_key_validator.rb' - 'app/validators/certificate_validator.rb' - 'app/validators/cluster_name_validator.rb' @@ -399,9 +366,7 @@ Style/IfUnlessModifier: - 'app/workers/concerns/application_worker.rb' - 'app/workers/concerns/packages/cleanup_artifact_worker.rb' - 'app/workers/concerns/project_start_import.rb' - - 'app/workers/concerns/waitable_worker.rb' - 'app/workers/concerns/worker_attributes.rb' - - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/delete_container_repository_worker.rb' - 'app/workers/file_hook_worker.rb' - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' @@ -427,10 +392,8 @@ Style/IfUnlessModifier: - 'config/initializers/google_api_client_patch.rb' - 'config/initializers/jira.rb' - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' - - 'config/initializers/load_balancing.rb' - 'config/initializers/remove_active_job_execute_callback.rb' - 'config/initializers/seed_fu.rb' - - 'config/initializers/sidekiq.rb' - 'config/initializers/stackprof.rb' - 'config/initializers/validate_database_config.rb' - 'config/initializers_before_autoloader/002_sidekiq.rb' @@ -477,15 +440,12 @@ Style/IfUnlessModifier: - 'ee/app/controllers/projects/push_rules_controller.rb' - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/controllers/trials_controller.rb' - - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/merge_trains_finder.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/destroy.rb' - 'ee/app/graphql/mutations/boards/scoped_board_mutation.rb' - - 'ee/app/graphql/mutations/dast_site_profiles/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver.rb' @@ -598,8 +558,6 @@ Style/IfUnlessModifier: - 'ee/app/services/geo/metrics_update_service.rb' - 'ee/app/services/geo/move_repository_service.rb' - 'ee/app/services/geo/prune_event_log_service.rb' - - 'ee/app/services/geo/repository_verification_primary_service.rb' - - 'ee/app/services/geo/repository_verification_secondary_service.rb' - 'ee/app/services/gitlab_subscriptions/plan_upgrade_service.rb' - 'ee/app/services/groups/memberships/export_service.rb' - 'ee/app/services/groups/update_repository_storage_service.rb' @@ -659,9 +617,7 @@ Style/IfUnlessModifier: - 'ee/lib/ee/api/helpers/variables_helpers.rb' - 'ee/lib/ee/api/internal/base.rb' - 'ee/lib/ee/api/merge_request_approvals.rb' - - 'ee/lib/ee/api/protected_branches.rb' - 'ee/lib/ee/api/settings.rb' - - 'ee/lib/ee/audit/project_changes_auditor.rb' - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/container_registry/client.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' @@ -740,7 +696,6 @@ Style/IfUnlessModifier: - 'ee/spec/support/helpers/feature_approval_helper.rb' - 'ee/spec/support/helpers/search_results_helpers.rb' - 'ee/spec/support/http_io/http_io_helpers.rb' - - 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb' - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - 'lib/api/api_guard.rb' @@ -865,7 +820,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/ci/config/extendable/entry.rb' - 'lib/gitlab/ci/config/external/file/base.rb' - 'lib/gitlab/ci/config/external/file/template.rb' - - 'lib/gitlab/ci/config/external/mapper.rb' - 'lib/gitlab/ci/config/normalizer.rb' - 'lib/gitlab/ci/parsers/coverage/sax_document.rb' - 'lib/gitlab/ci/parsers/security/common.rb' @@ -1023,7 +977,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/template_parser/eval_state.rb' - 'lib/gitlab/untrusted_regexp.rb' - 'lib/gitlab/url_blocker.rb' - - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data_counters/base_counter.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - 'lib/gitlab/utils.rb' @@ -1055,7 +1008,6 @@ Style/IfUnlessModifier: - 'lib/tasks/gitlab/storage.rake' - 'lib/tasks/gitlab/update_templates.rake' - 'qa/qa/ee/resource/settings/elasticsearch.rb' - - 'qa/qa/flow/sign_up.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/component/snippet.rb' - 'qa/qa/page/element.rb' @@ -1080,7 +1032,6 @@ Style/IfUnlessModifier: - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - - 'qa/qa/support/loglinking.rb' - 'qa/qa/tools/delete_projects.rb' - 'qa/qa/tools/delete_user_projects.rb' - 'qa/qa/tools/generate_perf_testdata.rb' @@ -1125,7 +1076,6 @@ Style/IfUnlessModifier: - 'spec/helpers/invite_members_helper_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb' - 'spec/lib/gitlab/config/entry/validators/nested_array_helpers_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' @@ -1148,10 +1098,8 @@ Style/IfUnlessModifier: - 'spec/requests/api/integrations_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/import_routing_spec.rb' - - 'spec/rubocop_spec_helper.rb' - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - - 'spec/services/clusters/applications/create_service_spec.rb' - 'spec/services/git/process_ref_changes_service_spec.rb' - 'spec/services/members/destroy_service_spec.rb' - 'spec/services/notification_recipients/builder/default_spec.rb' @@ -1162,7 +1110,6 @@ Style/IfUnlessModifier: - 'spec/services/projects/create_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/capybara.rb' - - 'spec/support/database/multiple_databases.rb' - 'spec/support/external_authorization_service_helpers.rb' - 'spec/support/flaky_tests.rb' - 'spec/support/generate-seed-repo-rb' diff --git a/.rubocop_todo/style/keyword_parameters_order.yml b/.rubocop_todo/style/keyword_parameters_order.yml index ca6cb416b93..3730a86221e 100644 --- a/.rubocop_todo/style/keyword_parameters_order.yml +++ b/.rubocop_todo/style/keyword_parameters_order.yml @@ -1,30 +1,7 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/KeywordParametersOrder: Exclude: - - 'app/controllers/concerns/product_analytics_tracking.rb' - - 'app/finders/group_descendants_finder.rb' - - 'app/finders/merge_request_target_project_finder.rb' - - 'app/graphql/resolvers/package_pipelines_resolver.rb' - - 'app/helpers/timeboxes_helper.rb' - - 'app/models/concerns/sortable.rb' - - 'app/services/clusters/kubernetes/create_or_update_service_account_service.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/file_upload.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3.rb' - - 'app/services/issues/create_service.rb' - - 'app/services/merge_requests/push_options_handler_service.rb' - - 'app/services/snippets/create_service.rb' - - 'app/services/work_items/create_and_link_service.rb' - - 'app/services/work_items/create_from_task_service.rb' - - 'app/services/work_items/create_service.rb' - - 'app/services/work_items/delete_task_service.rb' - - 'ee/app/graphql/mutations/dast/profiles/create.rb' - - 'ee/app/graphql/mutations/dast_scanner_profiles/create.rb' - - 'ee/app/graphql/mutations/dast_site_profiles/update.rb' - - 'ee/app/models/license.rb' - - 'ee/app/models/requirements_management/test_report.rb' - - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/bulk_find_or_create_service.rb' - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/create_service.rb' - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service.rb' - 'ee/app/services/audit_events/user_impersonation_group_audit_event_service.rb' @@ -46,30 +23,3 @@ Style/KeywordParametersOrder: - 'lib/gitlab/merge_requests/mergeability/results_store.rb' - 'lib/gitlab/usage_data_counters/editor_unique_counter.rb' - 'lib/microsoft_teams/notifier.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - - 'qa/spec/runtime/env_spec.rb' - - 'spec/graphql/types/ci/pipeline_counts_type_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/lib/gitlab/database/partitioning/detached_partition_dropper_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20220106111958_add_insert_or_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112043_add_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112085_add_update_vulnerability_reads_location_trigger_spec.rb' - - 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/migrations/confirm_support_bot_user_spec.rb' - - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - - 'spec/support/helpers/doc_url_helper.rb' - - 'spec/support/helpers/smime_helper.rb' - - 'spec/support/helpers/workhorse_helpers.rb' - - 'spec/support/shared_examples/projects/container_repository/cleanup_tags_service_shared_examples.rb' - - 'spec/support/shared_examples/services/container_expiration_policy_shared_examples.rb' - - 'spec/support/shared_examples/services/dependency_proxy_ttl_policies_shared_examples.rb' - - 'spec/support/shared_examples/services/namespace_package_settings_shared_examples.rb' - - 'spec/tasks/gitlab/usage_data_rake_spec.rb' - - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' diff --git a/.rubocop_todo/style/lambda.yml b/.rubocop_todo/style/lambda.yml index f37c2c4967e..e1c297ac5f6 100644 --- a/.rubocop_todo/style/lambda.yml +++ b/.rubocop_todo/style/lambda.yml @@ -49,7 +49,6 @@ Style/Lambda: - 'lib/gitlab/action_cable/request_store_callbacks.rb' - 'lib/gitlab/checks/diff_check.rb' - 'lib/gitlab/database/load_balancing/action_cable_callbacks.rb' - - 'lib/gitlab/memory/watchdog/configurator.rb' - 'lib/gitlab/middleware/rack_multipart_tempfile_factory.rb' - 'lib/gitlab/omniauth_initializer.rb' - 'lib/gitlab/prometheus/queries/query_additional_metrics.rb' @@ -57,7 +56,6 @@ Style/Lambda: - 'lib/gitlab/sidekiq_config/worker_matcher.rb' - 'lib/gitlab/sidekiq_middleware.rb' - 'lib/gitlab/utils/usage_data.rb' - - 'qa/qa/page/base.rb' - 'qa/qa/runtime/allure_report.rb' - 'qa/qa/specs/features/api/1_manage/import/import_large_github_repo_spec.rb' - 'qa/qa/support/api.rb' diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml index 295aa2f6878..6800ba2baf3 100644 --- a/.rubocop_todo/style/next.yml +++ b/.rubocop_todo/style/next.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/Next: Exclude: - 'lib/gitlab/fogbugz_import/importer.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index 4e8b608e424..0060919d7b6 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/NumericLiteralPrefix: Exclude: - 'app/models/container_repository.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index bac2e807053..2f042829e35 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -1,31 +1,8 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/PercentLiteralDelimiters: Exclude: - 'Guardfile' - - 'app/controllers/abuse_reports_controller.rb' - - 'app/controllers/admin/application_settings_controller.rb' - - 'app/controllers/admin/broadcast_messages_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/controllers/concerns/impersonation.rb' - - 'app/controllers/concerns/oauth_applications.rb' - - 'app/controllers/concerns/uploads_actions.rb' - - 'app/controllers/groups_controller.rb' - - 'app/controllers/import/bulk_imports_controller.rb' - - 'app/controllers/import/fogbugz_controller.rb' - - 'app/controllers/import/gitea_controller.rb' - - 'app/controllers/jira_connect/app_descriptor_controller.rb' - - 'app/controllers/jira_connect/subscriptions_controller.rb' - - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' - - 'app/controllers/projects/product_analytics_controller.rb' - - 'app/controllers/projects/service_desk_controller.rb' - - 'app/controllers/repositories/lfs_locks_api_controller.rb' - - 'app/finders/group_members_finder.rb' - - 'app/finders/members_finder.rb' - - 'app/finders/notes_finder.rb' - - 'app/finders/todos_finder.rb' - - 'app/helpers/application_helper.rb' - 'app/helpers/auth_helper.rb' - 'app/helpers/ci/variables_helper.rb' - 'app/helpers/clusters_helper.rb' @@ -33,7 +10,6 @@ Style/PercentLiteralDelimiters: - 'app/helpers/diff_helper.rb' - 'app/helpers/emails_helper.rb' - 'app/helpers/external_link_helper.rb' - - 'app/helpers/icons_helper.rb' - 'app/helpers/labels_helper.rb' - 'app/helpers/markup_helper.rb' - 'app/helpers/nav_helper.rb' @@ -82,7 +58,6 @@ Style/PercentLiteralDelimiters: - 'app/models/concerns/clusters/agents/authorization_config_scopes.rb' - 'app/models/concerns/diff_positionable_note.rb' - 'app/models/concerns/enums/prometheus_metric.rb' - - 'app/models/concerns/integrations/base_data_fields.rb' - 'app/models/concerns/issuable.rb' - 'app/models/concerns/issue_available_features.rb' - 'app/models/concerns/mentionable/reference_regexes.rb' @@ -112,7 +87,6 @@ Style/PercentLiteralDelimiters: - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/external_wiki.rb' - 'app/models/integrations/field.rb' - - 'app/models/integrations/flowdock.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/packagist.rb' @@ -159,13 +133,11 @@ Style/PercentLiteralDelimiters: - 'app/services/import_export_clean_up_service.rb' - 'app/services/incident_management/pager_duty/process_webhook_service.rb' - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/issues/export_csv_service.rb' - 'app/services/merge_requests/update_service.rb' - 'app/services/metrics/dashboard/default_embed_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - 'app/services/preview_markdown_service.rb' - 'app/services/projects/apple_target_platform_detector_service.rb' - - 'app/services/projects/container_repository/cleanup_tags_service.rb' - 'app/services/projects/download_service.rb' - 'app/services/projects/hashed_storage/migrate_attachments_service.rb' - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' @@ -201,7 +173,6 @@ Style/PercentLiteralDelimiters: - 'config/initializers/invisible_captcha.rb' - 'config/initializers/lograge.rb' - 'config/initializers/rspec_profiling.rb' - - 'config/initializers/sidekiq.rb' - 'config/initializers_before_autoloader/000_inflections.rb' - 'config/object_store_settings.rb' - 'config/spring.rb' @@ -269,7 +240,6 @@ Style/PercentLiteralDelimiters: - 'ee/app/models/geo_node_status.rb' - 'ee/app/models/incident_management/issuable_resource_link.rb' - 'ee/app/models/integrations/github.rb' - - 'ee/app/models/integrations/gitlab_slack_application.rb' - 'ee/app/models/merge_requests/status_check_response.rb' - 'ee/app/models/saml_provider.rb' - 'ee/app/models/security/orchestration_policy_configuration.rb' @@ -285,7 +255,6 @@ Style/PercentLiteralDelimiters: - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/iterations/update_service.rb' - 'ee/app/services/jira/jql_builder_service.rb' - - 'ee/app/services/requirements_management/export_csv_service.rb' - 'ee/app/services/security/configuration/save_auto_fix_service.rb' - 'ee/app/services/security/dependency_list_service.rb' - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb' @@ -296,7 +265,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/ee/api/helpers/projects_helpers.rb' - 'ee/lib/ee/api/members.rb' - 'ee/lib/ee/api/search.rb' - - 'ee/lib/ee/audit/group_changes_auditor.rb' - 'ee/lib/ee/gitlab/alert_management/payload/generic.rb' - 'ee/lib/ee/gitlab/auth/ldap/adapter.rb' - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' @@ -306,7 +274,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/ee/gitlab/etag_caching/router/rails.rb' - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' - 'ee/lib/ee/gitlab/path_regex.rb' - - 'ee/lib/ee/gitlab/uploads/migration_helper.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/elastic/class_proxy_util.rb' - 'ee/lib/elastic/latest/config.rb' @@ -315,8 +282,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/elastic/latest/project_instance_proxy.rb' - 'ee/lib/elastic/latest/snippet_class_proxy.rb' - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' - - 'ee/lib/gitlab/ci/parsers/security/formatters/dast.rb' - - 'ee/lib/gitlab/geo.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' - 'ee/lib/tasks/gitlab/elastic/test.rake' @@ -339,7 +304,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/features/projects/environments/environments_spec.rb' - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - 'ee/spec/features/projects/settings/protected_environments_spec.rb' - - 'ee/spec/features/protected_branches_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' - 'ee/spec/frontend/fixtures/saml_providers.rb' @@ -347,7 +311,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/graphql/ee/types/boards/board_issue_input_type_spec.rb' - 'ee/spec/graphql/mutations/boards/update_spec.rb' - 'ee/spec/graphql/resolvers/board_groupings/epics_resolvers_spec.rb' - - 'ee/spec/graphql/resolvers/epics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/pipeline_security_report_findings_resolver_spec.rb' - 'ee/spec/graphql/types/dast/profile_cadence_enum_spec.rb' - 'ee/spec/graphql/types/dast/scan_method_type_enum_spec.rb' @@ -439,7 +402,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/policies/group_policy_spec.rb' - 'ee/spec/policies/project_policy_spec.rb' - 'ee/spec/presenters/merge_request_approver_presenter_spec.rb' - - 'ee/spec/presenters/merge_request_presenter_spec.rb' - 'ee/spec/requests/admin/user_permission_exports_controller_spec.rb' - 'ee/spec/requests/api/dependencies_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' @@ -483,7 +445,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/validators/json_schema_validator_spec.rb' - 'ee/spec/views/operations/index.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/project_access_tokens/_project_access_token.html.haml_spec.rb' - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb' - 'ee/spec/workers/project_cache_worker_spec.rb' - 'ee/spec/workers/repository_import_worker_spec.rb' @@ -523,7 +484,6 @@ Style/PercentLiteralDelimiters: - 'lib/bitbucket/representation/issue.rb' - 'lib/container_registry/path.rb' - 'lib/feature.rb' - - 'lib/flowdock/git/builder.rb' - 'lib/generators/gitlab/usage_metric_definition_generator.rb' - 'lib/generators/gitlab/usage_metric_generator.rb' - 'lib/gitlab.rb' @@ -591,11 +551,9 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/sanitizers/exif.rb' - 'lib/gitlab/search/abuse_detection.rb' - 'lib/gitlab/search_context.rb' - - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - 'lib/gitlab/slash_commands/presenters/base.rb' - 'lib/gitlab/ssh_public_key.rb' - 'lib/gitlab/task_helpers.rb' - - 'lib/gitlab/uploads/migration_helper.rb' - 'lib/gitlab/url_blocker.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb' - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' @@ -626,7 +584,6 @@ Style/PercentLiteralDelimiters: - 'qa/qa/ee/page/project/issue/show.rb' - 'qa/qa/ee/page/project/job/show.rb' - 'qa/qa/ee/page/project/packages/index.rb' - - 'qa/qa/ee/page/project/pipeline/show.rb' - 'qa/qa/ee/page/project/show.rb' - 'qa/qa/ee/page/project/snippet/index.rb' - 'qa/qa/ee/page/project/wiki/show.rb' @@ -635,7 +592,6 @@ Style/PercentLiteralDelimiters: - 'qa/qa/resource/visibility.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/service/praefect_manager.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_repo_sync_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' @@ -704,7 +660,6 @@ Style/PercentLiteralDelimiters: - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/pipelines/pipelines_spec.rb' - - 'spec/features/protected_branches_spec.rb' - 'spec/features/tags/developer_views_tags_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/finders/alert_management/alerts_finder_spec.rb' @@ -742,7 +697,6 @@ Style/PercentLiteralDelimiters: - 'spec/helpers/page_layout_helper_spec.rb' - 'spec/helpers/profiles_helper_spec.rb' - 'spec/helpers/releases_helper_spec.rb' - - 'spec/helpers/storage_helper_spec.rb' - 'spec/helpers/tracking_helper_spec.rb' - 'spec/initializers/direct_upload_support_spec.rb' - 'spec/initializers/enumerator_next_patch_spec.rb' @@ -814,7 +768,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/ci/pipeline/chain/template_usage_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/equals_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/deployment_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb' - 'spec/lib/gitlab/ci/reports/security/reports_spec.rb' @@ -1083,7 +1036,6 @@ Style/PercentLiteralDelimiters: - 'spec/requests/api/task_completion_status_spec.rb' - 'spec/requests/api/unleash_spec.rb' - 'spec/requests/api/users_spec.rb' - - 'spec/requests/api/version_spec.rb' - 'spec/requests/api/wikis_spec.rb' - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jwt_controller_spec.rb' @@ -1111,7 +1063,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/ci/stuck_builds/drop_pending_service_spec.rb' - 'spec/services/ci/stuck_builds/drop_running_service_spec.rb' - 'spec/services/ci/stuck_builds/drop_scheduled_service_spec.rb' - - 'spec/services/clusters/applications/create_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/deployments/update_environment_service_spec.rb' - 'spec/services/design_management/copy_design_collection/copy_service_spec.rb' @@ -1137,7 +1088,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - 'spec/services/product_analytics/build_graph_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' - - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_link_service_spec.rb' - 'spec/services/projects/operations/update_service_spec.rb' - 'spec/services/projects/record_target_platforms_service_spec.rb' @@ -1191,7 +1141,6 @@ Style/PercentLiteralDelimiters: - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/tasks/gitlab/task_helpers_spec.rb' - - 'spec/tasks/gitlab/uploads/migrate_rake_spec.rb' - 'spec/tooling/danger/customer_success_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' @@ -1226,7 +1175,6 @@ Style/PercentLiteralDelimiters: - 'spec/workers/post_receive_spec.rb' - 'spec/workers/project_cache_worker_spec.rb' - 'spec/workers/projects/record_target_platforms_worker_spec.rb' - - 'spec/workers/repository_import_worker_spec.rb' - 'spec/workers/stuck_merge_jobs_worker_spec.rb' - 'spec/workers/update_project_statistics_worker_spec.rb' - 'tooling/danger/datateam.rb' diff --git a/.rubocop_todo/style/redundant_begin.yml b/.rubocop_todo/style/redundant_begin.yml index d2851de201b..8f490002fd6 100644 --- a/.rubocop_todo/style/redundant_begin.yml +++ b/.rubocop_todo/style/redundant_begin.yml @@ -1,56 +1,6 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantBegin: Exclude: - - 'app/controllers/concerns/membership_actions.rb' - 'app/controllers/concerns/metrics_dashboard.rb' - - 'app/controllers/concerns/renders_ldap_servers.rb' - - 'app/helpers/auth_helper.rb' - - 'app/models/event.rb' - - 'app/models/integrations/asana.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/user.rb' - - 'app/services/ci/register_job_service.rb' - - 'app/services/design_management/generate_image_versions_service.rb' - - 'app/services/error_tracking/list_projects_service.rb' - - 'app/services/issue_links/create_service.rb' - - 'app/services/merge_requests/assign_issues_service.rb' - - 'app/services/projects/batch_forks_count_service.rb' - - 'app/services/projects/batch_open_issues_count_service.rb' - - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - - 'app/services/users/update_highest_member_role_service.rb' - - 'ee/app/controllers/groups/sso_controller.rb' - - 'ee/app/finders/security/findings_finder.rb' - - 'ee/app/services/epics/epic_links/create_service.rb' - - 'ee/app/services/epics/related_epic_links/create_service.rb' - - 'ee/app/services/geo/container_repository_sync_service.rb' - - 'ee/app/validators/ee/json_schema_validator.rb' - - 'ee/lib/ee/api/helpers/award_emoji.rb' - 'ee/lib/gem_extensions/elasticsearch/model/adapter/multiple/records.rb' - - 'ee/lib/gitlab/ci/parsers/security/dast.rb' - - 'ee/lib/omni_auth/strategies/group_saml.rb' - - 'ee/lib/system_check/geo/authorized_keys_check.rb' - - 'lib/api/helpers/award_emoji.rb' - - 'lib/api/time_tracking_endpoints.rb' - - 'lib/atlassian/jira_connect/serializers/build_entity.rb' - - 'lib/backup/manager.rb' - - 'lib/banzai/pipeline/wiki_pipeline.rb' - - 'lib/gem_extensions/active_record/association.rb' - - 'lib/gitlab.rb' - - 'lib/gitlab/changes_list.rb' - - 'lib/gitlab/color.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/gitlab/database/schema_cache_with_renamed_table.rb' - - 'lib/gitlab/favicon.rb' - - 'lib/gitlab/import_export/base/relation_factory.rb' - - 'lib/gitlab/import_export/members_mapper.rb' - - 'lib/gitlab/import_export/project/tree_saver.rb' - - 'lib/gitlab/instrumentation/redis_interceptor.rb' - - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - - 'lib/gitlab/phabricator_import/project_creator.rb' - - 'lib/gitlab/project_search_results.rb' - - 'lib/gitlab/shell.rb' - - 'lib/gitlab/usage/metrics/aggregates/sources/calculations/intersection.rb' - - 'lib/sidebars/menu.rb' - - 'qa/qa/resource/api_fabricator.rb' - - 'qa/qa/runtime/api/client.rb' diff --git a/.rubocop_todo/style/redundant_condition.yml b/.rubocop_todo/style/redundant_condition.yml index 86be40f7ffa..c94a65c202c 100644 --- a/.rubocop_todo/style/redundant_condition.yml +++ b/.rubocop_todo/style/redundant_condition.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantCondition: Exclude: - 'ee/app/models/license.rb' diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml index ca7e01ffa61..b0d69cd2950 100644 --- a/.rubocop_todo/style/redundant_interpolation.yml +++ b/.rubocop_todo/style/redundant_interpolation.yml @@ -1,62 +1,7 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantInterpolation: Exclude: - - 'app/components/diffs/stats_component.rb' - - 'app/helpers/blob_helper.rb' - - 'app/helpers/ci/runners_helper.rb' - - 'app/helpers/commits_helper.rb' - - 'app/helpers/dropdowns_helper.rb' - - 'app/helpers/environments_helper.rb' - - 'app/helpers/icons_helper.rb' - - 'app/helpers/issuables_helper.rb' - - 'app/helpers/nav_helper.rb' - - 'app/helpers/projects_helper.rb' - - 'app/helpers/search_helper.rb' - - 'app/helpers/tooling/visual_review_helper.rb' - - 'app/models/concerns/issuable.rb' - - 'app/models/integrations/base_chat_notification.rb' - - 'app/models/integrations/hangouts_chat.rb' - - 'app/models/integrations/microsoft_teams.rb' - - 'app/models/integrations/pushover.rb' - - 'app/models/merge_request.rb' - - 'app/services/jira_import/start_import_service.rb' - - 'app/services/users/approve_service.rb' - - 'app/services/users/banned_user_base_service.rb' - - 'app/services/users/reject_service.rb' - - 'db/post_migrate/20220420214703_schedule_backfill_draft_status_on_merge_requests_corrected_regex.rb' - - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_reason_enum.rb' - - 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb' - - 'ee/app/helpers/ee/ci/runners_helper.rb' - - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/services/geo/event_store.rb' - - 'ee/app/services/geo/repository_updated_service.rb' - - 'ee/app/services/security/security_orchestration_policies/create_pipeline_service.rb' - - 'ee/app/services/users/abuse/excessive_projects_download_ban_service.rb' - - 'ee/app/services/users/abuse/git_abuse/namespace_throttle_service.rb' - - 'ee/db/fixtures/development/31_devops_adoption.rb' - - 'ee/lib/gitlab/insights/serializers/chartjs/base_serializer.rb' - - 'ee/spec/features/epics/epic_issues_spec.rb' - - 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb' - - 'ee/spec/features/registrations/one_trust_spec.rb' - - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' - - 'ee/spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - - 'ee/spec/lib/gitlab/insights/serializers/chartjs/line_serializer_spec.rb' - - 'ee/spec/lib/gitlab/insights/serializers/chartjs/multi_series_serializer_spec.rb' - - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb' - - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb' - - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb' - - 'ee/spec/requests/api/issues_spec.rb' - - 'ee/spec/requests/api/search_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - - 'ee/spec/services/search_service_spec.rb' - - 'ee/spec/services/timebox_report_service_spec.rb' - - 'ee/spec/support/shared_contexts/lib/gitlab/insights/serializers/serializers_shared_context.rb' - - 'ee/spec/support/shared_examples/lib/gitlab/elastic/standalone_indices_shared_examples.rb' - - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'lib/backup/manager.rb' - 'lib/backup/task.rb' - 'lib/gitlab/application_rate_limiter.rb' @@ -72,7 +17,6 @@ Style/RedundantInterpolation: - 'lib/gitlab/repository_cache_adapter.rb' - 'lib/gitlab/repository_hash_cache.rb' - 'lib/gitlab/repository_set_cache.rb' - - 'lib/gitlab/usage/metrics/names_suggestions/relation_parsers/constraints.rb' - 'lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - 'lib/gitlab/usage_data_counters/search_counter.rb' @@ -88,7 +32,6 @@ Style/RedundantInterpolation: - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/scan_result_policy_vulnerabilities_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/project_templates_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/parent_child_pipelines_dependent_relationship_spec.rb' - 'qa/qa/tools/generate_perf_testdata.rb' diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml deleted file mode 100644 index 1ca658776b8..00000000000 --- a/.rubocop_todo/style/redundant_parentheses.yml +++ /dev/null @@ -1,6 +0,0 @@ ---- -# Cop supports --auto-correct. -Style/RedundantParentheses: - Exclude: - - 'lib/gitlab/database/tables_truncate.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/utilization/billing_seats_usage_data_spec.rb' diff --git a/.rubocop_todo/style/redundant_regexp_escape.yml b/.rubocop_todo/style/redundant_regexp_escape.yml index 5c97275ee4b..22608a8e1f5 100644 --- a/.rubocop_todo/style/redundant_regexp_escape.yml +++ b/.rubocop_todo/style/redundant_regexp_escape.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantRegexpEscape: Exclude: - 'app/controllers/help_controller.rb' @@ -11,7 +11,6 @@ Style/RedundantRegexpEscape: - 'app/models/deploy_token.rb' - 'app/models/design_management/design.rb' - 'app/models/integrations/chat_message/base_message.rb' - - 'app/models/integrations/datadog.rb' - 'app/models/integrations/teamcity.rb' - 'app/models/issue.rb' - 'app/models/label.rb' @@ -23,7 +22,6 @@ Style/RedundantRegexpEscape: - 'app/models/snippet.rb' - 'app/services/metrics/dashboard/grafana_metric_embed_service.rb' - 'app/uploaders/file_uploader.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'config/routes/project.rb' - 'config/routes/uploads.rb' - 'ee/app/models/ee/epic.rb' @@ -60,7 +58,6 @@ Style/RedundantRegexpEscape: - 'lib/gitlab/git/repository.rb' - 'lib/gitlab/gitaly_client.rb' - 'lib/gitlab/harbor/query.rb' - - 'lib/gitlab/incoming_email.rb' - 'lib/gitlab/jira/dvcs.rb' - 'lib/gitlab/path_regex.rb' - 'lib/gitlab/private_commit_email.rb' @@ -68,7 +65,6 @@ Style/RedundantRegexpEscape: - 'lib/gitlab/quick_actions/extractor.rb' - 'lib/gitlab/regex.rb' - 'lib/gitlab/search/abuse_detection.rb' - - 'lib/gitlab/service_desk_email.rb' - 'lib/gitlab/task_helpers.rb' - 'lib/gitlab/url_sanitizer.rb' - 'lib/gitlab/utils.rb' @@ -78,40 +74,8 @@ Style/RedundantRegexpEscape: - 'lib/tasks/gettext.rake' - 'lib/tasks/gitlab/info.rake' - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/spec/runtime/key/ecdsa_spec.rb' - 'qa/spec/runtime/key/ed25519_spec.rb' - 'qa/spec/runtime/key/rsa_spec.rb' - - 'rubocop/cop/gitlab/finder_with_find_by.rb' - 'scripts/qa/testcases-check' - 'scripts/setup/find-jh-branch.rb' - - 'spec/controllers/projects_controller_spec.rb' - - 'spec/features/read_only_spec.rb' - - 'spec/helpers/tab_helper_spec.rb' - - 'spec/lib/banzai/filter/references/reference_filter_spec.rb' - - 'spec/lib/banzai/filter/syntax_highlight_filter_spec.rb' - - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_work_item_type_id_for_issues_spec.rb' - - 'spec/lib/gitlab/ci/config_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - - 'spec/lib/gitlab/import_export/saver_spec.rb' - - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - - 'spec/lib/gitlab/sql/pattern_spec.rb' - - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - - 'spec/mailers/emails/profile_spec.rb' - - 'spec/models/release_highlight_spec.rb' - - 'spec/requests/api/graphql/mutations/merge_requests/set_draft_spec.rb' - - 'spec/requests/api/graphql_spec.rb' - - 'spec/requests/api/project_debian_distributions_spec.rb' - - 'spec/requests/api/repositories_spec.rb' - - 'spec/services/projects/download_service_spec.rb' - - 'spec/support/matchers/exceed_query_limit.rb' - - 'spec/support/shared_examples/features/wiki/file_attachments_shared_examples.rb' - - 'spec/support/shared_examples/mailers/notify_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' - - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - - 'spec/uploaders/personal_file_uploader_spec.rb' - - 'spec/views/help/index.html.haml_spec.rb' - - 'tooling/danger/project_helper.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 8c688dc89c1..ec9aaac85dc 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/RedundantSelf: Exclude: - 'app/channels/awareness_channel.rb' @@ -71,7 +71,6 @@ Style/RedundantSelf: - 'app/models/concerns/mentionable.rb' - 'app/models/concerns/merge_request_reviewer_state.rb' - 'app/models/concerns/noteable.rb' - - 'app/models/concerns/packages/debian/distribution.rb' - 'app/models/concerns/participable.rb' - 'app/models/concerns/pg_full_text_searchable.rb' - 'app/models/concerns/protected_ref.rb' @@ -112,7 +111,6 @@ Style/RedundantSelf: - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' - - 'app/models/integrations/slack.rb' - 'app/models/integrations/zentao.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' @@ -190,7 +188,6 @@ Style/RedundantSelf: - 'config/initializers/active_record_keyset_pagination.rb' - 'config/initializers/forbid_sidekiq_in_transactions.rb' - 'config/initializers/mail_encoding_patch.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'db/post_migrate/20210329102724_add_new_trail_plans.rb' - 'db/post_migrate/20211029102822_add_open_source_plan.rb' - 'ee/app/graphql/resolvers/geo/registries_resolver.rb' @@ -223,7 +220,6 @@ Style/RedundantSelf: - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/member.rb' - - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/packages/package_file.rb' - 'ee/app/models/ee/project.rb' @@ -420,7 +416,6 @@ Style/RedundantSelf: - 'qa/qa/resource/user_gpg.rb' - 'qa/qa/runtime/release.rb' - 'qa/qa/scenario/bootable.rb' - - 'qa/qa/scenario/test/instance.rb' - 'sidekiq_cluster/sidekiq_cluster.rb' - 'spec/graphql/resolvers/group_labels_resolver_spec.rb' - 'spec/helpers/emails_helper_spec.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index a85039a45f5..8d35373a2c0 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/SingleArgumentDig: Exclude: - 'app/graphql/resolvers/namespace_projects_resolver.rb' @@ -38,7 +38,6 @@ Style/SingleArgumentDig: - 'lib/gitlab/auth/o_auth/auth_hash.rb' - 'lib/gitlab/ci/badge/coverage/template.rb' - 'lib/gitlab/ci/badge/template.rb' - - 'lib/gitlab/ci/lint.rb' - 'lib/gitlab/ci/parsers/accessibility/pa11y.rb' - 'lib/gitlab/ci/parsers/security/common.rb' - 'lib/gitlab/ci/reports/codequality_reports.rb' diff --git a/.rubocop_todo/style/sole_nested_conditional.yml b/.rubocop_todo/style/sole_nested_conditional.yml index 3c663b5f89a..20b70d36ce2 100644 --- a/.rubocop_todo/style/sole_nested_conditional.yml +++ b/.rubocop_todo/style/sole_nested_conditional.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/SoleNestedConditional: Exclude: - 'app/controllers/admin/application_settings_controller.rb' @@ -24,7 +24,6 @@ Style/SoleNestedConditional: - 'app/services/projects/create_service.rb' - 'app/services/projects/hashed_storage/migration_service.rb' - 'app/services/projects/hashed_storage/rollback_service.rb' - - 'app/workers/merge_requests/delete_source_branch_worker.rb' - 'ee/app/finders/ee/snippets_finder.rb' - 'ee/app/services/ee/issue_links/create_service.rb' - 'ee/app/services/ee/lfs/unlock_file_service.rb' @@ -39,7 +38,6 @@ Style/SoleNestedConditional: - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/elastic/latest/issue_class_proxy.rb' - 'ee/lib/gitlab/code_owners/groups_loader.rb' - - 'lib/api/ci/helpers/runner.rb' - 'lib/api/deploy_keys.rb' - 'lib/api/helpers/label_helpers.rb' - 'lib/api/maven_packages.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 65389d798d3..91eb45f73cf 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -1,24 +1,9 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/StringConcatenation: Exclude: - - 'app/components/pajamas/button_component.rb' - - 'app/controllers/concerns/creates_commit.rb' - - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' - - 'app/controllers/jira_connect/app_descriptor_controller.rb' - 'app/controllers/projects/labels_controller.rb' - 'app/controllers/projects/milestones_controller.rb' - - 'app/graphql/types/global_id_type.rb' - - 'app/helpers/application_helper.rb' - - 'app/helpers/blob_helper.rb' - - 'app/helpers/dropdowns_helper.rb' - - 'app/helpers/emails_helper.rb' - - 'app/helpers/events_helper.rb' - - 'app/helpers/numbers_helper.rb' - - 'app/helpers/submodule_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/models/application_setting.rb' - - 'app/models/commit_range.rb' - 'app/models/concerns/counter_attribute.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/concerns/from_set_operator.rb' @@ -66,7 +51,6 @@ Style/StringConcatenation: - 'ee/app/services/merge_requests/update_blocks_service.rb' - 'ee/app/workers/scan_security_report_secrets_worker.rb' - 'ee/lib/api/project_mirror.rb' - - 'ee/lib/ee/audit/project_changes_auditor.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' @@ -77,7 +61,6 @@ Style/StringConcatenation: - 'ee/lib/omni_auth/strategies/kerberos.rb' - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/lib/tasks/gitlab/license.rake' - - 'ee/spec/controllers/trial_registrations_controller_spec.rb' - 'ee/spec/features/boards/boards_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - 'ee/spec/helpers/search_helper_spec.rb' @@ -124,7 +107,6 @@ Style/StringConcatenation: - 'lib/gitlab/git.rb' - 'lib/gitlab/git/branch.rb' - 'lib/gitlab/git/tag.rb' - - 'lib/gitlab/git/wiki.rb' - 'lib/gitlab/github_import/importer/labels_importer.rb' - 'lib/gitlab/graphql/negatable_arguments.rb' - 'lib/gitlab/graphql/queries.rb' @@ -184,7 +166,6 @@ Style/StringConcatenation: - 'spec/features/projects/commits/user_browses_commits_spec.rb' - 'spec/features/projects/files/files_sort_submodules_with_folders_spec.rb' - 'spec/features/projects/import_export/import_file_spec.rb' - - 'spec/features/search/user_searches_for_code_spec.rb' - 'spec/finders/packages/go/module_finder_spec.rb' - 'spec/graphql/mutations/issues/create_spec.rb' - 'spec/helpers/application_helper_spec.rb' @@ -227,7 +208,6 @@ Style/StringConcatenation: - 'spec/lib/gitlab/gitaly_client/ref_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/remote_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/repository_service_spec.rb' - - 'spec/lib/gitlab/gitaly_client/wiki_service_spec.rb' - 'spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/other_markup_spec.rb' @@ -262,9 +242,9 @@ Style/StringConcatenation: - 'spec/models/custom_emoji_spec.rb' - 'spec/models/grafana_integration_spec.rb' - 'spec/models/integrations/campfire_spec.rb' - - 'spec/models/integrations/datadog_spec.rb' - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - 'spec/models/integrations/chat_message/push_message_spec.rb' + - 'spec/models/integrations/datadog_spec.rb' - 'spec/models/integrations/jenkins_spec.rb' - 'spec/models/merge_request_diff_spec.rb' - 'spec/models/merge_request_spec.rb' @@ -292,7 +272,6 @@ Style/StringConcatenation: - 'spec/routing/git_http_routing_spec.rb' - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - 'spec/services/clusters/gcp/finalize_creation_service_spec.rb' - - 'spec/services/clusters/kubernetes/configure_istio_ingress_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' @@ -311,7 +290,6 @@ Style/StringConcatenation: - 'spec/services/snippets/bulk_destroy_service_spec.rb' - 'spec/services/snippets/update_service_spec.rb' - 'spec/services/todo_service_spec.rb' - - 'spec/services/users/destroy_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - 'spec/support/capybara.rb' - 'spec/support/helpers/ci_artifact_metadata_generator.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index 29e94e77345..f601674a4bf 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -1,10 +1,9 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/StringLiteralsInInterpolation: Exclude: - 'app/graphql/mutations/base_mutation.rb' - 'app/helpers/colors_helper.rb' - - 'app/helpers/todos_helper.rb' - 'app/models/application_setting_implementation.rb' - 'app/models/ci/namespace_mirror.rb' - 'app/models/integrations/campfire.rb' @@ -21,7 +20,6 @@ Style/StringLiteralsInInterpolation: - 'ee/app/models/license.rb' - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/lib/ee/api/helpers/issues_helpers.rb' - - 'ee/lib/gitlab/elastic/helper.rb' - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' @@ -29,7 +27,6 @@ Style/StringLiteralsInInterpolation: - 'lib/api/helpers/snippets_helpers.rb' - 'lib/api/validations/validators/check_assignees_count.rb' - 'lib/banzai/filter/references/abstract_reference_filter.rb' - - 'lib/banzai/filter/syntax_highlight_filter.rb' - 'lib/generators/gitlab/usage_metric_definition_generator.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/ci/config/entry/job.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index d373788dbc6..074b400c4bb 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -1,5 +1,5 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/SymbolProc: Exclude: - 'app/controllers/admin/users_controller.rb' @@ -13,7 +13,6 @@ Style/SymbolProc: - 'app/graphql/mutations/commits/create.rb' - 'app/graphql/mutations/concerns/mutations/work_items/widgetable.rb' - 'app/graphql/mutations/jira_import/start.rb' - - 'app/graphql/mutations/work_items/update_widgets.rb' - 'app/graphql/types/work_items/widgets/description_type.rb' - 'app/helpers/graph_helper.rb' - 'app/models/ci/build_metadata.rb' @@ -54,7 +53,6 @@ Style/SymbolProc: - 'app/serializers/linked_project_issue_entity.rb' - 'app/serializers/member_entity.rb' - 'app/serializers/member_user_entity.rb' - - 'app/serializers/merge_request_poll_widget_entity.rb' - 'app/serializers/merge_request_widget_entity.rb' - 'app/serializers/project_entity.rb' - 'app/serializers/project_mirror_entity.rb' @@ -172,7 +170,6 @@ Style/SymbolProc: - 'lib/gitlab/diff/rendered/notebook/diff_file_helper.rb' - 'lib/gitlab/git/diff_stats_collection.rb' - 'lib/gitlab/gitaly_client/commit_service.rb' - - 'lib/gitlab/gitaly_client/wiki_service.rb' - 'lib/gitlab/import_export/attributes_finder.rb' - 'lib/gitlab/import_export/base/relation_object_saver.rb' - 'lib/gitlab/import_export/fast_hash_serializer.rb' @@ -199,12 +196,10 @@ Style/SymbolProc: - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/review_merge_request_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/custom_variable_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/online_garbage_collection_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_status_on_operation_dashboard_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'rubocop/cop/gitlab/namespaced_class.rb' |