diff options
Diffstat (limited to '.rubocop_todo/style')
| -rw-r--r-- | .rubocop_todo/style/class_and_module_children.yml | 3 | ||||
| -rw-r--r-- | .rubocop_todo/style/conditional_assignment.yml | 5 | ||||
| -rw-r--r-- | .rubocop_todo/style/each_for_simple_loop.yml | 6 | ||||
| -rw-r--r-- | .rubocop_todo/style/format_string.yml | 3 | ||||
| -rw-r--r-- | .rubocop_todo/style/hash_as_last_array_item.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/if_unless_modifier.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/mutable_constant.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/next.yml | 5 | ||||
| -rw-r--r-- | .rubocop_todo/style/percent_literal_delimiters.yml | 385 | ||||
| -rw-r--r-- | .rubocop_todo/style/redundant_condition.yml | 5 | ||||
| -rw-r--r-- | .rubocop_todo/style/redundant_freeze.yml | 83 | ||||
| -rw-r--r-- | .rubocop_todo/style/redundant_parentheses.yml | 9 | ||||
| -rw-r--r-- | .rubocop_todo/style/redundant_self.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/style/string_literals_in_interpolation.yml | 1 |
14 files changed, 1 insertions, 509 deletions
diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index 55df73d3633..80e5b613fac 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -70,7 +70,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/groups/dependency_proxy_auth_controller.rb' - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' - 'app/controllers/groups/deploy_tokens_controller.rb' - - 'app/controllers/groups/email_campaigns_controller.rb' - 'app/controllers/groups/group_links_controller.rb' - 'app/controllers/groups/group_members_controller.rb' - 'app/controllers/groups/imports_controller.rb' @@ -358,7 +357,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/designs_controller.rb' - 'ee/app/controllers/admin/geo/nodes_controller.rb' - - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/geo/replicables_controller.rb' - 'ee/app/controllers/admin/geo/settings_controller.rb' - 'ee/app/controllers/admin/licenses_controller.rb' @@ -459,7 +457,6 @@ Style/ClassAndModuleChildren: - 'ee/app/models/geo/base_registry.rb' - 'ee/app/models/geo/container_repository_registry.rb' - 'ee/app/models/geo/deleted_project.rb' - - 'ee/app/models/geo/design_registry.rb' - 'ee/app/models/geo/event_log_state.rb' - 'ee/app/models/geo/group_wiki_repository_registry.rb' - 'ee/app/models/geo/job_artifact_registry.rb' diff --git a/.rubocop_todo/style/conditional_assignment.yml b/.rubocop_todo/style/conditional_assignment.yml deleted file mode 100644 index d16f2f7c3a7..00000000000 --- a/.rubocop_todo/style/conditional_assignment.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/ConditionalAssignment: - Exclude: - - 'app/helpers/icons_helper.rb' diff --git a/.rubocop_todo/style/each_for_simple_loop.yml b/.rubocop_todo/style/each_for_simple_loop.yml deleted file mode 100644 index e7f99d69528..00000000000 --- a/.rubocop_todo/style/each_for_simple_loop.yml +++ /dev/null @@ -1,6 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/EachForSimpleLoop: - Exclude: - - 'ee/spec/lib/gitlab/insights/reducers/count_per_period_reducer_spec.rb' - - 'spec/services/members/invitation_reminder_email_service_spec.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index c128f96eafe..c45ddab8441 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -80,7 +80,6 @@ Style/FormatString: - 'app/models/integrations/asana.rb' - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/bugzilla.rb' - - 'app/models/integrations/campfire.rb' - 'app/models/integrations/chat_message/pipeline_message.rb' - 'app/models/integrations/confluence.rb' - 'app/models/integrations/custom_issue_tracker.rb' @@ -160,7 +159,6 @@ Style/FormatString: - 'ee/app/components/namespaces/free_user_cap/usage_quota_trial_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/licenses_controller.rb' - 'ee/app/controllers/concerns/audit_events/date_range.rb' - 'ee/app/controllers/ee/projects/issues_controller.rb' @@ -182,7 +180,6 @@ Style/FormatString: - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/timeboxes_helper.rb' - 'ee/app/helpers/groups/sso_helper.rb' - - 'ee/app/helpers/trial_registrations/reassurances_helper.rb' - 'ee/app/helpers/vulnerabilities_helper.rb' - 'ee/app/mailers/ee/emails/admin_notification.rb' - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml index d7032af8805..b2dceb48c1b 100644 --- a/.rubocop_todo/style/hash_as_last_array_item.yml +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -39,7 +39,6 @@ Style/HashAsLastArrayItem: - 'ee/app/serializers/dashboard_environments_serializer.rb' - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/needs_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'lib/api/entities/project.rb' - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 872282a6a93..ef4fca8270d 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -389,7 +389,6 @@ Style/IfUnlessModifier: - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/geo/settings_controller.rb' - 'ee/app/controllers/admin/push_rules_controller.rb' - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' diff --git a/.rubocop_todo/style/mutable_constant.yml b/.rubocop_todo/style/mutable_constant.yml index f7a82be400a..d549830992f 100644 --- a/.rubocop_todo/style/mutable_constant.yml +++ b/.rubocop_todo/style/mutable_constant.yml @@ -7,7 +7,6 @@ Style/MutableConstant: - 'app/graphql/mutations/packages/bulk_destroy.rb' - 'app/helpers/blame_helper.rb' - 'app/models/ci/build_trace_chunks/redis_base.rb' - - 'app/models/design_management/repository.rb' - 'app/models/integrations/datadog.rb' - 'app/presenters/packages/helm/index_presenter.rb' - 'app/services/import/validate_remote_git_endpoint_service.rb' diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml deleted file mode 100644 index 6800ba2baf3..00000000000 --- a/.rubocop_todo/style/next.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/Next: - Exclude: - - 'lib/gitlab/fogbugz_import/importer.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index aee5872a343..59acd655d4b 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -2,230 +2,6 @@ # Cop supports --autocorrect. Style/PercentLiteralDelimiters: Exclude: - - 'Guardfile' - - 'app/helpers/auth_helper.rb' - - 'app/helpers/ci/variables_helper.rb' - - 'app/helpers/clusters_helper.rb' - - 'app/helpers/commits_helper.rb' - - 'app/helpers/diff_helper.rb' - - 'app/helpers/emails_helper.rb' - - 'app/helpers/external_link_helper.rb' - - 'app/helpers/labels_helper.rb' - - 'app/helpers/markup_helper.rb' - - 'app/helpers/nav_helper.rb' - - 'app/helpers/profiles_helper.rb' - - 'app/helpers/search_helper.rb' - - 'app/helpers/stat_anchors_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/models/application_setting.rb' - - 'app/models/application_setting_implementation.rb' - - 'app/models/blob_viewer/binary_stl.rb' - - 'app/models/blob_viewer/cargo_toml.rb' - - 'app/models/blob_viewer/cartfile.rb' - - 'app/models/blob_viewer/changelog.rb' - - 'app/models/blob_viewer/composer_json.rb' - - 'app/models/blob_viewer/contributing.rb' - - 'app/models/blob_viewer/csv.rb' - - 'app/models/blob_viewer/gemfile.rb' - - 'app/models/blob_viewer/gemspec.rb' - - 'app/models/blob_viewer/gitlab_ci_yml.rb' - - 'app/models/blob_viewer/go_mod.rb' - - 'app/models/blob_viewer/godeps_json.rb' - - 'app/models/blob_viewer/license.rb' - - 'app/models/blob_viewer/markup.rb' - - 'app/models/blob_viewer/notebook.rb' - - 'app/models/blob_viewer/open_api.rb' - - 'app/models/blob_viewer/package_json.rb' - - 'app/models/blob_viewer/pdf.rb' - - 'app/models/blob_viewer/podfile.rb' - - 'app/models/blob_viewer/podspec.rb' - - 'app/models/blob_viewer/podspec_json.rb' - - 'app/models/blob_viewer/readme.rb' - - 'app/models/blob_viewer/requirements_txt.rb' - - 'app/models/blob_viewer/route_map.rb' - - 'app/models/blob_viewer/sketch.rb' - - 'app/models/blob_viewer/svg.rb' - - 'app/models/blob_viewer/yarn_lock.rb' - - 'app/models/bulk_imports/file_transfer/group_config.rb' - - 'app/models/bulk_imports/file_transfer/project_config.rb' - - 'app/models/ci/build.rb' - - 'app/models/ci/build_runner_session.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/clusters/platforms/kubernetes.rb' - - 'app/models/commit.rb' - - 'app/models/concerns/clusters/agents/authorizations/ci_access/config_scopes.rb' - - 'app/models/concerns/diff_positionable_note.rb' - - 'app/models/concerns/enums/prometheus_metric.rb' - - 'app/models/concerns/issuable.rb' - - 'app/models/concerns/issue_available_features.rb' - - 'app/models/concerns/mentionable/reference_regexes.rb' - - 'app/models/concerns/noteable.rb' - - 'app/models/concerns/resolvable_note.rb' - - 'app/models/concerns/with_uploads.rb' - - 'app/models/container_registry/event.rb' - - 'app/models/deploy_token.rb' - - 'app/models/description_version.rb' - - 'app/models/design_management.rb' - - 'app/models/diff_note.rb' - - 'app/models/discussion_note.rb' - - 'app/models/draft_note.rb' - - 'app/models/environment.rb' - - 'app/models/event.rb' - - 'app/models/instance_configuration.rb' - - 'app/models/integrations/asana.rb' - - 'app/models/integrations/assembla.rb' - - 'app/models/integrations/base_issue_tracker.rb' - - 'app/models/integrations/base_monitoring.rb' - - 'app/models/integrations/base_slash_commands.rb' - - 'app/models/integrations/base_third_party_wiki.rb' - - 'app/models/integrations/buildkite.rb' - - 'app/models/integrations/campfire.rb' - - 'app/models/integrations/datadog.rb' - - 'app/models/integrations/drone_ci.rb' - - 'app/models/integrations/emails_on_push.rb' - - 'app/models/integrations/external_wiki.rb' - - 'app/models/integrations/field.rb' - - 'app/models/integrations/jenkins.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/integrations/packagist.rb' - - 'app/models/integrations/pivotaltracker.rb' - - 'app/models/integrations/pushover.rb' - - 'app/models/integrations/teamcity.rb' - - 'app/models/integrations/zentao.rb' - - 'app/models/issuable_severity.rb' - - 'app/models/issue.rb' - - 'app/models/lfs_download_object.rb' - - 'app/models/namespace.rb' - - 'app/models/namespace/root_storage_statistics.rb' - - 'app/models/note.rb' - - 'app/models/notification_setting.rb' - - 'app/models/performance_monitoring/prometheus_dashboard.rb' - - 'app/models/project.rb' - - 'app/models/project_feature.rb' - - 'app/models/project_setting.rb' - - 'app/models/releases/link.rb' - - 'app/models/repository.rb' - - 'app/models/resource_label_event.rb' - - 'app/models/resource_state_event.rb' - - 'app/models/resource_timebox_event.rb' - - 'app/models/user.rb' - - 'app/models/user_interacted_project.rb' - - 'app/policies/identity_provider_policy.rb' - - 'app/presenters/dev_ops_report/metric_presenter.rb' - - 'app/presenters/search_service_presenter.rb' - - 'app/serializers/pipeline_serializer.rb' - - 'app/services/application_settings/update_service.rb' - - 'app/services/auth/container_registry_authentication_service.rb' - - 'app/services/boards/update_service.rb' - - 'app/services/bulk_imports/file_download_service.rb' - - 'app/services/ci/update_instance_variables_service.rb' - - 'app/services/clusters/kubernetes/create_or_update_service_account_service.rb' - - 'app/services/feature_flags/base_service.rb' - - 'app/services/files/multi_service.rb' - - 'app/services/import/bitbucket_server_service.rb' - - 'app/services/import/fogbugz_service.rb' - - 'app/services/import/github_service.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3.rb' - - 'app/services/import_export_clean_up_service.rb' - - 'app/services/incident_management/pager_duty/process_webhook_service.rb' - - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/merge_requests/update_service.rb' - - 'app/services/metrics/dashboard/default_embed_service.rb' - - 'app/services/packages/debian/generate_distribution_service.rb' - - 'app/services/preview_markdown_service.rb' - - 'app/services/projects/apple_target_platform_detector_service.rb' - - 'app/services/projects/download_service.rb' - - 'app/services/projects/hashed_storage/migrate_attachments_service.rb' - - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - - 'app/services/projects/update_service.rb' - - 'app/services/prometheus/proxy_service.rb' - - 'app/services/repositories/base_service.rb' - - 'app/services/repository_archive_clean_up_service.rb' - - 'app/services/resource_access_tokens/create_service.rb' - - 'app/services/resource_access_tokens/revoke_service.rb' - - 'app/services/search/global_service.rb' - - 'app/services/search/project_service.rb' - - 'app/services/snippets/update_service.rb' - - 'app/services/todos/destroy/destroyed_issuable_service.rb' - - 'app/services/todos/destroy/entity_leave_service.rb' - - 'app/uploaders/design_management/design_v432x230_uploader.rb' - - 'app/uploaders/gitlab_uploader.rb' - - 'app/validators/addressable_url_validator.rb' - - 'app/validators/gitlab/zoom_url_validator.rb' - - 'app/validators/json_schema_validator.rb' - - 'app/workers/members_destroyer/unassign_issuables_worker.rb' - - 'app/workers/projects/record_target_platforms_worker.rb' - - 'config/application.rb' - - 'config/boot.rb' - - 'config/environments/production.rb' - - 'config/initializers/1_settings.rb' - - 'config/initializers/content_security_policy.rb' - - 'config/initializers/doorkeeper.rb' - - 'config/initializers/enumerator_next_patch.rb' - - 'config/initializers/fog_core_patch.rb' - - 'config/initializers/forbid_sidekiq_in_transactions.rb' - - 'config/initializers/health_check.rb' - - 'config/initializers/invisible_captcha.rb' - - 'config/initializers/lograge.rb' - - 'config/initializers/rspec_profiling.rb' - - 'config/initializers_before_autoloader/000_inflections.rb' - - 'config/object_store_settings.rb' - - 'config/spring.rb' - - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - - 'ee/app/controllers/ee/projects/service_desk_controller.rb' - - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' - - 'ee/app/controllers/groups/protected_environments_controller.rb' - - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' - - 'ee/app/controllers/projects/protected_environments_controller.rb' - - 'ee/app/finders/iterations_finder.rb' - - 'ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb' - - 'ee/app/helpers/credentials_inventory_helper.rb' - - 'ee/app/helpers/ee/auth_helper.rb' - - 'ee/app/helpers/ee/dashboard_helper.rb' - - 'ee/app/helpers/ee/integrations_helper.rb' - - 'ee/app/helpers/ee/issues_helper.rb' - - 'ee/app/helpers/ee/labels_helper.rb' - - 'ee/app/helpers/ee/nav_helper.rb' - - 'ee/app/mailers/previews/ci_minutes_usage_mailer_preview.rb' - - 'ee/app/mailers/previews/emails/namespace_storage_usage_mailer_preview.rb' - - 'ee/app/mailers/previews/license_mailer_preview.rb' - - 'ee/app/models/app_sec/fuzzing/api/scan_profile.rb' - - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - - 'ee/app/models/concerns/ee/issue_available_features.rb' - - 'ee/app/models/ee/audit_event.rb' - - 'ee/app/models/ee/description_version.rb' - - 'ee/app/models/ee/groups/feature_setting.rb' - - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/project_feature.rb' - - 'ee/app/models/ee/resource_label_event.rb' - - 'ee/app/models/ee/resource_state_event.rb' - - 'ee/app/models/ee/user.rb' - - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/models/geo/project_registry.rb' - - 'ee/app/models/geo/secondary_usage_data.rb' - - 'ee/app/models/geo_node_status.rb' - - 'ee/app/models/incident_management/issuable_resource_link.rb' - - 'ee/app/models/integrations/github.rb' - - 'ee/app/models/merge_requests/status_check_response.rb' - - 'ee/app/models/saml_provider.rb' - - 'ee/app/models/security/orchestration_policy_configuration.rb' - - 'ee/app/models/software_license_policy.rb' - - 'ee/app/models/storage_shard.rb' - - 'ee/app/services/approval_rules/create_service.rb' - - 'ee/app/services/boards/epic_boards/update_service.rb' - - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' - - 'ee/app/services/concerns/search/elasticsearchable.rb' - - 'ee/app/services/ee/boards/update_service.rb' - - 'ee/app/services/ee/search/group_service.rb' - - 'ee/app/services/ee/search/project_service.rb' - - 'ee/app/services/epics/tree_reorder_service.rb' - - 'ee/app/services/iterations/update_service.rb' - - 'ee/app/services/jira/jql_builder_service.rb' - - 'ee/app/services/security/configuration/save_auto_fix_service.rb' - - 'ee/app/services/security/dependency_list_service.rb' - - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb' - - 'ee/elastic/migrate/20220613120500_migrate_commits_to_separate_index.rb' - 'ee/lib/api/status_checks.rb' - 'ee/lib/api/visual_review_discussions.rb' - 'ee/lib/ee/api/helpers/members_helpers.rb' @@ -250,7 +26,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' - 'ee/lib/tasks/gitlab/elastic/test.rake' - - 'ee/spec/config/metrics/every_metric_definition_spec.rb' - 'ee/spec/controllers/ee/sessions_controller_spec.rb' - 'ee/spec/controllers/groups/saml_providers_controller_spec.rb' - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' @@ -284,7 +59,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/helpers/ee/application_settings_helper_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/helpers/ee/environments_helper_spec.rb' - - 'ee/spec/helpers/ee/geo_helper_spec.rb' - 'ee/spec/helpers/ee/labels_helper_spec.rb' - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - 'ee/spec/helpers/merge_requests_helper_spec.rb' @@ -301,7 +75,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/external_users_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/groups_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/reports/security/reports_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_design_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' - 'ee/spec/lib/ee/gitlab/security/scan_configuration_spec.rb' @@ -314,7 +87,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/adapter_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' - - 'ee/spec/lib/gitlab/auth/saml/membership_updater_spec.rb' - 'ee/spec/lib/gitlab/auth/saml/user_spec.rb' - 'ee/spec/lib/gitlab/authority_analyzer_spec.rb' - 'ee/spec/lib/gitlab/cache_spec.rb' @@ -348,7 +120,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'ee/spec/models/ee/ci/runner_spec.rb' - 'ee/spec/models/ee/groups/feature_setting_spec.rb' - - 'ee/spec/models/ee/integration_spec.rb' - 'ee/spec/models/ee/integrations/jira_spec.rb' - 'ee/spec/models/ee/personal_access_token_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' @@ -398,7 +169,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/support/license_scanning_reports/license_scanning_report_helper.rb' - 'ee/spec/support/prometheus/additional_metrics_shared_examples.rb' - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - 'ee/spec/support/shared_examples/finders/geo/file_registry_finder_shared_examples.rb' - 'ee/spec/support/shared_examples/finders/geo/registry_finder_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/git_access_shared_examples.rb' @@ -409,134 +179,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb' - 'ee/spec/workers/project_cache_worker_spec.rb' - 'ee/spec/workers/repository_import_worker_spec.rb' - - 'lib/api/ci/helpers/runner.rb' - - 'lib/api/commit_statuses.rb' - - 'lib/api/discussions.rb' - - 'lib/api/entities/note.rb' - - 'lib/api/helpers/common_helpers.rb' - - 'lib/api/helpers/notes_helpers.rb' - - 'lib/api/helpers/projects_helpers.rb' - - 'lib/api/helpers/search_helpers.rb' - - 'lib/api/maven_packages.rb' - - 'lib/api/repositories.rb' - - 'lib/api/search.rb' - - 'lib/api/users.rb' - - 'lib/backup/database.rb' - - 'lib/backup/manager.rb' - - 'lib/banzai/filter/ascii_doc_sanitization_filter.rb' - - 'lib/banzai/filter/autolink_filter.rb' - - 'lib/banzai/filter/base_sanitization_filter.rb' - - 'lib/banzai/filter/broadcast_message_sanitization_filter.rb' - - 'lib/banzai/filter/custom_emoji_filter.rb' - - 'lib/banzai/filter/emoji_filter.rb' - - 'lib/banzai/filter/gollum_tags_filter.rb' - - 'lib/banzai/filter/inline_diff_filter.rb' - - 'lib/banzai/filter/issuable_reference_expansion_filter.rb' - - 'lib/banzai/filter/references/reference_filter.rb' - - 'lib/banzai/filter/repository_link_filter.rb' - - 'lib/banzai/filter/sanitization_filter.rb' - - 'lib/banzai/filter/spaced_link_filter.rb' - - 'lib/banzai/filter/syntax_highlight_filter.rb' - - 'lib/banzai/filter/table_of_contents_filter.rb' - - 'lib/banzai/pipeline/base_pipeline.rb' - - 'lib/banzai/pipeline/description_pipeline.rb' - - 'lib/banzai/pipeline/incident_management/timeline_event_pipeline.rb' - - 'lib/bitbucket/page.rb' - - 'lib/bitbucket/representation/issue.rb' - - 'lib/container_registry/path.rb' - - 'lib/feature.rb' - - 'lib/generators/gitlab/usage_metric_definition_generator.rb' - - 'lib/generators/gitlab/usage_metric_generator.rb' - - 'lib/gitlab.rb' - - 'lib/gitlab/alert_management/payload/managed_prometheus.rb' - - 'lib/gitlab/alert_management/payload/prometheus.rb' - - 'lib/gitlab/asciidoc/syntax_highlighter/html_pipeline_adapter.rb' - - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/auth/ldap/config.rb' - - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/ci/config/entry/bridge.rb' - - 'lib/gitlab/ci/reports/codequality_reports.rb' - - 'lib/gitlab/ci/reports/test_reports_comparer.rb' - - 'lib/gitlab/cleanup/orphan_job_artifact_files.rb' - - 'lib/gitlab/cluster/rack_timeout_observer.rb' - - 'lib/gitlab/content_security_policy/config_loader.rb' - - 'lib/gitlab/database/load_balancing/connection_proxy.rb' - - 'lib/gitlab/database/migration_helpers/cascading_namespace_settings.rb' - - 'lib/gitlab/database/reindexing.rb' - - 'lib/gitlab/dependency_linker/base_linker.rb' - - 'lib/gitlab/diff/char_diff.rb' - - 'lib/gitlab/diff/inline_diff_marker.rb' - - 'lib/gitlab/diff/line.rb' - - 'lib/gitlab/etag_caching/middleware.rb' - - 'lib/gitlab/etag_caching/router/graphql.rb' - - 'lib/gitlab/etag_caching/router/rails.rb' - - 'lib/gitlab/fips.rb' - - 'lib/gitlab/git/blob.rb' - - 'lib/gitlab/git/diff.rb' - - 'lib/gitlab/git/rugged_impl/repository.rb' - - 'lib/gitlab/git/tree.rb' - - 'lib/gitlab/git_access.rb' - - 'lib/gitlab/gitaly_client.rb' - - 'lib/gitlab/gitaly_client/diff.rb' - - 'lib/gitlab/gitaly_client/wiki_page.rb' - - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - - 'lib/gitlab/hotlinking_detector.rb' - - 'lib/gitlab/import_export/command_line_util.rb' - - 'lib/gitlab/import_export/file_importer.rb' - - 'lib/gitlab/import_export/repo_restorer.rb' - - 'lib/gitlab/jira_import/metadata_collector.rb' - - 'lib/gitlab/kas.rb' - - 'lib/gitlab/kroki.rb' - - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - - 'lib/gitlab/logger.rb' - - 'lib/gitlab/lograge/custom_options.rb' - - 'lib/gitlab/metrics/background_transaction.rb' - - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - - 'lib/gitlab/metrics/dashboard/stages/url_validator.rb' - - 'lib/gitlab/metrics/requests_rack_middleware.rb' - - 'lib/gitlab/metrics/subscribers/action_view.rb' - - 'lib/gitlab/metrics/subscribers/active_record.rb' - - 'lib/gitlab/metrics/transaction.rb' - - 'lib/gitlab/metrics/web_transaction.rb' - - 'lib/gitlab/middleware/read_only/controller.rb' - - 'lib/gitlab/project_search_results.rb' - - 'lib/gitlab/prometheus/query_variables.rb' - - 'lib/gitlab/query_limiting/transaction.rb' - - 'lib/gitlab/reference_extractor.rb' - - 'lib/gitlab/regex.rb' - - 'lib/gitlab/regex/bulk_imports.rb' - - 'lib/gitlab/sanitizers/exception_message.rb' - - 'lib/gitlab/sanitizers/exif.rb' - - 'lib/gitlab/search/abuse_detection.rb' - - 'lib/gitlab/search_context.rb' - - 'lib/gitlab/slash_commands/presenters/base.rb' - - 'lib/gitlab/ssh_public_key.rb' - - 'lib/gitlab/task_helpers.rb' - - 'lib/gitlab/url_blocker.rb' - - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb' - - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' - - 'lib/gitlab/usage/metrics/instrumentations/numbers_metric.rb' - - 'lib/gitlab/usage_data.rb' - - 'lib/gitlab/usage_data/topology.rb' - - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - - 'lib/gitlab/utils/sanitize_node_link.rb' - - 'lib/gitlab/web_hooks/rate_limiter.rb' - - 'lib/gitlab/workhorse.rb' - - 'lib/grafana/validator.rb' - - 'lib/omni_auth/strategies/jwt.rb' - - 'lib/release_highlights/validator/entry.rb' - - 'lib/security/ci_configuration/sast_build_action.rb' - - 'lib/sidebars/projects/menus/repository_menu.rb' - - 'lib/system_check/app/migrations_are_up_check.rb' - - 'lib/system_check/incoming_email/mail_room_running_check.rb' - - 'lib/system_check/sidekiq_check.rb' - - 'lib/tasks/cleanup.rake' - - 'lib/tasks/gettext.rake' - - 'lib/tasks/gitlab/info.rake' - - 'lib/tasks/gitlab/shell.rake' - - 'lib/tasks/gitlab/update_templates.rake' - - 'lib/tasks/tanuki_emoji.rake' - 'metrics_server/metrics_server.rb' - 'qa/qa/ee/page/dashboard/projects.rb' - 'qa/qa/ee/page/group/settings/general.rb' @@ -568,7 +210,6 @@ Style/PercentLiteralDelimiters: - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/commands/sidekiq_cluster/cli_spec.rb' - 'spec/components/pajamas/component_spec.rb' - - 'spec/config/mail_room_spec.rb' - 'spec/controllers/concerns/continue_params_spec.rb' - 'spec/controllers/graphql_controller_spec.rb' - 'spec/controllers/groups/releases_controller_spec.rb' @@ -577,13 +218,9 @@ Style/PercentLiteralDelimiters: - 'spec/controllers/profiles/two_factor_auths_controller_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - - 'spec/controllers/projects/environments/prometheus_api_controller_spec.rb' - - 'spec/controllers/projects/environments_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' - 'spec/controllers/projects/merge_requests_controller_spec.rb' - - 'spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' @@ -663,7 +300,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb' - 'spec/lib/banzai/filter/image_link_filter_spec.rb' - - 'spec/lib/banzai/filter/inline_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/commit_range_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' @@ -682,10 +318,8 @@ Style/PercentLiteralDelimiters: - 'spec/lib/banzai/pipeline/description_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/commit_parser_spec.rb' - 'spec/lib/banzai/reference_parser/issue_parser_spec.rb' - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' - 'spec/lib/bitbucket/collection_spec.rb' @@ -779,7 +413,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/graphql/tracers/metrics_tracer_spec.rb' - 'spec/lib/gitlab/hashed_path_spec.rb' - 'spec/lib/gitlab/highlight_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/i18n/translation_entry_spec.rb' - 'spec/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy_spec.rb' - 'spec/lib/gitlab/import_export/after_export_strategies/web_upload_strategy_spec.rb' @@ -802,8 +435,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/kubernetes/role_spec.rb' - 'spec/lib/gitlab/language_data_spec.rb' - 'spec/lib/gitlab/markup_helper_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/validator/errors_spec.rb' - 'spec/lib/gitlab/metrics/rails_slis_spec.rb' - 'spec/lib/gitlab/metrics/samplers/threads_sampler_spec.rb' - 'spec/lib/gitlab/middleware/go_spec.rb' @@ -815,7 +446,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/process_management_spec.rb' - 'spec/lib/gitlab/process_supervisor_spec.rb' - - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' @@ -836,12 +466,12 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/string_range_marker_spec.rb' - 'spec/lib/gitlab/string_regex_marker_spec.rb' - 'spec/lib/gitlab/suggestions/suggestion_set_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/lib/gitlab/tracking/event_definition_spec.rb' - 'spec/lib/gitlab/url_sanitizer_spec.rb' - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - 'spec/lib/gitlab/usage/metric_spec.rb' - 'spec/lib/gitlab/usage/service_ping/instrumented_payload_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/log_limited_array_spec.rb' - 'spec/lib/gitlab/webpack/graphql_known_operations_spec.rb' @@ -889,7 +519,6 @@ Style/PercentLiteralDelimiters: - 'spec/models/concerns/reactive_caching_spec.rb' - 'spec/models/concerns/sortable_spec.rb' - 'spec/models/deployment_spec.rb' - - 'spec/models/design_management/repository_spec.rb' - 'spec/models/diff_viewer/base_spec.rb' - 'spec/models/environment_spec.rb' - 'spec/models/group_label_spec.rb' @@ -908,11 +537,9 @@ Style/PercentLiteralDelimiters: - 'spec/models/packages/package_spec.rb' - 'spec/models/packages/tag_spec.rb' - 'spec/models/pages_domain_spec.rb' - - 'spec/models/performance_monitoring/prometheus_dashboard_spec.rb' - 'spec/models/personal_access_token_spec.rb' - 'spec/models/project_feature_spec.rb' - 'spec/models/project_label_spec.rb' - - 'spec/models/project_setting_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/project_team_spec.rb' - 'spec/models/projects/topic_spec.rb' @@ -924,13 +551,11 @@ Style/PercentLiteralDelimiters: - 'spec/models/user_spec.rb' - 'spec/models/web_ide_terminal_spec.rb' - 'spec/models/zoom_meeting_spec.rb' - - 'spec/policies/group_policy_spec.rb' - 'spec/policies/project_policy_spec.rb' - 'spec/presenters/ci/pipeline_artifacts/code_coverage_presenter_spec.rb' - 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' - - 'spec/requests/api/admin/broadcast_messages_spec.rb' - 'spec/requests/api/badges_spec.rb' - 'spec/requests/api/ci/jobs_spec.rb' - 'spec/requests/api/ci/pipelines_spec.rb' @@ -1022,7 +647,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/packages/create_dependency_service_spec.rb' - 'spec/services/packages/nuget/create_dependency_service_spec.rb' - - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/packages/update_tags_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' @@ -1032,12 +656,10 @@ Style/PercentLiteralDelimiters: - 'spec/services/projects/operations/update_service_spec.rb' - 'spec/services/projects/record_target_platforms_service_spec.rb' - 'spec/services/projects/update_statistics_service_spec.rb' - - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' - 'spec/services/upload_service_spec.rb' - 'spec/sidekiq_cluster/sidekiq_cluster_spec.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - - 'spec/support/banzai/reference_filter_shared_examples.rb' - 'spec/support/capybara.rb' - 'spec/support/helpers/gpg_helpers.rb' - 'spec/support/helpers/login_helpers.rb' @@ -1049,11 +671,8 @@ Style/PercentLiteralDelimiters: - 'spec/support/import_export/configuration_helper.rb' - 'spec/support/import_export/export_file_helper.rb' - 'spec/support/matchers/markdown_matchers.rb' - - 'spec/support/prometheus/additional_metrics_shared_examples.rb' - - 'spec/support/prometheus/metric_builders.rb' - 'spec/support/shared_contexts/graphql/resolvers/runners_resolver_shared_context.rb' - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' - - 'spec/support/shared_examples/controllers/metrics_dashboard_shared_examples.rb' - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - 'spec/support/shared_examples/features/page_description_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_creates_wiki_page_shared_examples.rb' @@ -1079,7 +698,6 @@ Style/PercentLiteralDelimiters: - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tooling/danger/customer_success_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' @@ -1107,7 +725,6 @@ Style/PercentLiteralDelimiters: - 'spec/views/projects/commit/branches.html.haml_spec.rb' - 'spec/workers/concerns/worker_context_spec.rb' - 'spec/workers/container_registry/migration/enqueuer_worker_spec.rb' - - 'spec/workers/gitlab/github_import/advance_stage_worker_spec.rb' - 'spec/workers/groups/update_statistics_worker_spec.rb' - 'spec/workers/jira_connect/sync_branch_worker_spec.rb' - 'spec/workers/post_receive_spec.rb' diff --git a/.rubocop_todo/style/redundant_condition.yml b/.rubocop_todo/style/redundant_condition.yml deleted file mode 100644 index 535dfa9e462..00000000000 --- a/.rubocop_todo/style/redundant_condition.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/RedundantCondition: - Exclude: - - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml index 12126c58313..12c9200bf54 100644 --- a/.rubocop_todo/style/redundant_freeze.yml +++ b/.rubocop_todo/style/redundant_freeze.yml @@ -2,61 +2,7 @@ # Cop supports --autocorrect. Style/RedundantFreeze: Exclude: - - 'app/controllers/help_controller.rb' - - 'app/controllers/import/bitbucket_server_controller.rb' - - 'app/finders/issuable_finder.rb' - - 'app/finders/repositories/changelog_commits_finder.rb' - - 'app/helpers/auth_helper.rb' - - 'app/helpers/colors_helper.rb' - - 'app/helpers/sidekiq_helper.rb' - - 'app/models/application_setting_implementation.rb' - - 'app/models/badge.rb' - - 'app/models/blob_viewer/go_mod.rb' - - 'app/models/ci/runner.rb' - - 'app/models/commit.rb' - - 'app/models/commit_range.rb' - - 'app/models/concerns/ci/maskable.rb' - - 'app/models/concerns/pg_full_text_searchable.rb' - - 'app/models/concerns/redactable.rb' - - 'app/models/concerns/taskable.rb' - - 'app/models/custom_emoji.rb' - - 'app/models/environment_status.rb' - - 'app/models/error_tracking/project_error_tracking_setting.rb' - - 'app/models/hooks/web_hook.rb' - - 'app/models/integrations/apple_app_store.rb' - - 'app/models/integrations/campfire.rb' - - 'app/models/integrations/chat_message/base_message.rb' - - 'app/models/integrations/confluence.rb' - - 'app/models/integrations/datadog.rb' - - 'app/models/integrations/discord.rb' - - 'app/models/integrations/field.rb' - - 'app/models/integrations/teamcity.rb' - - 'app/models/license_template.rb' - - 'app/models/members/group_member.rb' - - 'app/models/members/project_member.rb' - - 'app/models/merge_request.rb' - - 'app/models/namespaces/randomized_suffix_path.rb' - - 'app/models/note.rb' - - 'app/models/packages/debian.rb' - - 'app/models/packages/debian/file_entry.rb' - - 'app/models/personal_access_token.rb' - - 'app/models/releases/link.rb' - - 'app/models/snippet_repository.rb' - - 'app/models/terraform/state.rb' - - 'app/services/clusters/agent_tokens/track_usage_service.rb' - - 'app/services/error_tracking/list_projects_service.rb' - - 'app/services/grafana/proxy_service.rb' - - 'app/services/import/validate_remote_git_endpoint_service.rb' - - 'app/services/issues/base_service.rb' - - 'app/services/projects/import_error_filter.rb' - - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - - 'app/services/prometheus/proxy_variable_substitution_service.rb' - - 'app/uploaders/file_uploader.rb' - - 'app/validators/certificate_fingerprint_validator.rb' - - 'app/validators/json_schema_validator.rb' - - 'app/validators/line_code_validator.rb' - 'lib/api/api.rb' - - 'lib/api/concerns/packages/nuget_endpoints.rb' - 'lib/api/debian_group_packages.rb' - 'lib/api/go_proxy.rb' - 'lib/api/helpers.rb' @@ -68,8 +14,6 @@ Style/RedundantFreeze: - 'lib/banzai/filter/attributes_filter.rb' - 'lib/banzai/filter/autolink_filter.rb' - 'lib/banzai/filter/blockquote_fence_filter.rb' - - 'lib/banzai/filter/dollar_math_post_filter.rb' - - 'lib/banzai/filter/dollar_math_pre_filter.rb' - 'lib/banzai/filter/footnote_filter.rb' - 'lib/banzai/filter/gollum_tags_filter.rb' - 'lib/banzai/filter/markdown_post_escape_filter.rb' @@ -90,7 +34,6 @@ Style/RedundantFreeze: - 'lib/gitlab/ci/build/artifacts/metadata.rb' - 'lib/gitlab/ci/config/entry/artifacts.rb' - 'lib/gitlab/ci/config/external/file/base.rb' - - 'lib/gitlab/ci/interpolation/block.rb' - 'lib/gitlab/ci/parsers/test/junit.rb' - 'lib/gitlab/ci/pipeline/chain/skip.rb' - 'lib/gitlab/ci/pipeline/expression/lexeme/and.rb' @@ -113,7 +56,6 @@ Style/RedundantFreeze: - 'lib/gitlab/database/background_migration/batch_optimizer.rb' - 'lib/gitlab/database/load_balancing/service_discovery.rb' - 'lib/gitlab/database/migrations/runner.rb' - - 'lib/gitlab/database/query_analyzers/query_recorder.rb' - 'lib/gitlab/dependency_linker/base_linker.rb' - 'lib/gitlab/dependency_linker/gemfile_linker.rb' - 'lib/gitlab/dependency_linker/godeps_json_linker.rb' @@ -128,7 +70,6 @@ Style/RedundantFreeze: - 'lib/gitlab/email/handler/service_desk_handler.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb' - - 'lib/gitlab/front_matter.rb' - 'lib/gitlab/git.rb' - 'lib/gitlab/git/base_error.rb' - 'lib/gitlab/git/diff.rb' @@ -140,7 +81,6 @@ Style/RedundantFreeze: - 'lib/gitlab/golang.rb' - 'lib/gitlab/graphql/queries.rb' - 'lib/gitlab/harbor/query.rb' - - 'lib/gitlab/hook_data/base_builder.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/i18n/translation_entry.rb' - 'lib/gitlab/jira/dvcs.rb' @@ -165,26 +105,3 @@ Style/RedundantFreeze: - 'lib/gitlab/regex.rb' - 'lib/gitlab/regex/packages.rb' - 'lib/gitlab/robots_txt/parser.rb' - - 'lib/gitlab/saas.rb' - - 'lib/gitlab/sanitizers/exception_message.rb' - - 'lib/gitlab/sanitizers/svg.rb' - - 'lib/gitlab/search/abuse_detection.rb' - - 'lib/gitlab/search/found_blob.rb' - - 'lib/gitlab/search/query.rb' - - 'lib/gitlab/sidekiq_config/worker_matcher.rb' - - 'lib/gitlab/slash_commands/deploy.rb' - - 'lib/gitlab/slug/path.rb' - - 'lib/gitlab/spamcheck/client.rb' - - 'lib/gitlab/sql/pattern.rb' - - 'lib/gitlab/unicode.rb' - - 'lib/gitlab/untrusted_regexp/ruby_syntax.rb' - - 'lib/gitlab/usage_data_counters/gitlab_cli_activity_unique_counter.rb' - - 'lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter.rb' - - 'lib/gitlab/usage_data_counters/vscode_extension_activity_unique_counter.rb' - - 'lib/gitlab/utils/link_header_parser.rb' - - 'lib/gitlab/utils/markdown.rb' - - 'lib/gitlab/uuid.rb' - - 'lib/gitlab/version_info.rb' - - 'lib/gitlab/x509/certificate.rb' - - 'lib/gitlab/zoom_link_extractor.rb' - - 'lib/sbom/package_url/argument_validator.rb' diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml deleted file mode 100644 index 540dcfa3ca7..00000000000 --- a/.rubocop_todo/style/redundant_parentheses.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/RedundantParentheses: - Details: grace period - Exclude: - - 'spec/graphql/types/ci/job_kind_enum_spec.rb' - - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' - - 'spec/requests/verifies_with_email_spec.rb' - - 'spec/services/projects/create_service_spec.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index df5c1b6172a..3dd497248bc 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -87,7 +87,6 @@ Style/RedundantSelf: - 'app/models/integrations/base_ci.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/base_slash_commands.rb' - - 'app/models/integrations/campfire.rb' - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' @@ -205,7 +204,6 @@ Style/RedundantSelf: - 'ee/app/models/ee/user.rb' - 'ee/app/models/epic/metrics.rb' - 'ee/app/models/geo/base_registry.rb' - - 'ee/app/models/geo/design_registry.rb' - 'ee/app/models/geo/project_registry.rb' - 'ee/app/models/geo/upload_registry.rb' - 'ee/app/models/geo_node.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index 30a649cb4fa..c8cd3c9f074 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -6,7 +6,6 @@ Style/StringLiteralsInInterpolation: - 'app/helpers/colors_helper.rb' - 'app/models/application_setting_implementation.rb' - 'app/models/ci/namespace_mirror.rb' - - 'app/models/integrations/campfire.rb' - 'app/models/integrations/jira.rb' - 'app/services/draft_notes/publish_service.rb' - 'app/services/projects/create_service.rb' |