diff options
Diffstat (limited to '.rubocop_todo/style')
| -rw-r--r-- | .rubocop_todo/style/arguments_forwarding.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/class_and_module_children.yml | 4 | ||||
| -rw-r--r-- | .rubocop_todo/style/empty_method.yml | 3 | ||||
| -rw-r--r-- | .rubocop_todo/style/explicit_block_argument.yml | 3 | ||||
| -rw-r--r-- | .rubocop_todo/style/format_string.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/guard_clause.yml | 6 | ||||
| -rw-r--r-- | .rubocop_todo/style/if_unless_modifier.yml | 9 | ||||
| -rw-r--r-- | .rubocop_todo/style/inline_disable_annotation.yml | 129 | ||||
| -rw-r--r-- | .rubocop_todo/style/numeric_literal_prefix.yml | 3 | ||||
| -rw-r--r-- | .rubocop_todo/style/open_struct_use.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/redundant_return.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/single_argument_dig.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/sole_nested_conditional.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/style/symbol_proc.yml | 25 | ||||
| -rw-r--r-- | .rubocop_todo/style/zero_length_predicate.yml | 5 |
15 files changed, 4 insertions, 189 deletions
diff --git a/.rubocop_todo/style/arguments_forwarding.yml b/.rubocop_todo/style/arguments_forwarding.yml index f51e582b5a0..f578b75e5f0 100644 --- a/.rubocop_todo/style/arguments_forwarding.yml +++ b/.rubocop_todo/style/arguments_forwarding.yml @@ -110,7 +110,6 @@ Style/ArgumentsForwarding: - 'lib/gitlab/legacy_github_import/client.rb' - 'lib/gitlab/memory/watchdog/configuration.rb' - 'lib/gitlab/metrics/prometheus.rb' - - 'lib/gitlab/nav/top_nav_view_model_builder.rb' - 'lib/gitlab/quick_actions/dsl.rb' - 'lib/gitlab/rack_attack.rb' - 'lib/gitlab/redis/multi_store.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index 89b20f231f9..63f6b76a0ae 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -102,7 +102,7 @@ Style/ClassAndModuleChildren: - 'app/controllers/oauth/token_info_controller.rb' - 'app/controllers/oauth/tokens_controller.rb' - 'app/controllers/profiles/accounts_controller.rb' - - 'app/controllers/profiles/active_sessions_controller.rb' + - 'app/controllers/user_settings/active_sessions_controller.rb' - 'app/controllers/profiles/application_controller.rb' - 'app/controllers/profiles/avatars_controller.rb' - 'app/controllers/profiles/chat_names_controller.rb' @@ -111,8 +111,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/profiles/groups_controller.rb' - 'app/controllers/profiles/keys_controller.rb' - 'app/controllers/profiles/notifications_controller.rb' - - 'app/controllers/profiles/passwords_controller.rb' - - 'app/controllers/profiles/personal_access_tokens_controller.rb' - 'app/controllers/profiles/preferences_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - 'app/controllers/profiles/webauthn_registrations_controller.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index ff246e48364..f8a054f1c86 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -19,7 +19,6 @@ Style/EmptyMethod: - 'app/controllers/import/fogbugz_controller.rb' - 'app/controllers/import/manifest_controller.rb' - 'app/controllers/profiles/chat_names_controller.rb' - - 'app/controllers/profiles/passwords_controller.rb' - 'app/controllers/profiles/preferences_controller.rb' - 'app/controllers/profiles_controller.rb' - 'app/controllers/projects/alert_management_controller.rb' @@ -65,8 +64,6 @@ Style/EmptyMethod: - 'app/services/issuable_base_service.rb' - 'app/services/projects/transfer_service.rb' - 'app/workers/namespaces/root_statistics_worker.rb' - - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' - - 'db/post_migrate/20220524074947_finalize_backfill_null_note_discussion_ids.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/designs_controller.rb' - 'ee/app/controllers/admin/geo/settings_controller.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index 48be875ab5a..db1c8073df8 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -71,7 +71,6 @@ Style/ExplicitBlockArgument: - 'qa/qa/page/profile/menu.rb' - 'qa/qa/page/project/settings/deploy_keys.rb' - 'qa/qa/page/project/settings/deploy_tokens.rb' - - 'qa/qa/page/sub_menus/common.rb' - 'qa/qa/resource/events/base.rb' - 'qa/qa/runtime/api/repository_storage_moves.rb' - 'qa/qa/runtime/search.rb' @@ -85,8 +84,6 @@ Style/ExplicitBlockArgument: - 'spec/services/todo_service_spec.rb' - 'spec/support/database/gitlab_schemas_validate_connection.rb' - 'spec/support/helpers/feature_flag_helpers.rb' - - 'spec/support/helpers/features/runners_helpers.rb' - - 'spec/support/helpers/features/top_nav_spec_helpers.rb' - 'spec/support/helpers/modal_helpers.rb' - 'spec/support/helpers/next_found_instance_of.rb' - 'spec/support/helpers/usage_data_helpers.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 3e89b2ca7ea..b4f4dbf4717 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -226,7 +226,6 @@ Style/FormatString: - 'ee/lib/gitlab/geo.rb' - 'ee/lib/gitlab/licenses/submit_license_usage_data_banner.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - - 'ee/lib/gitlab/vulnerabilities/container_scanning_vulnerability.rb' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 74051fa5944..429eeff3787 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -61,7 +61,6 @@ Style/GuardClause: - 'app/helpers/admin/user_actions_helper.rb' - 'app/helpers/events_helper.rb' - 'app/helpers/issues_helper.rb' - - 'app/helpers/nav/top_nav_helper.rb' - 'app/helpers/notes_helper.rb' - 'app/helpers/preferences_helper.rb' - 'app/helpers/profiles_helper.rb' @@ -146,7 +145,6 @@ Style/GuardClause: - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/project_presenter.rb' - 'app/services/boards/issues/list_service.rb' - - 'app/services/bulk_imports/file_download_service.rb' - 'app/services/ci/create_web_ide_terminal_service.rb' - 'app/services/ci/daily_build_group_report_result_service.rb' - 'app/services/ci/job_artifacts/destroy_batch_service.rb' @@ -276,7 +274,6 @@ Style/GuardClause: - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/auth_helper.rb' - 'ee/app/helpers/ee/nav/new_dropdown_helper.rb' - - 'ee/app/helpers/ee/nav/top_nav_helper.rb' - 'ee/app/helpers/ee/projects/pipeline_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/models/allowed_email_domain.rb' @@ -430,7 +427,6 @@ Style/GuardClause: - 'lib/gitlab/auth/o_auth/user.rb' - 'lib/gitlab/auth/unique_ips_limiter.rb' - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - - 'lib/gitlab/bitbucket_import/importer.rb' - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/changelog/config.rb' @@ -556,8 +552,6 @@ Style/GuardClause: - 'lib/tasks/config_lint.rake' - 'lib/tasks/gettext.rake' - 'qa/qa/ee/page/file/show.rb' - - 'qa/qa/mobile/page/main/menu.rb' - - 'qa/qa/mobile/page/sub_menus/common.rb' - 'qa/qa/page/component/snippet.rb' - 'qa/qa/page/mattermost/login.rb' - 'qa/qa/page/page_concern.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index c6a44782153..db8f6d8d851 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -88,7 +88,6 @@ Style/IfUnlessModifier: - 'app/helpers/lazy_image_tag_helper.rb' - 'app/helpers/markup_helper.rb' - 'app/helpers/merge_requests_helper.rb' - - 'app/helpers/nav/top_nav_helper.rb' - 'app/helpers/nav_helper.rb' - 'app/helpers/page_layout_helper.rb' - 'app/helpers/preferences_helper.rb' @@ -320,7 +319,6 @@ Style/IfUnlessModifier: - 'app/services/users/build_service.rb' - 'app/services/users/respond_to_terms_service.rb' - 'app/services/wikis/create_attachment_service.rb' - - 'app/services/work_items/task_list_reference_removal_service.rb' - 'app/services/work_items/task_list_reference_replacement_service.rb' - 'app/uploaders/file_mover.rb' - 'app/uploaders/object_storage.rb' @@ -374,7 +372,6 @@ Style/IfUnlessModifier: - 'config/routes.rb' - 'danger/database/Dangerfile' - 'danger/pipeline/Dangerfile' - - 'db/post_migrate/20220523171107_drop_deploy_tokens_token_column.rb' - 'ee/app/components/namespaces/storage/limit_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/emails_controller.rb' @@ -554,7 +551,6 @@ Style/IfUnlessModifier: - 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb' - 'ee/db/geo/migrate/20170627195211_add_index_to_project_registry.rb' - 'ee/db/geo/migrate/20180402170913_add_missing_on_primary_to_job_artifact_registry..rb' - - 'ee/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index.rb' - 'ee/lib/api/merge_request_approval_rules.rb' - 'ee/lib/api/protected_environments.rb' - 'ee/lib/audit/details.rb' @@ -596,7 +592,6 @@ Style/IfUnlessModifier: - 'ee/lib/gitlab/geo/git_ssh_proxy.rb' - 'ee/lib/gitlab/geo/health_check.rb' - 'ee/lib/gitlab/geo/log_cursor/daemon.rb' - - 'ee/lib/gitlab/geo/log_cursor/events/repository_deleted_event.rb' - 'ee/lib/gitlab/geo/oauth/logout_token.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/lib/gitlab/geo/replicator.rb' @@ -627,7 +622,6 @@ Style/IfUnlessModifier: - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/elastic/search_results_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - 'ee/spec/models/concerns/elastic/note_spec.rb' - 'ee/spec/models/geo_node_status_spec.rb' - 'ee/spec/models/push_rule_spec.rb' @@ -733,7 +727,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/checks/matching_merge_request.rb' - 'lib/gitlab/checks/push_check.rb' - 'lib/gitlab/checks/push_file_count_check.rb' - - 'lib/gitlab/checks/tag_check.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/converter.rb' - 'lib/gitlab/ci/ansi2json/style.rb' @@ -907,7 +900,6 @@ Style/IfUnlessModifier: - 'lib/sidebars/projects/menus/settings_menu.rb' - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' - 'lib/system_check/init_helpers.rb' - - 'lib/tasks/cleanup.rake' - 'lib/tasks/eslint.rake' - 'lib/tasks/gitlab/assets.rake' - 'lib/tasks/gitlab/cleanup.rake' @@ -924,7 +916,6 @@ Style/IfUnlessModifier: - 'qa/qa/page/mattermost/login.rb' - 'qa/qa/page/page_concern.rb' - 'qa/qa/page/project/settings/deploy_tokens.rb' - - 'qa/qa/page/project/web_ide/edit.rb' - 'qa/qa/page/view.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/repository/push.rb' diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml index 136c5fe9a0c..1a6226514e6 100644 --- a/.rubocop_todo/style/inline_disable_annotation.yml +++ b/.rubocop_todo/style/inline_disable_annotation.yml @@ -162,7 +162,6 @@ Style/InlineDisableAnnotation: - 'app/finders/merge_requests_finder.rb' - 'app/finders/milestones_finder.rb' - 'app/finders/notes_finder.rb' - - 'app/finders/organizations/groups_finder.rb' - 'app/finders/packages/build_infos_finder.rb' - 'app/finders/projects/groups_finder.rb' - 'app/finders/projects/members/effective_access_level_finder.rb' @@ -327,7 +326,6 @@ Style/InlineDisableAnnotation: - 'app/graphql/types/user_preferences_type.rb' - 'app/graphql/types/user_status_type.rb' - 'app/graphql/types/work_item_id_type.rb' - - 'app/graphql/types/work_items/linked_item_type.rb' - 'app/graphql/types/work_items/widgets/assignees_type.rb' - 'app/graphql/types/work_items/widgets/award_emoji_type.rb' - 'app/graphql/types/work_items/widgets/current_user_todos_type.rb' @@ -352,7 +350,6 @@ Style/InlineDisableAnnotation: - 'app/helpers/issuables_helper.rb' - 'app/helpers/lazy_image_tag_helper.rb' - 'app/helpers/namespaces_helper.rb' - - 'app/helpers/nav/top_nav_helper.rb' - 'app/helpers/page_layout_helper.rb' - 'app/helpers/routing/projects_helper.rb' - 'app/helpers/routing/pseudonymization_helper.rb' @@ -688,10 +685,8 @@ Style/InlineDisableAnnotation: - 'app/services/packages/conan/single_package_search_service.rb' - 'app/services/packages/create_dependency_service.rb' - 'app/services/packages/create_package_service.rb' - - 'app/services/packages/debian/extract_metadata_service.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - - 'app/services/packages/helm/extract_file_metadata_service.rb' - 'app/services/packages/npm/create_package_service.rb' - 'app/services/packages/nuget/create_dependency_service.rb' - 'app/services/packages/nuget/extract_remote_metadata_file_service.rb' @@ -806,6 +801,7 @@ Style/InlineDisableAnnotation: - 'app/workers/bulk_imports/pipeline_worker.rb' - 'app/workers/bulk_imports/relation_batch_export_worker.rb' - 'app/workers/bulk_imports/stuck_import_worker.rb' + - 'app/workers/bulk_imports/transform_references_worker.rb' - 'app/workers/chaos/cpu_spin_worker.rb' - 'app/workers/chaos/db_spin_worker.rb' - 'app/workers/chaos/kill_worker.rb' @@ -1112,7 +1108,6 @@ Style/InlineDisableAnnotation: - 'config/initializers/mail_starttls_patch.rb' - 'config/initializers/postgres_cte_as_materialized.rb' - 'config/initializers/rack_VULNDB-255039_patch.rb' - - 'config/initializers/rspec_profiling.rb' - 'config/initializers/safe_session_store_patch.rb' - 'config/initializers/sidekiq.rb' - 'config/initializers/warden.rb' @@ -1123,28 +1118,6 @@ Style/InlineDisableAnnotation: - 'config/routes/project.rb' - 'danger/ce_ee_vue_templates/Dangerfile' - 'danger/roulette/Dangerfile' - - 'db/migrate/20220316022505_create_namespace_details.rb' - - 'db/migrate/20220331125725_add_title_to_topic.rb' - - 'db/migrate/20220401071609_add_campaign_to_in_product_marketing_email.rb' - - 'db/migrate/20220421141342_add_allowed_plans_to_ci_runners.rb' - - 'db/migrate/20220503035221_add_gitlab_schema_to_batched_background_migrations.rb' - - 'db/migrate/20220513114706_add_jira_connect_application_id_application_setting.rb' - - 'db/migrate/20220516092207_add_globally_allowed_ips_to_application_setting.rb' - - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - - 'db/migrate/20220601091804_add_semver_column_to_ci_runners.rb' - - 'db/migrate/20220602130306_add_namespace_type_index.rb' - - 'db/migrate/20220617141347_create_ci_secure_file_states.rb' - - 'db/migrate/20220726154013_add_component_id_to_sbom_occurrences.rb' - - 'db/migrate/20220802200719_add_user_details_profile_fields.rb' - - 'db/migrate/20220818125332_add_jitsu_tracking_columns_to_application_settings.rb' - - 'db/migrate/20220825105631_add_cube_api_key_to_application_settings.rb' - - 'db/migrate/20220902065317_add_partition_id_to_ci_builds.rb' - - 'db/migrate/20220914130800_add_jitsu_key_to_projects.rb' - - 'db/migrate/20220920135632_add_jira_connect_proxy_url_setting.rb' - - 'db/migrate/20220926023734_add_mirror_branch_regex_to_project_settings.rb' - - 'db/migrate/20221014034338_populate_releases_access_level_from_repository.rb' - - 'db/migrate/20221025043930_change_default_value_on_password_last_changed_at_to_user_details.rb' - - 'db/migrate/20221101032521_add_default_preferred_language_to_application_settings.rb' - 'db/migrate/20221111123146_add_onboarding_in_progress_to_users.rb' - 'db/migrate/20221111123147_add_onboarding_step_url_to_user_details.rb' - 'db/migrate/20221114131943_add_short_title_to_appearances.rb' @@ -1205,27 +1178,6 @@ Style/InlineDisableAnnotation: - 'db/migrate/20231017135207_add_fields_to_ml_model.rb' - 'db/migrate/20231019180421_add_name_description_to_catalog_resources.rb' - 'db/migrate/20231024142236_add_fields_to_bulk_import_failures.rb' - - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' - - 'db/post_migrate/20220504083836_cleanup_after_fixing_regression_with_new_users_emails.rb' - - 'db/post_migrate/20220530082653_add_traversal_id_type_group_index.rb' - - 'db/post_migrate/20220617123022_add_unique_index_on_projects_on_runners_token.rb' - - 'db/post_migrate/20220617123034_add_unique_index_on_projects_on_runners_token_encrypted.rb' - - 'db/post_migrate/20220628111752_drop_token_index_from_ci_builds.rb' - - 'db/post_migrate/20220630085003_drop_project_successfull_pages_deploy_index_from_ci_builds.rb' - - 'db/post_migrate/20220719081542_drop_queued_at_index_from_ci_builds.rb' - - 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb' - - 'db/post_migrate/20220804235614_add_comment_to_vulnerability_state_transitions.rb' - - 'db/post_migrate/20220822090656_drop_build_coverage_regex_from_project.rb' - - 'db/post_migrate/20220830061704_orphaned_invited_members_cleanup.rb' - - 'db/post_migrate/20220901071355_cleanup_attention_request_user_callouts.rb' - - 'db/post_migrate/20220902204048_move_security_findings_table_to_gitlab_partitions_dynamic_schema.rb' - - 'db/post_migrate/20220919023208_drop_unused_fields_from_merge_request_assignees.rb' - - 'db/post_migrate/20220919080303_delete_migrate_shared_vulnerability_scanners.rb' - - 'db/post_migrate/20220920135356_tiebreak_user_type_index.rb' - - 'db/post_migrate/20221006172302_adjust_task_note_rename_background_migration_values.rb' - - 'db/post_migrate/20221013154159_update_invalid_dormant_user_setting.rb' - - 'db/post_migrate/20221018232820_add_temp_index_for_user_details_fields.rb' - 'db/post_migrate/20221102231131_remove_temp_index_for_user_details_fields.rb' - 'db/post_migrate/20221115184525_remove_namespaces_tmp_project_id_column.rb' - 'db/post_migrate/20221220131020_bump_default_partition_id_value_for_ci_tables.rb' @@ -1324,7 +1276,6 @@ Style/InlineDisableAnnotation: - 'ee/app/finders/autocomplete/project_invited_groups_finder.rb' - 'ee/app/finders/autocomplete/vulnerabilities_autocomplete_finder.rb' - 'ee/app/finders/boards/milestones_finder.rb' - - 'ee/app/finders/boards/users_finder.rb' - 'ee/app/finders/concerns/ee/finder_with_group_hierarchy.rb' - 'ee/app/finders/concerns/epics/findable.rb' - 'ee/app/finders/concerns/epics/with_access_check.rb' @@ -1378,7 +1329,6 @@ Style/InlineDisableAnnotation: - 'ee/app/graphql/types/admin/cloud_licenses/subscription_future_entry_type.rb' - 'ee/app/graphql/types/ai/message_extras_type.rb' - 'ee/app/graphql/types/ai/message_type.rb' - - 'ee/app/graphql/types/ai/project_conversations_type.rb' - 'ee/app/graphql/types/ai/prompt/ai_prompt_type.rb' - 'ee/app/graphql/types/ai/prompt/explain_vulnerability_prompt_type.rb' - 'ee/app/graphql/types/ai/prompt/explain_vulnerability_prompt_type/presubmission_check_results_type.rb' @@ -1722,33 +1672,15 @@ Style/InlineDisableAnnotation: - 'ee/app/workers/emails/abandoned_trial_emails_cron_worker.rb' - 'ee/app/workers/epics/new_epic_issue_worker.rb' - 'ee/app/workers/epics/update_epics_dates_worker.rb' - - 'ee/app/workers/geo/batch/project_registry_scheduler_worker.rb' - - 'ee/app/workers/geo/batch/project_registry_worker.rb' - 'ee/app/workers/geo/bulk_mark_pending_batch_worker.rb' - 'ee/app/workers/geo/bulk_mark_verification_pending_batch_worker.rb' - 'ee/app/workers/geo/container_repository_sync_worker.rb' - 'ee/app/workers/geo/event_worker.rb' - 'ee/app/workers/geo/file_removal_worker.rb' - 'ee/app/workers/geo/hashed_storage_attachments_migration_worker.rb' - - 'ee/app/workers/geo/hashed_storage_migration_worker.rb' - 'ee/app/workers/geo/metrics_update_worker.rb' - 'ee/app/workers/geo/prune_event_log_worker.rb' - - 'ee/app/workers/geo/rename_repository_worker.rb' - - 'ee/app/workers/geo/repositories_clean_up_worker.rb' - - 'ee/app/workers/geo/repository_cleanup_worker.rb' - - 'ee/app/workers/geo/repository_shard_sync_worker.rb' - - 'ee/app/workers/geo/repository_sync_worker.rb' - - 'ee/app/workers/geo/repository_verification/primary/batch_worker.rb' - - 'ee/app/workers/geo/repository_verification/primary/shard_worker.rb' - - 'ee/app/workers/geo/repository_verification/primary/single_worker.rb' - - 'ee/app/workers/geo/repository_verification/secondary/scheduler_worker.rb' - - 'ee/app/workers/geo/repository_verification/secondary/shard_worker.rb' - - 'ee/app/workers/geo/repository_verification/secondary/single_worker.rb' - - 'ee/app/workers/geo/scheduler/per_shard_scheduler_worker.rb' - - 'ee/app/workers/geo/scheduler/primary/per_shard_scheduler_worker.rb' - - 'ee/app/workers/geo/scheduler/primary/scheduler_worker.rb' - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' - - 'ee/app/workers/geo/scheduler/secondary/per_shard_scheduler_worker.rb' - 'ee/app/workers/geo/scheduler/secondary/scheduler_worker.rb' - 'ee/app/workers/geo/secondary/registry_consistency_worker.rb' - 'ee/app/workers/geo/secondary_usage_data_cron_worker.rb' @@ -1756,7 +1688,6 @@ Style/InlineDisableAnnotation: - 'ee/app/workers/geo/sync_timeout_cron_worker.rb' - 'ee/app/workers/geo/verification_cron_worker.rb' - 'ee/app/workers/geo/verification_state_backfill_worker.rb' - - 'ee/app/workers/geo_repository_destroy_worker.rb' - 'ee/app/workers/gitlab_subscriptions/add_on_purchases/schedule_bulk_refresh_user_assignments_worker.rb' - 'ee/app/workers/gitlab_subscriptions/notify_seats_exceeded_batch_worker.rb' - 'ee/app/workers/gitlab_subscriptions/refresh_seats_worker.rb' @@ -1784,7 +1715,6 @@ Style/InlineDisableAnnotation: - 'ee/app/workers/merge_request_reset_approvals_worker.rb' - 'ee/app/workers/new_epic_worker.rb' - 'ee/app/workers/okrs/checkin_reminder_emails_cron_worker.rb' - - 'ee/app/workers/open_ai/clear_conversations_worker.rb' - 'ee/app/workers/package_metadata/advisories_sync_worker.rb' - 'ee/app/workers/package_metadata/licenses_sync_worker.rb' - 'ee/app/workers/personal_access_tokens/instance/policy_worker.rb' @@ -1928,7 +1858,6 @@ Style/InlineDisableAnnotation: - 'ee/lib/ee/gitlab/import_export/project/object_builder.rb' - 'ee/lib/ee/gitlab/object_hierarchy.rb' - 'ee/lib/ee/gitlab/quick_actions/users_extractor.rb' - - 'ee/lib/ee/gitlab/saas.rb' - 'ee/lib/ee/gitlab/tracking.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/ee/users/internal.rb' @@ -2010,7 +1939,6 @@ Style/InlineDisableAnnotation: - 'ee/lib/gitlab/insights/executors/issuable_executor.rb' - 'ee/lib/gitlab/insights/finders/issuable_finder.rb' - 'ee/lib/gitlab/insights/reducers/count_per_period_reducer.rb' - - 'ee/lib/gitlab/llm/ai_message.rb' - 'ee/lib/gitlab/llm/chain/tools/identifier.rb' - 'ee/lib/gitlab/llm/chain/tools/json_reader/executor.rb' - 'ee/lib/gitlab/llm/chain/tools/summarize_comments/executor.rb' @@ -2033,17 +1961,7 @@ Style/InlineDisableAnnotation: - 'ee/lib/gitlab/zoekt/search_results.rb' - 'ee/lib/product_analytics/settings.rb' - 'ee/lib/quality/seeders/vulnerabilities.rb' - - 'ee/lib/remote_development/agent_config/updater.rb' - - 'ee/lib/remote_development/workspaces/reconcile/input/actual_state_calculator.rb' - - 'ee/lib/remote_development/workspaces/reconcile/output/desired_config_generator.rb' - - 'ee/lib/remote_development/workspaces/reconcile/output/desired_config_generator_prev1.rb' - - 'ee/lib/remote_development/workspaces/reconcile/output/devfile_parser.rb' - - 'ee/lib/remote_development/workspaces/reconcile/output/devfile_parser_prev1.rb' - - 'ee/lib/remote_development/workspaces/reconcile/persistence/workspaces_from_agent_infos_updater.rb' - - 'ee/lib/remote_development/workspaces/reconcile/persistence/workspaces_to_be_returned_finder.rb' - - 'ee/lib/remote_development/workspaces/reconcile/persistence/workspaces_to_be_returned_updater.rb' - 'ee/lib/system_check/geo/authorized_keys_check.rb' - - 'ee/lib/system_check/geo/geo_database_configured_check.rb' - 'ee/lib/tasks/geo.rake' - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/locale/unfound_translations.rb' @@ -2087,7 +2005,6 @@ Style/InlineDisableAnnotation: - 'ee/spec/lib/ee/gitlab/background_migration/backfill_epic_cache_counts_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_missing_vulnerability_dismissal_details_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_orphaned_transferred_project_approval_rules_spec.rb' @@ -2118,7 +2035,6 @@ Style/InlineDisableAnnotation: - 'ee/spec/lib/gitlab/import_export/project/relation_factory_spec.rb' - 'ee/spec/lib/gitlab/llm/chain/agents/zero_shot/executor_real_requests_spec.rb' - 'ee/spec/lib/gitlab/llm/chain/tools/epic_identifier/executor_spec.rb' - - 'ee/spec/lib/gitlab/llm/concerns/circuit_breaker_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' - 'ee/spec/lib/gitlab/patch/database_config_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/sitemap_file_spec.rb' @@ -2127,16 +2043,6 @@ Style/InlineDisableAnnotation: - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/create/creator_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/create/personal_access_token_creator_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/create/post_flatten_devfile_validator_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/create/workspace_creator_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/create/workspace_variables_creator_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/reconcile/input/factory_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/reconcile/main_integration_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/reconcile/main_reconcile_scenarios_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/reconcile/persistence/workspaces_from_agent_infos_updater_spec.rb' - - 'ee/spec/lib/remote_development/workspaces/update/updater_spec.rb' - 'ee/spec/mailers/emails/enterprise_users_spec.rb' - 'ee/spec/mailers/emails/merge_requests_spec.rb' - 'ee/spec/mailers/emails/okr_spec.rb' @@ -2204,7 +2110,6 @@ Style/InlineDisableAnnotation: - 'ee/spec/support/helpers/duo_chat_fixture_helpers.rb' - 'ee/spec/support/matchers/locked_schema.rb' - 'ee/spec/support/shared_contexts/graphql/geo/registries_shared_context.rb' - - 'ee/spec/support/shared_contexts/remote_development/remote_development_shared_contexts.rb' - 'ee/spec/support/shared_contexts/saas_registration_settings_context.rb' - 'ee/spec/support/shared_contexts/saas_trial_settings_context.rb' - 'ee/spec/support/shared_contexts/user_contribution_events_shared_context.rb' @@ -2225,9 +2130,7 @@ Style/InlineDisableAnnotation: - 'ee/spec/support/shared_examples/workers/geo/framework_registry_sync_worker_shared_examples.rb' - 'ee/spec/uploaders/every_gitlab_uploader_spec.rb' - 'ee/spec/views/groups/group_members/index.html.haml_spec.rb' - - 'ee/spec/views/layouts/header/_new_dropdown.haml_spec.rb' - 'ee/spec/views/projects/project_members/index.html.haml_spec.rb' - - 'ee/spec/views/shared/_tier_badge.html.haml_spec.rb' - 'ee/spec/workers/audit_events/audit_event_streaming_worker_spec.rb' - 'ee/spec/workers/ee/ci/build_finished_worker_spec.rb' - 'ee/spec/workers/ee/new_issue_worker_spec.rb' @@ -2329,7 +2232,6 @@ Style/InlineDisableAnnotation: - 'lib/bulk_imports/file_downloads/filename_fetch.rb' - 'lib/bulk_imports/groups/transformers/group_attributes_transformer.rb' - 'lib/bulk_imports/pipeline/runner.rb' - - 'lib/bulk_imports/projects/pipelines/references_pipeline.rb' - 'lib/bulk_imports/uniquify.rb' - 'lib/click_house/models/base_model.rb' - 'lib/click_house/query_builder.rb' @@ -2450,7 +2352,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/background_migration/update_workspaces_config_version.rb' - 'lib/gitlab/background_task.rb' - 'lib/gitlab/base_doorkeeper_controller.rb' - - 'lib/gitlab/bitbucket_import/importer.rb' - 'lib/gitlab/bitbucket_import/importers/issue_importer.rb' - 'lib/gitlab/bitbucket_import/importers/issue_notes_importer.rb' - 'lib/gitlab/bitbucket_server_import/importers/pull_request_notes_importer.rb' @@ -2462,7 +2363,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/checks/branch_check.rb' - 'lib/gitlab/checks/diff_check.rb' - 'lib/gitlab/checks/matching_merge_request.rb' - - 'lib/gitlab/checks/tag_check.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/parser.rb' - 'lib/gitlab/ci/badge/pipeline/status.rb' @@ -2509,7 +2409,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/console.rb' - 'lib/gitlab/container_repository/tags/cache.rb' - 'lib/gitlab/content_security_policy/config_loader.rb' - - 'lib/gitlab/contributions_calendar.rb' - 'lib/gitlab/current_settings.rb' - 'lib/gitlab/daemon.rb' - 'lib/gitlab/data_builder/pipeline.rb' @@ -2571,7 +2470,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/encoding_helper.rb' - 'lib/gitlab/encrypted_command_base.rb' - 'lib/gitlab/encrypted_incoming_email_command.rb' - - 'lib/gitlab/encrypted_ldap_command.rb' - 'lib/gitlab/encrypted_redis_command.rb' - 'lib/gitlab/encrypted_service_desk_email_command.rb' - 'lib/gitlab/encrypted_smtp_command.rb' @@ -2579,7 +2477,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/error_tracking/processor/sanitizer_processor.rb' - 'lib/gitlab/etag_caching/store.rb' - 'lib/gitlab/exclusive_lease.rb' - - 'lib/gitlab/experiment/rollout/feature.rb' - 'lib/gitlab/external_authorization/cache.rb' - 'lib/gitlab/faraday/error_callback.rb' - 'lib/gitlab/file_hook.rb' @@ -2606,7 +2503,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/github_import/importer/labels_importer.rb' - 'lib/gitlab/github_import/importer/milestones_importer.rb' - 'lib/gitlab/github_import/importer/note_importer.rb' - - 'lib/gitlab/github_import/importer/pull_requests/review_importer.rb' - 'lib/gitlab/github_import/importer/pull_requests/review_requests_importer.rb' - 'lib/gitlab/github_import/importer/releases_importer.rb' - 'lib/gitlab/github_import/importer/repository_importer.rb' @@ -2697,7 +2593,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/patch/prependable.rb' - 'lib/gitlab/patch/redis_cache_store.rb' - 'lib/gitlab/patch/sidekiq_cron_poller.rb' - - 'lib/gitlab/patch/sidekiq_scheduled_enq.rb' - 'lib/gitlab/performance_bar.rb' - 'lib/gitlab/performance_bar/redis_adapter_when_peek_enabled.rb' - 'lib/gitlab/popen/runner.rb' @@ -2714,7 +2609,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/redis/cross_slot.rb' - 'lib/gitlab/redis/hll.rb' - 'lib/gitlab/redis/multi_store.rb' - - 'lib/gitlab/redis/sidekiq_status.rb' - 'lib/gitlab/reference_extractor.rb' - 'lib/gitlab/relative_positioning/item_context.rb' - 'lib/gitlab/repository_cache_adapter.rb' @@ -2813,15 +2707,12 @@ Style/InlineDisableAnnotation: - 'qa/qa/ee/page/main/banner.rb' - 'qa/qa/ee/page/project/monitor/on_call_schedule/index.rb' - 'qa/qa/ee/page/project/settings/merge_request.rb' - - 'qa/qa/ee/page/workspace/action.rb' - - 'qa/qa/ee/page/workspace/list.rb' - 'qa/qa/page/admin/applications.rb' - 'qa/qa/page/component/access_tokens.rb' - 'qa/qa/page/component/ci_icon.rb' - 'qa/qa/page/component/issuable/sidebar.rb' - 'qa/qa/page/component/new_snippet.rb' - 'qa/qa/page/component/visibility_setting.rb' - - 'qa/qa/page/component/web_ide/web_terminal_panel.rb' - 'qa/qa/page/file/show.rb' - 'qa/qa/page/layout/banner.rb' - 'qa/qa/page/merge_request/show.rb' @@ -2831,11 +2722,6 @@ Style/InlineDisableAnnotation: - 'qa/qa/page/project/settings/branch_rules_details.rb' - 'qa/qa/page/project/settings/integrations.rb' - 'qa/qa/page/project/settings/mirroring_repositories.rb' - - 'qa/qa/page/project/settings/runners.rb' - - 'qa/qa/page/project/settings/services/jenkins.rb' - - 'qa/qa/page/project/settings/services/jira.rb' - - 'qa/qa/page/project/settings/services/pipeline_status_emails.rb' - - 'qa/qa/page/search/results.rb' - 'qa/qa/page/sub_menus/super_sidebar/global_search_modal.rb' - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/base.rb' @@ -2854,7 +2740,6 @@ Style/InlineDisableAnnotation: - 'qa/qa/scenario/test/integration/registry_with_cdn.rb' - 'qa/qa/service/docker_run/gitlab_runner.rb' - 'qa/qa/service/shellout.rb' - - 'qa/qa/specs/features/api/1_manage/import/import_large_github_repo_spec.rb' - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_large_project_spec.rb' - 'qa/qa/specs/features/browser_ui/10_govern/user/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb' @@ -2929,7 +2814,6 @@ Style/InlineDisableAnnotation: - 'spec/controllers/projects/runners_controller_spec.rb' - 'spec/db/docs_spec.rb' - 'spec/deprecation_warnings.rb' - - 'spec/experiments/application_experiment_spec.rb' - 'spec/factories/design_management/designs.rb' - 'spec/factories/events.rb' - 'spec/factories/go_module_commits.rb' @@ -2960,7 +2844,6 @@ Style/InlineDisableAnnotation: - 'spec/graphql/mutations/design_management/delete_spec.rb' - 'spec/graphql/resolvers/board_resolver_spec.rb' - 'spec/graphql/resolvers/boards_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/catalog/versions_resolver_spec.rb' - 'spec/haml_lint/linter/inline_javascript_spec.rb' - 'spec/haml_lint/linter/no_plain_nodes_spec.rb' - 'spec/helpers/admin/abuse_reports_helper_spec.rb' @@ -2980,7 +2863,6 @@ Style/InlineDisableAnnotation: - 'spec/lib/api/base_spec.rb' - 'spec/lib/api/entities/wiki_page_spec.rb' - 'spec/lib/api/helpers/packages/npm_spec.rb' - - 'spec/lib/backup/database_model_spec.rb' - 'spec/lib/backup/database_spec.rb' - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/banzai/filter/footnote_filter_spec.rb' @@ -3002,9 +2884,7 @@ Style/InlineDisableAnnotation: - 'spec/lib/gitlab/background_migration/backfill_finding_id_in_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_has_merge_request_of_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_missing_ci_cd_settings_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_project_route_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_import_level_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_namespace_on_issues_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_resource_link_events_spec.rb' @@ -3015,14 +2895,11 @@ Style/InlineDisableAnnotation: - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_routes_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_personal_access_tokens_with_nil_expires_at_spec.rb' - 'spec/lib/gitlab/background_migration/convert_credit_card_validation_data_to_hashes_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphans_approval_merge_request_rules2_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphans_approval_project_rules2_spec.rb' - - 'spec/lib/gitlab/background_migration/destroy_invalid_group_members_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_members_spec.rb' - - 'spec/lib/gitlab/background_migration/destroy_invalid_project_members_spec.rb' - 'spec/lib/gitlab/background_migration/fix_allow_descendants_override_disabled_shared_runners_spec.rb' - 'spec/lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/fix_vulnerability_reads_has_issues_spec.rb' @@ -3058,7 +2935,6 @@ Style/InlineDisableAnnotation: - 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb' - 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb' - 'spec/lib/gitlab/encoding_helper_spec.rb' - - 'spec/lib/gitlab/experiment/rollout/feature_spec.rb' - 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb' - 'spec/lib/gitlab/git/object_pool_spec.rb' - 'spec/lib/gitlab/git/remote_mirror_spec.rb' @@ -3307,7 +3183,6 @@ Style/InlineDisableAnnotation: - 'spec/support/helpers/stub_snowplow.rb' - 'spec/support/helpers/wait_for_requests.rb' - 'spec/support/matchers/event_store.rb' - - 'spec/support/rspec_order.rb' - 'spec/support/shared_contexts/controllers/ambiguous_ref_controller_shared_context.rb' - 'spec/support/shared_contexts/disable_user_tracking.rb' - 'spec/support/shared_contexts/policies/project_policy_table_shared_context.rb' @@ -3369,7 +3244,6 @@ Style/InlineDisableAnnotation: - 'spec/tooling/lib/tooling/helpers/file_handler_spec.rb' - 'spec/tooling/lib/tooling/helpers/predictive_tests_helper_spec.rb' - 'spec/tooling/lib/tooling/job_metrics_spec.rb' - - 'spec/tooling/lib/tooling/parallel_rspec_runner_spec.rb' - 'spec/tooling/lib/tooling/predictive_tests_spec.rb' - 'spec/uploaders/file_uploader_spec.rb' - 'spec/uploaders/object_storage_spec.rb' @@ -3377,7 +3251,6 @@ Style/InlineDisableAnnotation: - 'spec/uploaders/packages/debian/component_file_uploader_spec.rb' - 'spec/views/groups/group_members/index.html.haml_spec.rb' - 'spec/views/layouts/group.html.haml_spec.rb' - - 'spec/views/layouts/header/_new_dropdown.haml_spec.rb' - 'spec/views/notify/import_work_items_csv_email.html.haml_spec.rb' - 'spec/views/projects/project_members/index.html.haml_spec.rb' - 'spec/workers/concerns/cronjob_queue_spec.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index 35c05e19837..0004b0da84b 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -9,8 +9,6 @@ Style/NumericLiteralPrefix: - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb' - 'ee/spec/models/ci/minutes/usage_spec.rb' - 'ee/spec/models/ee/group_spec.rb' @@ -31,6 +29,7 @@ Style/NumericLiteralPrefix: - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' + - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/conflict_files_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/diff_spec.rb' diff --git a/.rubocop_todo/style/open_struct_use.yml b/.rubocop_todo/style/open_struct_use.yml index c21b63bc22b..4b2eedd833a 100644 --- a/.rubocop_todo/style/open_struct_use.yml +++ b/.rubocop_todo/style/open_struct_use.yml @@ -6,6 +6,7 @@ Style/OpenStructUse: - 'ee/spec/helpers/ee/blob_helper_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/failure_handler_spec.rb' - 'spec/helpers/profiles_helper_spec.rb' + - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/diff_stitcher_spec.rb' - 'spec/support/helpers/repo_helpers.rb' diff --git a/.rubocop_todo/style/redundant_return.yml b/.rubocop_todo/style/redundant_return.yml index 344dbbbc4cd..86f8bb37d67 100644 --- a/.rubocop_todo/style/redundant_return.yml +++ b/.rubocop_todo/style/redundant_return.yml @@ -73,7 +73,6 @@ Style/RedundantReturn: - 'ee/app/serializers/vulnerabilities/merge_request_link_entity.rb' - 'ee/app/services/audit_events/streaming/headers/base.rb' - 'ee/app/services/ee/post_receive_service.rb' - - 'ee/app/services/gitlab_subscriptions/user_add_on_assignments/create_service.rb' - 'ee/app/services/security/orchestration/assign_service.rb' - 'ee/app/services/vulnerabilities/manually_create_service.rb' - 'ee/app/workers/ee/repository_check/batch_worker.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index b33a9954cfc..f9b27ea3b69 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -18,7 +18,6 @@ Style/SingleArgumentDig: - 'ee/app/workers/concerns/elastic/migration_helper.rb' - 'ee/lib/gitlab/ci/parsers/security/dependency_list.rb' - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb' - - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/graphql/mutations/vulnerabilities/create_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb' diff --git a/.rubocop_todo/style/sole_nested_conditional.yml b/.rubocop_todo/style/sole_nested_conditional.yml index f6bda8add14..d234bf439cc 100644 --- a/.rubocop_todo/style/sole_nested_conditional.yml +++ b/.rubocop_todo/style/sole_nested_conditional.yml @@ -52,5 +52,4 @@ Style/SoleNestedConditional: - 'lib/mattermost/session.rb' - 'lib/object_storage/direct_upload.rb' - 'qa/qa/flow/login.rb' - - 'qa/qa/page/project/web_ide/edit.rb' - 'spec/spec_helper.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index cae9839060b..52020404660 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -11,7 +11,6 @@ Style/SymbolProc: - 'app/models/integrations/prometheus.rb' - 'app/models/label_note.rb' - 'app/models/members/project_member.rb' - - 'app/models/namespace.rb' - 'app/models/preloaders/merge_request_diff_preloader.rb' - 'app/models/release.rb' - 'app/models/remote_mirror.rb' @@ -45,14 +44,12 @@ Style/SymbolProc: - 'app/services/ci/find_exposed_artifacts_service.rb' - 'app/services/ci/resource_groups/assign_resource_from_resource_group_service.rb' - 'app/services/ci/update_build_state_service.rb' - - 'app/services/clusters/agents/delete_expired_events_service.rb' - 'app/services/feature_flags/update_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/notes/destroy_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - 'app/services/resource_events/synthetic_label_notes_builder_service.rb' - 'app/services/two_factor/destroy_service.rb' - - 'app/workers/bulk_import_worker.rb' - 'app/workers/bulk_imports/stuck_import_worker.rb' - 'app/workers/ci/build_trace_chunk_flush_worker.rb' - 'app/workers/gitlab/import/stuck_import_job.rb' @@ -63,8 +60,6 @@ Style/SymbolProc: - 'config/initializers/doorkeeper_openid_connect.rb' - 'config/initializers/mail_encoding_patch.rb' - 'config/settings.rb' - - 'db/post_migrate/20220803042352_cleanup_mr_attention_request_todos.rb' - - 'ee/app/helpers/ee/mirror_helper.rb' - 'ee/app/helpers/ee/registrations_helper.rb' - 'ee/app/models/concerns/epic_tree_sorting.rb' - 'ee/app/models/ee/issue.rb' @@ -77,11 +72,8 @@ Style/SymbolProc: - 'ee/app/serializers/integrations/jira_serializers/issue_entity.rb' - 'ee/app/serializers/linked_epic_entity.rb' - 'ee/app/services/analytics/cycle_analytics/data_loader_service.rb' - - 'ee/app/services/geo/verification_state_backfill_service.rb' - 'ee/app/services/security/scanned_resources_counting_service.rb' - 'ee/app/services/timebox_report_service.rb' - - 'ee/app/services/vulnerabilities/historical_statistics/deletion_service.rb' - - 'ee/app/workers/geo/batch/project_registry_worker.rb' - 'ee/app/workers/geo/sync_timeout_cron_worker.rb' - 'ee/app/workers/geo/verification_cron_worker.rb' - 'ee/lib/api/entities/pending_member.rb' @@ -95,7 +87,6 @@ Style/SymbolProc: - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' - 'ee/lib/gitlab/custom_file_templates.rb' - 'ee/lib/gitlab/geo/oauth/logout_state.rb' - - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - 'ee/spec/factories/issues.rb' - 'ee/spec/features/billings/qrtly_reconciliation_alert_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' @@ -110,10 +101,8 @@ Style/SymbolProc: - 'lib/api/entities/issuable_references.rb' - 'lib/api/entities/merge_request_approvals.rb' - 'lib/api/entities/package.rb' - - 'lib/api/entities/protected_ref_access.rb' - 'lib/api/go_proxy.rb' - 'lib/api/helpers/internal_helpers.rb' - - 'lib/api/package_files.rb' - 'lib/atlassian/jira_connect/serializers/base_entity.rb' - 'lib/bulk_imports/common/pipelines/entity_finisher.rb' - 'lib/bulk_imports/ndjson_pipeline.rb' @@ -121,7 +110,6 @@ Style/SymbolProc: - 'lib/container_registry/gitlab_api_client.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_events.rb' - 'lib/gitlab/auth/o_auth/auth_hash.rb' - - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/checks/changes_access.rb' @@ -130,7 +118,6 @@ Style/SymbolProc: - 'lib/gitlab/config/entry/node.rb' - 'lib/gitlab/database/async_indexes/migration_helpers.rb' - 'lib/gitlab/database/consistency_checker.rb' - - 'lib/gitlab/database/migrations/background_migration_helpers.rb' - 'lib/gitlab/database/migrations/instrumentation.rb' - 'lib/gitlab/diff/file_collection/base.rb' - 'lib/gitlab/diff/rendered/notebook/diff_file_helper.rb' @@ -148,19 +135,12 @@ Style/SymbolProc: - 'lib/gitlab/slash_commands/deploy.rb' - 'lib/gitlab/ssh_public_key.rb' - 'lib/gitlab/suggestions/suggestion_set.rb' - - 'lib/gitlab/task_helpers.rb' - 'lib/tasks/gitlab/praefect.rake' - - 'qa/qa/ee/page/group/settings/general.rb' - - 'qa/qa/ee/page/operations_dashboard.rb' - 'qa/qa/page/group/settings/package_registries.rb' - 'qa/qa/page/profile/two_factor_auth.rb' - - 'qa/qa/resource/project_snippet.rb' - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/review_merge_request_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'rubocop/cop/gitlab/namespaced_class.rb' @@ -188,8 +168,6 @@ Style/SymbolProc: - 'spec/helpers/instance_configuration_helper_spec.rb' - 'spec/helpers/members_helper_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - - 'spec/lib/gitlab/database/dynamic_model_helpers_spec.rb' - - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/loose_foreign_key_helpers_spec.rb' - 'spec/lib/gitlab/git/commit_spec.rb' - 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb' @@ -197,15 +175,12 @@ Style/SymbolProc: - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_spec.rb' - 'spec/lib/gitlab/optimistic_locking_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' - 'spec/lib/gitlab/relative_positioning/item_context_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb' - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - 'spec/models/merge_request_diff_spec.rb' - - 'spec/models/namespace/root_storage_statistics_spec.rb' - 'spec/models/operations/feature_flags/strategy_spec.rb' - - 'spec/models/project_statistics_spec.rb' - 'spec/models/repository_spec.rb' - 'spec/models/user_spec.rb' - 'spec/presenters/projects/import_export/project_export_presenter_spec.rb' diff --git a/.rubocop_todo/style/zero_length_predicate.yml b/.rubocop_todo/style/zero_length_predicate.yml deleted file mode 100644 index 4d30c3e638d..00000000000 --- a/.rubocop_todo/style/zero_length_predicate.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/ZeroLengthPredicate: - Exclude: - - 'spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb' |